117578 2013-06-12 23:39:28 -0700 Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set 2013-06-13 10:21:13 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 praveen.j webkit-unassigned commit-queue crogers dev_sachin eric.carlson glenn jer.noble oldest_to_newest 899915 0 praveen.j 2013-06-12 23:39:28 -0700 In current WebKit code, callOnMainThread() is called always even though 'onaudioprocess' listener is not set in ScriptProcessorNode. 899919 1 204557 praveen.j 2013-06-12 23:53:06 -0700 Created attachment 204557 Patch 900150 2 204557 commit-queue 2013-06-13 10:03:31 -0700 Comment on attachment 204557 Patch Clearing flags on attachment: 204557 Committed r151558: <http://trac.webkit.org/changeset/151558> 900151 3 commit-queue 2013-06-13 10:03:34 -0700 All reviewed patches have been landed. Closing bug. 900177 4 204557 crogers 2013-06-13 10:21:13 -0700 Comment on attachment 204557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204557&action=review > Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:145 > + return; you need to call zero() on outputBus before returning to make sure you're producing silence 204557 2013-06-12 23:53:06 -0700 2013-06-13 10:21:13 -0700 Patch WebAudio-117578.txt text/plain 3911 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTUzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA2LTEyICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIEF2b2lkIHVud2Fu dGVkIHRocmVhZCBob3BzIGluIFNjcmlwdFByb2Nlc3Nvck5vZGUgd2hlbiAnb25hdWRpb3Byb2Nl c3MnIGxpc3RlbmVyIGlzIG5vdCBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc1NzguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2NyaXB0UHJvY2Vzc29yTm9kZSBwcm9jZXNzIG9wZXJhdGlvbiBj b250aW51ZXMgdG8gZGlzcGF0Y2ggQXVkaW9Qcm9jZXNzaW5nRXZlbnQKKyAgICAgICAgZXZlbiB0 aG91Z2ggJ29uYXVkaW9wcm9jZXNzJyBsaXN0ZW5lciBpcyBub3Qgc2V0LiBUaGlzIHJlc3VsdHMg aW4gdW53YW50ZWQgdGhyZWFkIGhvcHMuCisgICAgICAgIENvZGUgaXMgb3B0aW1pemVkIHRvIGRp c3BhdGNoIEF1ZGlvUHJvY2Vzc2luZ0V2ZW50IG9ubHkgaWYgdGhlIGxpc3RlbmVyIGlzIHNldC4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0 cy4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vU2NyaXB0UHJvY2Vzc29yTm9kZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRQcm9jZXNzb3JOb2RlOjpTY3JpcHRQcm9jZXNzb3JO b2RlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFByb2Nlc3Nvck5vZGU6OnByb2Nlc3MpOgor ICAgICAgICAoV2ViQ29yZTo6U2NyaXB0UHJvY2Vzc29yTm9kZTo6c2V0T25hdWRpb3Byb2Nlc3Mp OgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vU2NyaXB0UHJvY2Vzc29yTm9kZS5oOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0UHJvY2Vzc29yTm9kZTo6b25hdWRpb3Byb2Nlc3MpOgorCiAy MDEzLTA2LTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIHRoZSBub3Rpb24gb2YgaW5hY3RpdmUgcGx1Zy1pbnMKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vU2NyaXB0UHJvY2Vzc29yTm9kZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2Rl LmNwcAkocmV2aXNpb24gMTUxNTM1KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp by9TY3JpcHRQcm9jZXNzb3JOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODAsNiArODAsNyBA QCBTY3JpcHRQcm9jZXNzb3JOb2RlOjpTY3JpcHRQcm9jZXNzb3JOb2RlCiAgICAgLCBtX251bWJl ck9mSW5wdXRDaGFubmVscyhudW1iZXJPZklucHV0Q2hhbm5lbHMpCiAgICAgLCBtX251bWJlck9m T3V0cHV0Q2hhbm5lbHMobnVtYmVyT2ZPdXRwdXRDaGFubmVscykKICAgICAsIG1faW50ZXJuYWxJ bnB1dEJ1cyhBdWRpb0J1czo6Y3JlYXRlKG51bWJlck9mSW5wdXRDaGFubmVscywgQXVkaW9Ob2Rl OjpQcm9jZXNzaW5nU2l6ZUluRnJhbWVzLCBmYWxzZSkpCisgICAgLCBtX2hhc0F1ZGlvUHJvY2Vz c0xpc3RlbmVyKGZhbHNlKQogewogICAgIC8vIFJlZ2FyZGxlc3Mgb2YgdGhlIGFsbG93ZWQgYnVm ZmVyIHNpemVzLCB3ZSBzdGlsbCBuZWVkIHRvIHByb2Nlc3MgYXQgdGhlIGdyYW51bGFyaXR5IG9m IHRoZSBBdWRpb05vZGUuCiAgICAgaWYgKG1fYnVmZmVyU2l6ZSA8IEF1ZGlvTm9kZTo6UHJvY2Vz c2luZ1NpemVJbkZyYW1lcykKQEAgLTEzOCw3ICsxMzksMTEgQEAgdm9pZCBTY3JpcHRQcm9jZXNz b3JOb2RlOjpwcm9jZXNzKHNpemVfdAogICAgIC8vIEFkZGl0aW9uYWxseSwgdGhlcmUgaXMgYSBk b3VibGUtYnVmZmVyaW5nIGZvciBpbnB1dCBhbmQgb3V0cHV0IHdoaWNoIGlzIGV4cG9zZWQgZGly ZWN0bHkgdG8gSmF2YVNjcmlwdCAoc2VlIGlucHV0QnVmZmVyIGFuZCBvdXRwdXRCdWZmZXIgYmVs b3cpLgogICAgIC8vIFRoaXMgbm9kZSBpcyB0aGUgcHJvZHVjZXIgZm9yIGlucHV0QnVmZmVyIGFu ZCB0aGUgY29uc3VtZXIgZm9yIG91dHB1dEJ1ZmZlci4KICAgICAvLyBUaGUgSmF2YVNjcmlwdCBj b2RlIGlzIHRoZSBjb25zdW1lciBvZiBpbnB1dEJ1ZmZlciBhbmQgdGhlIHByb2R1Y2VyIGZvciBv dXRwdXRCdWZmZXIuCi0gICAgCisKKyAgICAvLyBDaGVjayBpZiBhdWRpb3Byb2Nlc3MgbGlzdGVu ZXIgaXMgc2V0LgorICAgIGlmICghbV9oYXNBdWRpb1Byb2Nlc3NMaXN0ZW5lcikKKyAgICAgICAg cmV0dXJuOworCiAgICAgLy8gR2V0IGlucHV0IGFuZCBvdXRwdXQgYnVzc2VzLgogICAgIEF1ZGlv QnVzKiBpbnB1dEJ1cyA9IHRoaXMtPmlucHV0KDApLT5idXMoKTsKICAgICBBdWRpb0J1cyogb3V0 cHV0QnVzID0gdGhpcy0+b3V0cHV0KDApLT5idXMoKTsKQEAgLTIxNCw2ICsyMTksMTIgQEAgdm9p ZCBTY3JpcHRQcm9jZXNzb3JOb2RlOjpwcm9jZXNzKHNpemVfdAogICAgIH0KIH0KIAordm9pZCBT Y3JpcHRQcm9jZXNzb3JOb2RlOjpzZXRPbmF1ZGlvcHJvY2VzcyhQYXNzUmVmUHRyPEV2ZW50TGlz dGVuZXI+IGxpc3RlbmVyKQoreworICAgIG1faGFzQXVkaW9Qcm9jZXNzTGlzdGVuZXIgPSBsaXN0 ZW5lcjsKKyAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5hdWRpb3By b2Nlc3NFdmVudCwgbGlzdGVuZXIpOworfQorCiB2b2lkIFNjcmlwdFByb2Nlc3Nvck5vZGU6OmZp cmVQcm9jZXNzRXZlbnREaXNwYXRjaCh2b2lkKiB1c2VyRGF0YSkKIHsKICAgICBTY3JpcHRQcm9j ZXNzb3JOb2RlKiBqc0F1ZGlvTm9kZSA9IHN0YXRpY19jYXN0PFNjcmlwdFByb2Nlc3Nvck5vZGUq Pih1c2VyRGF0YSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Njcmlw dFByb2Nlc3Nvck5vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuaAkocmV2aXNpb24gMTUxNTM1KQorKysgU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2RlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTY1LDcgKzY1LDggQEAgcHVibGljOgogCiAgICAgc2l6ZV90IGJ1ZmZlclNpemUo KSBjb25zdCB7IHJldHVybiBtX2J1ZmZlclNpemU7IH0KIAotICAgIERFRklORV9BVFRSSUJVVEVf RVZFTlRfTElTVEVORVIoYXVkaW9wcm9jZXNzKTsKKyAgICBFdmVudExpc3RlbmVyKiBvbmF1ZGlv cHJvY2VzcygpIHsgcmV0dXJuIGdldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygp LmF1ZGlvcHJvY2Vzc0V2ZW50KTsgfQorICAgIHZvaWQgc2V0T25hdWRpb3Byb2Nlc3MoUGFzc1Jl ZlB0cjxFdmVudExpc3RlbmVyPik7CiAgICAgCiBwcml2YXRlOgogICAgIHZpcnR1YWwgZG91Ymxl IHRhaWxUaW1lKCkgY29uc3QgT1ZFUlJJREU7CkBAIC05Miw2ICs5Myw3IEBAIHByaXZhdGU6CiAg ICAgdW5zaWduZWQgbV9udW1iZXJPZk91dHB1dENoYW5uZWxzOwogCiAgICAgUmVmUHRyPEF1ZGlv QnVzPiBtX2ludGVybmFsSW5wdXRCdXM7CisgICAgYm9vbCBtX2hhc0F1ZGlvUHJvY2Vzc0xpc3Rl bmVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=