117562 2013-06-12 14:50:27 -0700 Headers and footers should be pinned to the left edge of the window when scrolling horizontally, even when zoomed 2013-06-13 11:23:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin andersca bdakin cmarcelo commit-queue jamesr luiz sam simon.fraser tonikitoo oldest_to_newest 899819 0 bdakin 2013-06-12 14:50:27 -0700 http://trac.webkit.org/changeset/150043 made headers and footers stay pinned to the left edge when scrolling horizontally, but the bug still occurs when you are scrolled horizontally and zoomed in. Patch forthcoming. <rdar://problem/14006745> 899830 1 204540 bdakin 2013-06-12 15:40:43 -0700 Created attachment 204540 Patch 900225 2 204540 sam 2013-06-13 11:09:10 -0700 Comment on attachment 204540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204540&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:321 > + float horizontalScrollOffsetForBanner = scrollOffsetForFixedChildren.width(); > + if (frameScaleFactor() != 1) > + horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(viewportRect(), totalContentsSize(), position, scrollOrigin(), 1, false, headerHeight(), footerHeight()).width(); > + This could use a comment. It is confusing enough. 900237 3 bdakin 2013-06-13 11:23:04 -0700 Comment added! Thank you! http://trac.webkit.org/changeset/151564 204540 2013-06-12 15:40:43 -0700 2013-06-13 11:09:09 -0700 Patch for-review.txt text/plain 2433 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTUyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBIZWFkZXJzIGFuZCBmb290ZXJzIHNo b3VsZCBiZSBwaW5uZWQgdG8gdGhlIGxlZnQgZWRnZSBvZiB0aGUgd2luZG93IHdoZW4gc2Nyb2xs aW5nIAorICAgICAgICBob3Jpem9udGFsbHksIGV2ZW4gd2hlbiB6b29tZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzU2MgorICAgICAgICAtYW5k IGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDAwNjc0NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSByZWFsbHkgd2Fu dCB0byB1c2UgdGhlIHdpZHRoIHZhbHVlIGZyb20gc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlv bigpIGZvciB0aGUgCisgICAgICAgIGJhbm5lciB3aXRoIGEgc2NhbGVkIGZhY3RvciBvZiAxLiBT byBpZiB0aGVyZSBpcyBhIGRpZmZlcmVudCBzY2FsZSBmYWN0b3IsIHJlLQorICAgICAgICBjb21w dXRlIHRoaXMgdmFsdWUgc3BlY2lmaWNhbGx5IGZvciB0aGUgYmFubmVycy4gCisgICAgICAgICog cGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGVNYWM6OnNldFNjcm9sbExh eWVyUG9zaXRpb24pOgorCiAyMDEzLTA2LTEyICBFZHVhcmRvIExpbWEgTWl0ZXYgIDxlbGltYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFthdGtdIFJlcGxhY2UgZGVwcmVjYXRlZCBjYWxsIHRvIGF0 a19kb2N1bWVudF9nZXRfbG9jYWxlKCkgaW4gRHVtcFJlbmRlclRyZWUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZU1hYy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xs aW5nVHJlZVNjcm9sbGluZ05vZGVNYWMubW0JKHJldmlzaW9uIDE1MTUxMikKKysrIFNvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZU1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMzE1LDExICszMTUsMTUgQEAgdm9pZCBTY3JvbGxpbmdUcmVl U2Nyb2xsaW5nTm9kZU1hYzo6c2V0UwogICAgIGlmIChtX2NvdW50ZXJTY3JvbGxpbmdMYXllcikK ICAgICAgICAgbV9jb3VudGVyU2Nyb2xsaW5nTGF5ZXIuZ2V0KCkucG9zaXRpb24gPSBGbG9hdFBv aW50KHNjcm9sbE9mZnNldEZvckZpeGVkQ2hpbGRyZW4pOwogCisgICAgZmxvYXQgaG9yaXpvbnRh bFNjcm9sbE9mZnNldEZvckJhbm5lciA9IHNjcm9sbE9mZnNldEZvckZpeGVkQ2hpbGRyZW4ud2lk dGgoKTsKKyAgICBpZiAoZnJhbWVTY2FsZUZhY3RvcigpICE9IDEpCisgICAgICAgIGhvcml6b250 YWxTY3JvbGxPZmZzZXRGb3JCYW5uZXIgPSBGcmFtZVZpZXc6OnNjcm9sbE9mZnNldEZvckZpeGVk UG9zaXRpb24odmlld3BvcnRSZWN0KCksIHRvdGFsQ29udGVudHNTaXplKCksIHBvc2l0aW9uLCBz Y3JvbGxPcmlnaW4oKSwgMSwgZmFsc2UsIGhlYWRlckhlaWdodCgpLCBmb290ZXJIZWlnaHQoKSku d2lkdGgoKTsKKwogICAgIGlmIChtX2hlYWRlckxheWVyKQotICAgICAgICBtX2hlYWRlckxheWVy LmdldCgpLnBvc2l0aW9uID0gRmxvYXRQb2ludChzY3JvbGxPZmZzZXRGb3JGaXhlZENoaWxkcmVu LndpZHRoKCksIDApOworICAgICAgICBtX2hlYWRlckxheWVyLmdldCgpLnBvc2l0aW9uID0gRmxv YXRQb2ludChob3Jpem9udGFsU2Nyb2xsT2Zmc2V0Rm9yQmFubmVyLCAwKTsKIAogICAgIGlmICht X2Zvb3RlckxheWVyKQotICAgICAgICBtX2Zvb3RlckxheWVyLmdldCgpLnBvc2l0aW9uID0gRmxv YXRQb2ludChzY3JvbGxPZmZzZXRGb3JGaXhlZENoaWxkcmVuLndpZHRoKCksIHRvdGFsQ29udGVu dHNTaXplKCkuaGVpZ2h0KCkgLSBmb290ZXJIZWlnaHQoKSk7CisgICAgICAgIG1fZm9vdGVyTGF5 ZXIuZ2V0KCkucG9zaXRpb24gPSBGbG9hdFBvaW50KGhvcml6b250YWxTY3JvbGxPZmZzZXRGb3JC YW5uZXIsIHRvdGFsQ29udGVudHNTaXplKCkuaGVpZ2h0KCkgLSBmb290ZXJIZWlnaHQoKSk7CiAK ICAgICBpZiAoIW1fY2hpbGRyZW4pCiAgICAgICAgIHJldHVybjsK