117556 2013-06-12 11:53:14 -0700 "Open Video in New Window" doesn't make sense in fullscreen 2013-06-12 14:04:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ruthiecftg webkit-unassigned bdakin commit-queue eric.carlson jer.noble jonlee ruthiecftg webkit-bug-importer oldest_to_newest 899676 0 ruthiecftg 2013-06-12 11:53:14 -0700 The "Open Video in New Window" item should be removed from the contextual menu when in fullscreen because it isn't useful then. A mediaIsInFullscreen() method needs to be exposed in order to decide when to show the "Open Video in New Window" item. 899683 1 ruthiecftg 2013-06-12 11:54:25 -0700 <rdar://problem/14069845> 899716 2 204496 ruthiecftg 2013-06-12 12:03:42 -0700 Created attachment 204496 Patch 899727 3 204496 bdakin 2013-06-12 12:33:51 -0700 Comment on attachment 204496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204496&action=review > Source/WebKit2/ChangeLog:14 > + Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method. This is a nitpick, but in the future, you should add some newlines in this section of the ChangeLog to make it a little more readable. 899734 4 204496 commit-queue 2013-06-12 12:58:38 -0700 Comment on attachment 204496 Patch Clearing flags on attachment: 204496 Committed r151520: <http://trac.webkit.org/changeset/151520> 899735 5 commit-queue 2013-06-12 12:58:40 -0700 All reviewed patches have been landed. Closing bug. 204496 2013-06-12 12:03:42 -0700 2013-06-12 12:58:38 -0700 Patch bug-117556-20130612120205.patch text/plain 5607 ruthiecftg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTUxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTEyICBSdXRoIEZv bmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgICJPcGVuIFZpZGVvIGluIE5ldyBX aW5kb3ciIGRvZXNuJ3QgbWFrZSBzZW5zZSBpbiBmdWxsc2NyZWVuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc1NTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisg ICAgICAgICogV2ViQ29yZS5leHAuaW46IEFkZGVkIFdlYktpdDIgaG9vayBmb3IgbWVkaWFJc0lu RnVsbHNjcmVlbigpIG1ldGhvZC4KKwogMjAxMy0wNi0xMiAgUmFscGggVGhvbWFzICA8cmFscGh0 QGdtYWlsLmNvbT4KIAogICAgICAgICBbQ1NTIFNoYWRlcnNdIEFuaW1hdGlvbnMgYW5kIHRyYW5z aXRpb25zIHNob3VsZCB1c2UgdmFsaWRhdGVkIGN1c3RvbSBwcm9ncmFtcwpJbmRleDogU291cmNl L1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4JKHJldmlzaW9uIDE1MTUxMikKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUu ZXhwLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xMzc0LDYgKzEzNzQsNyBAQCBfX1pOSzdXZWJDb3Jl MTNIaXRUZXN0UmVzdWx0MTVhYnNvbHV0ZUxpCiBfX1pOSzdXZWJDb3JlMTNIaXRUZXN0UmVzdWx0 MTVzcGVsbGluZ1Rvb2xUaXBFUk5TXzEzVGV4dERpcmVjdGlvbkUKIF9fWk5LN1dlYkNvcmUxM0hp dFRlc3RSZXN1bHQxNmFic29sdXRlSW1hZ2VVUkxFdgogX19aTks3V2ViQ29yZTEzSGl0VGVzdFJl c3VsdDE2YWJzb2x1dGVNZWRpYVVSTEV2CitfX1pOSzdXZWJDb3JlMTNIaXRUZXN0UmVzdWx0MTlt ZWRpYUlzSW5GdWxsc2NyZWVuRXYKIF9fWk5LN1dlYkNvcmUxM0hpdFRlc3RSZXN1bHQxNmFsdERp c3BsYXlTdHJpbmdFdgogX19aTks3V2ViQ29yZTEzSGl0VGVzdFJlc3VsdDE3aXNDb250ZW50RWRp dGFibGVFdgogX19aTks3V2ViQ29yZTEzSGl0VGVzdFJlc3VsdDE4dGl0bGVEaXNwbGF5U3RyaW5n RXYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTUxNCkKKysrIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA2LTEyICBSdXRo IEZvbmcgIDxydXRoX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgICJPcGVuIFZpZGVvIGluIE5l dyBXaW5kb3ciIGRvZXNuJ3QgbWFrZSBzZW5zZSBpbiBmdWxsc2NyZWVuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc1NTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIG1ldGhvZCBtZWRpYUlzSW5G dWxsc2NyZWVuKCkgdGhhdCBjaGVja3MgaWYgYSBtZWRpYSBlbGVtZW50IGlzIGluCisgICAgICAg IGZ1bGxzY3JlZW4gbW9kZSwgd2hpY2ggaXMgbmVlZGVkIHRvIGRlY2lkZSB3aGVuIHRvIGRpc3Bs YXkgdGhlCisgICAgICAgICJPcGVuIFZpZGVvIGluIE5ldyBXaW5kb3ciIGNvbnRleHQgbWVudSBp dGVtLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRs ZUhpdFRlc3RSZXN1bHQuY3BwOgorICAgICAgICAoV0tCdW5kbGVIaXRUZXN0UmVzdWx0TWVkaWFJ c0luRnVsbHNjcmVlbik6IEFkZGVkLgorICAgICAgICBIb29rcyBpbnRvIG5ldyBJbmplY3RlZEJ1 bmRsZUhpdFRlc3RSZXN1bHQ6Om1lZGlhSXNJbkZ1bGxzY3JlZW4oKSBtZXRob2QuCisgICAgICAg ICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUhpdFRlc3RSZXN1bHQu aDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlSGl0 VGVzdFJlc3VsdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlSGl0VGVzdFJl c3VsdDo6bWVkaWFJc0luRnVsbHNjcmVlbik6IEFkZGVkLgorICAgICAgICBDaGVja3MgaWYgbWVk aWEgZWxlbWVudCBpcyBpbiBmdWxsc2NyZWVuLgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0Lmg6CisKIDIwMTMtMDYtMTIgIFJ1 dGggRm9uZyAgPHJ1dGhfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgZm9yIHRvZ2ds aW5nIGZ1bGxzY3JlZW4gb24gPHZpZGVvPiBlbGVtZW50cwpJbmRleDogU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv SW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0LmNwcAkocmV2aXNpb24gMTUxNTEyKQorKysgU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRl c3RSZXN1bHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCwxMSBAQCBTdHJpbmcgSW5q ZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0OjphYnNvCiAgICAgcmV0dXJuIG1faGl0VGVzdFJlc3Vs dC5hYnNvbHV0ZU1lZGlhVVJMKCkuc3RyaW5nKCk7CiB9CiAKK2Jvb2wgSW5qZWN0ZWRCdW5kbGVI aXRUZXN0UmVzdWx0OjptZWRpYUlzSW5GdWxsc2NyZWVuKCkgY29uc3QKK3sKKyAgICByZXR1cm4g bV9oaXRUZXN0UmVzdWx0Lm1lZGlhSXNJbkZ1bGxzY3JlZW4oKTsKK30KKwogU3RyaW5nIEluamVj dGVkQnVuZGxlSGl0VGVzdFJlc3VsdDo6bGlua0xhYmVsKCkgY29uc3QKIHsKICAgICByZXR1cm4g bV9oaXRUZXN0UmVzdWx0LnRleHRDb250ZW50KCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGVIaXRUZXN0UmVzdWx0LmgJKHJldmlzaW9uIDE1MTUxMikKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0 LmgJKHdvcmtpbmcgY29weSkKQEAgLTUxLDYgKzUxLDcgQEAgcHVibGljOgogICAgIFN0cmluZyBh YnNvbHV0ZVBERlVSTCgpIGNvbnN0OwogICAgIFN0cmluZyBhYnNvbHV0ZUxpbmtVUkwoKSBjb25z dDsKICAgICBTdHJpbmcgYWJzb2x1dGVNZWRpYVVSTCgpIGNvbnN0OworICAgIGJvb2wgbWVkaWFJ c0luRnVsbHNjcmVlbigpIGNvbnN0OwogCiAgICAgU3RyaW5nIGxpbmtMYWJlbCgpIGNvbnN0Owog ICAgIFN0cmluZyBsaW5rVGl0bGUoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVzdWx0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9j L1dLQnVuZGxlSGl0VGVzdFJlc3VsdC5jcHAJKHJldmlzaW9uIDE1MTUxMikKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVz dWx0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsMTEgQEAgV0tVUkxSZWYgV0tCdW5k bGVIaXRUZXN0UmVzdWx0Q29weUFic29sdQogICAgIHJldHVybiB0b0NvcGllZFVSTEFQSSh0b0lt cGwoaGl0VGVzdFJlc3VsdFJlZiktPmFic29sdXRlTWVkaWFVUkwoKSk7CiB9CiAKK2Jvb2wgV0tC dW5kbGVIaXRUZXN0UmVzdWx0TWVkaWFJc0luRnVsbHNjcmVlbihXS0J1bmRsZUhpdFRlc3RSZXN1 bHRSZWYgaGl0VGVzdFJlc3VsdFJlZikKK3sKKyAgICByZXR1cm4gdG9JbXBsKGhpdFRlc3RSZXN1 bHRSZWYpLT5tZWRpYUlzSW5GdWxsc2NyZWVuKCk7Cit9CisKIFdLUmVjdCBXS0J1bmRsZUhpdFRl c3RSZXN1bHRHZXRJbWFnZVJlY3QoV0tCdW5kbGVIaXRUZXN0UmVzdWx0UmVmIGhpdFRlc3RSZXN1 bHRSZWYpCiB7CiAgICAgcmV0dXJuIHRvQVBJKHRvSW1wbChoaXRUZXN0UmVzdWx0UmVmKS0+aW1h Z2VSZWN0KCkpOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9BUEkvYy9XS0J1bmRsZUhpdFRlc3RSZXN1bHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSGl0VGVzdFJlc3Vs dC5oCShyZXZpc2lvbiAxNTE1MTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSGl0VGVzdFJlc3VsdC5oCSh3b3JraW5nIGNvcHkpCkBA IC00NCw2ICs0NCw3IEBAIFdLX0VYUE9SVCBXS1VSTFJlZiBXS0J1bmRsZUhpdFRlc3RSZXN1bHQK IFdLX0VYUE9SVCBXS1VSTFJlZiBXS0J1bmRsZUhpdFRlc3RSZXN1bHRDb3B5QWJzb2x1dGVQREZV UkwoV0tCdW5kbGVIaXRUZXN0UmVzdWx0UmVmIGhpdFRlc3RSZXN1bHQpOwogV0tfRVhQT1JUIFdL VVJMUmVmIFdLQnVuZGxlSGl0VGVzdFJlc3VsdENvcHlBYnNvbHV0ZUxpbmtVUkwoV0tCdW5kbGVI aXRUZXN0UmVzdWx0UmVmIGhpdFRlc3RSZXN1bHQpOwogV0tfRVhQT1JUIFdLVVJMUmVmIFdLQnVu ZGxlSGl0VGVzdFJlc3VsdENvcHlBYnNvbHV0ZU1lZGlhVVJMKFdLQnVuZGxlSGl0VGVzdFJlc3Vs dFJlZiBoaXRUZXN0UmVzdWx0KTsKK1dLX0VYUE9SVCBib29sIFdLQnVuZGxlSGl0VGVzdFJlc3Vs dE1lZGlhSXNJbkZ1bGxzY3JlZW4oV0tCdW5kbGVIaXRUZXN0UmVzdWx0UmVmIGhpdFRlc3RSZXN1 bHQpOwogCiBXS19FWFBPUlQgV0tSZWN0IFdLQnVuZGxlSGl0VGVzdFJlc3VsdEdldEltYWdlUmVj dChXS0J1bmRsZUhpdFRlc3RSZXN1bHRSZWYgaGl0VGVzdFJlc3VsdCk7CiBXS19FWFBPUlQgYm9v bCBXS0J1bmRsZUhpdFRlc3RSZXN1bHRHZXRJc1NlbGVjdGVkKFdLQnVuZGxlSGl0VGVzdFJlc3Vs dFJlZiBoaXRUZXN0UmVzdWx0KTsK