117546 2013-06-12 08:06:15 -0700 [GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only) 2013-06-18 06:05:19 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 0 dpino webkit-unassigned cdumez commit-queue xan.lopez oldest_to_newest 899554 0 dpino 2013-06-12 08:06:15 -0700 There is the following comment in CodeGeneratorGObject.pm: # FIXME: should we use ObjCPolymorphic attribute? or is it specific to ObjC bindings? According to WebKit WebIDL spec [1] ObjCPolymorphic only applies to the Objective-C bindings, so this comment is misleading. [1] http://trac.webkit.org/wiki/WebKitIDL 899556 1 204443 dpino 2013-06-12 08:11:23 -0700 Created attachment 204443 Patch 901070 2 204443 commit-queue 2013-06-17 09:45:00 -0700 Comment on attachment 204443 Patch Rejecting attachment 204443 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 204443, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/906404 901081 3 204834 dpino 2013-06-17 10:13:05 -0700 Created attachment 204834 Patch 901375 4 204834 commit-queue 2013-06-18 06:05:16 -0700 Comment on attachment 204834 Patch Clearing flags on attachment: 204834 Committed r151682: <http://trac.webkit.org/changeset/151682> 901376 5 commit-queue 2013-06-18 06:05:19 -0700 All reviewed patches have been landed. Closing bug. 204443 2013-06-12 08:11:23 -0700 2013-06-17 10:12:57 -0700 Patch bug-117546-20130612170942.patch text/plain 1799 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA0ZjlmNTk2Mjg3ZWQ5 NDU1MzFiM2NjMzUwY2UyNTJlYjg4MWI4NC4uNWEzNGY5OGIwYjkzZWZkZjc5MTMwNmE3NWRlMjAw MDYyZTE4MmQwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTEyICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUmVtb3Zl IGNvbW1lbnQgYWJvdXQgcG9zc2liaWxpdHkgb2YgaGFuZGxpbmcgT2JqQ1BvbHltb3JwaGljIChp dCdzIHVzZWQgYnkgT2JqQyBiaW5kaW5ncyBvbmx5KQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSBXZWJLaXQgSURMIHNwZWMg dGhlIG1vZGlmaWVyIE9iakNQb2x5bW9ycGhpYyBvbmx5CisgICAgICAgIGFwcGxpZXMgdG8gdGhl IE9iamVjdGl2ZS1DIGJpbmRpbmdzIGdlbmVyYXRvcgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAo T09QUyEpLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbToKKyAgICAgICAgKElzUG9seW1vcnBoaWMpOiBSZW1vdmUgY29tbWVudC4gU2VhcmNoIGF0 dHJpYnV0ZSBpbiBhcnJheSwgaW5zdGVhZCBvZgorICAgICAgICBjb25jYXRlbmluZyBhIHNlcmll cyBvZiAnb3InIGNvbmRpdGlvbmFscy4KKwogMjAxMy0wNi0xMiAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG1lbW9yeUluZm9FbmFibGVkLCBx dWFudGl6ZWRNZW1vcnlJbmZvRW5hYmxlZCBzZXR0aW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggY2Yw Yjc0NDZkMjE3ZmE3YzZhODVjZmQ4ZDIyZmM2Y2Q0MGI5Y2RmZC4uNGQwNmVjOGQ4MzNkMzFjNTIy NTIxNTRhYmJiOTAwZjFiZGI0MThmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0xMzc1LDkgKzEzNzUs NyBAQCBzdWIgR2VuZXJhdGVFbmRIZWFkZXIgewogc3ViIElzUG9seW1vcnBoaWMgewogICAgIG15 ICR0eXBlID0gc2hpZnQ7CiAKLSAgICAjIEZJWE1FOiBzaG91bGQgd2UgdXNlIE9iakNQb2x5bW9y cGhpYyBhdHRyaWJ1dGU/IG9yIGlzIGl0IHNwZWNpZmljIHRvIE9iakMgYmluZGluZ3M/Ci0gICAg cmV0dXJuIDEgaWYgJHR5cGUgZXEgIk5vZGUiIG9yICR0eXBlIGVxICJFdmVudCIgb3IgJHR5cGUg ZXEgIkhUTUxDb2xsZWN0aW9uIiBvciAkdHlwZSBlcSAiU3R5bGVTaGVldCIgb3IgJHR5cGUgZXEg IkJsb2IiOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBzY2FsYXIoZ3JlcCB7JF8gZXEgJHR5 cGV9IHF3KEJsb2IgRXZlbnQgSFRNTENvbGxlY3Rpb24gTm9kZSBTdHlsZVNoZWV0KSk7CiB9CiAK IHN1YiBHZW5lcmF0ZUV2ZW50VGFyZ2V0SWZhY2Ugewo= 204834 2013-06-17 10:13:05 -0700 2013-06-18 06:05:16 -0700 Patch bug-117546-20130617191118.patch text/plain 1777 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNhYTgzZWNhNzJmNWQz M2NiY2I2NDAxNzA4N2QxZTIzNjZlYTBkYy4uZjYwOTYwM2EwZDYzZmY5NWRjYmEzMGUyN2M4YWM1 YTgyNzVhMzUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2LTEyICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUmVtb3Zl IGNvbW1lbnQgYWJvdXQgcG9zc2liaWxpdHkgb2YgaGFuZGxpbmcgT2JqQ1BvbHltb3JwaGljIChp dCdzIHVzZWQgYnkgT2JqQyBiaW5kaW5ncyBvbmx5KQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSBXZWJLaXQgSURMIHNwZWMg dGhlIG1vZGlmaWVyIE9iakNQb2x5bW9ycGhpYyBvbmx5CisgICAgICAgIGFwcGxpZXMgdG8gdGhl IE9iamVjdGl2ZS1DIGJpbmRpbmdzIGdlbmVyYXRvcgorCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAgKElzUG9seW1vcnBoaWMpOiBS ZW1vdmUgY29tbWVudC4gU2VhcmNoIHBhcmFtZXRlciAndHlwZScgaW4gYXJyYXksIGluc3RlYWQg b2YKKyAgICAgICAgY29uY2F0ZW5pbmcgYSBzZXJpZXMgb2YgJ29yJyBjb25kaXRpb25hbHMuCisK IDIwMTMtMDYtMTcgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5pbmdAZGlnaWEuY29t PgogCiAgICAgICAgIFtNYWNdIFJlbW92ZSB1bm1haW50YWluZWQgR1N0cmVhbWVyIHNwZWNpZmlj IHZpZGVvIGNvZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCA1NWIwNWQwOWNkZjUwZWMxODAyOWViYjEy ODE3YWI2MmM3NDc2MzYzLi5hNTJkNDdjYzA5YzEzNzBjNGY0YmJlNzIxZTQwZDYwNDQ2NGIxOTU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG0KQEAgLTEzODIsOSArMTM4Miw3IEBAIHN1YiBHZW5lcmF0ZUVuZEhl YWRlciB7CiBzdWIgSXNQb2x5bW9ycGhpYyB7CiAgICAgbXkgJHR5cGUgPSBzaGlmdDsKIAotICAg ICMgRklYTUU6IHNob3VsZCB3ZSB1c2UgT2JqQ1BvbHltb3JwaGljIGF0dHJpYnV0ZT8gb3IgaXMg aXQgc3BlY2lmaWMgdG8gT2JqQyBiaW5kaW5ncz8KLSAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAi Tm9kZSIgb3IgJHR5cGUgZXEgIkV2ZW50IiBvciAkdHlwZSBlcSAiSFRNTENvbGxlY3Rpb24iIG9y ICR0eXBlIGVxICJTdHlsZVNoZWV0IiBvciAkdHlwZSBlcSAiQmxvYiI7Ci0gICAgcmV0dXJuIDA7 CisgICAgcmV0dXJuIHNjYWxhcihncmVwIHskXyBlcSAkdHlwZX0gcXcoQmxvYiBFdmVudCBIVE1M Q29sbGVjdGlvbiBOb2RlIFN0eWxlU2hlZXQpKTsKIH0KIAogc3ViIEdlbmVyYXRlRXZlbnRUYXJn ZXRJZmFjZSB7Cg==