117541 2013-06-12 07:09:57 -0700 Fix crashes due to failed ImageBuffer allocation 2013-06-12 16:30:24 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez commit-queue d-r fmalita pdr schenney zimmermann oldest_to_newest 899532 0 gyuyoung.kim 2013-06-12 07:09:57 -0700 A crash can happen due to a failed ImageBuffer allocation in SVGImage::drawPatternForContainer(). Added a check for that failed allocation. Committed: https://src.chromium.org/viewvc/blink?revision=152268&view=revision 899533 1 204434 gyuyoung.kim 2013-06-12 07:12:04 -0700 Created attachment 204434 Patch 899535 2 204434 cdumez 2013-06-12 07:22:44 -0700 Comment on attachment 204434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204434&action=review > Source/WebCore/ChangeLog:8 > + From Blink r152268 by <wolenetz@chromium.org> This Blink revision seems to be from Philip Rogers <pdr@chromium.org>? 899543 3 204438 gyuyoung.kim 2013-06-12 07:40:50 -0700 Created attachment 204438 Patch 899544 4 gyuyoung.kim 2013-06-12 07:41:28 -0700 (In reply to comment #2) > (From update of attachment 204434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204434&action=review > > > Source/WebCore/ChangeLog:8 > > + From Blink r152268 by <wolenetz@chromium.org> > > This Blink revision seems to be from Philip Rogers <pdr@chromium.org>? Oops, my bad. Thanks. 899857 5 204438 commit-queue 2013-06-12 16:30:21 -0700 Comment on attachment 204438 Patch Clearing flags on attachment: 204438 Committed r151525: <http://trac.webkit.org/changeset/151525> 899858 6 commit-queue 2013-06-12 16:30:24 -0700 All reviewed patches have been landed. Closing bug. 204434 2013-06-12 07:12:04 -0700 2013-06-12 07:40:41 -0700 Patch bug-117541-20130612231023.patch text/plain 1798 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk5NDk3MDA2MmFjZWM2 NGNkMTk3NDYwMjY4MTA2Zjg2MDAzODM1MS4uNDk1NjE0ZGU5ZTJjNmY3NDQyMmY2N2FhNDI0NTNi Y2NkY2E5YWNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTEyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGNyYXNo ZXMgZHVlIHRvIGZhaWxlZCBJbWFnZUJ1ZmZlciBhbGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc1NDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGcm9tIEJsaW5rIHIxNTIyNjggYnkgPHdv bGVuZXR6QGNocm9taXVtLm9yZz4KKworICAgICAgICBBIGNyYXNoIGNhbiBoYXBwZW4gZHVlIHRv IGEgZmFpbGVkIEltYWdlQnVmZmVyIGFsbG9jYXRpb24gaW4KKyAgICAgICAgU1ZHSW1hZ2U6OmRy YXdQYXR0ZXJuRm9yQ29udGFpbmVyKCkuIEFkZGVkIGEgY2hlY2sgZm9yIHRoYXQgZmFpbGVkIGFs bG9jYXRpb24uCisKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U1ZHSW1hZ2U6OmRyYXdQYXR0ZXJuRm9yQ29udGFpbmVyKToKKwogMjAxMy0w Ni0xMiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNpc2Euc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgUmVuYW1lIFtDYWxsV2l0aF0gdG8gW0NvbnN0cnVjdG9yQ2FsbFdpdGhdIGZvciBJREwg aW50ZXJmYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0lt YWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKaW5kZXgg ZDViOGQzN2E0NjI0N2FiOTZjNjQ1NDY2NDI4NzA4OTU0ZjQwMzRhMC4uOWU5ZGE1MDI0ZDM3Nzc1 YTFjNTYzNmUwZDNiYWNlYmUzMDM0ZjhiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3Zn L2dyYXBoaWNzL1NWR0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3Mv U1ZHSW1hZ2UuY3BwCkBAIC0xNzcsNiArMTc3LDggQEAgdm9pZCBTVkdJbWFnZTo6ZHJhd1BhdHRl cm5Gb3JDb250YWluZXIoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFNpemUK ICAgICBpbWFnZUJ1ZmZlclNpemUuc2NhbGUoaW1hZ2VCdWZmZXJTY2FsZS53aWR0aCgpLCBpbWFn ZUJ1ZmZlclNjYWxlLmhlaWdodCgpKTsKIAogICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gYnVmZmVy ID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShleHBhbmRlZEludFNpemUoaW1hZ2VCdWZmZXJTaXplLnNp emUoKSksIDEpOworICAgIGlmICghYnVmZmVyKSAvLyBGYWlsZWQgdG8gYWxsb2NhdGUgYnVmZmVy LgorICAgICAgICByZXR1cm47CiAgICAgZHJhd0ZvckNvbnRhaW5lcihidWZmZXItPmNvbnRleHQo KSwgY29udGFpbmVyU2l6ZSwgem9vbSwgaW1hZ2VCdWZmZXJTaXplLCB6b29tZWRDb250YWluZXJS ZWN0LCBDb2xvclNwYWNlRGV2aWNlUkdCLCBDb21wb3NpdGVTb3VyY2VPdmVyLCBCbGVuZE1vZGVO b3JtYWwpOwogICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBidWZmZXItPmNvcHlJbWFnZShEb250 Q29weUJhY2tpbmdTdG9yZSwgVW5zY2FsZWQpOwogCg== 204438 2013-06-12 07:40:50 -0700 2013-06-12 16:30:21 -0700 Patch bug-117541-20130612233909.patch text/plain 1793 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk5NDk3MDA2MmFjZWM2 NGNkMTk3NDYwMjY4MTA2Zjg2MDAzODM1MS4uNTdiOThjNmE3M2Y5YjgzY2VjY2RmYmQyNzA1OWY5 MzQyODExYzNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTEyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGNyYXNo ZXMgZHVlIHRvIGZhaWxlZCBJbWFnZUJ1ZmZlciBhbGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc1NDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGcm9tIEJsaW5rIHIxNTIyNjggYnkgPHBk ckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQSBjcmFzaCBjYW4gaGFwcGVuIGR1ZSB0byBhIGZh aWxlZCBJbWFnZUJ1ZmZlciBhbGxvY2F0aW9uIGluCisgICAgICAgIFNWR0ltYWdlOjpkcmF3UGF0 dGVybkZvckNvbnRhaW5lcigpLiBBZGRlZCBhIGNoZWNrIGZvciB0aGF0IGZhaWxlZCBhbGxvY2F0 aW9uLgorCisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNWR0ltYWdlOjpkcmF3UGF0dGVybkZvckNvbnRhaW5lcik6CisKIDIwMTMtMDYtMTIg IENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAg IFJlbmFtZSBbQ2FsbFdpdGhdIHRvIFtDb25zdHJ1Y3RvckNhbGxXaXRoXSBmb3IgSURMIGludGVy ZmFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCmluZGV4IGQ1Yjhk MzdhNDYyNDdhYjk2YzY0NTQ2NjQyODcwODk1NGY0MDM0YTAuLjllOWRhNTAyNGQzNzc3NWExYzU2 MzZlMGQzYmFjZWJlMzAzNGY4YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFw aGljcy9TVkdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0lt YWdlLmNwcApAQCAtMTc3LDYgKzE3Nyw4IEBAIHZvaWQgU1ZHSW1hZ2U6OmRyYXdQYXR0ZXJuRm9y Q29udGFpbmVyKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRTaXplCiAgICAg aW1hZ2VCdWZmZXJTaXplLnNjYWxlKGltYWdlQnVmZmVyU2NhbGUud2lkdGgoKSwgaW1hZ2VCdWZm ZXJTY2FsZS5oZWlnaHQoKSk7CiAKICAgICBPd25QdHI8SW1hZ2VCdWZmZXI+IGJ1ZmZlciA9IElt YWdlQnVmZmVyOjpjcmVhdGUoZXhwYW5kZWRJbnRTaXplKGltYWdlQnVmZmVyU2l6ZS5zaXplKCkp LCAxKTsKKyAgICBpZiAoIWJ1ZmZlcikgLy8gRmFpbGVkIHRvIGFsbG9jYXRlIGJ1ZmZlci4KKyAg ICAgICAgcmV0dXJuOwogICAgIGRyYXdGb3JDb250YWluZXIoYnVmZmVyLT5jb250ZXh0KCksIGNv bnRhaW5lclNpemUsIHpvb20sIGltYWdlQnVmZmVyU2l6ZSwgem9vbWVkQ29udGFpbmVyUmVjdCwg Q29sb3JTcGFjZURldmljZVJHQiwgQ29tcG9zaXRlU291cmNlT3ZlciwgQmxlbmRNb2RlTm9ybWFs KTsKICAgICBSZWZQdHI8SW1hZ2U+IGltYWdlID0gYnVmZmVyLT5jb3B5SW1hZ2UoRG9udENvcHlC YWNraW5nU3RvcmUsIFVuc2NhbGVkKTsKIAo=