117538 2013-06-12 05:04:02 -0700 [GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings 2013-06-28 01:58:42 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 agomez webkit-unassigned cgarcia commit-queue eocanha gustavo mrobinson pnormand rego oldest_to_newest 899504 0 agomez 2013-06-12 05:04:02 -0700 The default WebKit2Gtk "decide-destination" method used in MiniBrowser gets the default downloads destination using G_USER_DIRECTORY_DOWNLOAD and the XDG specification. XDG settings may not be present in very bare home directories like when using a chroot. This causes a failure when deciding the destination through the default method. 899506 1 agomez 2013-06-12 05:05:14 -0700 This problem can be corrected locally in MiniBrowser but it may be worth correcting actually in the default method implemented by the WebKit2Gtk library. 899508 2 204427 agomez 2013-06-12 05:22:50 -0700 Created attachment 204427 Patch 900024 3 agomez 2013-06-13 07:31:36 -0700 Added Enrique to CC. 901828 4 204427 cgarcia 2013-06-19 10:06:29 -0700 Comment on attachment 204427 Patch This looks good to me, but I think this is actually a bug in the default implementation of decide-destination. Let's fix it in WebKitDownload and all other apps using the API will benefit from it. Note that in this case we would be updating the internal destination to NULL and emitting the notify signal. 902068 5 agomez 2013-06-20 03:36:19 -0700 (In reply to comment #4) > (From update of attachment 204427 [details]) > This looks good to me, but I think this is actually a bug in the default implementation of decide-destination. Let's fix it in WebKitDownload and all other apps using the API will benefit from it. Note that in this case we would be updating the internal destination to NULL and emitting the notify signal. True. Moving then to the proper component. 902074 6 205068 agomez 2013-06-20 03:42:51 -0700 Created attachment 205068 Patch 902078 7 commit-queue 2013-06-20 03:45:06 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 904482 8 205068 cgarcia 2013-06-28 01:20:11 -0700 Comment on attachment 205068 Patch Sorry for the delay reviewing it, it looks good to me, thanks! 904485 9 205068 commit-queue 2013-06-28 01:29:31 -0700 Comment on attachment 205068 Patch Clearing flags on attachment: 205068 Committed r152155: <http://trac.webkit.org/changeset/152155> 904486 10 commit-queue 2013-06-28 01:29:33 -0700 All reviewed patches have been landed. Closing bug. 904499 11 agomez 2013-06-28 01:58:42 -0700 (In reply to comment #8) > (From update of attachment 205068 [details]) > Sorry for the delay reviewing it, it looks good to me, thanks! Thanks to you for the review! 204427 2013-06-12 05:22:50 -0700 2013-06-20 03:42:44 -0700 Patch bug-117538-20130612152110.patch text/plain 3307 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjI2ZDNmMDQ5MjU5MDlmMTc3ZjM3N2UyN2ZmZWYxZDYz N2Y5YWY3Ny4uMTJjOTk0ZjQ4ZDAxZjJmZTkxMmQyZmJjYzJmY2EwOTQzODU4Yzc2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTA2LTEyICBBbmRyZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBNaW5pQnJvd3NlciBkb2Vzbid0IHNvbHZlIHRoZSBzYXZpbmcgbG9jYXRpb24g d2hlbiB0aGVyZSBhcmUgbm8gWERHIHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc1MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgWERHIHNwZWNpZmljYXRpb24gaXMgbm90IHdv cmtpbmcgZm9yIHRoZSAiRG93bmxvYWRzIgorICAgICAgICBkaXJlY3RvcnksIGxldCdzIHVzZSAk SE9NRSBhcyBmYWxsYmFjayBpbiBNaW5pQnJvd3Nlci4KKworICAgICAgICAqIE1pbmlCcm93c2Vy L2d0ay9Ccm93c2VyRG93bmxvYWRzQmFyLmM6CisgICAgICAgIChkb3dubG9hZERlY2lkZURlc3Rp bmF0aW9uKTogQWRkZWQuIFNhbWUgdGhhbiBkZWZhdWx0IG1ldGhvZCBidXQKKyAgICAgICAgd2hl biBYREcgZmFpbHMsIGRlZmF1bHRzIHRvIEhPTUUuCisgICAgICAgIChicm93c2VyRG93bmxvYWRO ZXcpOiBDb25uZWN0ZWQgImRlY2lkZS1kZXN0aW5hdGlvbiIgc2lnbmFsIHRvIHRoZQorICAgICAg ICBuZXcgbWV0aG9kLgorCiAyMDEzLTA2LTEyICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgdGhlIFdlYkNvcmVMYXllcihHdGsyKS5h IGFyY2hpdmVzIGJlZm9yZSByZWdlbmVyYXRpbmcgdGhlbQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWlu aUJyb3dzZXIvZ3RrL0Jyb3dzZXJEb3dubG9hZHNCYXIuYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyRG93bmxvYWRzQmFyLmMKaW5kZXggNWYwZTYyMGU1OTg2YTVmYmI4ZTk5ZTA1YzY0 M2U1YjZlNmFlZmQyMC4uNzliMTU0MjFmNmNlYjI5NjY5M2I1ZjNmODU4ZTM0Y2U0ZTVhODc5ZSAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJEb3dubG9hZHNCYXIuYwor KysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlckRvd25sb2Fkc0Jhci5jCkBAIC0yMTks NiArMjE5LDMxIEBAIHN0YXRpYyB2b2lkIGRvd25sb2FkUHJvZ3Jlc3MoV2ViS2l0RG93bmxvYWQg KmRvd25sb2FkLCBHUGFyYW1TcGVjICpwYXJhbVNwZWMsIEJyCiAgICAgZ19mcmVlKHJlbWFpbmlu Zyk7CiB9CiAKK3N0YXRpYyBnYm9vbGVhbiBkb3dubG9hZERlY2lkZURlc3RpbmF0aW9uKFdlYktp dERvd25sb2FkICpkb3dubG9hZCwgZ2NoYXIgKnN1Z2dlc3RlZEZpbGVuYW1lLCBCcm93c2VyRG93 bmxvYWQgKmJyb3dzZXJEb3dubG9hZCkKK3sKKyAgICBnYm9vbGVhbiByZXN1bHQgPSBGQUxTRTsK KworICAgIGNvbnN0IGdjaGFyICpkb3dubG9hZHNEaXIgPSBnX2dldF91c2VyX3NwZWNpYWxfZGly KEdfVVNFUl9ESVJFQ1RPUllfRE9XTkxPQUQpOworICAgIGlmICghZG93bmxvYWRzRGlyKSB7Cisg ICAgICAgIC8qIElmIHdlIGRvbid0IGhhdmUgWERHIHVzZXIgZGlycyBpbmZvLCBzZXQganVzdCB0 byBIT01FLiAqLworICAgICAgICBkb3dubG9hZHNEaXIgPSBnX2dldF9ob21lX2RpcigpOworICAg IH0KKworICAgIGdjaGFyICpmaWxlbmFtZSA9IGdfc3RyZGVsaW1pdChnX3N0cmR1cChzdWdnZXN0 ZWRGaWxlbmFtZSksIEdfRElSX1NFUEFSQVRPUl9TLCAnXycpOworICAgIGdjaGFyICpkZXN0aW5h dGlvbiA9IGdfYnVpbGRfZmlsZW5hbWUoZG93bmxvYWRzRGlyLCBmaWxlbmFtZSwgTlVMTCk7Cisg ICAgZ2NoYXIgKmRlc3RpbmF0aW9uVVJJID0gZ19maWxlbmFtZV90b191cmkoZGVzdGluYXRpb24s IDAsIDApOworCisgICAgaWYgKGRlc3RpbmF0aW9uVVJJKSB7CisgICAgICAgIHdlYmtpdF9kb3du bG9hZF9zZXRfZGVzdGluYXRpb24oZG93bmxvYWQsIGRlc3RpbmF0aW9uVVJJKTsKKyAgICAgICAg cmVzdWx0ID0gVFJVRTsKKyAgICB9CisKKyAgICBnX2ZyZWUoZmlsZW5hbWUpOworICAgIGdfZnJl ZShkZXN0aW5hdGlvbik7CisgICAgZ19mcmVlKGRlc3RpbmF0aW9uVVJJKTsKKyAgICByZXR1cm4g cmVzdWx0OworfQorCiBzdGF0aWMgdm9pZCBkb3dubG9hZFJlY2VpdmVkRGF0YShXZWJLaXREb3du bG9hZCAqZG93bmxvYWQsIGd1aW50NjQgZGF0YUxlbmd0aCwgQnJvd3NlckRvd25sb2FkICpicm93 c2VyRG93bmxvYWQpCiB7CiAgICAgYnJvd3NlckRvd25sb2FkLT5kb3dubG9hZGVkU2l6ZSArPSBk YXRhTGVuZ3RoOwpAQCAtMjYwLDYgKzI4NSw3IEBAIEd0a1dpZGdldCAqYnJvd3NlckRvd25sb2Fk TmV3KFdlYktpdERvd25sb2FkICpkb3dubG9hZCkKICAgICBicm93c2VyRG93bmxvYWQtPmRvd25s b2FkID0gZ19vYmplY3RfcmVmKGRvd25sb2FkKTsKICAgICBnX3NpZ25hbF9jb25uZWN0KGJyb3dz ZXJEb3dubG9hZC0+ZG93bmxvYWQsICJub3RpZnk6OnJlc3BvbnNlIiwgR19DQUxMQkFDSyhkb3du bG9hZFJlY2VpdmVkUmVzcG9uc2UpLCBicm93c2VyRG93bmxvYWQpOwogICAgIGdfc2lnbmFsX2Nv bm5lY3QoYnJvd3NlckRvd25sb2FkLT5kb3dubG9hZCwgIm5vdGlmeTo6ZXN0aW1hdGVkLXByb2dy ZXNzIiwgR19DQUxMQkFDSyhkb3dubG9hZFByb2dyZXNzKSwgYnJvd3NlckRvd25sb2FkKTsKKyAg ICBnX3NpZ25hbF9jb25uZWN0KGJyb3dzZXJEb3dubG9hZC0+ZG93bmxvYWQsICJkZWNpZGUtZGVz dGluYXRpb24iLCBHX0NBTExCQUNLKGRvd25sb2FkRGVjaWRlRGVzdGluYXRpb24pLCBicm93c2Vy RG93bmxvYWQpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QoYnJvd3NlckRvd25sb2FkLT5kb3dubG9h ZCwgInJlY2VpdmVkLWRhdGEiLCBHX0NBTExCQUNLKGRvd25sb2FkUmVjZWl2ZWREYXRhKSwgYnJv d3NlckRvd25sb2FkKTsKICAgICBnX3NpZ25hbF9jb25uZWN0KGJyb3dzZXJEb3dubG9hZC0+ZG93 bmxvYWQsICJmaW5pc2hlZCIsIEdfQ0FMTEJBQ0soZG93bmxvYWRGaW5pc2hlZCksIGJyb3dzZXJE b3dubG9hZCk7CiAgICAgZ19zaWduYWxfY29ubmVjdChicm93c2VyRG93bmxvYWQtPmRvd25sb2Fk LCAiZmFpbGVkIiwgR19DQUxMQkFDSyhkb3dubG9hZEZhaWxlZCksIGJyb3dzZXJEb3dubG9hZCk7 Cg== 205068 2013-06-20 03:42:51 -0700 2013-06-28 01:29:30 -0700 Patch bug-117538-20130620134101.patch text/plain 2031 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjViOGJlNjc2MjllZDBh ZTYzMjJhZmQzYWJhM2MwMzQ4ZjNjODIyOS4uNDY4OGIzMDk2MTk3ZWU1NWQ3MDVjOTcxZTcxYjE5 N2JiODIyZmIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTIwICBBbmRy ZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNaW5pQnJvd3Nl ciBkb2Vzbid0IHNvbHZlIHRoZSBzYXZpbmcgbG9jYXRpb24gd2hlbiB0aGVyZSBhcmUgbm8gWERH IHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTc1MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiB0aGUgWERHIHNwZWNpZmljYXRpb24gaXMgbm90IHdvcmtpbmcgZm9yIHRoZSAiRG93bmxv YWRzIgorICAgICAgICBkaXJlY3RvcnksIGxldCdzIHVzZSBIT01FIGFzIGZhbGxiYWNrLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwOgorICAgICAgICAo d2Via2l0RG93bmxvYWREZWNpZGVEZXN0aW5hdGlvbik6CisKIDIwMTMtMDYtMTkgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBDYW5u b3Qgb3BlbiBTaWx2ZXJsaWdodCBwcmVmZXJlbmNlcyB2aWEgY29udGV4dCBtZW51CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAKaW5k ZXggZTUzMjU0MWQwMmYwOTI5NGMyODAwYTQwNDEzZjQ0YmM3MGZkMWNjYi4uZTk1MjRjMjA5YjAy OWZiNWU2NTM2ZWJmNTdjZmIyZWI0MjE2NDU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcApAQCAtMTE0LDcgKzExNCwxMiBA QCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0RG93bmxvYWREZWNpZGVEZXN0aW5hdGlvbihXZWJLaXRE b3dubG9hZCogZG93bmxvYWQsIGNvbnN0CiAgICAgICAgIHJldHVybiBGQUxTRTsKIAogICAgIEdP d25QdHI8Y2hhcj4gZmlsZW5hbWUoZ19zdHJkZWxpbWl0KGdfc3RyZHVwKHN1Z2dlc3RlZEZpbGVu YW1lKSwgR19ESVJfU0VQQVJBVE9SX1MsICdfJykpOwotICAgIEdPd25QdHI8Y2hhcj4gZGVzdGlu YXRpb24oZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX3NwZWNpYWxfZGlyKEdfVVNFUl9ESVJF Q1RPUllfRE9XTkxPQUQpLCBmaWxlbmFtZS5nZXQoKSwgTlVMTCkpOworICAgIGNvbnN0IGdjaGFy ICpkb3dubG9hZHNEaXIgPSBnX2dldF91c2VyX3NwZWNpYWxfZGlyKEdfVVNFUl9ESVJFQ1RPUllf RE9XTkxPQUQpOworICAgIGlmICghZG93bmxvYWRzRGlyKSB7CisgICAgICAgIC8vIElmIHdlIGRv bid0IGhhdmUgWERHIHVzZXIgZGlycyBpbmZvLCBzZXQganVzdCB0byBIT01FLgorICAgICAgICBk b3dubG9hZHNEaXIgPSBnX2dldF9ob21lX2RpcigpOworICAgIH0KKyAgICBHT3duUHRyPGNoYXI+ IGRlc3RpbmF0aW9uKGdfYnVpbGRfZmlsZW5hbWUoZG93bmxvYWRzRGlyLCBmaWxlbmFtZS5nZXQo KSwgTlVMTCkpOwogICAgIEdPd25QdHI8Y2hhcj4gZGVzdGluYXRpb25VUkkoZ19maWxlbmFtZV90 b191cmkoZGVzdGluYXRpb24uZ2V0KCksIDAsIDApKTsKICAgICBkb3dubG9hZC0+cHJpdi0+ZGVz dGluYXRpb25VUkkgPSBkZXN0aW5hdGlvblVSSS5nZXQoKTsKICAgICBnX29iamVjdF9ub3RpZnko R19PQkpFQ1QoZG93bmxvYWQpLCAiZGVzdGluYXRpb24iKTsK