117535 2013-06-12 03:27:08 -0700 [Qt] Set windows key-code for multimedia keys 2013-06-12 04:44:48 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen hausmann jturcotte oldest_to_newest 899489 0 allan.jensen 2013-06-12 03:27:08 -0700 We do not currently set the windows keycode for generated key events for multimedia keys. Some of them do have well-defined values though. 899490 1 204423 allan.jensen 2013-06-12 03:28:49 -0700 Created attachment 204423 Patch 899493 2 204423 jturcotte 2013-06-12 03:48:03 -0700 Comment on attachment 204423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204423&action=review > Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp:439 > // VK_VOLUME_MUTE (AD) Windows 2000/XP: Volume Mute key > + case Qt::Key_VolumeMute: > + return VK_VOLUME_MUTE; Part of the file moves the comment after the value and remove the name in the comment. return VK_VOLUME_MUTE; // (AD) Windows 2000/XP: Volume Mute key I think it would be easier to read (slightly). r=me for the rest. 899500 3 allan.jensen 2013-06-12 04:44:48 -0700 Committed r151494: <http://trac.webkit.org/changeset/151494> 204423 2013-06-12 03:28:49 -0700 2013-06-12 03:48:03 -0700 Patch bug-117535-20130612122709.patch text/plain 2589 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU1ODJlYTY3ZDBiOWRj NWE0YmI1MWRmY2E2MjRkYjMxNTdjNWQ5Yy4uOTg4NTEyZTE2ZjcwZjA1NWY4ZTFiODNlZWJmZmJi NjFjZTFhYmU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTEyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gU2V0IHdpbmRvd3Mga2V5LWNvZGUgZm9yIG11bHRpbWVkaWEga2V5cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NTM1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFwIFF0IEtleS1ldmVudHMgdG8g dGhlaXIgZGVmaW5lZCB3aW5kb3dzIGtleWNvZGUgdmFsdWVzLgorCisgICAgICAgICogcGxhdGZv cm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6d2lu ZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMTMtMDYtMTAgIEJlbmphbWluIFBvdWxhaW4g IDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBzcGVjaWFsIHRyZWUgd2Fsa2lu ZyBmb3IgdGhlIHNpbmdsZSB0YWcgb3IgY2xhc3MgQ1NTIHF1ZXJ5IHNlbGVjdG9ycwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQu Y3BwCmluZGV4IGFmMjI5N2FkODZlOTk2YzZlYTc1YWQwOGJjZDUxZjI4ZDI0NTM1MTAuLmYxMzA0 NGM3ZjMzMDQzMDk4ZjdjMjc3MzRhMTlmYTJhYmVmZmQ5ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKQEAgLTQz MywxMyArNDMzLDI5IEBAIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVkIGlu dCBrZXljb2RlLCBib29sIGlzS2V5cGFkKQogICAgICAgICAvLyBWS19CUk9XU0VSX1NFQVJDSCAo QUEpIFdpbmRvd3MgMjAwMC9YUDogQnJvd3NlciBTZWFyY2gga2V5CiAgICAgICAgIC8vIFZLX0JS T1dTRVJfRkFWT1JJVEVTIChBQikgV2luZG93cyAyMDAwL1hQOiBCcm93c2VyIEZhdm9yaXRlcyBr ZXkKICAgICAgICAgLy8gVktfQlJPV1NFUl9IT01FIChBQykgV2luZG93cyAyMDAwL1hQOiBCcm93 c2VyIFN0YXJ0IGFuZCBIb21lIGtleQorCiAgICAgICAgIC8vIFZLX1ZPTFVNRV9NVVRFIChBRCkg V2luZG93cyAyMDAwL1hQOiBWb2x1bWUgTXV0ZSBrZXkKKyAgICBjYXNlIFF0OjpLZXlfVm9sdW1l TXV0ZToKKyAgICAgICAgcmV0dXJuIFZLX1ZPTFVNRV9NVVRFOwogICAgICAgICAvLyBWS19WT0xV TUVfRE9XTiAoQUUpIFdpbmRvd3MgMjAwMC9YUDogVm9sdW1lIERvd24ga2V5CisgICAgY2FzZSBR dDo6S2V5X1ZvbHVtZURvd246CisgICAgICAgIHJldHVybiBWS19WT0xVTUVfRE9XTjsKICAgICAg ICAgLy8gVktfVk9MVU1FX1VQIChBRikgV2luZG93cyAyMDAwL1hQOiBWb2x1bWUgVXAga2V5Cisg ICAgY2FzZSBRdDo6S2V5X1ZvbHVtZVVwOgorICAgICAgICByZXR1cm4gVktfVk9MVU1FX1VQOwog ICAgICAgICAvLyBWS19NRURJQV9ORVhUX1RSQUNLIChCMCkgV2luZG93cyAyMDAwL1hQOiBOZXh0 IFRyYWNrIGtleQorICAgIGNhc2UgUXQ6OktleV9NZWRpYU5leHQ6CisgICAgICAgIHJldHVybiBW S19NRURJQV9ORVhUX1RSQUNLOwogICAgICAgICAvLyBWS19NRURJQV9QUkVWX1RSQUNLIChCMSkg V2luZG93cyAyMDAwL1hQOiBQcmV2aW91cyBUcmFjayBrZXkKKyAgICBjYXNlIFF0OjpLZXlfTWVk aWFQcmV2aW91czoKKyAgICAgICAgcmV0dXJuIFZLX01FRElBX1BSRVZfVFJBQ0s7CiAgICAgICAg IC8vIFZLX01FRElBX1NUT1AgKEIyKSBXaW5kb3dzIDIwMDAvWFA6IFN0b3AgTWVkaWEga2V5Cisg ICAgY2FzZSBRdDo6S2V5X01lZGlhU3RvcDoKKyAgICAgICAgcmV0dXJuIFZLX01FRElBX1NUT1A7 CiAgICAgICAgIC8vIFZLX01FRElBX1BMQVlfUEFVU0UgKEIzKSBXaW5kb3dzIDIwMDAvWFA6IFBs YXkvUGF1c2UgTWVkaWEga2V5CisgICAgY2FzZSBRdDo6S2V5X01lZGlhVG9nZ2xlUGxheVBhdXNl OgorICAgICAgICByZXR1cm4gVktfTUVESUFfUExBWV9QQVVTRTsKKwogICAgICAgICAvLyBWS19M QVVOQ0hfTUFJTCAoQjQpIFdpbmRvd3MgMjAwMC9YUDogU3RhcnQgTWFpbCBrZXkKICAgICAgICAg Ly8gVktfTEFVTkNIX01FRElBX1NFTEVDVCAoQjUpIFdpbmRvd3MgMjAwMC9YUDogU2VsZWN0IE1l ZGlhIGtleQogICAgICAgICAvLyBWS19MQVVOQ0hfQVBQMSAoQjYpIFdpbmRvd3MgMjAwMC9YUDog U3RhcnQgQXBwbGljYXRpb24gMSBrZXkK