117514 2013-06-11 11:06:13 -0700 Too many XcodeCoverageSupportOptions 2013-06-12 00:30:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 0 achristensen webkit-unassigned commit-queue dbates oldest_to_newest 899233 0 achristensen 2013-06-11 11:06:13 -0700 build-webkit --coverage and build-jsc --coverage fail because there are too many coverage support options that do not seem to have been updated in a few years. The only ones that are necessary to generate coverage code are GCC_GENERATE_TEST_COVERAGE_FILES=YES and GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES. Xcode takes care of the rest. #ifdef COVERAGE does not appear in the code. I'm not sure what the -MD flag does, but it causes webkit to not compile. 899234 1 204345 achristensen 2013-06-11 11:10:18 -0700 Created attachment 204345 Patch 899264 2 204345 commit-queue 2013-06-11 13:02:10 -0700 Comment on attachment 204345 Patch Clearing flags on attachment: 204345 Committed r151461: <http://trac.webkit.org/changeset/151461> 899265 3 commit-queue 2013-06-11 13:02:13 -0700 All reviewed patches have been landed. Closing bug. 899463 4 ap 2013-06-12 00:30:59 -0700 > I'm not sure what the -MD flag does Looks like a gcc option, ----------------- -MD is equivalent to -M -MF file, except that -E is not implied. The driver determines file based on whether an -o option is given. If it is, the driver uses its argument but with a suffix of .d, otherwise it take the basename of the input file and applies a .d suffix. If -MD is used in conjunction with -E, any -o switch is understood to specify the dependency output file (but see -MF), but if used without -E, each -o is understood to specify a target object file. Since -E is not implied, -MD can be used to generate a dependency output file as a side-effect of the compilation process. ----------------- 204345 2013-06-11 11:10:18 -0700 2013-06-11 13:02:10 -0700 Patch bug-117514-20130611110839.patch text/plain 1359 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1MTQ0MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTA2LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFw cGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE3NTE0CisgICAgICAgIFJlbW92ZWQgZXh0cmEgWGNvZGUgY29kZSBjb3ZlcmFnZSBmbGFn cy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKFhjb2RlQ292ZXJhZ2VTdXBwb3J0T3B0aW9u cyk6CisKIDIwMTMtMDYtMTEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K IAogICAgICAgICBNYWtlIFdUUiB1c2UgaXRzIG93biB0ZW1wb3JhcnkgZGlyZWN0b3J5IGZvciBh cHBsaWNhdGlvbiBjYWNoZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTUxMDMzKQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01OTcsOSAr NTk3LDYgQEAgc3ViIFhjb2RlQ292ZXJhZ2VTdXBwb3J0T3B0aW9ucygpCiAgICAgbXkgQGNvdmVy YWdlU3VwcG9ydE9wdGlvbnMgPSAoKTsKICAgICBwdXNoIEBjb3ZlcmFnZVN1cHBvcnRPcHRpb25z LCAiR0NDX0dFTkVSQVRFX1RFU1RfQ09WRVJBR0VfRklMRVM9WUVTIjsKICAgICBwdXNoIEBjb3Zl cmFnZVN1cHBvcnRPcHRpb25zLCAiR0NDX0lOU1RSVU1FTlRfUFJPR1JBTV9GTE9XX0FSQ1M9WUVT IjsKLSAgICBwdXNoIEBjb3ZlcmFnZVN1cHBvcnRPcHRpb25zLCAiRVhUUkFfTElOSz0gXCQoRVhU UkFfTElOSykgLWZ0ZXN0LWNvdmVyYWdlIC1mcHJvZmlsZS1hcmNzIjsKLSAgICBwdXNoIEBjb3Zl cmFnZVN1cHBvcnRPcHRpb25zLCAiT1RIRVJfQ0ZMQUdTPSBcJChPVEhFUl9DRkxBR1MpIC1EQ09W RVJBR0UgLU1EIjsKLSAgICBwdXNoIEBjb3ZlcmFnZVN1cHBvcnRPcHRpb25zLCAiT1RIRVJfTERG TEFHUz1cJChPVEhFUl9MREZMQUdTKSAtZnRlc3QtY292ZXJhZ2UgLWZwcm9maWxlLWFyY3MgLWxn Y292IjsKICAgICByZXR1cm4gQGNvdmVyYWdlU3VwcG9ydE9wdGlvbnM7CiB9CiAK