11749 2006-12-04 15:00:43 -0800 ScrollBar::setProportion() calls updateThumbProportion() unnecessarily 2006-12-07 16:23:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC All RESOLVED FIXED http://mlb.mlb.com P2 Normal --- 1 dgibson77 dgibson77 oldest_to_newest 43466 0 dgibson77 2006-12-04 15:00:43 -0800 setProportion() blindly calls updateThumbProportion() even when nothing has changed. Depending on how platforms implement updateThumbProportion(), this can lead to anything from too much work to infinite loops. Rather than force updateThumbProportion() to realize when the proportion has not been updated, we should just make setProportion() be like setPosition() and do nothing when appropriate. Patch coming shortly. 43410 1 11731 dgibson77 2006-12-04 15:10:47 -0800 Created attachment 11731 patch v1 The simplest possible fix. I could have made setProportion() return a bool (like setPosition() does) or check that its arguments were positive, but I didn't have a particular reason to do so. 43271 2 ap 2006-12-05 01:13:50 -0800 (In reply to comment #0) > Depending on how platforms implement updateThumbProportion(), this > can lead to anything from too much work to infinite loops. Sounds like this fix needs a layout test then (especially if the latter is the Windows behavior). Is it possible to make one? 42949 3 11731 darin 2006-12-07 15:42:03 -0800 Comment on attachment 11731 patch v1 Looks fine, r=me. 42914 4 mrowe 2006-12-07 16:23:06 -0800 Landed in r18066. 11731 2006-12-04 15:10:47 -0800 2006-12-07 15:42:03 -0800 patch v1 patch text/plain 1036 dgibson77 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODAwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMTItMDQgIERvbiBHaWJzb24gIDxkZ2lic29uNzdAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzQ5OgorICAgICAgICBEb24n dCBjYWxsIHVwZGF0ZVRodW1iUHJvcG9ydGlvbigpIHVubmVjZXNzYXJpbHkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9TY3JvbGxCYXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyOjpz ZXRQcm9wb3J0aW9uKToKKwogMjAwNi0xMi0wNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3Igbm9uLVNWRyBidWlsZHMKSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vU2Nyb2xsQmFyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbEJhci5jcHAJKHJldmlzaW9uIDE4MDAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxCYXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSw2ICs2MSw5IEBAIGJvb2wgU2Nyb2xsYmFy OjpzZXRWYWx1ZShpbnQgdikKIAogdm9pZCBTY3JvbGxiYXI6OnNldFByb3BvcnRpb24oaW50IHZp c2libGVTaXplLCBpbnQgdG90YWxTaXplKQogeworICAgIGlmICh2aXNpYmxlU2l6ZSA9PSBtX3Zp c2libGVTaXplICYmIHRvdGFsU2l6ZSA9PSBtX3RvdGFsU2l6ZSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgbV92aXNpYmxlU2l6ZSA9IHZpc2libGVTaXplOwogICAgIG1fdG90YWxTaXplID0gdG90 YWxTaXplOwogCg==