117485 2013-06-10 21:23:01 -0700 text-transform: capitalize shouldn't upconvert 2013-06-10 22:40:40 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa abarth benjamin commit-queue darin esprehn+autocc glenn msaboff oldest_to_newest 899004 0 rniwa 2013-06-10 21:23:01 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/c5a221d6da2443df0639c01c40aac6040908ec79 In looking at STRING_STATS for Mobile New York Times, I noticed that text-transform: capitalize is bloating memory by upconverting strings. It's a small amount of memory, but there's no reason to upconvert the strings. After this CL, all the strings used by Mobile New York Times are fully optimized (or at least they will be after https://codereview.chromium.org/16158008/ lands). 899006 1 204282 rniwa 2013-06-10 21:36:50 -0700 Created attachment 204282 Merges the patch 899029 2 204282 commit-queue 2013-06-10 22:40:38 -0700 Comment on attachment 204282 Merges the patch Clearing flags on attachment: 204282 Committed r151422: <http://trac.webkit.org/changeset/151422> 899030 3 commit-queue 2013-06-10 22:40:40 -0700 All reviewed patches have been landed. Closing bug. 204282 2013-06-10 21:36:50 -0700 2013-06-10 22:40:38 -0700 Merges the patch bug-117485-20130610213512.patch text/plain 2896 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTQxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTEwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHRleHQtdHJhbnNmb3JtOiBjYXBp dGFsaXplIHNob3VsZG4ndCB1cGNvbnZlcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNzQ4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEF2b2lkIHRoZSB1cGNvbnZlcnNpb24uIE1lcmdlIGh0dHBzOi8v Y2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rL2M1YTIyMWQ2ZGEyNDQz ZGYwNjM5YzAxYzQwYWFjNjA0MDkwOGVjNzkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy VGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjptYWtlQ2FwaXRhbGl6ZWQpOgorCiAyMDEzLTA2 LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgbW9y ZSBmdW5jdGlvbnMgY29uc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4 dC5jcHAJKHJldmlzaW9uIDE1MTQxNCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDcgKzEwMCw3IEBAIHN0YXRpYyB2b2lk IG1ha2VDYXBpdGFsaXplZChTdHJpbmcqIHN0cmkKICAgICAgICAgcmV0dXJuOwogCiAgICAgdW5z aWduZWQgbGVuZ3RoID0gc3RyaW5nLT5sZW5ndGgoKTsKLSAgICBjb25zdCBVQ2hhciogY2hhcmFj dGVycyA9IHN0cmluZy0+Y2hhcmFjdGVycygpOworICAgIGNvbnN0IFN0cmluZ0ltcGwmIHN0cmlu Z0ltcGwgPSAqc3RyaW5nLT5pbXBsKCk7CiAKICAgICBpZiAobGVuZ3RoID49IG51bWVyaWNfbGlt aXRzPHVuc2lnbmVkPjo6bWF4KCkpCiAgICAgICAgIENSQVNIKCk7CkBAIC0xMDksMjggKzEwOSwy OSBAQCBzdGF0aWMgdm9pZCBtYWtlQ2FwaXRhbGl6ZWQoU3RyaW5nKiBzdHJpCiAgICAgc3RyaW5n V2l0aFByZXZpb3VzWzBdID0gcHJldmlvdXMgPT0gbm9CcmVha1NwYWNlID8gJyAnIDogcHJldmlv dXM7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMTsgaSA8IGxlbmd0aCArIDE7IGkrKykgewogICAg ICAgICAvLyBSZXBsYWNlICZuYnNwIHdpdGggYSByZWFsIHNwYWNlIHNpbmNlIElDVSBubyBsb25n ZXIgdHJlYXRzICZuYnNwIGFzIGEgd29yZCBzZXBhcmF0b3IuCi0gICAgICAgIGlmIChjaGFyYWN0 ZXJzW2kgLSAxXSA9PSBub0JyZWFrU3BhY2UpCisgICAgICAgIGlmIChzdHJpbmdJbXBsW2kgLSAx XSA9PSBub0JyZWFrU3BhY2UpCiAgICAgICAgICAgICBzdHJpbmdXaXRoUHJldmlvdXNbaV0gPSAn ICc7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHN0cmluZ1dpdGhQcmV2aW91c1tpXSA9IGNo YXJhY3RlcnNbaSAtIDFdOworICAgICAgICAgICAgc3RyaW5nV2l0aFByZXZpb3VzW2ldID0gc3Ry aW5nSW1wbFtpIC0gMV07CiAgICAgfQogCiAgICAgVGV4dEJyZWFrSXRlcmF0b3IqIGJvdW5kYXJ5 ID0gd29yZEJyZWFrSXRlcmF0b3Ioc3RyaW5nV2l0aFByZXZpb3VzLmNoYXJhY3RlcnMoKSwgbGVu Z3RoICsgMSk7CiAgICAgaWYgKCFib3VuZGFyeSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgU3Ry aW5nQnVmZmVyPFVDaGFyPiBkYXRhKGxlbmd0aCk7CisgICAgU3RyaW5nQnVpbGRlciByZXN1bHQ7 CisgICAgcmVzdWx0LnJlc2VydmVDYXBhY2l0eShsZW5ndGgpOwogCiAgICAgaW50MzJfdCBlbmRP ZldvcmQ7CiAgICAgaW50MzJfdCBzdGFydE9mV29yZCA9IHRleHRCcmVha0ZpcnN0KGJvdW5kYXJ5 KTsKICAgICBmb3IgKGVuZE9mV29yZCA9IHRleHRCcmVha05leHQoYm91bmRhcnkpOyBlbmRPZldv cmQgIT0gVGV4dEJyZWFrRG9uZTsgc3RhcnRPZldvcmQgPSBlbmRPZldvcmQsIGVuZE9mV29yZCA9 IHRleHRCcmVha05leHQoYm91bmRhcnkpKSB7CiAgICAgICAgIGlmIChzdGFydE9mV29yZCkgLy8g SWdub3JlIGZpcnN0IGNoYXIgb2YgcHJldmlvdXMgc3RyaW5nCi0gICAgICAgICAgICBkYXRhW3N0 YXJ0T2ZXb3JkIC0gMV0gPSBjaGFyYWN0ZXJzW3N0YXJ0T2ZXb3JkIC0gMV0gPT0gbm9CcmVha1Nw YWNlID8gbm9CcmVha1NwYWNlIDogdG9UaXRsZUNhc2Uoc3RyaW5nV2l0aFByZXZpb3VzW3N0YXJ0 T2ZXb3JkXSk7CisgICAgICAgICAgICByZXN1bHQuYXBwZW5kKHN0cmluZ0ltcGxbc3RhcnRPZldv cmQgLSAxXSA9PSBub0JyZWFrU3BhY2UgPyBub0JyZWFrU3BhY2UgOiB0b1RpdGxlQ2FzZShzdHJp bmdXaXRoUHJldmlvdXNbc3RhcnRPZldvcmRdKSk7CiAgICAgICAgIGZvciAoaW50IGkgPSBzdGFy dE9mV29yZCArIDE7IGkgPCBlbmRPZldvcmQ7IGkrKykKLSAgICAgICAgICAgIGRhdGFbaSAtIDFd ID0gY2hhcmFjdGVyc1tpIC0gMV07CisgICAgICAgICAgICByZXN1bHQuYXBwZW5kKHN0cmluZ0lt cGxbaSAtIDFdKTsKICAgICB9CiAKLSAgICAqc3RyaW5nID0gU3RyaW5nOjphZG9wdChkYXRhKTsK KyAgICAqc3RyaW5nID0gcmVzdWx0LnRvU3RyaW5nKCk7CiB9CiAKIFJlbmRlclRleHQ6OlJlbmRl clRleHQoTm9kZSogbm9kZSwgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBzdHIpCg==