117475 2013-06-10 20:48:30 -0700 There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds 2013-06-11 11:49:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa commit-queue oldest_to_newest 898986 0 rniwa 2013-06-10 20:48:30 -0700 There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds 898987 1 204280 rniwa 2013-06-10 20:49:07 -0700 Created attachment 204280 Cleanup 898988 2 rniwa 2013-06-10 20:50:22 -0700 Merging https://chromium.googlesource.com/chromium/blink/+/7e84ad771ca41b3b0dad937238090babb6f52499 899244 3 204280 commit-queue 2013-06-11 11:49:19 -0700 Comment on attachment 204280 Cleanup Clearing flags on attachment: 204280 Committed r151449: <http://trac.webkit.org/changeset/151449> 899245 4 commit-queue 2013-06-11 11:49:21 -0700 All reviewed patches have been landed. Closing bug. 204280 2013-06-10 20:49:07 -0700 2013-06-11 11:49:18 -0700 Cleanup bug-117475-20130610204729.patch text/plain 3113 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTQxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2LTEwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFRoZXJlIGFyZSB1bnVzZWQgdmFy aWFibGVzIGluIEFwcGx5U3R5bGVDb21tYW5kOjptZXJnZUVuZFdpdGhOZXh0SWZJZGVudGljYWwg YW5kIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpyZW1vdmVVbnJlbmRlcmVkVGV4dE5vZGVzQXRF bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0 NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmVkLgorCisgICAgICAgICogZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpBcHBseVN0eWxlQ29tbWFuZDo6bWVyZ2VFbmRXaXRoTmV4dElmSWRlbnRpY2Fs KToKKyAgICAgICAgKiBlZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpyZW1vdmVVbnJlbmRlcmVkVGV4 dE5vZGVzQXRFbmRzKToKKwogMjAxMy0wNi0xMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBNYWtlIG1vcmUgZnVuY3Rpb25zIGNvbnN0CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAkocmV2aXNpb24gMTUxNDE0 KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEzMDMsMTggKzEzMDMsMTMgQEAgYm9vbCBBcHBseVN0eWxlQ29tbWFuZDo6 bWVyZ2VTdGFydFdpdGhQcgogYm9vbCBBcHBseVN0eWxlQ29tbWFuZDo6bWVyZ2VFbmRXaXRoTmV4 dElmSWRlbnRpY2FsKGNvbnN0IFBvc2l0aW9uJiBzdGFydCwgY29uc3QgUG9zaXRpb24mIGVuZCkK IHsKICAgICBOb2RlKiBlbmROb2RlID0gZW5kLmNvbnRhaW5lck5vZGUoKTsKLSAgICBpbnQgZW5k T2Zmc2V0ID0gZW5kLmNvbXB1dGVPZmZzZXRJbkNvbnRhaW5lck5vZGUoKTsKIAogICAgIGlmIChp c0F0b21pY05vZGUoZW5kTm9kZSkpIHsKLSAgICAgICAgaWYgKG9mZnNldElzQmVmb3JlTGFzdE5v ZGVPZmZzZXQoZW5kT2Zmc2V0LCBlbmROb2RlKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsK LQotICAgICAgICB1bnNpZ25lZCBwYXJlbnRMYXN0T2Zmc2V0ID0gZW5kLmRlcHJlY2F0ZWROb2Rl KCktPnBhcmVudE5vZGUoKS0+Y2hpbGROb2RlQ291bnQoKSAtIDE7Ci0gICAgICAgIGlmIChlbmQu ZGVwcmVjYXRlZE5vZGUoKS0+bmV4dFNpYmxpbmcoKSkKKyAgICAgICAgaW50IGVuZE9mZnNldCA9 IGVuZC5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCk7CisgICAgICAgIGlmIChvZmZzZXRJ c0JlZm9yZUxhc3ROb2RlT2Zmc2V0KGVuZE9mZnNldCwgZW5kTm9kZSkgfHwgZW5kLmRlcHJlY2F0 ZWROb2RlKCktPm5leHRTaWJsaW5nKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAg ICAgICAgZW5kTm9kZSA9IGVuZC5kZXByZWNhdGVkTm9kZSgpLT5wYXJlbnROb2RlKCk7Ci0gICAg ICAgIGVuZE9mZnNldCA9IHBhcmVudExhc3RPZmZzZXQ7CiAgICAgfQogCiAgICAgaWYgKCFlbmRO b2RlLT5pc0VsZW1lbnROb2RlKCkgfHwgZW5kTm9kZS0+aGFzVGFnTmFtZShiclRhZykpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5k LmNwcAkocmV2aXNpb24gMTUxNDE0KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNl U2VsZWN0aW9uQ29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3NiwxMCArNjc2LDkgQEAg dm9pZCBSZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6cmVtb3ZlVW5yZQogICAgICAgICByZW1vdmVO b2RlKGxhc3RMZWFmSW5zZXJ0ZWQpOwogICAgIH0KIAotICAgIC8vIFdlIGRvbid0IGhhdmUgdG8g bWFrZSBzdXJlIHRoYXQgZmlyc3ROb2RlSW5zZXJ0ZWQgaXNuJ3QgaW5zaWRlIGEgc2VsZWN0IG9y IHNjcmlwdCBlbGVtZW50LCBiZWNhdXNlCi0gICAgLy8gaXQgaXMgYSB0b3AgbGV2ZWwgbm9kZSBp biB0aGUgZnJhZ21lbnQgYW5kIHRoZSB1c2VyIGNhbid0IGluc2VydCBpbnRvIHRob3NlIGVsZW1l bnRzLgorICAgIC8vIFdlIGRvbid0IGhhdmUgdG8gbWFrZSBzdXJlIHRoYXQgZmlyc3ROb2RlSW5z ZXJ0ZWQgaXNuJ3QgaW5zaWRlIGEgc2VsZWN0IG9yIHNjcmlwdCBlbGVtZW50CisgICAgLy8gYmVj YXVzZSBpdCBpcyBhIHRvcCBsZXZlbCBub2RlIGluIHRoZSBmcmFnbWVudCBhbmQgdGhlIHVzZXIg Y2FuJ3QgaW5zZXJ0IGludG8gdGhvc2UgZWxlbWVudHMuCiAgICAgTm9kZSogZmlyc3ROb2RlSW5z ZXJ0ZWQgPSBpbnNlcnRlZE5vZGVzLmZpcnN0Tm9kZUluc2VydGVkKCk7Ci0gICAgbGFzdExlYWZJ bnNlcnRlZCA9IGluc2VydGVkTm9kZXMubGFzdExlYWZJbnNlcnRlZCgpOwogICAgIGlmIChmaXJz dE5vZGVJbnNlcnRlZCAmJiBmaXJzdE5vZGVJbnNlcnRlZC0+aXNUZXh0Tm9kZSgpICYmICFub2Rl SGFzVmlzaWJsZVJlbmRlclRleHQodG9UZXh0KGZpcnN0Tm9kZUluc2VydGVkKSkpIHsKICAgICAg ICAgaW5zZXJ0ZWROb2Rlcy53aWxsUmVtb3ZlTm9kZShmaXJzdE5vZGVJbnNlcnRlZCk7CiAgICAg ICAgIHJlbW92ZU5vZGUoZmlyc3ROb2RlSW5zZXJ0ZWQpOwo=