11747 2006-12-03 19:03:38 -0800 [S60] when html doc begins with comments, parsing fails to update elementsById table 2006-12-15 14:41:47 -0800 1 1 1 Unclassified WebKit DOM 412 S60 Emulator S60 3rd edition CLOSED FIXED P2 Normal --- 1 shaun.keller webkit-unassigned oldest_to_newest 43430 0 shaun.keller 2006-12-03 19:03:38 -0800 TSW# YZHG-6TEKLK 43431 1 11724 shaun.keller 2006-12-03 19:22:29 -0800 Created attachment 11724 allow for comment nodes when deciding to synthesize a missing html node made against 3.2 43095 2 11751 shaun.keller 2006-12-06 07:37:25 -0800 Created attachment 11751 simplified according to Antti Koivisto's suggestion passed test 43073 3 11751 zalan 2006-12-06 18:24:07 -0800 Comment on attachment 11751 simplified according to Antti Koivisto's suggestion r=me 42920 4 zalan 2006-12-07 18:04:42 -0800 r18070 3.2 41671 5 krishnamurty.podipireddy 2006-12-15 14:41:47 -0800 Verified and Closed. 11724 2006-12-03 19:22:29 -0800 2006-12-06 07:37:25 -0800 allow for comment nodes when deciding to synthesize a missing html node leading-comments.patch text/plain 2451 shaun.keller SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDE3OTk0KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE0IEBADQorMjAwNi0xMi0wMyAgc2hrZWxsZXIgIDxzaGF1bi5rZWxsZXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgWmFsYW4gQnVqdGFzICh6YnVqdGFz QGdtYWlsLmNvbSkuDQorICAgICAgICBERVNDOiBzeW50aGVzaXplIG1pc3NpbmcgaHRtbCBub2Rl IHdoZW4gY29tbWVudHMgc3RhcnQgZG9jDQorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc0Nw0KKw0KKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNF UyBBRERFRCBPUiBDSEFOR0VEDQorDQorICAgICAgICAqIGtodG1sL2h0bWwvaHRtbHBhcnNlci5j cHA6DQorICAgICAgICAoS0hUTUxQYXJzZXI6Omluc2VydE5vZGUpOg0KKw0KIDIwMDYtMTEtMzAg IHlhZGF2YWxsICA8c3JpcmFtLnlhZGF2YWxsaUBub2tpYS5jb20+DQogDQogICAgICAgICBSZXZp ZXdlZCBieSBaYWxhbiBCdWp0YXMgKHpidWp0YXNAZ21haWwuY29tKS4NCkluZGV4OiBXZWJDb3Jl L2todG1sL2h0bWwvaHRtbHBhcnNlci5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL2todG1s L2h0bWwvaHRtbHBhcnNlci5jcHAJKHJldmlzaW9uIDE3OTI5KQ0KKysrIFdlYkNvcmUva2h0bWwv aHRtbC9odG1scGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTc2Myw5ICs3NjMsMjkgQEAg Ym9vbCBLSFRNTFBhcnNlcjo6aW5zZXJ0Tm9kZShOb2RlSW1wbCAqbg0KICAgICAgICAgICAgIGhh bmRsZWQgPSB0cnVlOw0KICAgICAgICAgICAgIGJyZWFrOw0KICAgICAgICAgZGVmYXVsdDoNCi0g ICAgICAgICAgICBpZihjdXJyZW50LT5pc0RvY3VtZW50Tm9kZSgpKQ0KLSAgICAgICAgICAgIHsN CisgICAgICAgICAgICAvLyBtYXkgaGF2ZSBmYWlsZWQgYmVjYXVzZSBkb2MgZGlkbid0IGJlZ2lu IHdpdGggaHRtbCBhbmQNCisgICAgICAgICAgICAvLyBkb2N1bWVudCBub2RlIGRvZXNuJ3QgcGVy bWl0IG11Y2ggZWxzZSBhcyBjaGlsZHJlbiwNCisgICAgICAgICAgICAvLyBzbyBtYXliZSBnZW5l cmF0ZSBhbiBodG1sIG5vZGUgYW5kIHRyeSBhZ2Fpbg0KKyAgICAgICAgICAgIGlmKGN1cnJlbnQt PmlzRG9jdW1lbnROb2RlKCkpIHsNCisgICAgICAgICAgICAgICAgYm9vbCBhZGRIVE1MID0gZmFs c2U7DQogICAgICAgICAgICAgICAgIGlmKGN1cnJlbnQtPmZpcnN0Q2hpbGQoKSA9PSAwKSB7DQor ICAgICAgICAgICAgICAgICAgICBhZGRIVE1MID0gdHJ1ZTsNCisgICAgICAgICAgICAgICAgfSBl bHNlIHsNCisgICAgICAgICAgICAgICAgICAgIC8vIHdoYXQncyBhbGxvd2VkIGFzIGNoaWxkcmVu IG11c3QgbWF0Y2ggd2hhdCdzDQorICAgICAgICAgICAgICAgICAgICAvLyBhbGxvd2VkIGluIEhU TUxEb2N1bWVudEltcGw6OmNoaWxkQWxsb3dlZCgpDQorICAgICAgICAgICAgICAgICAgICAvLyB3 aGljaCBhdCB0aW1lIG9mIGNvZGluZyBpcyBodG1sIGVsZW1lbnQgYW5kDQorICAgICAgICAgICAg ICAgICAgICAvLyBjb21tZW50cywgc28gaWYgZmluZCBhbnl0aGluZyBvdGhlciB0aGFuIGNvbW1l bnRzDQorICAgICAgICAgICAgICAgICAgICAvLyBpdCBtdXN0IGJlIGh0bWwgYWxyZWFkeQ0KKyAg ICAgICAgICAgICAgICAgICAgTm9kZUxpc3RJbXBsICpjaGlsZHJlbiA9IGN1cnJlbnQtPmNoaWxk Tm9kZXMoKTsNCisgICAgICAgICAgICAgICAgICAgIGludCBuQ2hpbGRyZW4gPSBjaGlsZHJlbiA/ IChpbnQpY2hpbGRyZW4tPmxlbmd0aCgpIDogMDsNCisgICAgICAgICAgICAgICAgICAgIGludCBp ID0gMDsNCisgICAgICAgICAgICAgICAgICAgIHdoaWxlKGkgPCBuQ2hpbGRyZW4pIHsNCisgICAg ICAgICAgICAgICAgICAgICAgICBOb2RlSW1wbCAqbiA9IGNoaWxkcmVuLT5pdGVtKGkrKyk7DQor ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG4tPm5vZGVUeXBlKCkgIT0gTm9kZTo6Q09NTUVO VF9OT0RFKSBicmVhazsNCisgICAgICAgICAgICAgICAgICAgIH0NCisgICAgICAgICAgICAgICAg ICAgIGlmKGkgPT0gbkNoaWxkcmVuKSBhZGRIVE1MID0gdHJ1ZTsNCisgICAgICAgICAgICAgICAg fQ0KKyAgICAgICAgICAgICAgICBpZihhZGRIVE1MKSB7DQogICAgICAgICAgICAgICAgICAgICBl ID0gbmV3IEhUTUxIdG1sRWxlbWVudEltcGwoZG9jdW1lbnQpOw0KICAgICAgICAgICAgICAgICAg ICAgaW5zZXJ0Tm9kZShlKTsNCiAgICAgICAgICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOw0K 11751 2006-12-06 07:37:25 -0800 2006-12-06 18:24:07 -0800 simplified according to Antti Koivisto's suggestion leading-comments-2.patch text/plain 1644 shaun.keller SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDE3OTk0KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE0IEBADQorMjAwNi0xMi0wMyAgc2hrZWxsZXIgIDxzaGF1bi5rZWxsZXJA bm9raWEuY29tPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgWmFsYW4gQnVqdGFzICh6YnVqdGFz QGdtYWlsLmNvbSkuDQorICAgICAgICBERVNDOiBzeW50aGVzaXplIG1pc3NpbmcgaHRtbCBub2Rl IHdoZW4gY29tbWVudHMgc3RhcnQgZG9jDQorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTc0Nw0KKw0KKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNF UyBBRERFRCBPUiBDSEFOR0VEDQorDQorICAgICAgICAqIGtodG1sL2h0bWwvaHRtbHBhcnNlci5j cHA6DQorICAgICAgICAoS0hUTUxQYXJzZXI6Omluc2VydE5vZGUpOg0KKw0KIDIwMDYtMTEtMzAg IHlhZGF2YWxsICA8c3JpcmFtLnlhZGF2YWxsaUBub2tpYS5jb20+DQogDQogICAgICAgICBSZXZp ZXdlZCBieSBaYWxhbiBCdWp0YXMgKHpidWp0YXNAZ21haWwuY29tKS4NCkluZGV4OiBXZWJDb3Jl L2todG1sL2h0bWwvaHRtbHBhcnNlci5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL2todG1s L2h0bWwvaHRtbHBhcnNlci5jcHAJKHJldmlzaW9uIDE3OTI5KQ0KKysrIFdlYkNvcmUva2h0bWwv aHRtbC9odG1scGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTc2Myw5ICs3NjMsMTIgQEAg Ym9vbCBLSFRNTFBhcnNlcjo6aW5zZXJ0Tm9kZShOb2RlSW1wbCAqbg0KICAgICAgICAgICAgIGhh bmRsZWQgPSB0cnVlOw0KICAgICAgICAgICAgIGJyZWFrOw0KICAgICAgICAgZGVmYXVsdDoNCi0g ICAgICAgICAgICBpZihjdXJyZW50LT5pc0RvY3VtZW50Tm9kZSgpKQ0KLSAgICAgICAgICAgIHsN Ci0gICAgICAgICAgICAgICAgaWYoY3VycmVudC0+Zmlyc3RDaGlsZCgpID09IDApIHsNCisgICAg ICAgICAgICAvLyBtYXliZSBtaXNzaW5nIGh0bWwgZWxlbWVudCwgaWYgc28gZ2VuZXJhdGUgb25l DQorICAgICAgICAgICAgaWYoY3VycmVudC0+aXNEb2N1bWVudE5vZGUoKSkgew0KKyAgICAgICAg ICAgICAgICAvLyB0ZXN0IG11c3QgbWF0Y2ggSFRNTERvY3VtZW50SW1wbDo6Y2hpbGRBbGxvd2Vk KCksDQorICAgICAgICAgICAgICAgIC8vIGlmIGZpbmQgZWxlbWVudCwgbXVzdCBhbHJlYWR5IGJl IGh0bWwNCisgICAgICAgICAgICAgICAgaWYoY3VycmVudC0+Zmlyc3RDaGlsZCgpID09IDANCisg ICAgICAgICAgICAgICAgICAgfHwgc3RhdGljX2Nhc3Q8RG9jdW1lbnRJbXBsKj4oY3VycmVudCkt PmRvY3VtZW50RWxlbWVudCgpPT0wKSB7DQogICAgICAgICAgICAgICAgICAgICBlID0gbmV3IEhU TUxIdG1sRWxlbWVudEltcGwoZG9jdW1lbnQpOw0KICAgICAgICAgICAgICAgICAgICAgaW5zZXJ0 Tm9kZShlKTsNCiAgICAgICAgICAgICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOw0K