117464 2013-06-10 18:39:41 -0700 Have to invalidate the mute button when changing the volume 2013-06-11 14:59:56 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa commit-queue eric.carlson esprehn+autocc glenn jer.noble jonlee oldest_to_newest 898958 0 rniwa 2013-06-10 18:39:41 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08 This is because the painting code in RenderMediaControlsChromium.cpp:paintMediaMuteButton depends on the volume, and that code gets called via RenderTheme, so nothing else can invalidate the button. diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp index c418b69..37a0418 100644 --- a/Source/core/html/shadow/MediaControls.cpp +++ b/Source/core/html/shadow/MediaControls.cpp @@ -225,6 +225,8 @@ { if (m_volumeSlider) m_volumeSlider->setVolume(m_mediaController->volume()); + if (m_panelMuteButton && m_panelMuteButton->renderer()) + m_panelMuteButton->renderer()->repaint(); } void MediaControls::changedClosedCaptionsVisibility() 899278 1 204357 rniwa 2013-06-11 13:39:32 -0700 Created attachment 204357 Merges the patch 899279 2 commit-queue 2013-06-11 13:40:19 -0700 Attachment 204357 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/shadow/MediaControls.cpp']" exit_code: 1 Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 899297 3 204360 rniwa 2013-06-11 14:28:26 -0700 Created attachment 204360 Replace tab characters by spaces 899310 4 rniwa 2013-06-11 14:59:30 -0700 Committed r151476: <http://trac.webkit.org/changeset/151476> 899311 5 204360 rniwa 2013-06-11 14:59:56 -0700 Comment on attachment 204360 Replace tab characters by spaces The patch has been reviewed by darin. Thanks darin! 204357 2013-06-11 13:39:32 -0700 2013-06-11 14:28:24 -0700 Merges the patch bug-117464-20130611133753.patch text/plain 1387 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEhhdmUgdG8gaW52YWxpZGF0ZSB0 aGUgbXV0ZSBidXR0b24gd2hlbiBjaGFuZ2luZyB0aGUgdm9sdW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0NjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRwczovL2Nocm9taXVtLmdv b2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy9jNGM2ODVjODI5MDg0NDk1MjZmZDhjMjUx Y2M1NTFlNzI5ZWJlZDA4CisJYnV0IHdpdGhvdXQgYSB0ZXN0IHNpbmNlIHRoZSB0ZXN0IGRvZXNu J3Qgd29yayBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbHM6OmNoYW5nZWRWb2x1bWUpOgor CiAyMDEzLTA2LTExICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFNldCB0aGUgZm9udCBzaXplIGZvciBpbi1iYW5kIGNhcHRpb25zIG9uIHRoZSBkaXNwbGF5IGJv eCwgbm90IHRoZSA6Y3VlLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFD b250cm9scy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVk aWFDb250cm9scy5jcHAJKHJldmlzaW9uIDE1MTQ0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L01lZGlhQ29udHJvbHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDEsNiArMjQxLDgg QEAgdm9pZCBNZWRpYUNvbnRyb2xzOjpjaGFuZ2VkVm9sdW1lKCkKIHsKICAgICBpZiAobV92b2x1 bWVTbGlkZXIpCiAgICAgICAgIG1fdm9sdW1lU2xpZGVyLT5zZXRWb2x1bWUobV9tZWRpYUNvbnRy b2xsZXItPnZvbHVtZSgpKTsKKyAgICBpZiAobV9wYW5lbE11dGVCdXR0b24gJiYgbV9wYW5lbE11 dGVCdXR0b24tPnJlbmRlcmVyKCkpCisgICAgICAgIG1fcGFuZWxNdXRlQnV0dG9uLT5yZW5kZXJl cigpLT5yZXBhaW50KCk7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sczo6Y2hhbmdlZENsb3NlZENh cHRpb25zVmlzaWJpbGl0eSgpCg== 204360 2013-06-11 14:28:26 -0700 2013-06-11 14:59:55 -0700 Replace tab characters by spaces bug-117464-20130611142647.patch text/plain 1391 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTQ3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEhhdmUgdG8gaW52YWxpZGF0ZSB0 aGUgbXV0ZSBidXR0b24gd2hlbiBjaGFuZ2luZyB0aGUgdm9sdW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0NjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRwczovL2Nocm9taXVtLmdv b2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy9jNGM2ODVjODI5MDg0NDk1MjZmZDhjMjUx Y2M1NTFlNzI5ZWJlZDA4CisgICAgICAgIGJ1dCB3aXRob3V0IGEgdGVzdCBzaW5jZSB0aGUgdGVz dCBkb2Vzbid0IHdvcmsgaW4gV2ViS2l0LgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFD b250cm9scy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjpjaGFuZ2VkVm9s dW1lKToKKwogMjAxMy0wNi0xMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVc2UgSFRNTEVsZW1lbnRGYWN0b3J5IHRvIGNyZWF0ZSBlcXVpdmFsZW50IGVsZW1l bnRzIGluIFdlYlZUVEVsZW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01l ZGlhQ29udHJvbHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L01lZGlhQ29udHJvbHMuY3BwCShyZXZpc2lvbiAxNTE0NzEpCisrKyBTb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQxLDYgKzI0 MSw4IEBAIHZvaWQgTWVkaWFDb250cm9sczo6Y2hhbmdlZFZvbHVtZSgpCiB7CiAgICAgaWYgKG1f dm9sdW1lU2xpZGVyKQogICAgICAgICBtX3ZvbHVtZVNsaWRlci0+c2V0Vm9sdW1lKG1fbWVkaWFD b250cm9sbGVyLT52b2x1bWUoKSk7CisgICAgaWYgKG1fcGFuZWxNdXRlQnV0dG9uICYmIG1fcGFu ZWxNdXRlQnV0dG9uLT5yZW5kZXJlcigpKQorICAgICAgICBtX3BhbmVsTXV0ZUJ1dHRvbi0+cmVu ZGVyZXIoKS0+cmVwYWludCgpOwogfQogCiB2b2lkIE1lZGlhQ29udHJvbHM6OmNoYW5nZWRDbG9z ZWRDYXB0aW9uc1Zpc2liaWxpdHkoKQo=