117452 2013-06-10 17:39:38 -0700 [Qt][GTK] Build fix after r151403 2013-06-10 21:47:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117420 1 seokju webkit-unassigned abecsi andersca cgarcia cmarcelo commit-queue gustavo menard mrobinson ossy oldest_to_newest 898877 0 seokju 2013-06-10 17:39:38 -0700 [Qt][GTK] Build fix after r151403. 898884 1 204247 seokju 2013-06-10 17:40:50 -0700 Created attachment 204247 Patch 898897 2 commit-queue 2013-06-10 17:42:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 899009 3 ossy 2013-06-10 21:46:06 -0700 LGTM, r=me. (It is a trivial buildfix and only touches platform codes, so it doesn't need owner review too.) 899010 4 204247 ossy 2013-06-10 21:47:52 -0700 Comment on attachment 204247 Patch Clearing flags on attachment: 204247 Committed r151419: <http://trac.webkit.org/changeset/151419> 899011 5 ossy 2013-06-10 21:47:57 -0700 All reviewed patches have been landed. Closing bug. 204247 2013-06-10 17:40:50 -0700 2013-06-10 21:47:51 -0700 Patch bug-117452-20130611093912.patch text/plain 3706 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQ4MGViNTUxYTM1NGY3 OGRiZjNjZTg3ZDA4OTc3OGVhYWMwZmYxNS4uOTdmNjU2NDFhOWM1ZjQ5Y2YzMjU3YTc1YmM2ZGUx ZTI5YWU5ZmFhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTEwICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdW0dUS10gQnVp bGQgZml4IGFmdGVyIHIxNTE0MDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNzQ1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6cHJlZmVyZW5jZXNEaWRDaGFuZ2UpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmg6CisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcF9wLmg6CisgICAgICAgIChRUmF3V2ViVmll d1ByaXZhdGU6OnByZWZlcmVuY2VzRGlkQ2hhbmdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQv UXRQYWdlQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OlF0UGFnZUNsaWVudDo6cHJlZmVyZW5j ZXNEaWRDaGFuZ2UpOgorCiAyMDEzLTA2LTEwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gU3RvcmFnZUFyZWFNYXA6OmFwcGx5Q2hhbmdl IHdoZW4gY2xlYXJpbmcgbG9jYWwgc3RvcmFnZSBpbiBhbm90aGVyIHdlYiBwcm9jZXNzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAK aW5kZXggYmY2MTYyNDBhMDFmYmYzODk4MDE3MTI3OGE4YjY2N2FjYzhhNmU4MS4uMGM2ZmEwMmI5 YTQ2ODRkNDNmNmUzZWNiYTgwNWE0Mjk5Y2QyNDRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtMjg0LDYgKzI4NCwx MSBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpwYWdlQ2xvc2VkKCkKICAgICBub3RJbXBsZW1lbnRl ZCgpOwogfQogCit2b2lkIFBhZ2VDbGllbnRJbXBsOjpwcmVmZXJlbmNlc0RpZENoYW5nZSgpCit7 CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwogdm9pZCBQYWdlQ2xpZW50SW1wbDo6Zmxhc2hC YWNraW5nU3RvcmVVcGRhdGVzKGNvbnN0IFZlY3RvcjxJbnRSZWN0PiYpCiB7CiAgICAgbm90SW1w bGVtZW50ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1BhZ2VDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdl Q2xpZW50SW1wbC5oCmluZGV4IDMxNzhlNWQyZjJhNjRkMzk5Y2Q3MmMzOGRiODIzMjA1NjcxYTM2 ZTUuLjliOGU5MmQ2MzVmZjUxZGMxZWI2NWVlMTkxYjI4ZjI1NzkzYjg3MzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaApAQCAtNjYs NiArNjYsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkQ3Jhc2goKTsK ICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVsYXVuY2hQcm9jZXNzKCk7CiAgICAgdmlydHVhbCB2b2lk IHBhZ2VDbG9zZWQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgcHJlZmVyZW5jZXNEaWRDaGFuZ2UoKTsK ICAgICB2aXJ0dWFsIHZvaWQgdGFrZUZvY3VzKGJvb2wgZGlyZWN0aW9uKTsKICAgICB2aXJ0dWFs IHZvaWQgdG9vbFRpcENoYW5nZWQoY29uc3QgV1RGOjpTdHJpbmcmLCBjb25zdCBXVEY6OlN0cmlu ZyYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJzb3IoY29uc3QgV2ViQ29yZTo6Q3Vyc29yJik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vi dmlld19wX3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2 aWV3X3BfcC5oCmluZGV4IDVhOGZjMzQ3OTk1NDc0ODlmMTVmMDg5NDkzYzVhYzJhNTgzMGU4YTcu LmJhOTllMWFmNjY5OGU1MzA5NjRkZDk4ZTQyMjIzNDg1OTdmZjA4MDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3X3BfcC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3X3BfcC5oCkBA IC0zNyw2ICszNyw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBwYWdlQ2xvc2VkKCkg eyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgcHJlZmVyZW5jZXNEaWRDaGFuZ2UoKSB7IH0KKwogICAg IHZpcnR1YWwgdm9pZCBzZXRGaW5kSW5kaWNhdG9yKFBhc3NSZWZQdHI8V2ViS2l0OjpGaW5kSW5k aWNhdG9yPiwgYm9vbCBmYWRlT3V0LCBib29sIGFuaW1hdGUpIHsgfQogICAgIHZpcnR1YWwgdm9p ZCBkaWRDb21taXRMb2FkRm9yTWFpbkZyYW1lKGJvb2wgdXNlQ3VzdG9tUmVwcmVzZW50YXRpb24p IHsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5pc2hMb2FkaW5nRGF0YUZvckN1c3RvbVJlcHJl c2VudGF0aW9uKGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkRmlsZW5hbWUsIGNvbnN0IENvcmVJUEM6 OkRhdGFSZWZlcmVuY2UmKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFBhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VD bGllbnQuaAppbmRleCBjYjk3Y2U0ZmY0ODFmYWQyZGRhODkyMGQwY2NiNGExODYzMTVhYmYwLi5m MWNiMjIyZmM2ZGE0MDRiYzlhMjk3MTYwY2NkNDY1NzkxMGEzZGU0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5oCkBAIC03MCw2ICs3MCw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoY29uc3Qg TGF5ZXJUcmVlQ29udGV4dCYpOwogI2VuZGlmIC8vIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElO RykKICAgICB2aXJ0dWFsIHZvaWQgcGFnZUNsb3NlZCgpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBw cmVmZXJlbmNlc0RpZENoYW5nZSgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBzdGFydERyYWcoY29u c3QgV2ViQ29yZTo6RHJhZ0RhdGEmLCBQYXNzUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gZHJhZ0lt YWdlKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29yKGNvbnN0IFdlYkNvcmU6OkN1cnNvciYp OwogICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJzb3JIaWRkZW5VbnRpbE1vdXNlTW92ZXMoYm9vbCk7 Cg==