117448 2013-06-10 16:49:16 -0700 Clean up the initializer mess in Document 2013-06-11 13:41:40 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa benjamin benjamin commit-queue dcheng esprehn+autocc kling koivisto oldest_to_newest 898836 0 rniwa 2013-06-10 16:49:16 -0700 https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7 Before this, some members were initialized in the initializer list and others were initialized in the body of the constructor. As far as I can tell, it's OK for everything to just be in the initializer list. As a bonus, I found two completely unused members in Document (and a local static) and removed them as well. 898936 1 204268 benjamin 2013-06-10 18:01:56 -0700 Created attachment 204268 Patch 898938 2 204268 rniwa 2013-06-10 18:04:03 -0700 Comment on attachment 204268 Patch Let's wait for EWS though. 898951 3 rniwa 2013-06-10 18:25:59 -0700 Apparently it got reverted in https://chromium.googlesource.com/chromium/blink/+/c3ff928bbdc8eef2bb274516949f31345ca24569. 899280 4 benjamin 2013-06-11 13:40:48 -0700 Committed r151466: <http://trac.webkit.org/changeset/151466> 899281 5 benjamin 2013-06-11 13:41:40 -0700 (In reply to comment #3) > Apparently it got reverted in https://chromium.googlesource.com/chromium/blink/+/c3ff928bbdc8eef2bb274516949f31345ca24569. Should be good, I did not copy the bad parts of the original patch. 204268 2013-06-10 18:01:56 -0700 2013-06-10 18:04:03 -0700 Patch bug-117448-20130610180018.patch text/plain 6054 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliYWJiZTFmOThmZTRj MTA3MWMzZDY0OWU5ZjNkNjUxM2JjZjFlZS4uZmM3YTU1YTVkNjVmZjBjNzJiNTUyMjE2MDQwNjJk YmE3YTMxMTE2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTA2LTEwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIENsZWFuIHVwIHRo ZSBpbml0aWFsaXplciBtZXNzIGluIERvY3VtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTc0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBCYXNpYyBjbGVhbmluZyBmcm9tCisgICAgICAgIGh0dHBz Oi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rL2U1NGJhOGQzYjYy YjAyNDVlY2RmMmYzZWMxMWNkMzNiNDAzNWE0ZDcKKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1lbnQpOgorICAgICAgICAqIGRv bS9Eb2N1bWVudC5oOgorCisyMDEzLTA2LTEwICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5A YXBwbGUuY29tPgorCiAgICAgICAgIEZpeCB0aGUgZWxlbWVudCB0eXBlIGluIHRoZSBzZWxlY3Rv ciBjaGVja2VycwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE3NDUwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGYwYzVjYWVlZmVjOWUwMDA0 ZDkzN2M1NTU3MTNmZWU1OWY5ZDhkZWIuLmYwNzc2NzRmYjUwMjU5OGZkMTdlYTRmNjdkYzk0MGFh YzU3NDRlMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMzkzLDI4ICszOTMsNDcgQEAg RG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsLCB1bnNpZ25l ZCBkb2N1bWVudENsYXNzZXMpCiAgICAgOiBDb250YWluZXJOb2RlKDAsIENyZWF0ZURvY3VtZW50 KQogICAgICwgVHJlZVNjb3BlKHRoaXMpCiAgICAgLCBtX3N0eWxlUmVzb2x2ZXJUaHJvd2F3YXlU aW1lcih0aGlzLCAmRG9jdW1lbnQ6OnN0eWxlUmVzb2x2ZXJUaHJvd2F3YXlUaW1lckZpcmVkLCB0 aW1lQmVmb3JlVGhyb3dpbmdBd2F5U3R5bGVSZXNvbHZlckFmdGVyTGFzdFVzZUluU2Vjb25kcykK KyAgICAsIG1fZGlkQ2FsY3VsYXRlU3R5bGVSZXNvbHZlcihmYWxzZSkKKyAgICAsIG1faGFzTm9k ZXNXaXRoUGxhY2Vob2xkZXJTdHlsZShmYWxzZSkKKyAgICAsIG1fbmVlZHNOb3RpZnlSZW1vdmVB bGxQZW5kaW5nU3R5bGVzaGVldChmYWxzZSkKKyAgICAsIG1faWdub3JlUGVuZGluZ1N0eWxlc2hl ZXRzKGZhbHNlKQorICAgICwgbV9wZW5kaW5nU2hlZXRMYXlvdXQoTm9MYXlvdXRXaXRoUGVuZGlu Z1NoZWV0cykKKyAgICAsIG1fZnJhbWUoZnJhbWUpCiAgICAgLCBtX2FjdGl2ZVBhcnNlckNvdW50 KDApCiAgICAgLCBtX2NvbnRleHRGZWF0dXJlcyhDb250ZXh0RmVhdHVyZXM6OmRlZmF1bHRTd2l0 Y2goKSkKKyAgICAsIG1fd2VsbEZvcm1lZChmYWxzZSkKKyAgICAsIG1fcHJpbnRpbmcoZmFsc2Up CisgICAgLCBtX3BhZ2luYXRlZEZvclNjcmVlbihmYWxzZSkKKyAgICAsIG1faWdub3JlQXV0b2Zv Y3VzKGZhbHNlKQogICAgICwgbV9jb21wYXRpYmlsaXR5TW9kZShOb1F1aXJrc01vZGUpCiAgICAg LCBtX2NvbXBhdGliaWxpdHlNb2RlTG9ja2VkKGZhbHNlKQorICAgICwgbV90ZXh0Q29sb3IoQ29s b3I6OmJsYWNrKQogICAgICwgbV9kb21UcmVlVmVyc2lvbigrK3NfZ2xvYmFsVHJlZVZlcnNpb24p CisgICAgLCBtX2xpc3RlbmVyVHlwZXMoMCkKICAgICAsIG1fbXV0YXRpb25PYnNlcnZlclR5cGVz KDApCiAgICAgLCBtX3N0eWxlU2hlZXRDb2xsZWN0aW9uKERvY3VtZW50U3R5bGVTaGVldENvbGxl Y3Rpb246OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1fdmlzaXRlZExpbmtTdGF0ZShWaXNpdGVkTGlu a1N0YXRlOjpjcmVhdGUodGhpcykpCisgICAgLCBtX3Zpc3VhbGx5T3JkZXJlZChmYWxzZSkKICAg ICAsIG1fcmVhZHlTdGF0ZShDb21wbGV0ZSkKKyAgICAsIG1fYlBhcnNpbmcoZmFsc2UpCiAgICAg LCBtX3N0eWxlUmVjYWxjVGltZXIodGhpcywgJkRvY3VtZW50OjpzdHlsZVJlY2FsY1RpbWVyRmly ZWQpCiAgICAgLCBtX3BlbmRpbmdTdHlsZVJlY2FsY1Nob3VsZEZvcmNlKGZhbHNlKQorICAgICwg bV9pblN0eWxlUmVjYWxjKGZhbHNlKQorICAgICwgbV9jbG9zZUFmdGVyU3R5bGVSZWNhbGMoZmFs c2UpCisgICAgLCBtX2dvdG9BbmNob3JOZWVkZWRBZnRlclN0eWxlc2hlZXRzTG9hZChmYWxzZSkK ICAgICAsIG1fZnJhbWVFbGVtZW50c1Nob3VsZElnbm9yZVNjcm9sbGluZyhmYWxzZSkKICAgICAs IG1fY29udGFpbnNWYWxpZGl0eVN0eWxlUnVsZXMoZmFsc2UpCiAgICAgLCBtX3VwZGF0ZUZvY3Vz QXBwZWFyYW5jZVJlc3RvcmVzU2VsZWN0aW9uKGZhbHNlKQogICAgICwgbV9pZ25vcmVEZXN0cnVj dGl2ZVdyaXRlQ291bnQoMCkKICAgICAsIG1fdGl0bGVTZXRFeHBsaWNpdGx5KGZhbHNlKQogICAg ICwgbV91cGRhdGVGb2N1c0FwcGVhcmFuY2VUaW1lcih0aGlzLCAmRG9jdW1lbnQ6OnVwZGF0ZUZv Y3VzQXBwZWFyYW5jZVRpbWVyRmlyZWQpCisgICAgLCBtX2Nzc1RhcmdldCgwKQorICAgICwgbV9w cm9jZXNzaW5nTG9hZEV2ZW50KGZhbHNlKQogICAgICwgbV9sb2FkRXZlbnRGaW5pc2hlZChmYWxz ZSkKICAgICAsIG1fc3RhcnRUaW1lKGN1cnJlbnRUaW1lKCkpCiAgICAgLCBtX292ZXJNaW5pbXVt TGF5b3V0VGhyZXNob2xkKGZhbHNlKQogICAgICwgbV9zY3JpcHRSdW5uZXIoU2NyaXB0UnVubmVy OjpjcmVhdGUodGhpcykpCi0gICAgLCBtX3htbFZlcnNpb24oIjEuMCIpCisgICAgLCBtX3htbFZl cnNpb24oQVNDSUlMaXRlcmFsKCIxLjAiKSkKICAgICAsIG1feG1sU3RhbmRhbG9uZShTdGFuZGFs b25lVW5zcGVjaWZpZWQpCiAgICAgLCBtX2hhc1hNTERlY2xhcmF0aW9uKDApCiAgICAgLCBtX3Nh dmVkUmVuZGVyZXIoMCkKQEAgLTQ2NiwxMiArNDg1LDYgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZy YW1lKiBmcmFtZSwgY29uc3QgS1VSTCYgdXJsLCB1bnNpZ25lZCBkb2N1bWVudENsYXNzZXMpCiAg ICAgLCBtX2RpZEFzc29jaWF0ZUZvcm1Db250cm9sc1RpbWVyKHRoaXMsICZEb2N1bWVudDo6ZGlk QXNzb2NpYXRlRm9ybUNvbnRyb2xzVGltZXJGaXJlZCkKICAgICAsIG1faGFzSW5qZWN0ZWRQbHVn SW5zU2NyaXB0KGZhbHNlKQogewotICAgIG1fcHJpbnRpbmcgPSBmYWxzZTsKLSAgICBtX3BhZ2lu YXRlZEZvclNjcmVlbiA9IGZhbHNlOwotCi0gICAgbV9pZ25vcmVBdXRvZm9jdXMgPSBmYWxzZTsK LQotICAgIG1fZnJhbWUgPSBmcmFtZTsKICAgICBpZiAobV9mcmFtZSkKICAgICAgICAgcHJvdmlk ZUNvbnRleHRGZWF0dXJlc1RvRG9jdW1lbnRGcm9tKHRoaXMsIG1fZnJhbWUtPnBhZ2UoKSk7CiAK QEAgLTQ5NCwzNyArNTA3LDE0IEBAIERvY3VtZW50OjpEb2N1bWVudChGcmFtZSogZnJhbWUsIGNv bnN0IEtVUkwmIHVybCwgdW5zaWduZWQgZG9jdW1lbnRDbGFzc2VzKQogI2lmIEVOQUJMRShURVhU X0FVVE9TSVpJTkcpCiAgICAgbV90ZXh0QXV0b3NpemVyID0gVGV4dEF1dG9zaXplcjo6Y3JlYXRl KHRoaXMpOwogI2VuZGlmCi0gICAgbV92aXN1YWxseU9yZGVyZWQgPSBmYWxzZTsKLSAgICBtX2JQ YXJzaW5nID0gZmFsc2U7Ci0gICAgbV93ZWxsRm9ybWVkID0gZmFsc2U7Ci0KLSAgICBtX3RleHRD b2xvciA9IENvbG9yOjpibGFjazsKLSAgICBtX2xpc3RlbmVyVHlwZXMgPSAwOwotICAgIG1faW5T dHlsZVJlY2FsYyA9IGZhbHNlOwotICAgIG1fY2xvc2VBZnRlclN0eWxlUmVjYWxjID0gZmFsc2U7 Ci0KLSAgICBtX2dvdG9BbmNob3JOZWVkZWRBZnRlclN0eWxlc2hlZXRzTG9hZCA9IGZhbHNlOwot Ci0gICAgbV9kaWRDYWxjdWxhdGVTdHlsZVJlc29sdmVyID0gZmFsc2U7Ci0gICAgbV9pZ25vcmVQ ZW5kaW5nU3R5bGVzaGVldHMgPSBmYWxzZTsKLSAgICBtX25lZWRzTm90aWZ5UmVtb3ZlQWxsUGVu ZGluZ1N0eWxlc2hlZXQgPSBmYWxzZTsKLSAgICBtX2hhc05vZGVzV2l0aFBsYWNlaG9sZGVyU3R5 bGUgPSBmYWxzZTsKLSAgICBtX3BlbmRpbmdTaGVldExheW91dCA9IE5vTGF5b3V0V2l0aFBlbmRp bmdTaGVldHM7Ci0KLSAgICBtX2Nzc1RhcmdldCA9IDA7CiAKICAgICByZXNldExpbmtDb2xvcigp OwogICAgIHJlc2V0VmlzaXRlZExpbmtDb2xvcigpOwogICAgIHJlc2V0QWN0aXZlTGlua0NvbG9y KCk7CiAKLSAgICBtX3Byb2Nlc3NpbmdMb2FkRXZlbnQgPSBmYWxzZTsKLSAgICAKICAgICBpbml0 U2VjdXJpdHlDb250ZXh0KCk7CiAgICAgaW5pdEROU1ByZWZldGNoKCk7CiAKLSAgICBzdGF0aWMg aW50IGRvY0lEID0gMDsKLSAgICBtX2RvY0lEID0gZG9jSUQrKzsKLQogICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBXVEZfQVJSQVlfTEVOR1RIKG1fbm9kZUxpc3RDb3VudHMpOyBpKyspCiAg ICAgICAgIG1fbm9kZUxpc3RDb3VudHNbaV0gPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4 IDhhODRhMGVmYWVjYTZiZjIxOWViNTY5NGIyN2U4MzcyNWExMGVjMTguLjc0ODhlNjExMmQ1MzEx NWY2MzRmYmQ1MDQ0MjAxODQxMWVhZjZkNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC04NzUs OCArODc1LDYgQEAgcHVibGljOgogCiAgICAgRG9jdW1lbnQqIHBhcmVudERvY3VtZW50KCkgY29u c3Q7CiAgICAgRG9jdW1lbnQqIHRvcERvY3VtZW50KCkgY29uc3Q7Ci0KLSAgICBpbnQgZG9jSUQo KSBjb25zdCB7IHJldHVybiBtX2RvY0lEOyB9CiAgICAgCiAgICAgU2NyaXB0UnVubmVyKiBzY3Jp cHRSdW5uZXIoKSB7IHJldHVybiBtX3NjcmlwdFJ1bm5lci5nZXQoKTsgfQogCkBAIC0xMjgwLDcg KzEyNzgsNiBAQCBwcml2YXRlOgogCiAgICAgT3duUHRyPFN0eWxlUmVzb2x2ZXI+IG1fc3R5bGVS ZXNvbHZlcjsKICAgICBib29sIG1fZGlkQ2FsY3VsYXRlU3R5bGVSZXNvbHZlcjsKLSAgICBib29s IG1faGFzRGlydHlTdHlsZVJlc29sdmVyOwogICAgIGJvb2wgbV9oYXNOb2Rlc1dpdGhQbGFjZWhv bGRlclN0eWxlOwogICAgIGJvb2wgbV9uZWVkc05vdGlmeVJlbW92ZUFsbFBlbmRpbmdTdHlsZXNo ZWV0OwogICAgIC8vIEJ1dCBzb21ldGltZXMgeW91IG5lZWQgdG8gaWdub3JlIHBlbmRpbmcgc3R5 bGVzaGVldCBjb3VudCB0bwpAQCAtMTM2Miw3ICsxMzU5LDYgQEAgcHJpdmF0ZToKICAgICBDb2xv ciBtX2FjdGl2ZUxpbmtDb2xvcjsKICAgICBPd25QdHI8VmlzaXRlZExpbmtTdGF0ZT4gbV92aXNp dGVkTGlua1N0YXRlOwogCi0gICAgYm9vbCBtX2xvYWRpbmdTaGVldDsKICAgICBib29sIG1fdmlz dWFsbHlPcmRlcmVkOwogICAgIFJlYWR5U3RhdGUgbV9yZWFkeVN0YXRlOwogICAgIGJvb2wgbV9i UGFyc2luZzsKQEAgLTE0MTQsOCArMTQxMCw2IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPERvY3Vt ZW50PiBtX3RyYW5zZm9ybVNvdXJjZURvY3VtZW50OwogI2VuZGlmCiAKLSAgICBpbnQgbV9kb2NJ RDsgLy8gQSB1bmlxdWUgZG9jdW1lbnQgaWRlbnRpZmllciB1c2VkIGZvciB0aGluZ3MgbGlrZSBk b2N1bWVudC1zcGVjaWZpYyBtYXBwZWQgYXR0cmlidXRlcy4KLQogICAgIFN0cmluZyBtX3htbEVu Y29kaW5nOwogICAgIFN0cmluZyBtX3htbFZlcnNpb247CiAgICAgdW5zaWduZWQgbV94bWxTdGFu ZGFsb25lIDogMjsK