117413 2013-06-10 10:09:50 -0700 [CoordinatedGraphics] Typos in custom shader support 2013-06-10 22:47:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ralpht+bugs webkit-unassigned cmarcelo commit-queue dongseong.hwang jaepark luiz noam zeno oldest_to_newest 898678 0 ralpht+bugs 2013-06-10 10:09:50 -0700 CoordinatedLayerTreeHost.cpp:333 is for (size_t j = 0; j < keyframes.size(); ++j) { const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i)); but it should be: for (size_t j = 0; j < keyframes.size(); ++j) { const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j)); Also, WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:730 has the same bug, it is: for (size_t j = 0; j < keyframes.size(); ++j) { const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(i)); but should be: for (size_t j = 0; j < keyframes.size(); ++j) { const FilterAnimationValue& filterValue = static_cast<const FilterAnimationValue&>(keyframes.at(j)); I'm not set up for submitting patches currently, but I'll try to get setup soon (in the meantime, if anyone else wants to submit something for this then that would be wonderful ;) ). 898941 1 204271 jaepark 2013-06-10 18:09:03 -0700 Created attachment 204271 Patch 899034 2 204271 commit-queue 2013-06-10 22:47:47 -0700 Comment on attachment 204271 Patch Clearing flags on attachment: 204271 Committed r151423: <http://trac.webkit.org/changeset/151423> 899035 3 commit-queue 2013-06-10 22:47:49 -0700 All reviewed patches have been landed. Closing bug. 204271 2013-06-10 18:09:03 -0700 2013-06-10 22:47:47 -0700 Patch bug-117413-20130610180831.patch text/plain 3656 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJhZWQ0NjBhNzIzZmE1 MmNlN2U5MTAzYzlkODYzNTY5MWQ1OGVmMC4uOWMzOWE5YjFlZThlM2I3NWMxZTA1YzZmMjFlNGZm N2UxYTM2MmRiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTEwICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0Nvb3JkaW5h dGVkR3JhcGhpY3NdIFR5cG9zIGluIGN1c3RvbSBzaGFkZXIgc3VwcG9ydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NDEzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV3Jvbmcga2V5ZnJhbWUgaXMgcGFz c2VkIHdoZW4gYXNzaWduaW5nIGZpbHRlclZhbHVlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnNldExheWVyQW5pbWF0 aW9uc0lmTmVlZGVkKToKKwogMjAxMy0wNi0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNTEzMDIpOiBNYW55IGJyb2tlbiB3ZWJhdWRp by8gdGVzdHMgb24gTWFjIHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDJhYWM4MTJkMjBkNDdkZDFhMjg5 NmRlYjliZTFjYjA5YWM1ZjhiYi4uMTlmOWFiOGM1ODUzNzM5MmJiOGYzMmUxNjhjZmI5M2JiYzNi ZjYzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTEwICBKYWUgSHl1biBQ YXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0Nvb3JkaW5hdGVkR3Jh cGhpY3NdIFR5cG9zIGluIGN1c3RvbSBzaGFkZXIgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3NDEzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV3Jvbmcga2V5ZnJhbWUgaXMgcGFzc2VkIHdo ZW4gYXNzaWduaW5nIGZpbHRlclZhbHVlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpwcmVwYXJlQ3VzdG9tRmlsdGVy UHJveGllc0lmTmVlZGVkKToKKwogMjAxMy0wNi0xMCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE1MTQx MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9j b29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NT Y2VuZS5jcHAKaW5kZXggNjYzZDlhZTAzMDg2N2VhYmEyZmU4MGFiZWVkNzNmZWU5MzVlMTNmOC4u OWRkMmQ3MTBiZWRlNTY4MDMzODdjMTlkNzMzZDQxNDhiODYzN2NkMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5h dGVkR3JhcGhpY3NTY2VuZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAKQEAgLTcy Nyw3ICs3MjcsNyBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6c2V0TGF5ZXJBbmlt YXRpb25zSWZOZWVkZWQoVGV4dHVyZU1hcHBlckxheWVyKiBsYQogICAgICAgICBpZiAoa2V5ZnJh bWVzLnByb3BlcnR5KCkgIT0gQW5pbWF0ZWRQcm9wZXJ0eVdlYmtpdEZpbHRlcikKICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICBmb3IgKHNpemVfdCBqID0gMDsgaiA8IGtleWZyYW1lcy5z aXplKCk7ICsraikgewotICAgICAgICAgICAgY29uc3QgRmlsdGVyQW5pbWF0aW9uVmFsdWUmIGZp bHRlclZhbHVlID0gc3RhdGljX2Nhc3Q8Y29uc3QgRmlsdGVyQW5pbWF0aW9uVmFsdWUmPihrZXlm cmFtZXMuYXQoaSkpOworICAgICAgICAgICAgY29uc3QgRmlsdGVyQW5pbWF0aW9uVmFsdWUmIGZp bHRlclZhbHVlID0gc3RhdGljX2Nhc3Q8Y29uc3QgRmlsdGVyQW5pbWF0aW9uVmFsdWUmPihrZXlm cmFtZXMuYXQoaikpOwogICAgICAgICAgICAgaW5qZWN0Q2FjaGVkQ3VzdG9tRmlsdGVyUHJvZ3Jh bXMoZmlsdGVyVmFsdWUudmFsdWUoKSk7CiAgICAgICAgIH0KICAgICB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAppbmRl eCAwMzVmYzdmNTJiOTlhZmVhNjAzN2QyODRkODYyZGNkNmQwNGEzOGYwLi4xODZiMmViNjY0ZTE4 ZGY5YTg5NWMwNWM5MDQ0Zjg2NTA2NTU2ZmUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJl ZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTMzMCw3ICszMzAs NyBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6cHJlcGFyZUN1c3RvbUZpbHRlclBy b3hpZXNJZk5lZWRlZChDb29yZGluYXRlZEdyYQogICAgICAgICAgICAgaWYgKGtleWZyYW1lcy5w cm9wZXJ0eSgpICE9IEFuaW1hdGVkUHJvcGVydHlXZWJraXRGaWx0ZXIpCiAgICAgICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgICAgICBmb3IgKHNpemVfdCBqID0gMDsgaiA8IGtleWZyYW1l cy5zaXplKCk7ICsraikgewotICAgICAgICAgICAgICAgIGNvbnN0IEZpbHRlckFuaW1hdGlvblZh bHVlJiBmaWx0ZXJWYWx1ZSA9IHN0YXRpY19jYXN0PGNvbnN0IEZpbHRlckFuaW1hdGlvblZhbHVl Jj4oa2V5ZnJhbWVzLmF0KGkpKTsKKyAgICAgICAgICAgICAgICBjb25zdCBGaWx0ZXJBbmltYXRp b25WYWx1ZSYgZmlsdGVyVmFsdWUgPSBzdGF0aWNfY2FzdDxjb25zdCBGaWx0ZXJBbmltYXRpb25W YWx1ZSY+KGtleWZyYW1lcy5hdChqKSk7CiAgICAgICAgICAgICAgICAgY2hlY2tDdXN0b21GaWx0 ZXJQcm9ncmFtUHJveGllcyhmaWx0ZXJWYWx1ZS52YWx1ZSgpKTsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQo=