117400 2013-06-10 03:10:11 -0700 Replace [ConstructorRaisesException] with [RaisesException] 2013-06-12 10:11:02 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX https://src.chromium.org/viewvc/blink?view=rev&revision=148027 BlinkMergeCandidate P2 Normal --- 117350 1 cdumez cdumez benjamin commit-queue darin haraken laszlo.gombos oldest_to_newest 898595 0 cdumez 2013-06-10 03:10:11 -0700 [RaisesException] extended attribute was added in Bug 117350 for Web IDL operations. [ConstructorRaisesException] was the pre-existing equivalent for interface constructors. It does not make sense to have 2 Web IDL extended attributes to do the same thing so we should consider replacing [ConstructorRaisesException] with [RaisesException] as blink did. 898598 1 204148 cdumez 2013-06-10 03:22:37 -0700 Created attachment 204148 Patch 898599 2 204148 haraken 2013-06-10 03:24:21 -0700 Comment on attachment 204148 Patch ok 898605 3 204148 commit-queue 2013-06-10 04:05:49 -0700 Comment on attachment 204148 Patch Clearing flags on attachment: 204148 Committed r151378: <http://trac.webkit.org/changeset/151378> 898606 4 commit-queue 2013-06-10 04:05:53 -0700 All reviewed patches have been landed. Closing bug. 899069 5 darin 2013-06-11 00:06:37 -0700 This change seems strange. Now we label an entire interface “RaisesException” and to me it’s not obvious what that means. 899076 6 cdumez 2013-06-11 00:42:30 -0700 (In reply to comment #5) > This change seems strange. Now we label an entire interface “RaisesException” and to me it’s not obvious what that means. I see. I was trying to reduce the number of WebKit-specific IDL attributes (and be consistent with Blink IDL). However, I see your point that we do loose some readability in this case (and people would likely have to refer to the WebKit IDL wiki). It did not disturb me much because a similar thing was already done for: http://trac.webkit.org/wiki/WebKitIDL#CallWith If you specify [CallWith] on an interface, it applies only to the constructor, not for all attributes / operations of the interface. The attribute could have been called [CallConstructorWith] for clarity but [CallWith] is used (probably for consistency with operations / attributes). Having a limited number of Webkit-specific IDL attributes also has benefits. I don't have strong feelings either way (only slight preference was keeping the patch in). Therefore, if you prefer to keep [ConstructorRaisesException], then I don't mind reverting this patch. However, I would then propose that we introduce [CallConstructorWith] to follow the same pattern. 899236 7 darin 2013-06-11 11:12:25 -0700 I agree that CallConstructorWith is clearer than CallWith. I don’t agree that same attribute name used as an interface attribute and an operation attribute with subtly different meanings counts as a smaller number of attributes. We are optimizing a number, number of distinct attribute names, that is not a helpful metric. I agree that minimizing the number of attributes is important. Although, as an aside, I think it is more important to minimize the degree to which class names and behavior are hardcoded into the bindings generation scripts than to minimize the number of attributes. But I believe that reusing the same name for multiple subtly different purposes is a false economy. 899447 8 cdumez 2013-06-11 23:02:58 -0700 (In reply to comment #7) > I agree that CallConstructorWith is clearer than CallWith. > > I don’t agree that same attribute name used as an interface attribute and an operation attribute with subtly different meanings counts as a smaller number of attributes. > > We are optimizing a number, number of distinct attribute names, that is not a helpful metric. > > I agree that minimizing the number of attributes is important. Although, as an aside, I think it is more important to minimize the degree to which class names and behavior are hardcoded into the bindings generation scripts than to minimize the number of attributes. > > But I believe that reusing the same name for multiple subtly different purposes is a false economy. Ok, I'm not disagreeing with you. I will roll this out soon then and likely propose a small patch to introduce CallConstructorWith. 899448 9 haraken 2013-06-11 23:05:50 -0700 > Ok, I'm not disagreeing with you. I will roll this out soon then and likely propose a small patch to introduce CallConstructorWith. Bikeshedding: [ConstructorCallWith] might be slightly better, since we might want to prefix all constructor related IDL attributes with "Constructor". Historically, previously [CallWith] was [ConstructorCallWith]. I replaced [ConstructorCallWith] with [CallWith] at some point. 899449 10 cdumez 2013-06-11 23:06:53 -0700 Reverted r151378 for reason: Decreased IDL readability a bit Committed r151487: <http://trac.webkit.org/changeset/151487> 899450 11 cdumez 2013-06-11 23:08:10 -0700 (In reply to comment #9) > > Ok, I'm not disagreeing with you. I will roll this out soon then and likely propose a small patch to introduce CallConstructorWith. > > Bikeshedding: [ConstructorCallWith] might be slightly better, since we might want to prefix all constructor related IDL attributes with "Constructor". > > Historically, previously [CallWith] was [ConstructorCallWith]. I replaced [ConstructorCallWith] with [CallWith] at some point. Makes sense Kentaro. I'll use that instead then, thanks. 899594 12 darin 2013-06-12 10:00:51 -0700 Thanks guys. Hope my wording didn’t come across as harsh. I may have prioritized clarity over politeness a bit! 899599 13 cdumez 2013-06-12 10:11:02 -0700 (In reply to comment #12) > Thanks guys. Hope my wording didn’t come across as harsh. I may have prioritized clarity over politeness a bit! Not at all :) Thanks for the feedback. 204148 2013-06-10 03:22:37 -0700 2013-06-10 04:05:49 -0700 Patch 117400_ConstructorRaisesException.patch text/plain 11328 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZTU4MmVhLi4zMWFhZDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzkg QEAKKzIwMTMtMDYtMTAgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFJlcGxhY2UgW0NvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uXSB3aXRo IFtSYWlzZXNFeGNlcHRpb25dCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTc0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZXBsYWNlIFtDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbl0gd2l0aCBbUmFp c2VzRXhjZXB0aW9uXSBJREwgZXh0ZW5kZWQKKyAgICAgICAgYXR0cmlidXRlIGFuZCBkcm9wIFtD b25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbl0uIEl0IG1ha2VzIGxpdHRsZSBzZW5zZQorICAgICAg ICB0byBoYXZlIDIgZXh0ZW5kZWQgYXR0cmlidXRlcyB3aXRoIHRoZSBzYW1lIG1lYW5pbmcuCisK KyAgICAgICAgW1JhaXNlc0V4Y2VwdGlvbl0gY2FuIG5vdyBiZSB1c2VkIG9uIElETCBvcGVyYXRp b25zIHRvIGluZGljYXRlIHRoYXQgdGhlCisgICAgICAgIG1ldGhvZCBtYXkgdGhyb3cgZXhjZXB0 aW9ucyBvciBvbiBpbnRlcmZhY2VzIHRvIGluZGljYXRlIHRoYXQgdGhlCisgICAgICAgIGNvbnN0 cnVjdG9yIG1heSB0aHJvdyBleGNlcHRpb25zLgorCisgICAgICAgIEZyb20gQmxpbmsgcjE0ODAy NyBieSBLZW50YXJvIEhhcmEgPGhhcmFrZW5AY2hyb21pdW0ub3JnPi4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVsZXMvZW5jcnlw dGVkbWVkaWEvTWVkaWFLZXlzLmlkbDoKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JU Q0ljZUNhbmRpZGF0ZS5pZGw6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVy Q29ubmVjdGlvbi5pZGw6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENTZXNzaW9u RGVzY3JpcHRpb24uaWRsOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlv Q29udGV4dC5pZGw6CisgICAgICAgICogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGw6 CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAg IChHZW5lcmF0ZUNvbnN0cnVjdG9yRGVmaW5pdGlvbik6CisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9JRExBdHRyaWJ1dGVzLnR4dDoKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv VGVzdEludGVyZmFjZS5pZGw6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RO YW1lZENvbnN0cnVjdG9yLmlkbDoKKyAgICAgICAgKiBjc3MvV2ViS2l0Q1NTTWF0cml4LmlkbDoK KyAgICAgICAgKiBodG1sL0hUTUxPcHRpb25FbGVtZW50LmlkbDoKKyAgICAgICAgKiBwYWdlL0V2 ZW50U291cmNlLmlkbDoKKyAgICAgICAgKiB3b3JrZXJzL1NoYXJlZFdvcmtlci5pZGw6CisgICAg ICAgICogd29ya2Vycy9Xb3JrZXIuaWRsOgorCiAyMDEzLTA2LTEwICBCZW5qYW1pbiBQb3VsYWlu ICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgc3BlY2lhbCB0cmVlIHdhbGtp bmcgZm9yIHRoZSBzaW5nbGUgdGFnIG9yIGNsYXNzIENTUyBxdWVyeSBzZWxlY3RvcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZW5jcnlwdGVkbWVkaWEvTWVkaWFLZXlzLmlk bCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZW5jcnlwdGVkbWVkaWEvTWVkaWFLZXlzLmlkbApp bmRleCA2NDI3YWJhLi5hZDllZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2VuY3J5cHRlZG1lZGlhL01lZGlhS2V5cy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9lbmNyeXB0ZWRtZWRpYS9NZWRpYUtleXMuaWRsCkBAIC0yNiw3ICsyNiw3IEBACiBbCiAgICAg Q29uZGl0aW9uYWw9RU5DUllQVEVEX01FRElBX1YyLAogICAgIENvbnN0cnVjdG9yKERPTVN0cmlu ZyBrZXlTeXN0ZW0pLAotICAgIENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAorICAgIFJhaXNl c0V4Y2VwdGlvbiwKIF0gaW50ZXJmYWNlIE1lZGlhS2V5cyB7CiAgICAgW0NhbGxXaXRoPVNjcmlw dEV4ZWN1dGlvbkNvbnRleHQsIFJhaXNlc0V4Y2VwdGlvbl0gTWVkaWFLZXlTZXNzaW9uIGNyZWF0 ZVNlc3Npb24oW0RlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBET01TdHJpbmcgdHlwZSwgW0Rl ZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBVaW50OEFycmF5IGluaXREYXRhKTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENJY2VDYW5kaWRhdGUu aWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENJY2VDYW5kaWRhdGUu aWRsCmluZGV4IDJjYTE0ZTUuLjljYmE0NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDSWNlQ2FuZGlkYXRlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRpZGF0ZS5pZGwKQEAgLTMxLDcgKzMxLDcg QEAKIFsKICAgICBDb25kaXRpb25hbD1NRURJQV9TVFJFQU0sCiAgICAgQ29uc3RydWN0b3IoRGlj dGlvbmFyeSBkaWN0aW9uYXJ5KSwKLSAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbgorICAg IFJhaXNlc0V4Y2VwdGlvbgogXSBpbnRlcmZhY2UgUlRDSWNlQ2FuZGlkYXRlIHsKICAgICByZWFk b25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNhbmRpZGF0ZTsKICAgICByZWFkb25seSBhdHRyaWJ1 dGUgRE9NU3RyaW5nIHNkcE1pZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5pZGwKaW5kZXggOTAyMWFmNS4uMDk5N2Iw ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVy Q29ubmVjdGlvbi5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9S VENQZWVyQ29ubmVjdGlvbi5pZGwKQEAgLTMyLDcgKzMyLDcgQEAKICAgICBDb25kaXRpb25hbD1N RURJQV9TVFJFQU0sCiAgICAgQWN0aXZlRE9NT2JqZWN0LAogICAgIENvbnN0cnVjdG9yKERpY3Rp b25hcnkgcnRjSWNlU2VydmVycywgb3B0aW9uYWwgRGljdGlvbmFyeSBtZWRpYUNvbnN0cmFpbnRz KSwKLSAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiwKKyAgICBSYWlzZXNFeGNlcHRpb24s CiAgICAgQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwKICAgICBFdmVudFRhcmdldCwK ICAgICBJbnRlcmZhY2VOYW1lPXdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1Nlc3Npb25EZXNjcmlwdGlvbi5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1Nlc3Npb25EZXNjcmlw dGlvbi5pZGwKaW5kZXggYjUxNzQ2Yy4uNTgwMmUwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENTZXNzaW9uRGVzY3JpcHRpb24uaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDU2Vzc2lvbkRlc2NyaXB0aW9uLmlk bApAQCAtMzEsNyArMzEsNyBAQAogWwogICAgIENvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKICAg ICBDb25zdHJ1Y3RvcihEaWN0aW9uYXJ5IGRpY3Rpb25hcnkpLAotICAgIENvbnN0cnVjdG9yUmFp c2VzRXhjZXB0aW9uCisgICAgUmFpc2VzRXhjZXB0aW9uCiBdIGludGVyZmFjZSBSVENTZXNzaW9u RGVzY3JpcHRpb24gewogICAgIFtTZXR0ZXJSYWlzZXNFeGNlcHRpb25dIGF0dHJpYnV0ZSBET01T dHJpbmcgdHlwZTsKICAgICBbU2V0dGVyUmFpc2VzRXhjZXB0aW9uXSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIHNkcDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2Zm bGluZUF1ZGlvQ29udGV4dC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09m ZmxpbmVBdWRpb0NvbnRleHQuaWRsCmluZGV4IGViZjBjZGIuLmIzNDA0OWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT2ZmbGluZUF1ZGlvQ29udGV4dC5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9PZmZsaW5lQXVkaW9Db250ZXh0 LmlkbApAQCAtMjcsNyArMjcsNyBAQAogICAgIEV2ZW50VGFyZ2V0LAogICAgIEpTR2VuZXJhdGVU b0pTT2JqZWN0LAogICAgIENvbnN0cnVjdG9yKHVuc2lnbmVkIGxvbmcgbnVtYmVyT2ZDaGFubmVs cywgdW5zaWduZWQgbG9uZyBudW1iZXJPZkZyYW1lcywgZmxvYXQgc2FtcGxlUmF0ZSksCi0gICAg Q29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24sCisgICAgUmFpc2VzRXhjZXB0aW9uLAogICAgIENh bGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsCiAgICAgSW50ZXJmYWNlTmFtZT13ZWJraXRP ZmZsaW5lQXVkaW9Db250ZXh0CiBdIGludGVyZmFjZSBPZmZsaW5lQXVkaW9Db250ZXh0IDogQXVk aW9Db250ZXh0IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0 cy9XZWJTb2NrZXQuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNv Y2tldC5pZGwKaW5kZXggOGQyYjcyMS4uY2Q4NTc0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldC5pZGwKQEAgLTM3LDcgKzM3LDcgQEAKICAgICBD b25zdHJ1Y3RvcihET01TdHJpbmcgdXJsKSwKICAgICBDb25zdHJ1Y3RvcihET01TdHJpbmcgdXJs LCBzZXF1ZW5jZTxET01TdHJpbmc+IHByb3RvY29scyksCiAgICAgQ29uc3RydWN0b3IoRE9NU3Ry aW5nIHVybCwgRE9NU3RyaW5nIHByb3RvY29sKSwKLSAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2Vw dGlvbiwKKyAgICBSYWlzZXNFeGNlcHRpb24sCiAgICAgQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9u Q29udGV4dCwKICAgICBFdmVudFRhcmdldCwKICAgICBKU05vU3RhdGljVGFibGVzLApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0g Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRl eCAzZTE4NTgzLi5lMmQ5MzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtNDEzNCw3ICs0MTM0LDcgQEAgRU5ECiAKICAg ICAgICAgICAgIEdlbmVyYXRlQXJndW1lbnRzQ291bnRDaGVjaygkb3V0cHV0QXJyYXksICRmdW5j dGlvbiwgJGludGVyZmFjZSk7CiAKLSAgICAgICAgICAgIGlmICgkZnVuY3Rpb24tPnNpZ25hdHVy ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJhaXNlc0V4Y2VwdGlvbiJ9IHx8ICRpbnRlcmZhY2Ut PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiJ9KSB7Cisg ICAgICAgICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJSYWlzZXNFeGNlcHRpb24ifSB8fCAkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsi UmFpc2VzRXhjZXB0aW9uIn0pIHsKICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJFeGNl cHRpb25Db2RlLmgifSA9IDE7CiAgICAgICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAi ICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwO1xuIik7CiAgICAgICAgICAgICB9CkBAIC00MTYxLDcg KzQxNjEsNyBAQCBFTkQKICAgICAgICAgICAgICAgICAkaW5kZXgrKzsKICAgICAgICAgICAgIH0K IAotICAgICAgICAgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25z dHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiJ9KSB7CisgICAgICAgICAgICBpZiAoJGludGVyZmFjZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJhaXNlc0V4Y2VwdGlvbiJ9KSB7CiAgICAgICAgICAgICAg ICAgcHVzaChAY29uc3RydWN0b3JBcmdMaXN0LCAiZWMiKTsKICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIG15ICRjb25zdHJ1Y3RvckFyZyA9IGpvaW4oIiwgIiwgQGNvbnN0cnVjdG9yQXJnTGlz dCk7CkBAIC00MTcxLDcgKzQxNzEsNyBAQCBFTkQKICAgICAgICAgICAgICAgICBwdXNoKEAkb3V0 cHV0QXJyYXksICIgICAgUmVmUHRyPCR7aW50ZXJmYWNlTmFtZX0+IG9iamVjdCA9ICR7aW50ZXJm YWNlTmFtZX06OmNyZWF0ZSgke2NvbnN0cnVjdG9yQXJnfSk7XG4iKTsKICAgICAgICAgICAgIH0K IAotICAgICAgICAgICAgaWYgKCRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25z dHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiJ9KSB7CisgICAgICAgICAgICBpZiAoJGludGVyZmFjZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJhaXNlc0V4Y2VwdGlvbiJ9KSB7CiAgICAgICAgICAgICAg ICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIGlmIChlYykge1xuIik7CiAgICAgICAgICAgICAg ICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgICAgICBzZXRET01FeGNlcHRpb24oZXhlYywgZWMp O1xuIik7CiAgICAgICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoKSk7XG4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMQXR0cmlidXRlcy50eHQgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0lETEF0dHJpYnV0ZXMudHh0CmluZGV4IGMwMzY5MTYuLmEwYjli N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMQXR0cmli dXRlcy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExBdHRyaWJ1 dGVzLnR4dApAQCAtMjgsNyArMjgsNiBAQCBDbGFtcAogQ29uZGl0aW9uYWw9KgogQ29uc3RydWN0 b3IKIENvbnN0cnVjdG9yQ29uZGl0aW9uYWw9KgotQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24K IENvbnN0cnVjdG9yVGVtcGxhdGU9RXZlbnR8VHlwZWRBcnJheQogQ3VzdG9tCiBDdXN0b21DYWxs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdElu dGVyZmFjZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdElu dGVyZmFjZS5pZGwKaW5kZXggYWU0ZGJkMC4uMjhmYTJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RJbnRlcmZhY2UuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0SW50ZXJmYWNlLmlkbApAQCAtMzQs NyArMzQsNyBAQAogICAgIENvbmRpdGlvbmFsPUNvbmRpdGlvbjF8Q29uZGl0aW9uMiwKICAgICBD YWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAogICAgIENvbnN0cnVjdG9yKERPTVN0cmlu ZyBzdHIxLCBbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBzdHIyKSwKLSAg ICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbiwKKyAgICBSYWlzZXNFeGNlcHRpb24sCiAgICAg Q29uc3RydWN0b3JDb25kaXRpb25hbD1URVNUX0lOVEVSRkFDRSwKICAgICBJbXBsZW1lbnRhdGlv bkxhY2tzVlRhYmxlCiBdIGludGVyZmFjZSBUZXN0SW50ZXJmYWNlIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0TmFtZWRDb25zdHJ1Y3Rvci5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdE5hbWVkQ29uc3Ry dWN0b3IuaWRsCmluZGV4IGQ0N2M1MDMuLjk1Nzc3ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0TmFtZWRDb25zdHJ1Y3Rvci5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3ROYW1lZENvbnN0cnVjdG9y LmlkbApAQCAtMzEsNiArMzEsNiBAQAogWwogICAgIEFjdGl2ZURPTU9iamVjdCwKICAgICBOYW1l ZENvbnN0cnVjdG9yPUF1ZGlvKERPTVN0cmluZyBzdHIxLCBbRGVmYXVsdD1VbmRlZmluZWRdIG9w dGlvbmFsIERPTVN0cmluZyBzdHIyLCBbRGVmYXVsdD1OdWxsU3RyaW5nXSBvcHRpb25hbCBET01T dHJpbmcgc3RyMyksCi0gICAgQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRpb24KKyAgICBSYWlzZXNF eGNlcHRpb24KIF0gaW50ZXJmYWNlIFRlc3ROYW1lZENvbnN0cnVjdG9yIHsKIH07CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmlkbCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguaWRsCmluZGV4IDliNjAyYTguLmU4OWQyYWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NNYXRyaXguaWRsCkBAIC0yNiw3ICsyNiw3IEBACiAvLyBJ bnRyb2R1Y2VkIGluIERPTSBMZXZlbCA/OgogWwogICAgIENvbnN0cnVjdG9yKFtEZWZhdWx0PU51 bGxTdHJpbmddIG9wdGlvbmFsIERPTVN0cmluZyBjc3NWYWx1ZSksCi0gICAgQ29uc3RydWN0b3JS YWlzZXNFeGNlcHRpb24sCisgICAgUmFpc2VzRXhjZXB0aW9uLAogXSBpbnRlcmZhY2UgV2ViS2l0 Q1NTTWF0cml4IHsKIAogICAgIC8vIFRoZXNlIGF0dHJpYnV0ZXMgYXJlIHNpbXBsZSBhbGlhc2Vz IGZvciBjZXJ0YWluIGVsZW1lbnRzIG9mIHRoZSA0eDQgbWF0cml4CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxPcHRpb25FbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE9wdGlvbkVsZW1lbnQuaWRsCmluZGV4IGVlYWZhNDIuLjIyNzU4YzEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9wdGlvbkVsZW1lbnQuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE9wdGlvbkVsZW1lbnQuaWRsCkBAIC0yMSw3ICsyMSw3IEBACiBb CiAgICAgSlNHZW5lcmF0ZVRvTmF0aXZlT2JqZWN0LAogICAgIE5hbWVkQ29uc3RydWN0b3I9T3B0 aW9uKFtEZWZhdWx0PU51bGxTdHJpbmddIG9wdGlvbmFsIERPTVN0cmluZyBkYXRhLCBbRGVmYXVs dD1OdWxsU3RyaW5nXSBvcHRpb25hbCBET01TdHJpbmcgdmFsdWUsIFtEZWZhdWx0PVVuZGVmaW5l ZF0gb3B0aW9uYWwgYm9vbGVhbiBkZWZhdWx0U2VsZWN0ZWQsIFtEZWZhdWx0PVVuZGVmaW5lZF0g b3B0aW9uYWwgYm9vbGVhbiBzZWxlY3RlZCksCi0gICAgQ29uc3RydWN0b3JSYWlzZXNFeGNlcHRp b24KKyAgICBSYWlzZXNFeGNlcHRpb24KIF0gaW50ZXJmYWNlIEhUTUxPcHRpb25FbGVtZW50IDog SFRNTEVsZW1lbnQgewogICAgIFtSZWZsZWN0XSBhdHRyaWJ1dGUgYm9vbGVhbiBkaXNhYmxlZDsK ICAgICByZWFkb25seSBhdHRyaWJ1dGUgSFRNTEZvcm1FbGVtZW50IGZvcm07CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRTb3VyY2UuaWRsCmluZGV4IDE4NWY0ZmQuLjQwYWE3YTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRTb3VyY2UuaWRsCkBAIC0zNCw3ICszNCw3IEBACiAgICAgQWN0aXZlRE9NT2JqZWN0 LAogICAgIENvbnN0cnVjdG9yKERPTVN0cmluZyB1cmwsIG9wdGlvbmFsIERpY3Rpb25hcnkgZXZl bnRTb3VyY2VJbml0KSwKICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAotICAg IENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAorICAgIFJhaXNlc0V4Y2VwdGlvbiwKICAgICBF dmVudFRhcmdldCwKICAgICBKU05vU3RhdGljVGFibGVzCiBdIGludGVyZmFjZSBFdmVudFNvdXJj ZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlci5pZGwKaW5kZXggMDdlY2U0NS4u ZjVlMDE1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIu aWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyLmlkbApAQCAtMzQs NyArMzQsNyBAQAogICAgIENvbmRpdGlvbmFsPVNIQVJFRF9XT1JLRVJTLAogICAgIEN1c3RvbUNv bnN0cnVjdG9yKERPTVN0cmluZyBzY3JpcHRVUkwsIFtEZWZhdWx0PU51bGxTdHJpbmddIG9wdGlv bmFsIERPTVN0cmluZyBuYW1lKSwKICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0 LAotICAgIENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAorICAgIFJhaXNlc0V4Y2VwdGlvbiwK ICAgICBKU0N1c3RvbU1hcmtGdW5jdGlvbiwKICAgICBKU0dlbmVyYXRlVG9OYXRpdmVPYmplY3Qs CiAgICAgSlNHZW5lcmF0ZVRvSlNPYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvV29ya2VyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmlkbAppbmRl eCAxMzZkYWI1Li41NWNhYmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dv cmtlci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaWRsCkBAIC0yOSw3 ICsyOSw3IEBACiAgICAgQ29uZGl0aW9uYWw9V09SS0VSUywKICAgICBDdXN0b21Db25zdHJ1Y3Rv cihET01TdHJpbmcgc2NyaXB0VXJsKSwKICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250 ZXh0LAotICAgIENvbnN0cnVjdG9yUmFpc2VzRXhjZXB0aW9uLAorICAgIFJhaXNlc0V4Y2VwdGlv biwKICAgICBKU0dlbmVyYXRlVG9OYXRpdmVPYmplY3QsCiAgICAgSlNHZW5lcmF0ZVRvSlNPYmpl Y3QKIF0gaW50ZXJmYWNlIFdvcmtlciA6IEFic3RyYWN0V29ya2VyIHsK