117376 2013-06-08 18:17:33 -0700 fourthTier: Recursive deadlock in DFG::ByteCodeParser 2013-06-08 22:41:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 898432 0 fpizlo 2013-06-08 18:17:33 -0700 Patch forthcoming. <rdar://problem/14101274> 898433 1 204105 fpizlo 2013-06-08 18:19:05 -0700 Created attachment 204105 the patch 898436 2 204105 mhahnenberg 2013-06-08 18:37:15 -0700 Comment on attachment 204105 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review r=me > Source/WTF/ChangeLog:8 > + I've often wanted to leave a lock early. Now I have that power! Yay! 898442 3 204105 darin 2013-06-08 18:46:22 -0700 Comment on attachment 204105 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > Source/WTF/wtf/Locker.h:39 > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > + Locker(T* lockable) : m_lockable(lockable) { lock(); } I think these ought to say explicit. 898444 4 fpizlo 2013-06-08 18:57:07 -0700 (In reply to comment #3) > (From update of attachment 204105 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > > > Source/WTF/wtf/Locker.h:39 > > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > > + Locker(T* lockable) : m_lockable(lockable) { lock(); } > > I think these ought to say explicit. Yes. Will change. 898450 5 fpizlo 2013-06-08 22:41:35 -0700 Landed in http://trac.webkit.org/changeset/151352 204105 2013-06-08 18:19:05 -0700 2013-06-08 18:46:22 -0700 the patch blah.patch text/plain 3336 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMzUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA2LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogUmVjdXJzaXZlIGRlYWRsb2NrIGluIERGRzo6Qnl0ZUNvZGVQYXJzZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzM3NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTGVh dmUgdGhlIGxvY2sgZWFybHkgdG8gcHJldmVudCBhIGRlYWRsb2NrIGJlbmVhdGggZ2V0KCkuCisK KyAgICAgICAgKiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6 OkJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKToKKwogMjAxMy0wNi0wOCAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlZCBib2d1cyBhc3NlcnRpb24gaW4g Q2FsbEZyYW1lOjpzZXRMb2NhdGlvbkFzQnl0ZWNvZGVPZmZzZXQoKS4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lvbiAx NTEzNDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzExNSw2ICszMTE1LDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNl cjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAgICAgICAgICAgIENvbmN1cnJlbnRKSVRMb2Nr ZXIgbG9ja2VyKG1faW5saW5lU3RhY2tUb3AtPm1fcHJvZmlsZWRCbG9jay0+bV9sb2NrKTsKICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoIXB1dFRvQmFzZS0+bV9yZWFkeSkg eworICAgICAgICAgICAgICAgICAgICBsb2NrZXIudW5sb2NrRWFybHkoKTsKICAgICAgICAgICAg ICAgICAgICAgYWRkVG9HcmFwaChGb3JjZU9TUkV4aXQpOwogICAgICAgICAgICAgICAgICAgICBh ZGRUb0dyYXBoKFBoYW50b20sIGdldChiYXNlKSk7CiAgICAgICAgICAgICAgICAgICAgIGFkZFRv R3JhcGgoUGhhbnRvbSwgZ2V0KHZhbHVlKSk7CkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMzUwKQorKysg U291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAx My0wNi0wOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIGZvdXJ0 aFRpZXI6IFJlY3Vyc2l2ZSBkZWFkbG9jayBpbiBERkc6OkJ5dGVDb2RlUGFyc2VyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTczNzYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEkndmUgb2Z0 ZW4gd2FudGVkIHRvIGxlYXZlIGEgbG9jayBlYXJseS4gTm93IEkgaGF2ZSB0aGF0IHBvd2VyIQor CisgICAgICAgICogd3RmL0xvY2tlci5oOgorICAgICAgICAoV1RGOjpMb2NrZXI6OkxvY2tlcik6 CisgICAgICAgIChXVEY6OkxvY2tlcjo6fkxvY2tlcik6CisgICAgICAgIChMb2NrZXIpOgorICAg ICAgICAoV1RGOjpMb2NrZXI6OnVubG9ja0Vhcmx5KToKKyAgICAgICAgKFdURjo6TG9ja2VyOjps b2NrKToKKwogMjAxMy0wNi0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgTWVyZ2VkIGZyb20gaHR0cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0 L3RydW5rCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Mb2NrZXIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9Mb2NrZXIuaAkocmV2aXNpb24gMTUxMzQ3KQorKysgU291cmNlL1dURi93dGYv TG9ja2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAo QykgMjAwOCwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTM1LDEwICszNSwyNyBAQCBuYW1lc3BhY2UgV1RGIHsK IHRlbXBsYXRlIDx0eXBlbmFtZSBUPiBjbGFzcyBMb2NrZXIgewogICAgIFdURl9NQUtFX05PTkNP UFlBQkxFKExvY2tlcik7CiBwdWJsaWM6Ci0gICAgTG9ja2VyKFQmIGxvY2thYmxlKSA6IG1fbG9j a2FibGUobG9ja2FibGUpIHsgbV9sb2NrYWJsZS5sb2NrKCk7IH0KLSAgICB+TG9ja2VyKCkgeyBt X2xvY2thYmxlLnVubG9jaygpOyB9CisgICAgTG9ja2VyKFQmIGxvY2thYmxlKSA6IG1fbG9ja2Fi bGUoJmxvY2thYmxlKSB7IGxvY2soKTsgfQorICAgIExvY2tlcihUKiBsb2NrYWJsZSkgOiBtX2xv Y2thYmxlKGxvY2thYmxlKSB7IGxvY2soKTsgfQorICAgIH5Mb2NrZXIoKQorICAgIHsKKyAgICAg ICAgaWYgKG1fbG9ja2FibGUpCisgICAgICAgICAgICBtX2xvY2thYmxlLT51bmxvY2soKTsKKyAg ICB9CisgICAgCisgICAgdm9pZCB1bmxvY2tFYXJseSgpCisgICAgeworICAgICAgICBtX2xvY2th YmxlLT51bmxvY2soKTsKKyAgICAgICAgbV9sb2NrYWJsZSA9IDA7CisgICAgfQogcHJpdmF0ZToK LSAgICBUJiBtX2xvY2thYmxlOworICAgIHZvaWQgbG9jaygpCisgICAgeworICAgICAgICBpZiAo bV9sb2NrYWJsZSkKKyAgICAgICAgICAgIG1fbG9ja2FibGUtPmxvY2soKTsKKyAgICB9CisgICAg CisgICAgVCogbV9sb2NrYWJsZTsKIH07CiAKIH0K