117366 2013-06-07 17:02:14 -0700 isContravenedByStructure is backwards 2013-06-11 13:53:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 898330 0 mhahnenberg 2013-06-07 17:02:14 -0700 We should be checking if arrayModeForStructure(structure) is a subset of arrayModesThatPassFiltering(), not the other way around. 898331 1 204075 mhahnenberg 2013-06-07 17:03:22 -0700 Created attachment 204075 Patch 898334 2 204075 fpizlo 2013-06-07 17:10:31 -0700 Comment on attachment 204075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204075&action=review > Source/JavaScriptCore/dfg/DFGArrayMode.h:366 > bool isContravenedByStructure(Structure* structure) Can we make it clearer that the thing that was proven was the structure? What about having a method called: structureWouldPassArrayModeFiltering(Structure*) RS=me to make a change like that 899285 3 mhahnenberg 2013-06-11 13:53:42 -0700 Committed r151468: <http://trac.webkit.org/changeset/151468> 204075 2013-06-07 17:03:22 -0700 2013-06-07 17:10:31 -0700 Patch bug-117366-20130607170344.patch text/plain 1415 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMzQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA2LTA3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgaXNDb250cmF2ZW5lZEJ5U3RydWN0dXJlIGlzIGJhY2t3YXJkcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MzY2CisKKyAgICAgICAg V2Ugc2hvdWxkIGJlIGNoZWNraW5nIGlmIGFycmF5TW9kZUZvclN0cnVjdHVyZShzdHJ1Y3R1cmUp IGlzIGEgc3Vic2V0IG9mIAorICAgICAgICBhcnJheU1vZGVzVGhhdFBhc3NGaWx0ZXJpbmcoKSwg bm90IHRoZSBvdGhlciB3YXkgYXJvdW5kLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0FycmF5TW9kZS5oOgorICAgICAgICAoSlNDOjpE Rkc6OkFycmF5TW9kZTo6aXNDb250cmF2ZW5lZEJ5U3RydWN0dXJlKToKKwogMjAxMy0wNi0wNyAg TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBmb3VydGhUaWVy OiBUaGUgYmFzZWxpbmUgaml0IGFuZCBMTGludCBzaG91bGQgdXNlIGNvbW1vbiBzbG93IHBhdGhz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FycmF5TW9kZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmgJKHJldmlzaW9u IDE1MTM0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmgJKHdv cmtpbmcgY29weSkKQEAgLTM2NSw3ICszNjUsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGlzQ29u dHJhdmVuZWRCeVN0cnVjdHVyZShTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkKICAgICB7Ci0gICAgICAg IHJldHVybiAhYXJyYXlNb2Rlc0FscmVhZHlDaGVja2VkKGFycmF5TW9kZXNUaGF0UGFzc0ZpbHRl cmluZygpLCBhcnJheU1vZGVGcm9tU3RydWN0dXJlKHN0cnVjdHVyZSkpOworICAgICAgICByZXR1 cm4gIWFycmF5TW9kZXNBbHJlYWR5Q2hlY2tlZChhcnJheU1vZGVGcm9tU3RydWN0dXJlKHN0cnVj dHVyZSksIGFycmF5TW9kZXNUaGF0UGFzc0ZpbHRlcmluZygpKTsKICAgICB9CiAgICAgCiAgICAg QXJyYXlNb2RlcyBhcnJheU1vZGVzVGhhdFBhc3NGaWx0ZXJpbmcoKSBjb25zdAo=