117344 2013-06-07 06:16:51 -0700 [curl] Allow headers with empty value 2013-06-08 14:33:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Curl P2 Normal --- 117300 0 galpeter webkit-unassigned bfulgham commit-queue oldest_to_newest 898142 0 galpeter 2013-06-07 06:16:51 -0700 The current usage of the curl backend does not allow headers with empty value. This can be easily fixed just a simple quotes ("") as value instead of an empty string will tell curl that we want it as an empty value. 898143 1 204036 galpeter 2013-06-07 06:21:51 -0700 Created attachment 204036 patch 898150 2 204036 galpeter 2013-06-07 06:40:57 -0700 Comment on attachment 204036 patch soo... it seems this is not my day it seems curl doesn't do what it says on it's own documentation page. But still with that patch some test cases passed :) I'll deliver a better patch. 898158 3 204041 galpeter 2013-06-07 07:06:57 -0700 Created attachment 204041 fixed patch Not this'll work as intended. 898380 4 204041 kenneth 2013-06-08 04:18:26 -0700 Comment on attachment 204041 fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=204041&action=review > Source/WebCore/ChangeLog:11 > + No new tests, alread covered by: > + http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html > + http/tests/xmlhttprequest/post-blob-content-type-sync.html > + no updated results? > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:758 > + // insert the ; to tell curl that this header has an empty value Nit: Use real sentences: "Insert" and punctuation mark at end. 898385 5 galpeter 2013-06-08 04:41:05 -0700 (In reply to comment #4) > (From update of attachment 204041 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204041&action=review > > > Source/WebCore/ChangeLog:11 > > + No new tests, alread covered by: > > + http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html > > + http/tests/xmlhttprequest/post-blob-content-type-sync.html > > + > > no updated results? No need for that. With this patch the test executes as expected. > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:758 > > + // insert the ; to tell curl that this header has an empty value > > Nit: Use real sentences: "Insert" and punctuation mark at end. Okay, will post the update in a minute. 898386 6 204088 galpeter 2013-06-08 04:42:25 -0700 Created attachment 204088 patch with fixes updated the patch based on the previous comment. 898409 7 204088 bfulgham 2013-06-08 14:12:51 -0700 Comment on attachment 204088 patch with fixes r=me. 898413 8 204088 commit-queue 2013-06-08 14:33:43 -0700 Comment on attachment 204088 patch with fixes Clearing flags on attachment: 204088 Committed r151348: <http://trac.webkit.org/changeset/151348> 898414 9 commit-queue 2013-06-08 14:33:45 -0700 All reviewed patches have been landed. Closing bug. 204036 2013-06-07 06:21:51 -0700 2013-06-07 06:40:57 -0700 patch curl_empty_header.patch text/plain 1564 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYTk4MzQzLi45OTc1NjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDYtMDcgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBbY3VybF0gQWxsb3cgaGVhZGVycyB3aXRoIGVtcHR5IHZhbHVlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTczNDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVh ZCBjb3ZlcmVkIGJ5OgorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHBy ZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OmluaXRpYWxpemVIYW5kbGUpOgorCiAyMDEzLTA2 LTA3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRnJhbWUgZmxh dHRlbmluZzogY3Jhc2ggd2hlbiBjaGlsZCBpZnJhbWUgaXMgcmVtb3ZlZCBkdXJpbmcgYmVmb3Jl bG9hZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9S ZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggMGNiODIwNy4uYmVmNGYyZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNl SGFuZGxlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKQEAgLTc1Miw3ICs3NTIsNyBAQCB2b2lkIFJl c291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJjZUhhbmRsZSogam9i KQogICAgICAgICBIVFRQSGVhZGVyTWFwOjpjb25zdF9pdGVyYXRvciBlbmQgPSBjdXN0b21IZWFk ZXJzLmVuZCgpOwogICAgICAgICBmb3IgKEhUVFBIZWFkZXJNYXA6OmNvbnN0X2l0ZXJhdG9yIGl0 ID0gY3VzdG9tSGVhZGVycy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAgICAg IFN0cmluZyBrZXkgPSBpdC0+a2V5OwotICAgICAgICAgICAgU3RyaW5nIHZhbHVlID0gaXQtPnZh bHVlOworICAgICAgICAgICAgU3RyaW5nIHZhbHVlID0gIWl0LT52YWx1ZS5pc0VtcHR5KCkgPyBp dC0+dmFsdWUgOiAiXCJcIiI7CiAgICAgICAgICAgICBTdHJpbmcgaGVhZGVyU3RyaW5nKGtleSk7 CiAgICAgICAgICAgICBoZWFkZXJTdHJpbmcuYXBwZW5kKCI6ICIpOwogICAgICAgICAgICAgaGVh ZGVyU3RyaW5nLmFwcGVuZCh2YWx1ZSk7Cg== 204041 2013-06-07 07:06:57 -0700 2013-06-08 04:42:25 -0700 fixed patch curl_empty_header.patch text/plain 1830 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYTk4MzQzLi40Mjg3MTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDYtMDcgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBbY3VybF0gQWxsb3cgaGVhZGVycyB3aXRoIGVtcHR5IHZhbHVlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTczNDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVh ZCBjb3ZlcmVkIGJ5OgorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHBy ZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUuaHRtbAorICAgICAgICBodHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3Bvc3QtYmxvYi1jb250ZW50LXR5cGUtc3luYy5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZSk6 CisKIDIwMTMtMDYtMDcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBGcmFtZSBmbGF0dGVuaW5nOiBjcmFzaCB3aGVuIGNoaWxkIGlmcmFtZSBpcyByZW1vdmVkIGR1 cmluZyBiZWZvcmVsb2FkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAppbmRleCAwY2I4MjA3 Li5lOTNkNmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApAQCAtNzU0LDggKzc1NCwx MyBAQCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJj ZUhhbmRsZSogam9iKQogICAgICAgICAgICAgU3RyaW5nIGtleSA9IGl0LT5rZXk7CiAgICAgICAg ICAgICBTdHJpbmcgdmFsdWUgPSBpdC0+dmFsdWU7CiAgICAgICAgICAgICBTdHJpbmcgaGVhZGVy U3RyaW5nKGtleSk7Ci0gICAgICAgICAgICBoZWFkZXJTdHJpbmcuYXBwZW5kKCI6ICIpOwotICAg ICAgICAgICAgaGVhZGVyU3RyaW5nLmFwcGVuZCh2YWx1ZSk7CisgICAgICAgICAgICBpZiAodmFs dWUuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIC8vIGluc2VydCB0aGUgOyB0byB0ZWxsIGN1 cmwgdGhhdCB0aGlzIGhlYWRlciBoYXMgYW4gZW1wdHkgdmFsdWUKKyAgICAgICAgICAgICAgICBo ZWFkZXJTdHJpbmcuYXBwZW5kKCI7Iik7CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAg ICAgICBoZWFkZXJTdHJpbmcuYXBwZW5kKCI6ICIpOworICAgICAgICAgICAgICAgIGhlYWRlclN0 cmluZy5hcHBlbmQodmFsdWUpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgQ1N0cmluZyBo ZWFkZXJMYXRpbjEgPSBoZWFkZXJTdHJpbmcubGF0aW4xKCk7CiAgICAgICAgICAgICBoZWFkZXJz ID0gY3VybF9zbGlzdF9hcHBlbmQoaGVhZGVycywgaGVhZGVyTGF0aW4xLmRhdGEoKSk7CiAgICAg ICAgIH0K 204088 2013-06-08 04:42:25 -0700 2013-06-08 14:33:43 -0700 patch with fixes curl_empty_header.patch text/plain 1874 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggYWE5ODM0My4uNDI4NzE4OCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZw0KKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQpAQCAtMSwzICsx LDE3IEBADQorMjAxMy0wNi0wNyAgUGV0ZXIgR2FsICA8Z2FscGV0ZXJAaW5mLnUtc3plZ2VkLmh1 Pg0KKw0KKyAgICAgICAgW2N1cmxdIEFsbG93IGhlYWRlcnMgd2l0aCBlbXB0eSB2YWx1ZQ0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzM0NA0KKw0K KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICBObyBuZXcg dGVzdHMsIGFscmVhZHkgY292ZXJlZCBieToNCisgICAgICAgIGh0dHAvdGVzdHMveG1saHR0cHJl cXVlc3QveG1saHR0cHJlcXVlc3Qtc2V0cmVxdWVzdGhlYWRlci1uby12YWx1ZS5odG1sDQorICAg ICAgICBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Bvc3QtYmxvYi1jb250ZW50LXR5cGUtc3lu Yy5odG1sDQorDQorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZU1hbmFnZXIuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6 aW5pdGlhbGl6ZUhhbmRsZSk6DQorDQogMjAxMy0wNi0wNyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPg0KIA0KICAgICAgICAgRnJhbWUgZmxhdHRlbmluZzogY3Jhc2ggd2hlbiBjaGls ZCBpZnJhbWUgaXMgcmVtb3ZlZCBkdXJpbmcgYmVmb3JlbG9hZC4NCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1h bmFnZXIuY3BwDQppbmRleCAwY2I4MjA3Li5hY2I2YWRhIDEwMDY0NA0KLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHANCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1h bmFnZXIuY3BwDQpAQCAtNzU0LDggKzc1NCwxMyBAQCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdl cjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJjZUhhbmRsZSogam9iKQ0KICAgICAgICAgICAgIFN0 cmluZyBrZXkgPSBpdC0+a2V5Ow0KICAgICAgICAgICAgIFN0cmluZyB2YWx1ZSA9IGl0LT52YWx1 ZTsNCiAgICAgICAgICAgICBTdHJpbmcgaGVhZGVyU3RyaW5nKGtleSk7DQotICAgICAgICAgICAg aGVhZGVyU3RyaW5nLmFwcGVuZCgiOiAiKTsNCi0gICAgICAgICAgICBoZWFkZXJTdHJpbmcuYXBw ZW5kKHZhbHVlKTsNCisgICAgICAgICAgICBpZiAodmFsdWUuaXNFbXB0eSgpKQ0KKyAgICAgICAg ICAgICAgICAvLyBJbnNlcnQgdGhlIDsgdG8gdGVsbCBjdXJsIHRoYXQgdGhpcyBoZWFkZXIgaGFz IGFuIGVtcHR5IHZhbHVlLg0KKyAgICAgICAgICAgICAgICBoZWFkZXJTdHJpbmcuYXBwZW5kKCI7 Iik7DQorICAgICAgICAgICAgZWxzZSB7DQorICAgICAgICAgICAgICAgIGhlYWRlclN0cmluZy5h cHBlbmQoIjogIik7DQorICAgICAgICAgICAgICAgIGhlYWRlclN0cmluZy5hcHBlbmQodmFsdWUp Ow0KKyAgICAgICAgICAgIH0NCiAgICAgICAgICAgICBDU3RyaW5nIGhlYWRlckxhdGluMSA9IGhl YWRlclN0cmluZy5sYXRpbjEoKTsNCiAgICAgICAgICAgICBoZWFkZXJzID0gY3VybF9zbGlzdF9h cHBlbmQoaGVhZGVycywgaGVhZGVyTGF0aW4xLmRhdGEoKSk7DQogICAgICAgICB9DQo=