117332 2013-06-06 23:37:10 -0700 [GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL 2013-06-12 01:09:58 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dpino webkit-unassigned cdumez commit-queue xan.lopez oldest_to_newest 898030 0 dpino 2013-06-06 23:37:10 -0700 According to the 'Document Object Model' CSS spec: http://www.w3.org/TR/DOM-Level-2-Style/css.html Parameter 'pseudoElement' from function 'getComputedStyle' could be null. The GObject binding generator generates code that always check this parameter cannot be null. 898038 1 204004 dpino 2013-06-06 23:45:58 -0700 Created attachment 204004 Patch 899465 2 204004 xan.lopez 2013-06-12 00:46:51 -0700 Comment on attachment 204004 Patch Looks good in general. It's a bit sad to duplicate some of the setup code but the existing one seems pretty specific to the test that uses it. 899467 3 204004 commit-queue 2013-06-12 01:09:55 -0700 Comment on attachment 204004 Patch Clearing flags on attachment: 204004 Committed r151489: <http://trac.webkit.org/changeset/151489> 899468 4 commit-queue 2013-06-12 01:09:58 -0700 All reviewed patches have been landed. Closing bug. 204004 2013-06-06 23:45:58 -0700 2013-06-12 01:09:54 -0700 Patch bug-117332-20130607084424.patch text/plain 6354 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRkYWQ0Zjg0MWQyZmQ2 N2Y3YzcwYzYyMjRjMWIyY2UzYzM1NTc1MS4uNzEyODY4ZWQ1ZTg4OWZjZDkyOTZiMTg1OTQ4MTE4 ZWRlYTE2MDExNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA2LTA2ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gUGFyYW1l dGVyICdwc2V1ZG9FbGVtZW50JyBmcm9tIGZ1bmN0aW9uICd3ZWJraXRfZG9tX2RvbV93aW5kb3df Z2V0X2NvbXB1dGVkX3N0eWxlJyBzaG91bGQgYmUgYWxsb3dlZCB0byBiZSBOVUxMCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTczMzIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcGFyYW1ldGVyICdw c2V1ZG9FbGVtZW50JyB0byB0aGUgbGlzdCBvZiBwYXJhbWV0ZXJzIHRoYXQgYXJlIGFsbG93ZWQg dG8KKyAgICAgICAgYmUgTlVMTC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChHZXRHUmV0dXJuTWFjcm8pOgorCisyMDEzLTA2 LTA2ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dU S10gUGFyYW1ldGVyICdyZWZDaGlsZCcgZnJvbSBmdW5jdGlvbiAnd2Via2l0X2RvbV9ub2RlX2lu c2VydF9iZWZvcmUnIHNob3VsZCBiZSBhbGxvd2VkIHRvIGJlIE5VTEwKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMwMwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNjkyZWRiOTIwNGYyY2ZlYjk1NTA0MDMwMzM2YzdkZTFlMWU1OWZmZi4uYTU5NTcyMDU2 YzlmNDM1ZGJmMzgzNDA2Mjk1OTlhZWIyZWU5MGI3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDI0IEBACiAyMDEzLTA2LTA2ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5j b20+CiAKKyAgICAgICAgW0dUS10gUGFyYW1ldGVyICdwc2V1ZG9FbGVtZW50JyBmcm9tIGZ1bmN0 aW9uICd3ZWJraXRfZG9tX2RvbV93aW5kb3dfZ2V0X2NvbXB1dGVkX3N0eWxlJyBzaG91bGQgYmUg YWxsb3dlZCB0byBiZSBOVUxMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTczMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgdGVzdCBmb3IgZnVuY3Rpb24gJ3dlYmtpdF9kb21fZG9tX3dpbmRvd19n ZXRfY29tcHV0ZWRfc3R5bGUnLgorCisgICAgICAgICogdGVzdHMvdGVzdGRvbWRvbXdpbmRvdy5j OgorICAgICAgICAoZG9tX2RvbV93aW5kb3dfZml4dHVyZV9zZXR1cCk6IFRlc3Qgc2V0dXAgZm9y IGZ1bmN0aW9uCisgICAgICAgICdkb21fZG9tX3dpbmRvd19nZXRfY29tcHV0ZWRfc3R5bGUnLgor ICAgICAgICAoZG9tX2RvbV93aW5kb3dfZml4dHVyZV90ZWFyZG93bik6IFRlc3QgdGVhcmRvd24g Zm9yIGZ1bmN0aW9uCisgICAgICAgICdkb21fZG9tX3dpbmRvd19nZXRfY29tcHV0ZWRfc3R5bGUn LgorICAgICAgICAobG9hZGVkQ2FsbGJhY2spOgorICAgICAgICAodGVzdF9kb21fZG9tX3dpbmRv d19nZXRfY29tcHV0ZWRfc3R5bGUpOiBDaGVja3MgZnVuY3Rpb24KKyAgICAgICAgJ2RvbV9kb21f d2luZG93X2dldF9jb21wdXRlZF9zdHlsZScuCisgICAgICAgIChtYWluKToKKworMjAxMy0wNi0w NiAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtd IFBhcmFtZXRlciAncmVmQ2hpbGQnIGZyb20gZnVuY3Rpb24gJ3dlYmtpdF9kb21fbm9kZV9pbnNl cnRfYmVmb3JlJyBzaG91bGQgYmUgYWxsb3dlZCB0byBiZSBOVUxMCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTczMDMKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5k ZXggY2JlNjk3MTcxY2UxZGY5OWEzMTE3ZDUxNWI1YTIyMjRhY2NhM2MzOC4uMGZiNmZmNWY4ZWFj NWI1MDE4NzM5NjE0MGI1NTdjOGIxZTEyOGNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC00OCw3ICs0 OCw4IEBAIG15ICViYXNlVHlwZUhhc2ggPSAoIk9iamVjdCIgPT4gMSwgIk5vZGUiID0+IDEsICJO b2RlTGlzdCIgPT4gMSwgIk5hbWVkTm9kZU1hcCIKICMgTGlzdCBvZiBmdW5jdGlvbiBwYXJhbWV0 ZXJzIHRoYXQgYXJlIGFsbG93ZWQgdG8gYmUgTlVMTAogbXkgJGNhbkJlTnVsbFBhcmFtcyA9IHsK ICAgICAnd2Via2l0X2RvbV9kb2N1bWVudF9ldmFsdWF0ZScgPT4gWydpblJlc3VsdCcsICdyZXNv bHZlciddLAotICAgICd3ZWJraXRfZG9tX25vZGVfaW5zZXJ0X2JlZm9yZScgPT4gWydyZWZDaGls ZCddCisgICAgJ3dlYmtpdF9kb21fbm9kZV9pbnNlcnRfYmVmb3JlJyA9PiBbJ3JlZkNoaWxkJ10s CisgICAgJ3dlYmtpdF9kb21fZG9tX3dpbmRvd19nZXRfY29tcHV0ZWRfc3R5bGUnID0+IFsncHNl dWRvRWxlbWVudCddCiB9OwogCiAjIERlZmF1bHQgY29uc3RydWN0b3IKQEAgLTg2Myw2ICs4NjQs OSBAQCBzdWIgR2V0R1JldHVybk1hY3JvIHsKICAgICAgICAgICAgICRjb25kaXRpb24gPSAiISRw YXJhbU5hbWUgfHwgJGNvbmRpdGlvbiI7CiAgICAgICAgIH0KICAgICB9IGVsc2UgeworICAgICAg ICBpZiAoUGFyYW1DYW5CZU51bGwoJGZ1bmN0aW9uTmFtZSwgJHBhcmFtTmFtZSkpIHsKKyAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgfQogICAgICAgICAkY29uZGl0aW9uID0gIiRwYXJhbU5h bWUiOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGRv bWRvbXdpbmRvdy5jIGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGRvbWRvbXdpbmRvdy5j CmluZGV4IDNkMzEyZGZkMzFjMDRhZTIxYWRmNGUyOWRlNjNiMTYyNTQ0M2I1OTIuLjcwMWRmNGYx Nzg1NGJkNWI5MTc0ZDJhMzk4MDdmNzdjYjMxZjdhODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZ3RrL3Rlc3RzL3Rlc3Rkb21kb213aW5kb3cuYworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay90 ZXN0cy90ZXN0ZG9tZG9td2luZG93LmMKQEAgLTI1LDcgKzI1LDcgQEAKICNpbmNsdWRlIDxndGsv Z3RrLmg+CiAjaW5jbHVkZSA8d2Via2l0L3dlYmtpdC5oPgogCi0jZGVmaW5lIEhUTUxfRE9DVU1F TlQgIjxodG1sPjxoZWFkPjx0aXRsZT5UaGlzIGlzIHRoZSB0aXRsZTwvdGl0bGU+PC9oZWFkPjxi b2R5PjxwIGlkPSd0ZXN0Jz50ZXN0PC9wPjwvYm9keT48L2h0bWw+IgorI2RlZmluZSBIVE1MX0RP Q1VNRU5UICI8aHRtbD48aGVhZD48dGl0bGU+PC90aXRsZT48L2hlYWQ+PHN0eWxlIHR5cGU9J3Rl eHQvY3NzJz4jdGVzdCB7IGZvbnQtc2l6ZTogMTZweDsgfTwvc3R5bGU+PGJvZHk+PHAgaWQ9J3Rl c3QnPnRlc3Q8L3A+PC9ib2R5PjwvaHRtbD4iCiAKIHR5cGVkZWYgc3RydWN0IHsKICAgICBHdGtX aWRnZXQqIHdlYlZpZXc7CkBAIC02Miw2ICs2MiwyNiBAQCBzdGF0aWMgdm9pZCBkb21fZG9tdmll d19maXh0dXJlX3RlYXJkb3duKERvbURvbXZpZXdGaXh0dXJlKiBmaXh0dXJlLCBnY29uc3Rwb2lu dAogICAgIGdfbWFpbl9sb29wX3VucmVmKGZpeHR1cmUtPmxvb3ApOwogfQogCitzdGF0aWMgdm9p ZCBkb21fZG9tX3dpbmRvd19maXh0dXJlX3NldHVwKERvbURvbXZpZXdGaXh0dXJlKiBmaXh0dXJl LCBnY29uc3Rwb2ludGVyIGRhdGEpCit7CisgICAgZml4dHVyZS0+bG9vcCA9IGdfbWFpbl9sb29w X25ldyhOVUxMLCBUUlVFKTsKKyAgICBmaXh0dXJlLT53ZWJWaWV3ID0gd2Via2l0X3dlYl92aWV3 X25ldygpOworICAgIGdfb2JqZWN0X3JlZl9zaW5rKGZpeHR1cmUtPndlYlZpZXcpOworCisgICAg aWYgKGRhdGEgIT0gTlVMTCkKKyAgICAgICAgd2Via2l0X3dlYl92aWV3X2xvYWRfc3RyaW5nKFdF QktJVF9XRUJfVklFVyAoZml4dHVyZS0+d2ViVmlldyksIChjb25zdCBjaGFyKikgZGF0YSwgTlVM TCwgTlVMTCwgTlVMTCk7CisKKyAgICBnX2lkbGVfYWRkKChHU291cmNlRnVuYylmaW5pc2hfbG9h ZGluZywgZml4dHVyZSk7CisgICAgZ19tYWluX2xvb3BfcnVuKGZpeHR1cmUtPmxvb3ApOworfQor CitzdGF0aWMgdm9pZCBkb21fZG9tX3dpbmRvd19maXh0dXJlX3RlYXJkb3duKERvbURvbXZpZXdG aXh0dXJlKiBmaXh0dXJlLCBnY29uc3Rwb2ludGVyIGRhdGEpCit7CisgICAgaWYgKGZpeHR1cmUt PndlYlZpZXcpCisgICAgICAgIGdfb2JqZWN0X3VucmVmKGZpeHR1cmUtPndlYlZpZXcpOworICAg IGdfbWFpbl9sb29wX3VucmVmKGZpeHR1cmUtPmxvb3ApOworfQorCiBzdGF0aWMgZ2Jvb2xlYW4g bG9hZGVkQ2FsbGJhY2soV2ViS2l0RE9NRE9NV2luZG93KiB2aWV3LCBXZWJLaXRET01FdmVudCog ZXZlbnQsIERvbURvbXZpZXdGaXh0dXJlKiBmaXh0dXJlKQogewogICAgIGdfYXNzZXJ0KGZpeHR1 cmUtPmxvYWRlZCA9PSBGQUxTRSk7CkBAIC0xOTQsNiArMjE0LDIxIEBAIHN0YXRpYyB2b2lkIHRl c3RfZG9tX2RvbXZpZXdfZGlzcGF0Y2hfZXZlbnQoRG9tRG9tdmlld0ZpeHR1cmUqIGZpeHR1cmUs IGdjb25zdHBvCiAgICAgZ19hc3NlcnQoZml4dHVyZS0+Y2xpY2tlZCk7CiB9CiAKK3N0YXRpYyB2 b2lkIHRlc3RfZG9tX2RvbV93aW5kb3dfZ2V0X2NvbXB1dGVkX3N0eWxlKERvbURvbXZpZXdGaXh0 dXJlKiBmaXh0dXJlLCBnY29uc3Rwb2ludGVyIGRhdGEpCit7CisgICAgV2ViS2l0RE9NRG9jdW1l bnQqIGRvY3VtZW50ID0gd2Via2l0X3dlYl92aWV3X2dldF9kb21fZG9jdW1lbnQoV0VCS0lUX1dF Ql9WSUVXKGZpeHR1cmUtPndlYlZpZXcpKTsKKyAgICBnX2Fzc2VydChkb2N1bWVudCk7CisgICAg V2ViS2l0RE9NRE9NV2luZG93KiBkb21XaW5kb3cgPSB3ZWJraXRfZG9tX2RvY3VtZW50X2dldF9k ZWZhdWx0X3ZpZXcoZG9jdW1lbnQpOworICAgIGdfYXNzZXJ0KGRvbVdpbmRvdyk7CisKKyAgICBX ZWJLaXRET01FbGVtZW50KiAgZWxlbWVudCA9IHdlYmtpdF9kb21fZG9jdW1lbnRfZ2V0X2VsZW1l bnRfYnlfaWQoZG9jdW1lbnQsICJ0ZXN0Iik7CisgICAgZ19hc3NlcnQoZWxlbWVudCk7CisgICAg Z19hc3NlcnQoV0VCS0lUX0RPTV9JU19FTEVNRU5UKGVsZW1lbnQpKTsKKyAgICBXZWJLaXRET01D U1NTdHlsZURlY2xhcmF0aW9uKiBjc3NTdHlsZSA9IHdlYmtpdF9kb21fZG9tX3dpbmRvd19nZXRf Y29tcHV0ZWRfc3R5bGUoZG9tV2luZG93LCBlbGVtZW50LCBOVUxMKTsKKyAgICBnY2hhciogZm9u dFNpemUgPSB3ZWJraXRfZG9tX2Nzc19zdHlsZV9kZWNsYXJhdGlvbl9nZXRfcHJvcGVydHlfdmFs dWUoY3NzU3R5bGUsICJmb250LXNpemUiKTsKKyAgICBnX2Fzc2VydF9jbXBzdHIoZm9udFNpemUs ID09LCAiMTZweCIpOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAg ICAgZ3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIE5VTEwpOwpAQCAtMjEyLDYgKzI0NywxMiBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgICAgICAgICAgICB0ZXN0X2Rv bV9kb212aWV3X2Rpc3BhdGNoX2V2ZW50LAogICAgICAgICAgICAgICAgZG9tX2RvbXZpZXdfZml4 dHVyZV90ZWFyZG93bik7CiAKKyAgICBnX3Rlc3RfYWRkKCIvd2Via2l0L2RvbWRvbXdpbmRvdy9n ZXRfY29tcHV0ZWRfc3R5bGUiLAorICAgICAgICAgICAgICAgRG9tRG9tdmlld0ZpeHR1cmUsIEhU TUxfRE9DVU1FTlQsCisgICAgICAgICAgICAgICBkb21fZG9tX3dpbmRvd19maXh0dXJlX3NldHVw LAorICAgICAgICAgICAgICAgdGVzdF9kb21fZG9tX3dpbmRvd19nZXRfY29tcHV0ZWRfc3R5bGUs CisgICAgICAgICAgICAgICBkb21fZG9tX3dpbmRvd19maXh0dXJlX3RlYXJkb3duKTsKKwogICAg IHJldHVybiBnX3Rlc3RfcnVuKCk7CiB9CiAK