117328 2013-06-06 17:53:04 -0700 Completely initialise ChildProcess state on launch 2013-06-06 18:12:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 897988 0 oliver 2013-06-06 17:53:04 -0700 Completely initialise ChildProcess state on launch 897990 1 203984 oliver 2013-06-06 17:53:41 -0700 Created attachment 203984 Patch 897992 2 203984 sam 2013-06-06 17:59:59 -0700 Comment on attachment 203984 Patch Process initialization should happen in ChildProcess::initialize() or one of its subclasses. It seems like setProcessSuppressionEnabled(false); is already called from ChildProcess::platformInitialize(), why is that not enough? 897994 3 203986 oliver 2013-06-06 18:03:07 -0700 Created attachment 203986 Patch 897996 4 203986 sam 2013-06-06 18:07:36 -0700 Comment on attachment 203986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203986&action=review > Source/WebKit2/ChangeLog:8 > + Don't rely on receiving a message from the UI process as part of our initialisation I don't think this make sense. > Source/WebKit2/Shared/mac/ChildProcessMac.mm:151 > - setProcessSuppressionEnabled(false); > + setProcessSuppressionEnabledInternal(false); You should note why you are using the weird internal variant here. 897997 5 oliver 2013-06-06 18:12:26 -0700 Committed r151305: <http://trac.webkit.org/changeset/151305> 203984 2013-06-06 17:53:41 -0700 2013-06-06 18:03:05 -0700 Patch bug-117328-20130606175311.patch text/plain 1333 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmMwNGY0NmJkMjIzODNh NjcyNGM1ODk4OTczMGQ5ODE5OGVlNjQ5YS4uYjgzOTczYTIxYjY2ZWNkN2ZiMTdlNTI3OTcwN2Qw YjY0MjEyNGQ5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTA2ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29tcGxldGVseSBpbml0aWFs aXNlIENoaWxkUHJvY2VzcyBzdGF0ZSBvbiBsYXVuY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHJlbHkgb24gcmVjZWl2aW5nIGEgbWVzc2Fn ZSBmcm9tIHRoZSBVSSBwcm9jZXNzIGFzIHBhcnQgb2Ygb3VyIGluaXRpYWxpc2F0aW9uCisKKyAg ICAgICAgKiBTaGFyZWQvQ2hpbGRQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hpbGRQ cm9jZXNzOjpDaGlsZFByb2Nlc3MpOgorCiAyMDEzLTA2LTA2ICBSYWZhZWwgQnJhbmRhbyAgPHJh ZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW0d0a10gQ29ubmVjdGlvbiBpcyBs ZWFraW5nIHdoZW4gV2ViUHJvY2VzcyBpcyB0ZXJtaW5hdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9D aGlsZFByb2Nlc3MuY3BwCmluZGV4IDdjMjcwZTg3NjY5OGVhODQ3ODY1ZDc5ZmI0MmY5NTAzYjcx NTU5MTEuLjA0MDM2YWU1MTU3ZTI2ZGRmMWUwZGUyOWU3YTFiMGQwYWQ0ZDAyZWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwCkBAIC00Niw2ICs0Niw5IEBAIENoaWxkUHJv Y2Vzczo6Q2hpbGRQcm9jZXNzKCkKICAgICAsIG1fc3VzcGVuc2lvbkh5c3RlcmVzaXNUaW1lcihS dW5Mb29wOjptYWluKCksIHRoaXMsICZDaGlsZFByb2Nlc3M6OnN1c3BlbnNpb25IeXN0ZXJlc2lz VGltZXJGaXJlZCkKICNlbmRpZgogeworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBzZXRQcm9jZXNz U3VwcHJlc3Npb25FbmFibGVkSW50ZXJuYWwoZmFsc2UpOworI2VuZGlmCiB9CiAKIENoaWxkUHJv Y2Vzczo6fkNoaWxkUHJvY2VzcygpCg== 203986 2013-06-06 18:03:07 -0700 2013-06-06 18:07:36 -0700 Patch bug-117328-20130606180237.patch text/plain 1533 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmMwNGY0NmJkMjIzODNh NjcyNGM1ODk4OTczMGQ5ODE5OGVlNjQ5YS4uNWI3MTM2NTdlMjExYTY2ODE5YTgwMzM1NTBhMDhi MjY1Yzg4YjkwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTA2ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29tcGxldGVseSBpbml0aWFs aXNlIENoaWxkUHJvY2VzcyBzdGF0ZSBvbiBsYXVuY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHJlbHkgb24gcmVjZWl2aW5nIGEgbWVzc2Fn ZSBmcm9tIHRoZSBVSSBwcm9jZXNzIGFzIHBhcnQgb2Ygb3VyIGluaXRpYWxpc2F0aW9uCisKKyAg ICAgICAgKiBTaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6 Q2hpbGRQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorCiAyMDEzLTA2LTA2ICBSYWZhZWwg QnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW0d0a10gQ29u bmVjdGlvbiBpcyBsZWFraW5nIHdoZW4gV2ViUHJvY2VzcyBpcyB0ZXJtaW5hdGVkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0NoaWxkUHJvY2Vzc01hYy5tbSBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ2hpbGRQcm9jZXNzTWFjLm1tCmluZGV4IDViNWRhYmQ0NjFj NjliZjZkNTQ0MmIzZWM3NjI3NWJhNTZjYTg0ZTguLjgyZDA5NDNhMTM5M2Q5ZDc4Yzg3NmU4M2Zl Zjk2OGI4YThlYmEwMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ2hp bGRQcm9jZXNzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ2hpbGRQcm9j ZXNzTWFjLm1tCkBAIC0xNDgsNyArMTQ4LDcgQEAgdm9pZCBDaGlsZFByb2Nlc3M6OnBsYXRmb3Jt SW5pdGlhbGl6ZSgpCiAgICAgaW5pdGlhbGl6ZVRpbWVyQ29hbGVzY2luZ1BvbGljeSgpOwogI2Vu ZGlmCiAgICAgLy8gU3RhcnRpbmcgd2l0aCBwcm9jZXNzIHN1cHByZXNzaW9uIGRpc2FibGVkLiAg VGhlIHByb3h5IGZvciB0aGlzIHByb2Nlc3Mgd2lsbCBlbmFibGUgaWYgYXBwcm9wcmlhdGUgZnJv bSBkaWRGaW5pc2hMYXVuY2hpbmcoKS4KLSAgICBzZXRQcm9jZXNzU3VwcHJlc3Npb25FbmFibGVk KGZhbHNlKTsKKyAgICBzZXRQcm9jZXNzU3VwcHJlc3Npb25FbmFibGVkSW50ZXJuYWwoZmFsc2Up OwogCiAgICAgW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSBjaGFuZ2VDdXJyZW50RGly ZWN0b3J5UGF0aDpbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZVBhdGhdXTsKIH0K