117303 2013-06-06 08:42:45 -0700 [GTK] Parameter 'refChild' from function 'webkit_dom_node_insert_before' should be allowed to be NULL 2013-06-06 13:43:37 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dpino webkit-unassigned cdumez commit-queue xan.lopez oldest_to_newest 897795 0 dpino 2013-06-06 08:42:45 -0700 According to the spec, parameter 'refChild' from insertBefore can be null. http://www.w3.org/TR/DOM-Level-2-Core/core.html However, the GObject DOM bindings generator generates code that don't allow this parameter to be NULL. 897797 1 203938 dpino 2013-06-06 08:51:21 -0700 Created attachment 203938 Patch 897893 2 203938 xan.lopez 2013-06-06 13:21:02 -0700 Comment on attachment 203938 Patch Awesome! 897908 3 203938 commit-queue 2013-06-06 13:43:35 -0700 Comment on attachment 203938 Patch Clearing flags on attachment: 203938 Committed r151288: <http://trac.webkit.org/changeset/151288> 897909 4 commit-queue 2013-06-06 13:43:37 -0700 All reviewed patches have been landed. Closing bug. 203938 2013-06-06 08:51:21 -0700 2013-06-06 13:43:35 -0700 Patch bug-117303-20130606174948.patch text/plain 4562 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg1YzNiZmE4NTg0ODNh MWRjYTljMmU1OTBhMGQ2NmUzZDliODk2Mi4uZmFmNjUzNWU5MjJkMmQwMWQ0M2QzNGY1NDIzOTdk NzE2OTA4MTg5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTA2LTA2ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gUGFyYW1l dGVyICdyZWZDaGlsZCcgZnJvbSBmdW5jdGlvbiAnd2Via2l0X2RvbV9ub2RlX2luc2VydF9iZWZv cmUnIHNob3VsZCBiZSBhbGxvd2VkIHRvIGJlIE5VTEwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBwYXJhbWV0ZXIgJ3JlZkNoaWxkJyB0byB0aGUg bGlzdCBvZiBwYXJhbWV0ZXJzIHRoYXQgYXJlIGFsbG93ZWQgdG8KKyAgICAgICAgYmUgTlVMTC4K KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisK KzIwMTMtMDYtMDYgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KKwogICAg ICAgICBbR1RLXSBQYXJhbWV0ZXJzICdpblJlc3VsdCcgYW5kICdyZXNvbHZlcicgZnJvbSBmdW5j dGlvbiAnd2Via2l0X2RvbV9kb2N1bWVudF9ldmFsdWF0ZScgc2hvdWxkIGJlIGFsbG93ZWQgdG8g YmUgTlVMTAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE3MTI5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBhMjI4OWE0ODJmYmFmMTMzYTNkNWZmZTYwYzcz NWY1NjY4Nzg0MjcxLi5lNDg4ZmI5NzFmN2QwMjE2ZWMyYjBjYmYyYjI5M2EwOWQ2ODU3NDI5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTMtMDYtMDYgIERpZWdvIFBpbm8g R2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBQYXJhbWV0ZXIgJ3Jl ZkNoaWxkJyBmcm9tIGZ1bmN0aW9uICd3ZWJraXRfZG9tX25vZGVfaW5zZXJ0X2JlZm9yZScgc2hv dWxkIGJlIGFsbG93ZWQgdG8gYmUgTlVMTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yIGZ1bmN0aW9uICd3ZWJraXRfZG9tX25vZGVf aW5zZXJ0X2JlZm9yZScuCisKKyAgICAgICAgKiB0ZXN0cy90ZXN0ZG9tbm9kZS5jOiBDaGVja3Mg ZnVuY3Rpb24gZG9tX2RvY3VtZW50X25vZGVfaW5zZXJ0X2JlZm9yZQorICAgICAgICAodGVzdF9k b21fbm9kZV9pbnNlcnRpb24pOgorCisyMDEzLTA2LTA2ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRw aW5vQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gUGFyYW1ldGVycyAnaW5SZXN1bHQnIGFu ZCAncmVzb2x2ZXInIGZyb20gZnVuY3Rpb24gJ3dlYmtpdF9kb21fZG9jdW1lbnRfZXZhbHVhdGUn IHNob3VsZCBiZSBhbGxvd2VkIHRvIGJlIE5VTEwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzEyOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCA5Zjk3N2I1 MTI4M2I1OGZjOTMxMmJiODMyZDY3N2MyZjgyZTA3ZDE4Li5jYmU2OTcxNzFjZTFkZjk5YTMxMTdk NTE1YjVhMjIyNGFjY2EzYzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTQ3LDcgKzQ3LDggQEAgbXkg JWJhc2VUeXBlSGFzaCA9ICgiT2JqZWN0IiA9PiAxLCAiTm9kZSIgPT4gMSwgIk5vZGVMaXN0IiA9 PiAxLCAiTmFtZWROb2RlTWFwIgogCiAjIExpc3Qgb2YgZnVuY3Rpb24gcGFyYW1ldGVycyB0aGF0 IGFyZSBhbGxvd2VkIHRvIGJlIE5VTEwKIG15ICRjYW5CZU51bGxQYXJhbXMgPSB7Ci0gICAgJ3dl YmtpdF9kb21fZG9jdW1lbnRfZXZhbHVhdGUnID0+IFsnaW5SZXN1bHQnLCAncmVzb2x2ZXInXQor ICAgICd3ZWJraXRfZG9tX2RvY3VtZW50X2V2YWx1YXRlJyA9PiBbJ2luUmVzdWx0JywgJ3Jlc29s dmVyJ10sCisgICAgJ3dlYmtpdF9kb21fbm9kZV9pbnNlcnRfYmVmb3JlJyA9PiBbJ3JlZkNoaWxk J10KIH07CiAKICMgRGVmYXVsdCBjb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ndGsvdGVzdHMvdGVzdGRvbW5vZGUuYyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rk b21ub2RlLmMKaW5kZXggNjYxMmRiZmYzNWRjOGMyNzI1YzJhNzgzODQ2N2NkODFkZWU3ODg1Zi4u MDUyMWQxNzE1MDkyZmRhZThiOTA1MTdjNDFmMjg2OWNjNmM1MDE3OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGRvbW5vZGUuYworKysgYi9Tb3VyY2UvV2ViS2l0L2d0 ay90ZXN0cy90ZXN0ZG9tbm9kZS5jCkBAIC0xNjgsNyArMTY4LDMyIEBAIHN0YXRpYyB2b2lkIHRl c3RfZG9tX25vZGVfaW5zZXJ0aW9uKERvbU5vZGVGaXh0dXJlKiBmaXh0dXJlLCBnY29uc3Rwb2lu dGVyIGRhdGEpCiAgICAgZ19hc3NlcnRfY21waW50KHdlYmtpdF9kb21fbm9kZV9saXN0X2dldF9s ZW5ndGgobGlzdCksID09LCAwKTsKICAgICBnX29iamVjdF91bnJlZihsaXN0KTsKIAotICAgIC8q IFRPRE86IGluc2VydF9iZWZvcmUsIHdoaWNoIGRvZXMgbm90IHNlZW0gdG8gYmUgd29ya2luZyBj b3JyZWN0bHkgKi8KKyAgICAvKiBUZXN0IGluc2VydF9iZWZvcmUgKi8KKworICAgIC8qIElmIHJl ZkNoaWxkIGlzIG51bGwsIGluc2VydCBuZXdDaGlsZCBhcyBsYXN0IGVsZW1lbnQgb2YgcGFyZW50 ICovCisgICAgZGl2ID0gd2Via2l0X2RvbV9kb2N1bWVudF9jcmVhdGVfZWxlbWVudChkb2N1bWVu dCwgIkRJViIsIE5VTEwpOworICAgIHdlYmtpdF9kb21fbm9kZV9pbnNlcnRfYmVmb3JlKFdFQktJ VF9ET01fTk9ERShib2R5KSwgV0VCS0lUX0RPTV9OT0RFKGRpdiksIE5VTEwsIE5VTEwpOworICAg IGdfYXNzZXJ0KHdlYmtpdF9kb21fbm9kZV9oYXNfY2hpbGRfbm9kZXMoV0VCS0lUX0RPTV9OT0RF KGJvZHkpKSk7CisgICAgbGlzdCA9IHdlYmtpdF9kb21fbm9kZV9nZXRfY2hpbGRfbm9kZXMoV0VC S0lUX0RPTV9OT0RFKGJvZHkpKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQod2Via2l0X2RvbV9ub2Rl X2xpc3RfZ2V0X2xlbmd0aChsaXN0KSwgPT0sIDEpOworICAgIG5vZGUgPSB3ZWJraXRfZG9tX25v ZGVfbGlzdF9pdGVtKGxpc3QsIDApOworICAgIGdfYXNzZXJ0KG5vZGUpOworICAgIGdfYXNzZXJ0 KHdlYmtpdF9kb21fbm9kZV9pc19zYW1lX25vZGUoV0VCS0lUX0RPTV9OT0RFKGRpdiksIG5vZGUp KTsKKyAgICBnX29iamVjdF91bnJlZihsaXN0KTsKKworICAgIC8qIE5vdyBpbnNlcnQgYSAncCcg YmVmb3JlICdkaXYnICovCisgICAgcCA9IHdlYmtpdF9kb21fZG9jdW1lbnRfY3JlYXRlX2VsZW1l bnQoZG9jdW1lbnQsICJQIiwgTlVMTCk7CisgICAgd2Via2l0X2RvbV9ub2RlX2luc2VydF9iZWZv cmUoV0VCS0lUX0RPTV9OT0RFKGJvZHkpLCBXRUJLSVRfRE9NX05PREUocCksIFdFQktJVF9ET01f Tk9ERShkaXYpLCBOVUxMKTsKKyAgICBnX2Fzc2VydCh3ZWJraXRfZG9tX25vZGVfaGFzX2NoaWxk X25vZGVzKFdFQktJVF9ET01fTk9ERShib2R5KSkpOworICAgIGxpc3QgPSB3ZWJraXRfZG9tX25v ZGVfZ2V0X2NoaWxkX25vZGVzKFdFQktJVF9ET01fTk9ERShib2R5KSk7CisgICAgZ19hc3NlcnRf Y21waW50KHdlYmtpdF9kb21fbm9kZV9saXN0X2dldF9sZW5ndGgobGlzdCksID09LCAyKTsKKyAg ICBub2RlID0gd2Via2l0X2RvbV9ub2RlX2xpc3RfaXRlbShsaXN0LCAwKTsKKyAgICBnX2Fzc2Vy dChub2RlKTsKKyAgICBnX2Fzc2VydCh3ZWJraXRfZG9tX25vZGVfaXNfc2FtZV9ub2RlKFdFQktJ VF9ET01fTk9ERShwKSwgbm9kZSkpOworICAgIG5vZGUgPSB3ZWJraXRfZG9tX25vZGVfbGlzdF9p dGVtKGxpc3QsIDEpOworICAgIGdfYXNzZXJ0KG5vZGUpOworICAgIGdfYXNzZXJ0KHdlYmtpdF9k b21fbm9kZV9pc19zYW1lX25vZGUoV0VCS0lUX0RPTV9OT0RFKGRpdiksIG5vZGUpKTsKKyAgICBn X29iamVjdF91bnJlZihsaXN0KTsKIH0KIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2 KQo=