117302 2013-06-06 08:41:15 -0700 [curl] Custom HTTP method support 2013-06-11 09:37:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Curl P2 Normal --- 117300 0 galpeter webkit-unassigned bfulgham ossy oldest_to_newest 897794 0 galpeter 2013-06-06 08:41:15 -0700 The curl backend does not support custom http methods. For example one can not issue an XMLHTTPRequest with a method "MYMETHOD", the backend will issue instead a simple "GET" request. 897808 1 203941 galpeter 2013-06-06 09:22:38 -0700 Created attachment 203941 proposed patch 898377 2 203941 kenneth 2013-06-08 04:15:32 -0700 Comment on attachment 203941 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=203941&action=review > Source/WebCore/ChangeLog:10 > + > + No new tests, already covered by existing ones like: > + http/tests/xmlhttprequest/workers/methods.html > + http/tests/xmlhttprequest/workers/methods-async.html you dont need to update the result then? 898381 3 galpeter 2013-06-08 04:31:15 -0700 (In reply to comment #2) > (From update of attachment 203941 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203941&action=review > > > Source/WebCore/ChangeLog:10 > > + > > + No new tests, already covered by existing ones like: > > + http/tests/xmlhttprequest/workers/methods.html > > + http/tests/xmlhttprequest/workers/methods-async.html > > you dont need to update the result then? No, because the results are OK. The tests were failing before. 899210 4 203941 ossy 2013-06-11 09:37:29 -0700 Comment on attachment 203941 proposed patch Clearing flags on attachment: 203941 Committed r151441: <http://trac.webkit.org/changeset/151441> 899211 5 ossy 2013-06-11 09:37:34 -0700 All reviewed patches have been landed. Closing bug. 203941 2013-06-06 09:22:38 -0700 2013-06-11 09:37:29 -0700 proposed patch curl_method_support.patch text/plain 2054 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNzYxODU5Li45MGRmZjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDYtMDYgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBbY3VybF0gQ3VzdG9tIEhUVFAgbWV0aG9kIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzMwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBj b3ZlcmVkIGJ5IGV4aXN0aW5nIG9uZXMgbGlrZToKKyAgICAgICAgaHR0cC90ZXN0cy94bWxodHRw cmVxdWVzdC93b3JrZXJzL21ldGhvZHMuaHRtbAorICAgICAgICBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3dvcmtlcnMvbWV0aG9kcy1hc3luYy5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZSk6CisKIDIwMTMtMDYtMDYg IENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAg IFJlbW92ZSB1bnVzZWQgSGFzaFZhbHVlRm9yQ2xhc3NBbmROYW1lKCkgZnJvbSBKU0MgYmluZGlu Z3MgZ2VuZXJhdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCmluZGV4IDBjYjgyMDcuLmMw YWQzYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9S ZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCkBAIC03NjEsMTQgKzc2MSwxOSBA QCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6aW5pdGlhbGl6ZUhhbmRsZShSZXNvdXJjZUhh bmRsZSogam9iKQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCJHRVQiID09IGpvYi0+Zmly c3RSZXF1ZXN0KCkuaHR0cE1ldGhvZCgpKQorICAgIFN0cmluZyBtZXRob2QgPSBqb2ItPmZpcnN0 UmVxdWVzdCgpLmh0dHBNZXRob2QoKTsKKyAgICBpZiAoIkdFVCIgPT0gbWV0aG9kKQogICAgICAg ICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX0hUVFBHRVQsIFRSVUUpOwot ICAgIGVsc2UgaWYgKCJQT1NUIiA9PSBqb2ItPmZpcnN0UmVxdWVzdCgpLmh0dHBNZXRob2QoKSkK KyAgICBlbHNlIGlmICgiUE9TVCIgPT0gbWV0aG9kKQogICAgICAgICBzZXR1cFBPU1Qoam9iLCAm aGVhZGVycyk7Ci0gICAgZWxzZSBpZiAoIlBVVCIgPT0gam9iLT5maXJzdFJlcXVlc3QoKS5odHRw TWV0aG9kKCkpCisgICAgZWxzZSBpZiAoIlBVVCIgPT0gbWV0aG9kKQogICAgICAgICBzZXR1cFBV VChqb2IsICZoZWFkZXJzKTsKLSAgICBlbHNlIGlmICgiSEVBRCIgPT0gam9iLT5maXJzdFJlcXVl c3QoKS5odHRwTWV0aG9kKCkpCisgICAgZWxzZSBpZiAoIkhFQUQiID09IG1ldGhvZCkKICAgICAg ICAgY3VybF9lYXN5X3NldG9wdChkLT5tX2hhbmRsZSwgQ1VSTE9QVF9OT0JPRFksIFRSVUUpOwor ICAgIGVsc2UgeworICAgICAgICBjdXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BU X0NVU1RPTVJFUVVFU1QsIG1ldGhvZC5sYXRpbjEoKS5kYXRhKCkpOworICAgICAgICBzZXR1cFBV VChqb2IsICZoZWFkZXJzKTsKKyAgICB9CiAKICAgICBpZiAoaGVhZGVycykgewogICAgICAgICBj dXJsX2Vhc3lfc2V0b3B0KGQtPm1faGFuZGxlLCBDVVJMT1BUX0hUVFBIRUFERVIsIGhlYWRlcnMp Owo=