117297 2013-06-06 07:39:18 -0700 Clean up AddIncludesForType in JSC bindings generators 2013-06-06 11:45:56 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin haraken laszlo.gombos rniwa oldest_to_newest 897777 0 cdumez 2013-06-06 07:39:18 -0700 AddIncludesForType subroutine in the JSC bindings generators could use some clean up. 897784 1 203934 cdumez 2013-06-06 07:47:35 -0700 Created attachment 203934 Patch 897786 2 203934 haraken 2013-06-06 08:02:02 -0700 Comment on attachment 203934 Patch OK. I was doing a similar clean-up in CodeGeneratorV8.pm and left the work in a half-way state... (Please feel free to steal it if you want:-) 897866 3 203934 commit-queue 2013-06-06 11:45:53 -0700 Comment on attachment 203934 Patch Clearing flags on attachment: 203934 Committed r151283: <http://trac.webkit.org/changeset/151283> 897867 4 commit-queue 2013-06-06 11:45:56 -0700 All reviewed patches have been landed. Closing bug. 203934 2013-06-06 07:47:35 -0700 2013-06-06 11:45:53 -0700 Patch 117297_AddIncludesForType.patch text/plain 4130 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZjFhNjQ2Li40YzQ1MzAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTMtMDYtMDYgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIENsZWFuIHVwIEFkZEluY2x1ZGVzRm9yVHlwZSBpbiBKU0MgYmluZGlu Z3MgZ2VuZXJhdG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE3Mjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2xlYW4gdXAgQWRkSW5jbHVkZXNGb3JUeXBlIGluIEpTQyBiaW5kaW5ncyBnZW5lcmF0 b3JzOgorICAgICAgICAtIEFkZCBKU0Mgc3BlY2lmaWMgU2tpcEluY2x1ZGVIZWFkZXIoKSBzdWJy b3V0aW5lIGFuZCBtb3ZlCisgICAgICAgIGV4Y2VwdGlvbnMgdGhlcmUuCisgICAgICAgIC0gUmVt b3ZlIHNwZWNpYWwgY2FzZSBmb3IgU2VyaWFsaXplZFNjcmlwdFZhbHVlIGJ5IGltcHJvdmluZwor ICAgICAgICB0aGUgY29uZGl0aW9uIGZvciBjYWxsYmFja3M6ICJKUyIgcHJlZml4IGlzIG5vdyBv bmx5IGFkZGVkIHRvCisgICAgICAgIGhlYWRlcnMgaW4gY2FsbGJhY2tzIGlmIHRoZXkgYXJlIHdy YXBwZXIgdHlwZXMuIE5vbi13cmFwcGVyCisgICAgICAgIHR5cGVzIHN1Y2ggYXMgU2VyaWFsaXpl ZFNjcmlwdFZhbHVlIGRvIG5vdCBoYXZlIGEgSlMqLmgKKyAgICAgICAgaGVhZGVyLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgY29kZSBjbGVhbiB1cC4KKworICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKFNraXBJbmNsdWRlSGVhZGVyKToKKyAg ICAgICAgLSBSZXVzZSBJc1ByaW1pdGl2ZVR5cGUoKSB0byBhdm9pZCBjb2RlIGR1cGxpY2F0aW9u LgorICAgICAgICAtIFJlbW92ZSBzcGVjaWFsIGNhc2UgZm9yIFN0cmluZyBhcyB0aGlzIGlzIG5v dCBhIHZhbGlkIElETCB0eXBlCisgICAgICAgIGFuZCBpdCBpcyBub3QgY3VycmVudGx5IHVzZWQu CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAg IChTa2lwSW5jbHVkZUhlYWRlcik6CisgICAgICAgIChBZGRJbmNsdWRlc0ZvclR5cGUpOgorCiAy MDEzLTA2LTA2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgU1ZH IG9iamVjdHMgYXJlIG1pc3BsYWNlZCB3aGVuIFNWRyByb290IGhhcyBDU1MgdHJhbnNmb3JtLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCmlu ZGV4IDg2Y2Y1Y2QuLjNkZjNlNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KQEAgLTMzMiw5ICszMzIsNyBAQCBzdWIgU2tpcEluY2x1 ZGVIZWFkZXIKICAgICBteSAkb2JqZWN0ID0gc2hpZnQ7CiAgICAgbXkgJHR5cGUgPSBzaGlmdDsK IAotICAgIHJldHVybiAxIGlmICRwcmltaXRpdmVUeXBlSGFzaHskdHlwZX07Ci0gICAgcmV0dXJu IDEgaWYgJG51bWVyaWNUeXBlSGFzaHskdHlwZX07Ci0gICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEg IlN0cmluZyI7CisgICAgcmV0dXJuIDEgaWYgJG9iamVjdC0+SXNQcmltaXRpdmVUeXBlKCR0eXBl KTsKIAogICAgICMgU3BlY2lhbCBjYXNlOiBTVkdQb2ludC5oIC8gU1ZHTnVtYmVyLmggZG8gbm90 IGV4aXN0LgogICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJTVkdQb2ludCIgb3IgJHR5cGUgZXEg IlNWR051bWJlciI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCmluZGV4IDMyN2U3ZmQuLmEwNjVhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0yMDIsMzEg KzIwMiw0MyBAQCBzdWIgQWRkSW5jbHVkZXNGb3JUeXBlSW5IZWFkZXIKICAgICBBZGRJbmNsdWRl c0ZvclR5cGUoJHR5cGUsICRpc0NhbGxiYWNrLCBcJWhlYWRlckluY2x1ZGVzKTsKIH0KIAorbXkg JXR5cGVzV2l0aG91dEhlYWRlciA9ICgKKyAgICAiQXJyYXkiID0+IDEsCisgICAgIkRPTVN0cmlu ZyIgPT4gMSwKKyAgICAiRE9NVGltZVN0YW1wIiA9PiAxLAorICAgICJhbnkiID0+IDEKKyk7CisK K3N1YiBTa2lwSW5jbHVkZUhlYWRlcgoreworICAgIG15ICR0eXBlID0gc2hpZnQ7CisKKyAgICBy ZXR1cm4gMSBpZiAkY29kZUdlbmVyYXRvci0+U2tpcEluY2x1ZGVIZWFkZXIoJHR5cGUpOworICAg IHJldHVybiAxIGlmICRjb2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5cGUoJHR5cGUpIG9yICRj b2RlR2VuZXJhdG9yLT5HZXRBcnJheVR5cGUoJHR5cGUpOworICAgIHJldHVybiAkdHlwZXNXaXRo b3V0SGVhZGVyeyR0eXBlfTsKK30KKwogc3ViIEFkZEluY2x1ZGVzRm9yVHlwZQogewogICAgIG15 ICR0eXBlID0gc2hpZnQ7CiAgICAgbXkgJGlzQ2FsbGJhY2sgPSBzaGlmdDsKICAgICBteSAkaW5j bHVkZXNSZWYgPSBzaGlmdDsKIAorICAgIHJldHVybiBpZiBTa2lwSW5jbHVkZUhlYWRlcigkdHlw ZSk7CisKICAgICAjIFdoZW4gd2UncmUgZmluaXNoZWQgd2l0aCB0aGUgb25lLWZpbGUtcGVyLWNs YXNzCiAgICAgIyByZW9yZ2FuaXphdGlvbiwgd2Ugd29uJ3QgbmVlZCB0aGVzZSBzcGVjaWFsIGNh c2VzLgotICAgIGlmICgkY29kZUdlbmVyYXRvci0+SXNQcmltaXRpdmVUeXBlKCR0eXBlKSBvciAk Y29kZUdlbmVyYXRvci0+U2tpcEluY2x1ZGVIZWFkZXIoJHR5cGUpCi0gICAgICAgIG9yICR0eXBl IGVxICJET01TdHJpbmciIG9yICR0eXBlIGVxICJhbnkiIG9yICR0eXBlIGVxICJBcnJheSIgb3Ig JHR5cGUgZXEgIkRPTVRpbWVTdGFtcCIpIHsKLSAgICB9IGVsc2lmICgkdHlwZSA9fiAvU1ZHUGF0 aFNlZy8pIHsKKyAgICBpZiAoJHR5cGUgPX4gL1NWR1BhdGhTZWcvKSB7CiAgICAgICAgIG15ICRq b2luZWROYW1lID0gJHR5cGU7CiAgICAgICAgICRqb2luZWROYW1lID1+IHMvQWJzfFJlbC8vOwog ICAgICAgICAkaW5jbHVkZXNSZWYtPnsiJHtqb2luZWROYW1lfS5oIn0gPSAxOwogICAgIH0gZWxz aWYgKCR0eXBlIGVxICJYUGF0aE5TUmVzb2x2ZXIiKSB7CiAgICAgICAgICRpbmNsdWRlc1JlZi0+ eyJKU1hQYXRoTlNSZXNvbHZlci5oIn0gPSAxOwogICAgICAgICAkaW5jbHVkZXNSZWYtPnsiSlND dXN0b21YUGF0aE5TUmVzb2x2ZXIuaCJ9ID0gMTsKLSAgICB9IGVsc2lmICgkdHlwZSBlcSAiU2Vy aWFsaXplZFNjcmlwdFZhbHVlIikgewotICAgICAgICAkaW5jbHVkZXNSZWYtPnsiU2VyaWFsaXpl ZFNjcmlwdFZhbHVlLmgifSA9IDE7Ci0gICAgfSBlbHNpZiAoJGlzQ2FsbGJhY2spIHsKKyAgICB9 IGVsc2lmICgkaXNDYWxsYmFjayAmJiAkY29kZUdlbmVyYXRvci0+SXNXcmFwcGVyVHlwZSgkdHlw ZSkpIHsKICAgICAgICAgJGluY2x1ZGVzUmVmLT57IkpTJHt0eXBlfS5oIn0gPSAxOwogICAgIH0g ZWxzaWYgKCRjb2RlR2VuZXJhdG9yLT5Jc1R5cGVkQXJyYXlUeXBlKCR0eXBlKSkgewogICAgICAg ICAkaW5jbHVkZXNSZWYtPnsiPHd0Zi8ke3R5cGV9Lmg+In0gPSAxOwotICAgIH0gZWxzaWYgKCRj b2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5cGUoJHR5cGUpKSB7Ci0gICAgfSBlbHNpZiAoJGNv ZGVHZW5lcmF0b3ItPkdldEFycmF5VHlwZSgkdHlwZSkpIHsKICAgICB9IGVsc2UgewogICAgICAg ICAjIGRlZmF1bHQsIGluY2x1ZGUgdGhlIHNhbWUgbmFtZWQgZmlsZQogICAgICAgICAkaW5jbHVk ZXNSZWYtPnsiJHt0eXBlfS5oIn0gPSAxOwo=