117276 2013-06-05 13:55:35 -0700 [BlackBerry] Deleting the pendingSelectionCandidate on the wrong thread causes an assert. 2013-06-05 14:42:33 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gmak webkit-unassigned commit-queue oldest_to_newest 897538 0 gmak 2013-06-05 13:55:35 -0700 Move the deletion to webkit 897546 1 203883 gmak 2013-06-05 14:07:13 -0700 Created attachment 203883 Patch with changelog 897548 2 203883 rwlbuis 2013-06-05 14:09:31 -0700 Comment on attachment 203883 Patch with changelog Looks good. 897566 3 203883 commit-queue 2013-06-05 14:42:32 -0700 Comment on attachment 203883 Patch with changelog Clearing flags on attachment: 203883 Committed r151241: <http://trac.webkit.org/changeset/151241> 897567 4 commit-queue 2013-06-05 14:42:33 -0700 All reviewed patches have been landed. Closing bug. 203883 2013-06-05 14:07:13 -0700 2013-06-05 14:42:32 -0700 Patch with changelog 0001-2013-06-05-Genevieve-Mak-gmak-rim.com.patch text/plain 7581 gmak RnJvbSA0MGYwY2UzODk2OGYxM2ExNWYzYzhhYzViZmEyZmI3ZDFiMDhmZDFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFdl ZCwgNSBKdW4gMjAxMyAxNjowOTo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTMtMDYtMDUg IEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CgogICAgICAgIFtCbGFja0JlcnJ5XSBEZWxl dGluZyB0aGUgcGVuZGluZ1NlbGVjdGlvbkNhbmRpZGF0ZSBvbiB0aGUgd3JvbmcgdGhyZWFkIGNh dXNlcyBhbiBhc3NlcnQuCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNzI3NgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAg ICAgUmV2aWV3ZWQgSW50ZXJuYWxseSBieSBOaW1hIEdoYW5hdmF0aWFuLgogICAgICAgIFBSICMz NDIzOTkKICAgICAgICBTdG9yZSBhbmQgZGVsZXRlIHRoZSBzZWxlY3Rpb25TY3JvbGxWaWV3IGlu IHdlYmtpdCB3aGljaCBpcyB3aGF0IHdlIGFscmVhZHkgZG8gZm9yCiAgICAgICAgc2Nyb2xsaW5n IHN1YmZyYW1lcy4KCiAgICAgICAgKiBBcGkvSW5SZWdpb25TY3JvbGxlci5jcHA6CiAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6SW5SZWdpb25TY3JvbGxlclByaXZhdGU6OkluUmVnaW9uU2Ny b2xsZXJQcml2YXRlKToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9s bGVyUHJpdmF0ZTo6cmVzZXRTZWxlY3Rpb25TY3JvbGxWaWV3KToKICAgICAgICAoV2ViS2l0KToK ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2xl YXJEb2N1bWVudERhdGEpOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Ny b2xsZXJQcml2YXRlOjpjYWxjdWxhdGVJblJlZ2lvblNjcm9sbGFibGVBcmVhc0ZvclBvaW50KToK ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6dXBk YXRlU2VsZWN0aW9uU2Nyb2xsVmlldyk6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5S ZWdpb25TY3JvbGxlclByaXZhdGU6OmZpcnN0U2Nyb2xsYWJsZUluUmVnaW9uRm9yTm9kZSk6CiAg ICAgICAgKiBBcGkvSW5SZWdpb25TY3JvbGxlcl9wLmg6CiAgICAgICAgKEluUmVnaW9uU2Nyb2xs ZXJQcml2YXRlKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Ny b2xsZXIuY3BwIHwgICAyOCArKysrKysrKysrKysrKystLS0tLS0KIFNvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlcl9wLmggfCAgICAyICsrCiBTb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAyMyArKysrKysrKysrKysr KysrKwogMyBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3Bw CmluZGV4IGI2MDdkZGIwLi41ZjE1YzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKQEAgLTc5LDYgKzc5LDcgQEAgYm9vbCBJblJl Z2lvblNjcm9sbGVyOjpzZXREb2N1bWVudFNjcm9sbFBvc2l0aW9uV2ViS2l0VGhyZWFkKHVuc2ln bmVkIGNhbW91ZmxhZ2UKIEluUmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpJblJlZ2lvblNjcm9sbGVy UHJpdmF0ZShXZWJQYWdlUHJpdmF0ZSogd2ViUGFnZVByaXZhdGUpCiAgICAgOiBtX3dlYlBhZ2Uo d2ViUGFnZVByaXZhdGUpCiAgICAgLCBtX25lZWRzQWN0aXZlU2Nyb2xsYWJsZUFyZWFDYWxjdWxh dGlvbihmYWxzZSkKKyAgICAsIG1fc2VsZWN0aW9uU2Nyb2xsVmlldygwKQogewogfQogCkBAIC05 NCw2ICs5NSwxNiBAQCB2b2lkIEluUmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpyZXNldCgpCiAgICAg bV9hY3RpdmVJblJlZ2lvblNjcm9sbGFibGVBcmVhcy5jbGVhcigpOwogfQogCit2b2lkIEluUmVn aW9uU2Nyb2xsZXJQcml2YXRlOjpyZXNldFNlbGVjdGlvblNjcm9sbFZpZXcoKQoreworICAgIG1f d2ViUGFnZS0+bV9jbGllbnQtPm5vdGlmeVNlbGVjdGlvblNjcm9sbFZpZXcoMCk7CisgICAgbV93 ZWJQYWdlLT5tX3NlbGVjdGlvbkhhbmRsZXItPnNldFNlbGVjdGlvblN1YmZyYW1lVmlld3BvcnRS ZWN0KFdlYkNvcmU6OkludFJlY3QoKSk7CisgICAgaWYgKG1fc2VsZWN0aW9uU2Nyb2xsVmlldykg eworICAgICAgICBkZWxldGUgbV9zZWxlY3Rpb25TY3JvbGxWaWV3OworICAgICAgICBtX3NlbGVj dGlvblNjcm9sbFZpZXcgPSAwOworICAgIH0KK30KKwogYm9vbCBJblJlZ2lvblNjcm9sbGVyUHJp dmF0ZTo6aXNBY3RpdmUoKSBjb25zdAogewogICAgIHJldHVybiBtX2FjdGl2ZUluUmVnaW9uU2Ny b2xsYWJsZUFyZWFzLnNpemUoKSA+IDA7CkBAIC0xMDEsMTIgKzExMiwxNyBAQCBib29sIEluUmVn aW9uU2Nyb2xsZXJQcml2YXRlOjppc0FjdGl2ZSgpIGNvbnN0CiAKIHZvaWQgSW5SZWdpb25TY3Jv bGxlclByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKGNvbnN0IERvY3VtZW50KiBkb2N1bWVudEdv aW5nQXdheSkKIHsKKyAgICBJblJlZ2lvblNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSA9 IHN0YXRpY19jYXN0PEluUmVnaW9uU2Nyb2xsYWJsZUFyZWEqPihtX3NlbGVjdGlvblNjcm9sbFZp ZXcpOworICAgIEFTU0VSVChzY3JvbGxhYmxlQXJlYSk7CisgICAgaWYgKHNjcm9sbGFibGVBcmVh LT5kb2N1bWVudCgpID09IGRvY3VtZW50R29pbmdBd2F5KQorICAgICAgICByZXNldFNlbGVjdGlv blNjcm9sbFZpZXcoKTsKKwogICAgIGlmIChtX25lZWRzQWN0aXZlU2Nyb2xsYWJsZUFyZWFDYWxj dWxhdGlvbikgewogICAgICAgICByZXNldCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0g ICAgSW5SZWdpb25TY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEgPSBzdGF0aWNfY2FzdDxJ blJlZ2lvblNjcm9sbGFibGVBcmVhKj4obV9hY3RpdmVJblJlZ2lvblNjcm9sbGFibGVBcmVhc1sw XSk7CisgICAgc2Nyb2xsYWJsZUFyZWEgPSBzdGF0aWNfY2FzdDxJblJlZ2lvblNjcm9sbGFibGVB cmVhKj4obV9hY3RpdmVJblJlZ2lvblNjcm9sbGFibGVBcmVhc1swXSk7CiAgICAgQVNTRVJUKHNj cm9sbGFibGVBcmVhKTsKICAgICBpZiAoc2Nyb2xsYWJsZUFyZWEtPmRvY3VtZW50KCkgPT0gZG9j dW1lbnRHb2luZ0F3YXkpCiAgICAgICAgIHJlc2V0KCk7CkBAIC0yNDAsNyArMjU2LDYgQEAgdm9p ZCBJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2FsY3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJl YXNGb3JQb2ludChjb25zdCBXZWIKIHsKICAgICBBU1NFUlQobV9hY3RpdmVJblJlZ2lvblNjcm9s bGFibGVBcmVhcy5lbXB0eSgpKTsKICAgICBtX25lZWRzQWN0aXZlU2Nyb2xsYWJsZUFyZWFDYWxj dWxhdGlvbiA9IGZhbHNlOwotCiAgICAgY29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0ID0gbV93 ZWJQYWdlLT5oaXRUZXN0UmVzdWx0KGRvY3VtZW50UG9pbnQpOwogICAgIE5vZGUqIG5vZGUgPSBy ZXN1bHQuaW5uZXJOb25TaGFyZWROb2RlKCk7CiAgICAgaWYgKCFub2RlIHx8ICFub2RlLT5yZW5k ZXJlcigpKQpAQCAtMzAzLDExICszMTgsMTAgQEAgdm9pZCBJblJlZ2lvblNjcm9sbGVyUHJpdmF0 ZTo6Y2FsY3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludChjb25zdCBXZWIKIHZv aWQgSW5SZWdpb25TY3JvbGxlclByaXZhdGU6OnVwZGF0ZVNlbGVjdGlvblNjcm9sbFZpZXcoY29u c3QgTm9kZSogbm9kZSkKIHsKICAgICAvLyBUT0RPOiBkb24ndCBub3RpZnkgdGhlIGNsaWVudCBp ZiB0aGUgbm9kZSBkaWRuJ3QgY2hhbmdlLgotICAgIC8vIERlbGV0aW5nIHRoZSBzY3JvbGx2aWV3 IGlzIGhhbmRsZWQgYnkgdGhlIGNsaWVudC4KLSAgICBQbGF0Zm9ybTo6U2Nyb2xsVmlld0Jhc2Uq IHNlbGVjdGlvblNjcm9sbFZpZXcgPSBmaXJzdFNjcm9sbGFibGVJblJlZ2lvbkZvck5vZGUobm9k ZSk7Ci0gICAgbV93ZWJQYWdlLT5tX2NsaWVudC0+bm90aWZ5U2VsZWN0aW9uU2Nyb2xsVmlldyhz ZWxlY3Rpb25TY3JvbGxWaWV3KTsKKyAgICBtX3NlbGVjdGlvblNjcm9sbFZpZXcgPSBmaXJzdFNj cm9sbGFibGVJblJlZ2lvbkZvck5vZGUobm9kZSk7CisgICAgbV93ZWJQYWdlLT5tX2NsaWVudC0+ bm90aWZ5U2VsZWN0aW9uU2Nyb2xsVmlldyhtX3NlbGVjdGlvblNjcm9sbFZpZXcpOwogICAgIC8v IElmIHRoZXJlJ3Mgbm8gc3ViZnJhbWUgc2V0IGFuIGVtcHR5IHJlY3Qgc28gdGhhdCB3ZSBkZWZh dWx0IHRvIHRoZSBtYWluIGZyYW1lLgotICAgIG1fd2ViUGFnZS0+bV9zZWxlY3Rpb25IYW5kbGVy LT5zZXRTZWxlY3Rpb25TdWJmcmFtZVZpZXdwb3J0UmVjdChzZWxlY3Rpb25TY3JvbGxWaWV3ID8g V2ViQ29yZTo6SW50UmVjdChzZWxlY3Rpb25TY3JvbGxWaWV3LT5kb2N1bWVudFZpZXdwb3J0UmVj dCgpKSA6IFdlYkNvcmU6OkludFJlY3QoKSk7CisgICAgbV93ZWJQYWdlLT5tX3NlbGVjdGlvbkhh bmRsZXItPnNldFNlbGVjdGlvblN1YmZyYW1lVmlld3BvcnRSZWN0KG1fc2VsZWN0aW9uU2Nyb2xs VmlldyA/IFdlYkNvcmU6OkludFJlY3QobV9zZWxlY3Rpb25TY3JvbGxWaWV3LT5kb2N1bWVudFZp ZXdwb3J0UmVjdCgpKSA6IFdlYkNvcmU6OkludFJlY3QoKSk7CiB9CiAKIFBsYXRmb3JtOjpTY3Jv bGxWaWV3QmFzZSogSW5SZWdpb25TY3JvbGxlclByaXZhdGU6OmZpcnN0U2Nyb2xsYWJsZUluUmVn aW9uRm9yTm9kZShjb25zdCBOb2RlKiBub2RlKQpAQCAtMzI1LDcgKzMzOSw3IEBAIFBsYXRmb3Jt OjpTY3JvbGxWaWV3QmFzZSogSW5SZWdpb25TY3JvbGxlclByaXZhdGU6OmZpcnN0U2Nyb2xsYWJs ZUluUmVnaW9uRm9yTm9kCiAgICAgICAgICAgICBpZiAoUmVuZGVyVmlldyogcmVuZGVyVmlldyA9 IHRvUmVuZGVyVmlldyhyZW5kZXJlcikpIHsKICAgICAgICAgICAgICAgICBGcmFtZVZpZXcqIHZp ZXcgPSByZW5kZXJWaWV3LT5mcmFtZVZpZXcoKTsKICAgICAgICAgICAgICAgICBpZiAoIXZpZXcp IHsKLSAgICAgICAgICAgICAgICAgICAgcmVzZXQoKTsKKyAgICAgICAgICAgICAgICAgICAgcmVz ZXRTZWxlY3Rpb25TY3JvbGxWaWV3KCk7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiAwOwog ICAgICAgICAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9JblJlZ2lvblNjcm9sbGVyX3AuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv SW5SZWdpb25TY3JvbGxlcl9wLmgKaW5kZXggMTk3NDcxMDQuLjk4YWZjY2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlcl9wLmgKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyX3AuaApAQCAtNDUs NiArNDUsNyBAQCBwdWJsaWM6CiAgICAgSW5SZWdpb25TY3JvbGxlclByaXZhdGUoV2ViUGFnZVBy aXZhdGUqKTsKIAogICAgIHZvaWQgcmVzZXQoKTsKKyAgICB2b2lkIHJlc2V0U2VsZWN0aW9uU2Ny b2xsVmlldygpOwogICAgIGJvb2wgaXNBY3RpdmUoKSBjb25zdDsKIAogICAgIGJvb2wgc2V0U2Ny b2xsUG9zaXRpb25Db21wb3NpdGluZ1RocmVhZCh1bnNpZ25lZCBjYW1vdWZsYWdlZExheWVyLCBj b25zdCBXZWJDb3JlOjpJbnRQb2ludCYgc2Nyb2xsUG9zaXRpb24pOwpAQCAtNzcsNiArNzgsNyBA QCBwcml2YXRlOgogICAgIGJvb2wgaXNWYWxpZFNjcm9sbGFibGVOb2RlKFdlYkNvcmU6Ok5vZGUq KSBjb25zdDsKICAgICBXZWJDb3JlOjpJbnRSZWN0IGNsaXBUb1JlY3QoY29uc3QgV2ViQ29yZTo6 SW50UmVjdCYsIEluUmVnaW9uU2Nyb2xsYWJsZUFyZWEqKTsKICAgICBzdGQ6OnZlY3RvcjxQbGF0 Zm9ybTo6U2Nyb2xsVmlld0Jhc2UqPiBtX2FjdGl2ZUluUmVnaW9uU2Nyb2xsYWJsZUFyZWFzOwor ICAgIFBsYXRmb3JtOjpTY3JvbGxWaWV3QmFzZSogbV9zZWxlY3Rpb25TY3JvbGxWaWV3OwogfTsK IAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggYjQ1NDUzOC4uNjU1NWRhOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTMtMDYt MDUgIEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IERlbGV0aW5nIHRoZSBwZW5kaW5nU2VsZWN0aW9uQ2FuZGlkYXRlIG9uIHRoZSB3cm9uZyB0aHJl YWQgY2F1c2VzIGFuIGFzc2VydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNzI3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgTmltYSBHaGFuYXZhdGlhbi4KKyAg ICAgICAgUFIgIzM0MjM5OQorICAgICAgICBTdG9yZSBhbmQgZGVsZXRlIHRoZSBzZWxlY3Rpb25T Y3JvbGxWaWV3IGluIHdlYmtpdCB3aGljaCBpcyB3aGF0IHdlIGFscmVhZHkgZG8gZm9yCisgICAg ICAgIHNjcm9sbGluZyBzdWJmcmFtZXMuCisKKyAgICAgICAgKiBBcGkvSW5SZWdpb25TY3JvbGxl ci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Nyb2xsZXJQcml2 YXRlOjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJL aXQ6OkluUmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpyZXNldFNlbGVjdGlvblNjcm9sbFZpZXcpOgor ICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5SZWdpb25T Y3JvbGxlclByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKToKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6SW5SZWdpb25TY3JvbGxlclByaXZhdGU6OmNhbGN1bGF0ZUluUmVnaW9uU2Nyb2xs YWJsZUFyZWFzRm9yUG9pbnQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lv blNjcm9sbGVyUHJpdmF0ZTo6dXBkYXRlU2VsZWN0aW9uU2Nyb2xsVmlldyk6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpmaXJzdFNjcm9sbGFi bGVJblJlZ2lvbkZvck5vZGUpOgorICAgICAgICAqIEFwaS9JblJlZ2lvblNjcm9sbGVyX3AuaDoK KyAgICAgICAgKEluUmVnaW9uU2Nyb2xsZXJQcml2YXRlKToKKwogMjAxMy0wNS0xMyAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEZyYW1lOjplZGl0b3Io KSBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlCi0tIAoxLjcuMTAuMiAoQXBwbGUgR2l0LTMzKQoK