117273 2013-06-05 13:26:08 -0700 Don't throttle timers if a page is doing something that might be interesting 2013-06-05 15:24:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver barraclough simon.fraser thorton oldest_to_newest 897527 0 oliver 2013-06-05 13:26:08 -0700 Don't throttle timers if a page is doing something that might be interesting 897528 1 203877 oliver 2013-06-05 13:27:31 -0700 Created attachment 203877 Patch 897573 2 203877 barraclough 2013-06-05 15:19:06 -0700 Comment on attachment 203877 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203877&action=review r+ > Source/WebCore/page/Page.cpp:1285 > + throttleTimers(); I think this is redundant to the action taken by the PageThrottler, it should already be doing the right thing. > Source/WebCore/page/Page.cpp:1289 > + unthrottleTimers(); ditto. 897575 3 oliver 2013-06-05 15:24:23 -0700 Committed r151244: <http://trac.webkit.org/changeset/151244> 203877 2013-06-05 13:27:31 -0700 2013-06-05 15:19:23 -0700 Patch bug-117273-20130605132705.patch text/plain 4757 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDhjNDQwYTZmNzMwN2Ux OTc5ZGMwMzg1OWFhN2ZjZGI4MjYyMDFmOC4uZWJiYzg2MmNjMjYzMDc1NWE2NThmMjRmYjVjZjdl Y2ZmM2MzMDE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA2LTA1ICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdGhyb3R0bGUgdGlt ZXJzIGlmIGEgcGFnZSBpcyBkb2luZyBzb21ldGhpbmcgdGhhdCBtaWdodCBiZSBpbnRlcmVzdGlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3Mjcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0 aGUgZGVjaXNpb24gYWJvdXQgd2hldGhlciBvciBub3QgdG8gdGhyb3R0bGUgdGltZXJzIGJlCisg ICAgICAgIGRldGVybWluZWQgYnkgdGhlIFBhZ2VUaHJvdHRsZXIKKworICAgICAgICAqIHBhZ2Uv UGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjp0aHJvdHRsZVRpbWVycyk6CisgICAg ICAgIChXZWJDb3JlOjpQYWdlOjp1bnRocm90dGxlVGltZXJzKToKKyAgICAgICAgKFdlYkNvcmU6 OlBhZ2U6OnNldFZpc2liaWxpdHlTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpoaWRk ZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nU3RhdGVDaGFuZ2VkKToKKyAgICAgICAgKiBwYWdlL1Bh Z2UuaDoKKyAgICAgICAgKiBwYWdlL1BhZ2VUaHJvdHRsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGFnZVRocm90dGxlcjo6dGhyb3R0bGVQYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VU aHJvdHRsZXI6OnVudGhyb3R0bGVQYWdlKToKKwogMjAxMy0wNi0wNSAgS29uZGFwYWxseSBLYWx5 YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gQnVpbGQg Zml4IHdpdGggRUdMIGFuZCBHTEVTMiBiYWNrZW5kLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggMjBk ZDg2MmEwMzgyMzBmNzc0NzkwOTJlYjA3MGNjMmI3OWM2ZDdjNi4uNGU4MzgzMmIxOTJiZDQ1Y2Uy ZjE0MDUwODJhZGFmYjc5Nzc1YmM4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Q YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xMjUwLDYgKzEy NTAsMjIgQEAgdm9pZCBQYWdlOjpjaGVja1N1YmZyYW1lQ291bnRDb25zaXN0ZW5jeSgpIGNvbnN0 CiB9CiAjZW5kaWYKIAordm9pZCBQYWdlOjp0aHJvdHRsZVRpbWVycygpCit7CisjaWYgRU5BQkxF KEhJRERFTl9QQUdFX0RPTV9USU1FUl9USFJPVFRMSU5HKQorICAgIGlmIChtX3NldHRpbmdzLT5o aWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nRW5hYmxlZCgpKQorICAgICAgICBzZXRUaW1lckFs aWdubWVudEludGVydmFsKFNldHRpbmdzOjpoaWRkZW5QYWdlRE9NVGltZXJBbGlnbm1lbnRJbnRl cnZhbCgpKTsKKyNlbmRpZgorfQorCit2b2lkIFBhZ2U6OnVudGhyb3R0bGVUaW1lcnMoKQorewor I2lmIEVOQUJMRShISURERU5fUEFHRV9ET01fVElNRVJfVEhST1RUTElORykKKyAgICBpZiAobV9z ZXR0aW5ncy0+aGlkZGVuUGFnZURPTVRpbWVyVGhyb3R0bGluZ0VuYWJsZWQoKSkKKyAgICAgICAg c2V0VGltZXJBbGlnbm1lbnRJbnRlcnZhbChTZXR0aW5nczo6ZGVmYXVsdERPTVRpbWVyQWxpZ25t ZW50SW50ZXJ2YWwoKSk7CisjZW5kaWYKK30KKwogI2lmIEVOQUJMRShQQUdFX1ZJU0lCSUxJVFlf QVBJKSB8fCBFTkFCTEUoSElEREVOX1BBR0VfRE9NX1RJTUVSX1RIUk9UVExJTkcpCiB2b2lkIFBh Z2U6OnNldFZpc2liaWxpdHlTdGF0ZShQYWdlVmlzaWJpbGl0eVN0YXRlIHZpc2liaWxpdHlTdGF0 ZSwgYm9vbCBpc0luaXRpYWxTdGF0ZSkKIHsKQEAgLTEyNjUsMTcgKzEyODEsMTIgQEAgdm9pZCBQ YWdlOjpzZXRWaXNpYmlsaXR5U3RhdGUoUGFnZVZpc2liaWxpdHlTdGF0ZSB2aXNpYmlsaXR5U3Rh dGUsIGJvb2wgaXNJbml0aWEKICNlbmRpZgogCiAgICAgaWYgKHZpc2liaWxpdHlTdGF0ZSA9PSBX ZWJDb3JlOjpQYWdlVmlzaWJpbGl0eVN0YXRlSGlkZGVuKSB7Ci0jaWYgRU5BQkxFKEhJRERFTl9Q QUdFX0RPTV9USU1FUl9USFJPVFRMSU5HKQotICAgICAgICBpZiAobV9zZXR0aW5ncy0+aGlkZGVu UGFnZURPTVRpbWVyVGhyb3R0bGluZ0VuYWJsZWQoKSkKLSAgICAgICAgICAgIHNldFRpbWVyQWxp Z25tZW50SW50ZXJ2YWwoU2V0dGluZ3M6OmhpZGRlblBhZ2VET01UaW1lckFsaWdubWVudEludGVy dmFsKCkpOwotI2VuZGlmCisgICAgICAgIGlmIChtX3BhZ2VUaHJvdHRsZXItPnNob3VsZFRocm90 dGxlVGltZXJzKCkpCisgICAgICAgICAgICB0aHJvdHRsZVRpbWVycygpOwogICAgICAgICBpZiAo bV9zZXR0aW5ncy0+aGlkZGVuUGFnZUNTU0FuaW1hdGlvblN1c3BlbnNpb25FbmFibGVkKCkpCiAg ICAgICAgICAgICBtYWluRnJhbWUoKS0+YW5pbWF0aW9uKCktPnN1c3BlbmRBbmltYXRpb25zKCk7 CiAgICAgfSBlbHNlIHsKLSNpZiBFTkFCTEUoSElEREVOX1BBR0VfRE9NX1RJTUVSX1RIUk9UVExJ TkcpCi0gICAgICAgIGlmIChtX3NldHRpbmdzLT5oaWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5n RW5hYmxlZCgpKQotICAgICAgICAgICAgc2V0VGltZXJBbGlnbm1lbnRJbnRlcnZhbChTZXR0aW5n czo6ZGVmYXVsdERPTVRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoKSk7Ci0jZW5kaWYKKyAgICAgICAg dW50aHJvdHRsZVRpbWVycygpOwogICAgICAgICBpZiAobV9zZXR0aW5ncy0+aGlkZGVuUGFnZUNT U0FuaW1hdGlvblN1c3BlbnNpb25FbmFibGVkKCkpCiAgICAgICAgICAgICBtYWluRnJhbWUoKS0+ YW5pbWF0aW9uKCktPnJlc3VtZUFuaW1hdGlvbnMoKTsKICAgICB9CkBAIC0xNTI1LDcgKzE1MzYs NyBAQCB2b2lkIFBhZ2U6OmhpZGRlblBhZ2VET01UaW1lclRocm90dGxpbmdTdGF0ZUNoYW5nZWQo KQogewogICAgIGlmIChtX3NldHRpbmdzLT5oaWRkZW5QYWdlRE9NVGltZXJUaHJvdHRsaW5nRW5h YmxlZCgpKSB7CiAjaWYgRU5BQkxFKFBBR0VfVklTSUJJTElUWV9BUEkpCi0gICAgICAgIGlmICht X3Zpc2liaWxpdHlTdGF0ZSA9PSBXZWJDb3JlOjpQYWdlVmlzaWJpbGl0eVN0YXRlSGlkZGVuKQor ICAgICAgICBpZiAobV9wYWdlVGhyb3R0bGVyLT5zaG91bGRUaHJvdHRsZVRpbWVycygpKQogICAg ICAgICAgICAgc2V0VGltZXJBbGlnbm1lbnRJbnRlcnZhbChTZXR0aW5nczo6aGlkZGVuUGFnZURP TVRpbWVyQWxpZ25tZW50SW50ZXJ2YWwoKSk7CiAjZW5kaWYKICAgICB9IGVsc2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmgKaW5kZXggZDJiNDM4M2IyYjNlOWFiNmNjMzhlYjdiYzEwNTgxMDE5N2JiMjVhOC4uNzIxZTYw YjFkNzRmZTBkOWI5ZmU2NDRkZmNjODdhZjkwNWQ5MWYxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAgLTQz MSw2ICs0MzEsOSBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBjb2xsZWN0UGx1Z2luVmlld3MoVmVj dG9yPFJlZlB0cjxQbHVnaW5WaWV3QmFzZT4sIDMyPiYgcGx1Z2luVmlld0Jhc2VzKTsKIAorICAg IHZvaWQgdGhyb3R0bGVUaW1lcnMoKTsKKyAgICB2b2lkIHVudGhyb3R0bGVUaW1lcnMoKTsKKwog ICAgIGNvbnN0IE93blB0cjxDaHJvbWU+IG1fY2hyb21lOwogICAgIE93blB0cjxEcmFnQ2FyZXRD b250cm9sbGVyPiBtX2RyYWdDYXJldENvbnRyb2xsZXI7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZVRocm90dGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VU aHJvdHRsZXIuY3BwCmluZGV4IDVkZDM4OTQxN2NhMGRkYmY3MGQ5ODRjYzNjZDRhZDcwMDU4ZDc4 MjIuLjE5YjBmYzI2OGIwZTg5MmNjN2E3NDE4NmUzMDg5MWVkNGNlMjBjMTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZVRocm90dGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlVGhyb3R0bGVyLmNwcApAQCAtNzcsNiArNzcsOCBAQCB2b2lkIFBhZ2VUaHJv dHRsZXI6OnRocm90dGxlUGFnZSgpCiAgICAgICAgIGlmIChmcmFtZS0+ZG9jdW1lbnQoKSkKICAg ICAgICAgICAgIGZyYW1lLT5kb2N1bWVudCgpLT5zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXJT ZXRUaHJvdHRsZWQodHJ1ZSk7CiAgICAgfQorCisgICAgbV9wYWdlLT50aHJvdHRsZVRpbWVycygp OwogfQogCiB2b2lkIFBhZ2VUaHJvdHRsZXI6OnVudGhyb3R0bGVQYWdlKCkKQEAgLTk2LDYgKzk4 LDggQEAgdm9pZCBQYWdlVGhyb3R0bGVyOjp1bnRocm90dGxlUGFnZSgpCiAgICAgICAgIGlmIChm cmFtZS0+ZG9jdW1lbnQoKSkKICAgICAgICAgICAgIGZyYW1lLT5kb2N1bWVudCgpLT5zY3JpcHRl ZEFuaW1hdGlvbkNvbnRyb2xsZXJTZXRUaHJvdHRsZWQoZmFsc2UpOwogICAgIH0KKworICAgIG1f cGFnZS0+dW50aHJvdHRsZVRpbWVycygpOwogfQogCiB2b2lkIFBhZ2VUaHJvdHRsZXI6OnNldFRo cm90dGxlZChib29sIGlzVGhyb3R0bGVkKQo=