117271 2013-06-05 12:37:30 -0700 [BlackBerry] Make image clickable when it has anchor as parent node. 2013-06-05 14:40:19 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tijiang webkit-unassigned commit-queue oldest_to_newest 897515 0 tijiang 2013-06-05 12:37:30 -0700 Make the image click-able when it has anchor as parent. Although to check all the ancestors would be safe but it is too expensive. We will consider that later. 897524 1 203876 tijiang 2013-06-05 13:08:01 -0700 Created attachment 203876 Patch 897525 2 203876 rwlbuis 2013-06-05 13:13:42 -0700 Comment on attachment 203876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203876&action=review > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:96 > + || (element->hasTagName(HTMLNames::imgTag) && element->parentNode()->hasTagName(HTMLNames::aTag))) Is it possible for parentNode to be null here? 897530 3 203878 tijiang 2013-06-05 13:33:30 -0700 Created attachment 203878 Patch 897540 4 203878 rwlbuis 2013-06-05 13:58:35 -0700 Comment on attachment 203878 Patch LGTM. 897564 5 203878 commit-queue 2013-06-05 14:40:17 -0700 Comment on attachment 203878 Patch Clearing flags on attachment: 203878 Committed r151240: <http://trac.webkit.org/changeset/151240> 897565 6 commit-queue 2013-06-05 14:40:19 -0700 All reviewed patches have been landed. Closing bug. 203876 2013-06-05 13:08:01 -0700 2013-06-05 13:33:26 -0700 Patch bug-117271-20130605160629.patch text/plain 1715 tijiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiZGJhYjhiMzc4YTI5NDcxNWJkMzNlMjFjOWM3ZjI4YzZlMTk4M2Y2Li4wMWQ0OTgyNThk MjllNmM3ZmEyOTEzODNjZGNkOWQ4YjE0YjkxNTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNi0wNSAgVGlhbmNoZW5nIEppYW5nICA8dGlq aWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBNYWtlIGltYWdlIGNsaWNrYWJs ZSB3aGVuIGl0IGhhcyBhbmNob3IgYXMgcGFyZW50IG5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcyNzEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCbGFja0JlcnJ5IFBSIDM0NTk5NQorICAgICAg ICBJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEdlbmV2aWV2ZSBNYWsuCisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9GYXRGaW5nZXJzLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RmF0 RmluZ2Vyczo6aXNFbGVtZW50Q2xpY2thYmxlKToKKwogMjAxMy0wNi0wNSAgTWlrZSBGZW50b24g IDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gaGFu ZGxlcyBhcmUgaW52ZXJ0ZWQgb24gZGlyZWN0aW9uYWwgc2VsZWN0aW9ucwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAppbmRl eCA5NTViYzFhMDc3MzFlZTJmZmVkZGYxMjUzYWYyYTg0N2UwNGJlYTRiLi45MmU4YTRhNzYyMWM4 NjE1YjEwMDY5NDNhNjcxNTNjOGZlMjBmMDk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtOTIsNyArOTIsOCBA QCBib29sIEZhdEZpbmdlcnM6OmlzRWxlbWVudENsaWNrYWJsZShFbGVtZW50KiBlbGVtZW50KSBj b25zdAogCiAgICAgaWYgKGVsZW1lbnQtPndlYmtpdE1hdGNoZXNTZWxlY3RvcigiYVtocmVmXSwq OmxpbmssKjp2aXNpdGVkLCpbcm9sZT1idXR0b25dLGJ1dHRvbixpbnB1dCxzZWxlY3QsbGFiZWxb Zm9yXSxhcmVhW2hyZWZdLHRleHRhcmVhLGVtYmVkLG9iamVjdCIsIGVjKQogICAgICAgICB8fCBl bGVtZW50LT5pc01lZGlhQ29udHJvbEVsZW1lbnQoKQotICAgICAgICB8fCBlbGVtZW50LT5pc0Nv bnRlbnRFZGl0YWJsZSgpKQorICAgICAgICB8fCBlbGVtZW50LT5pc0NvbnRlbnRFZGl0YWJsZSgp CisgICAgICAgIHx8IChlbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6aW1nVGFnKSAmJiBl bGVtZW50LT5wYXJlbnROb2RlKCktPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjphVGFnKSkpCiAgICAg ICAgIHJldHVybiB0cnVlOwogCiAgICAgcmV0dXJuIGhhc01vdXNlUHJlc3NMaXN0ZW5lcihlbGVt ZW50KQo= 203878 2013-06-05 13:33:30 -0700 2013-06-05 14:40:17 -0700 Patch bug-117271-20130605163159.patch text/plain 1740 tijiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiZGJhYjhiMzc4YTI5NDcxNWJkMzNlMjFjOWM3ZjI4YzZlMTk4M2Y2Li4wMWQ0OTgyNThk MjllNmM3ZmEyOTEzODNjZGNkOWQ4YjE0YjkxNTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNi0wNSAgVGlhbmNoZW5nIEppYW5nICA8dGlq aWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBNYWtlIGltYWdlIGNsaWNrYWJs ZSB3aGVuIGl0IGhhcyBhbmNob3IgYXMgcGFyZW50IG5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcyNzEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCbGFja0JlcnJ5IFBSIDM0NTk5NQorICAgICAg ICBJbnRlcm5hbGx5IFJldmlld2VkIGJ5IEdlbmV2aWV2ZSBNYWsuCisgICAgICAgICogV2ViS2l0 U3VwcG9ydC9GYXRGaW5nZXJzLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RmF0 RmluZ2Vyczo6aXNFbGVtZW50Q2xpY2thYmxlKToKKwogMjAxMy0wNi0wNSAgTWlrZSBGZW50b24g IDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gaGFu ZGxlcyBhcmUgaW52ZXJ0ZWQgb24gZGlyZWN0aW9uYWwgc2VsZWN0aW9ucwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRmF0RmluZ2Vycy5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAppbmRl eCA5NTViYzFhMDc3MzFlZTJmZmVkZGYxMjUzYWYyYTg0N2UwNGJlYTRiLi43MWU1Y2MwODE3NmJk MTU5MDIwMWIzZjNmYjVkMTlhNjgzNmQ2ZGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcApAQCAtOTIsNyArOTIsOCBA QCBib29sIEZhdEZpbmdlcnM6OmlzRWxlbWVudENsaWNrYWJsZShFbGVtZW50KiBlbGVtZW50KSBj b25zdAogCiAgICAgaWYgKGVsZW1lbnQtPndlYmtpdE1hdGNoZXNTZWxlY3RvcigiYVtocmVmXSwq OmxpbmssKjp2aXNpdGVkLCpbcm9sZT1idXR0b25dLGJ1dHRvbixpbnB1dCxzZWxlY3QsbGFiZWxb Zm9yXSxhcmVhW2hyZWZdLHRleHRhcmVhLGVtYmVkLG9iamVjdCIsIGVjKQogICAgICAgICB8fCBl bGVtZW50LT5pc01lZGlhQ29udHJvbEVsZW1lbnQoKQotICAgICAgICB8fCBlbGVtZW50LT5pc0Nv bnRlbnRFZGl0YWJsZSgpKQorICAgICAgICB8fCBlbGVtZW50LT5pc0NvbnRlbnRFZGl0YWJsZSgp CisgICAgICAgIHx8IChlbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6aW1nVGFnKSAmJiBl bGVtZW50LT5wYXJlbnROb2RlKCkgJiYgZWxlbWVudC0+cGFyZW50Tm9kZSgpLT5oYXNUYWdOYW1l KEhUTUxOYW1lczo6YVRhZykpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIHJldHVybiBo YXNNb3VzZVByZXNzTGlzdGVuZXIoZWxlbWVudCkK