117268 2013-06-05 11:58:03 -0700 REGRESSION (r148713): Crash under waitForDidUpdateInWindowState 2013-06-05 12:42:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca oldest_to_newest 897497 0 thorton 2013-06-05 11:58:03 -0700 Anders thinks we need an isValid. I also noticed that we're not clearing m_waitingForDidUpdateInWindowState if the WebProcess quits. <rdar://problem/13822353> Null deref: CoreIPC::Connection::waitForMessage(CoreIPC::StringReference, CoreIPC::StringReference, unsigned long long, double) + 0x47 bool CoreIPC::Connection::waitForAndDispatchImmediately<Messages::WebPageProxy::DidUpdateInWindowState>(unsigned long long, double) + 0x37 897500 1 203870 thorton 2013-06-05 12:00:36 -0700 Created attachment 203870 patch 897520 2 thorton 2013-06-05 12:42:07 -0700 http://trac.webkit.org/changeset/151234 203870 2013-06-05 12:00:36 -0700 2013-06-05 12:01:27 -0700 patch crash.diff text/plain 1697 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhOGM1ZWNlLi42YjM1ODlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDYtMDUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE0ODcxMyk6IENyYXNoIHVuZGVyIHdhaXRGb3JEaWRVcGRh dGVJbldpbmRvd1N0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTcyNjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzODIyMzUzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGlmIHRoZSBX ZWJQcm9jZXNzIGlzIHZhbGlkIGJlZm9yZSB3YWl0aW5nIGZvciBhIG1lc3NhZ2UgZnJvbSBpdC4K KyAgICAgICAgUmVzZXQgdGhlIGJvb2wgdGhhdCB0ZWxscyB1cyB0aGF0IHdlIGhhdmUgYW4gb3V0 c3RhbmRpbmcgZGlkVXBkYXRlSW5XaW5kb3dTdGF0ZSBtZXNzYWdlIGlmIHRoZSBXZWJQcm9jZXNz IHF1aXRzLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6d2FpdEZvckRpZFVwZGF0ZUluV2luZG93U3RhdGUpOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnJlc2V0U3RhdGVBZnRlclByb2Nlc3NFeGl0 ZWQpOgorCiAyMDEzLTA2LTA1ICBHd2FuZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAw Lm5ldD4KIAogICAgICAgICBbQ29vcmRpbmF0ZWQgR3JhcGhpY3NdIFByZXZlbnQgYSByZWN1cnNp dmUgcGFpbnRpbmcgaW4gQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDE4OTMxOWIuLjZhOTJmODYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0xMTA0LDYgKzExMDQsOSBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6d2FpdEZvckRpZFVwZGF0ZUluV2luZG93U3RhdGUoKQogICAg IGlmIChtX3dhaXRpbmdGb3JEaWRVcGRhdGVJbldpbmRvd1N0YXRlKQogICAgICAgICByZXR1cm47 CiAKKyAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgbV93YWl0aW5n Rm9yRGlkVXBkYXRlSW5XaW5kb3dTdGF0ZSA9IHRydWU7CiAKICAgICBpZiAoIW1fcHJvY2Vzcy0+ aXNMYXVuY2hpbmcoKSkgewpAQCAtMzg0Nyw2ICszODUwLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6 OnJlc2V0U3RhdGVBZnRlclByb2Nlc3NFeGl0ZWQoKQogCiAgICAgbV9pc1ZhbGlkID0gZmFsc2U7 CiAgICAgbV9pc1BhZ2VTdXNwZW5kZWQgPSBmYWxzZTsKKyAgICBtX3dhaXRpbmdGb3JEaWRVcGRh dGVJbldpbmRvd1N0YXRlID0gZmFsc2U7CiAKICAgICBpZiAobV9tYWluRnJhbWUpIHsKICAgICAg ICAgbV91cmxBdFByb2Nlc3NFeGl0ID0gbV9tYWluRnJhbWUtPnVybCgpOwo=