117244 2013-06-05 04:20:29 -0700 Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present. 2013-06-05 05:35:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco bfulgham commit-queue dbates gustavo pnormand roger_fong oldest_to_newest 897260 0 rakuco 2013-06-05 04:20:29 -0700 Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present. 897263 1 203799 rakuco 2013-06-05 04:22:26 -0700 Created attachment 203799 Patch 897304 2 203799 dbates 2013-06-05 05:21:44 -0700 Comment on attachment 203799 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > Tools/Scripts/webkitdirs.pm:188 > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR. 897312 3 203810 rakuco 2013-06-05 05:32:07 -0700 Created attachment 203810 Patch for landing 897313 4 rakuco 2013-06-05 05:32:20 -0700 (In reply to comment #2) > (From update of attachment 203799 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > > > Tools/Scripts/webkitdirs.pm:188 > > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; > > I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR. Done: https://bugs.webkit.org/show_bug.cgi?id=117249 897314 5 rakuco 2013-06-05 05:35:54 -0700 Landed in <https://trac.webkit.org/r151216>. 203799 2013-06-05 04:22:26 -0700 2013-06-05 05:32:00 -0700 Patch bug-117244-20130605142222.patch text/plain 1647 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjgwMTlkMDRlMjQ4NjJjY2FlYjk4ZWZjMjQ1MTNjNDUy NTk3YWExMy4uYWYxYTY4MGIwYzFmYTFjOWRlZGQyNzJmNDI0MWU5NThlYjI4OTFhNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTA2LTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEu Y29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFVzZSBXRUJLSVRPVVRQVVRESVIgaWYgV0VCS0lU X09VVFBVVERJUiBpcyBub3QgcHJlc2VudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNzI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeGVkIGEgcmVncmVzc2lvbiBpbnRyb2R1Y2VkIGJ5IHIxNTEx OTY6IG5vdCBvbmx5IGRvZXMgd2Via2l0Lm9yZworICAgICAgICBzdGlsbCBtZW50aW9uIFdFQktJ VE9VVFBVVERJUiBpbnN0ZWFkIG9mIFdFQktJVF9PVVRQVVRESVIsIGJ1dCB0aGUKKyAgICAgICAg aW5mcmFzdHJ1Y3R1cmUgdXNlZCBieSBwb3J0cyBzdWNoIGFzIEdUSysgYW5kIEVGTCBhbHNvIHVz ZSBvbiBpdCBmb3IKKyAgICAgICAgdGhpbmdzIHN1Y2ggYXMgamhidWlsZC4KKworICAgICAgICBX aGlsZSBldmVyeXRoaW5nIGlzIG5vdCBmdWxseSB0cmFuc2l0aW9uZWQgdG8gV0VCS0lUX09VVFBV VERJUiwgcmVhZAorICAgICAgICBib3RoIGVudmlyb25tZW50IHZhcmlhYmxlcy4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUJhc2VQcm9kdWN0 RGlyKToKKwogMjAxMy0wNi0wNSAgRGFyaXVzeiBGcmFua2lld2ljeiAgPGQuZnJhbmtpZXdpY0Bz YW1zdW5nLmNvbT4KIAogICAgICAgICBCYWQgdmFsdWUgaW4gdGVzdHMgY291bnRlciBhdCBuZXct cnVuLXdlYmtpdC10ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGYzNzYwMjkxMGNkMDcwN2RkODI5 YzdjZDQ0MjgzNzk5ZjQyZWFiZjguLjc1Njk1OTE1ZDhiYzI1OTIzMjBiMWRlZTM2NDQ5NWNkZWEz YWI0M2EgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE4Myw3ICsxODMsOSBAQCBzdWIgZGV0ZXJtaW5l QmFzZVByb2R1Y3REaXIKICAgICBkZXRlcm1pbmVTb3VyY2VEaXIoKTsKIAogICAgIG15ICRzZXRT aGFyZWRQcmVjb21wc0RpcjsKKwogICAgICRiYXNlUHJvZHVjdERpciA9ICRFTlZ7IldFQktJVF9P VVRQVVRESVIifTsKKyAgICAkYmFzZVByb2R1Y3REaXIgPSAkRU5WeyJXRUJLSVRPVVRQVVRESVIi fSBpZiBub3QgJGJhc2VQcm9kdWN0RGlyOwogCiAgICAgaWYgKCFkZWZpbmVkKCRiYXNlUHJvZHVj dERpcikgYW5kIGlzQXBwbGVNYWNXZWJLaXQoKSkgewogICAgICAgICAjIFNpbGVudGx5IHJlbW92 ZSB+L0xpYnJhcnkvUHJlZmVyZW5jZXMveGNvZGVidWlsZC5wbGlzdCB3aGljaCBjYW4K 203810 2013-06-05 05:32:07 -0700 2013-06-05 05:32:07 -0700 Patch for landing bug-117244-20130605153202.patch text/plain 1852 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjgwMTlkMDRlMjQ4NjJjY2FlYjk4ZWZjMjQ1MTNjNDUy NTk3YWExMy4uM2Q5NTM3ZDU4NmQ5YWY5YTAwOGI5Mjk2MDM3NTM4N2U2NDJiZGRhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTA2LTA1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEu Y29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFVzZSBXRUJLSVRPVVRQVVRESVIgaWYgV0VCS0lU X09VVFBVVERJUiBpcyBub3QgcHJlc2VudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNzI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBC YXRlcy4KKworICAgICAgICBGaXhlZCBhIHJlZ3Jlc3Npb24gaW50cm9kdWNlZCBieSByMTUxMTk2 OiBub3Qgb25seSBkb2VzIHdlYmtpdC5vcmcKKyAgICAgICAgc3RpbGwgbWVudGlvbiBXRUJLSVRP VVRQVVRESVIgaW5zdGVhZCBvZiBXRUJLSVRfT1VUUFVURElSLCBidXQgdGhlCisgICAgICAgIGlu ZnJhc3RydWN0dXJlIHVzZWQgYnkgcG9ydHMgc3VjaCBhcyBHVEsrIGFuZCBFRkwgYWxzbyB1c2Ug b24gaXQgZm9yCisgICAgICAgIHRoaW5ncyBzdWNoIGFzIGpoYnVpbGQuCisKKyAgICAgICAgV2hp bGUgZXZlcnl0aGluZyBpcyBub3QgZnVsbHkgdHJhbnNpdGlvbmVkIHRvIFdFQktJVF9PVVRQVVRE SVIsIHJlYWQKKyAgICAgICAgYm90aCBlbnZpcm9ubWVudCB2YXJpYWJsZXMuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVCYXNlUHJvZHVjdERp cik6CisKIDIwMTMtMDYtMDUgIERhcml1c3ogRnJhbmtpZXdpY3ogIDxkLmZyYW5raWV3aWNAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgQmFkIHZhbHVlIGluIHRlc3RzIGNvdW50ZXIgYXQgbmV3LXJ1 bi13ZWJraXQtdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBmMzc2MDI5MTBjZDA3MDdkZDgyOWM3 Y2Q0NDI4Mzc5OWY0MmVhYmY4Li40MjFlZWMwZDZmNjJlYTYxNjMzOTkwNmNjMDg2OGJmNWFhOWM4 Zjk3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xODMsNyArMTgzLDEyIEBAIHN1YiBkZXRlcm1pbmVC YXNlUHJvZHVjdERpcgogICAgIGRldGVybWluZVNvdXJjZURpcigpOwogCiAgICAgbXkgJHNldFNo YXJlZFByZWNvbXBzRGlyOworCisgICAgIyBGSVhNRTogU2VlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcyNDkuCisgICAgIyAgICAgICAgT25jZSBhbGwgcG9ydHMg aGF2ZSBtaWdyYXRlZCB0byBXRUJLSVRfT1VUUFVURElSLCB3ZSBjYW4gc3RvcAorICAgICMgICAg ICAgIHJlYWRpbmcgdGhlIFdFQktJVE9VVFBVVERJUiBlbnZpcm9ubWVudCB2YXJpYWJsZS4KICAg ICAkYmFzZVByb2R1Y3REaXIgPSAkRU5WeyJXRUJLSVRfT1VUUFVURElSIn07CisgICAgJGJhc2VQ cm9kdWN0RGlyID0gJEVOVnsiV0VCS0lUT1VUUFVURElSIn0gaWYgbm90ICRiYXNlUHJvZHVjdERp cjsKIAogICAgIGlmICghZGVmaW5lZCgkYmFzZVByb2R1Y3REaXIpIGFuZCBpc0FwcGxlTWFjV2Vi S2l0KCkpIHsKICAgICAgICAgIyBTaWxlbnRseSByZW1vdmUgfi9MaWJyYXJ5L1ByZWZlcmVuY2Vz L3hjb2RlYnVpbGQucGxpc3Qgd2hpY2ggY2FuCg==