11724 2006-11-30 10:39:27 -0800 [S60] 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll 2011-03-21 11:52:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ S60 Emulator S60 3rd edition CLOSED FIXED PlatformOnly P2 Critical --- 1 Sachin.Padma webkit-unassigned oldest_to_newest 43785 0 Sachin.Padma 2006-11-30 10:39:27 -0800 S60_3_1_200638 release, file name \S60\mw\web\WebEngine\OssWebengine\WebKit\ResourceLoader\CacheSrc\HttpCacheEntry.cpp contains the following code... TInt CHttpCacheEntry::Internalize( RFileReadStream& aReadStream ) { TRAPD( err, TInt len; // url length len = aReadStream.ReadInt32L(); delete iUrl; iUrl = HBufC8::NewL( len ); <== if NewL leaves, then iUrl is deleted, but iUrl is not NULL TPtr8 ptr8( iUrl->Des() ); // url aReadStream.ReadL( ptr8, len ); // filename length len = aReadStream.ReadInt32L(); HBufC* filename = HBufC::NewLC( len ); TPtr ptr( filename->Des() ); // url aReadStream.ReadL( ptr, len ); // SetFileNameL( filename->Des() ); // CleanupStack::PopAndDestroy(); // filename // la TReal64 la; la = aReadStream.ReadReal64L(); iLastAccessed = la; // ref iRef = aReadStream.ReadUint32L(); // size iSize = aReadStream.ReadUint32L( ); // size iHeaderSize = aReadStream.ReadUint32L( ); // protected iProtected = aReadStream.ReadInt32L(); // SetState( ECacheComplete ); ); return err; } ... and this causes problems after CHttpCacheEntry destructor is run, because it deletes the same heap-allocated iUrl again. 43786 1 Sachin.Padma 2006-11-30 10:39:56 -0800 TSW ID: THYN-6VJCRE 43787 2 11684 Sachin.Padma 2006-11-30 10:43:24 -0800 Created attachment 11684 fix url not set null of deleting 43736 3 11684 yongjun.zhang 2006-11-30 12:18:06 -0800 Comment on attachment 11684 fix url not set null of deleting r=me 43720 4 Sachin.Padma 2006-11-30 12:34:55 -0800 committed as r17943 33979 5 krishnamurty.podipireddy 2007-01-21 08:28:00 -0800 Verified and Closed. 370631 6 joel.parks 2011-03-21 11:52:52 -0700 re-purposing InTSW keyword for use by QtWebkit team 11684 2006-11-30 10:43:24 -0800 2006-11-30 12:18:06 -0800 fix url not set null of deleting bug11724.patch text/plain 4639 Sachin.Padma SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzkzOSkNCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpDQpA QCAtMSwzICsxLDEyIEBADQorMjAwNi0xMS0zMCAgc3BhZG1hICA8U2FjaGluLlBhZG1hQG5va2lh LmNvbT4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IFlvbmdqdW4uDQorICAgICAgICBERVNDOiAz LjEgJiAzLjIgTWVtb3J5IGhhbmRsaW5nIGVycm9yIGluIENIdHRwQ2FjaGVFbnRyeTo6SW50ZXJu YWxpemUoKSwgQnJvd3NlckNhY2hlLmRsbA0KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MjQNCisNCisgICAgICAgICogUmVzb3VyY2VMb2FkZXIvQ2Fj aGVTcmMvSHR0cENhY2hlRW50cnkuY3BwOg0KKyAgICAgICAgKENIdHRwQ2FjaGVFbnRyeTo6SW50 ZXJuYWxpemUpOg0KKw0KIDIwMDYtMTEtMjggIHlhZGF2YWxsICA8c3JpcmFtLnlhZGF2YWxsaUBu b2tpYS5jb20+DQogDQogICAgICAgICBSZXZpZXdlZCBieSBTYWNoaW4gUGFkbWEgKHNhY2hpbi5w YWRtYUBub2tpYS5jb20pLg0KSW5kZXg6IFdlYktpdC9SZXNvdXJjZUxvYWRlci9DYWNoZVNyYy9I dHRwQ2FjaGVFbnRyeS5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvUmVzb3VyY2VMb2FkZXIv Q2FjaGVTcmMvSHR0cENhY2hlRW50cnkuY3BwCShyZXZpc2lvbiAxNzkyOSkNCisrKyBXZWJLaXQv UmVzb3VyY2VMb2FkZXIvQ2FjaGVTcmMvSHR0cENhY2hlRW50cnkuY3BwCSh3b3JraW5nIGNvcHkp DQpAQCAtOSw5ICs5LDkgQEANCiAqICAgIENvcHlyaWdodCAoYykgMjAwNiwgTm9raWEgQ29ycG9y YXRpb24NCiAqICAgIEFsbCByaWdodHMgcmVzZXJ2ZWQuDQogKiAgDQotKiAgCVJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dA0K LSogIAltb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMNCi0qICAJYXJlIG1ldDoNCisqICAgUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0DQorKiAgIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucw0KKyogICBhcmUgbWV0Og0KICogIA0KICogICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBz b3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0DQogKiAgICAgICAgbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy Lg0KQEAgLTIzLDE4ICsyMywxOCBAQA0KICogICAgICAgIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNl ZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZA0KICogICAgICAgIGZyb20g dGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4N CiAqICANCi0qICAJVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhP TERFUlMgQU5EIENPTlRSSUJVVE9SUw0KLSogIAkiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVA0KLSogIAlMSU1JVEVEIFRPLCBU SEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IN Ci0qICAJQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNI QUxMIFRIRSBDT1BZUklHSFQNCi0qICAJT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBG T1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsDQotKiAgCVNQRUNJQUwsIEVYRU1Q TEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QNCi0qICAJ TElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsg TE9TUyBPRiBVU0UsDQotKiAgCURBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQ VElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQ0KLSogIAlUSEVPUlkgT0YgTElBQklMSVRZ LCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUDQotKiAgCShJ TkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQg T0YgVEhFDQotKiAgCVVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0gNCi0qICAJREFNQUdFLg0KKyogICBUSElTIFNPRlRXQVJFIElT IFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTDQorKiAg ICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5H LCBCVVQgTk9UDQorKiAgIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVS Q0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUg0KKyogICBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBB UkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVA0KKyogICBPV05F UiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5D SURFTlRBTCwNCisqICAgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFH RVMgKElOQ0xVRElORywgQlVUIE5PVA0KKyogICBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBT VUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwNCisqICAgREFUQSwgT1Ig UFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04g QU5ZDQorKiAgIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklD VCBMSUFCSUxJVFksIE9SIFRPUlQNCisqICAgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVS V0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUNCisqICAgVVNFIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSA0KKyogICBE QU1BR0UuDQogKiAgDQogKiAgICBQbGVhc2Ugc2VlIGZpbGUgcGF0ZW50bGljZW5zZS50eHQgZm9y IGZ1cnRoZXIgZ3JhbnRzLg0KICogPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpAQCAtMTI4LDEwICsx MjgsMTAgQEAgQ0h0dHBDYWNoZUVudHJ5KiBDSHR0cENhY2hlRW50cnk6Ok5ld0xDKA0KIC8vIERl c3RydWN0b3INCiBDSHR0cENhY2hlRW50cnk6On5DSHR0cENhY2hlRW50cnkoKQ0KICAgICB7DQot CWlmKCBpVmljdGltICkNCi0JCXsNCi0JCWlFdmljdGlvbkhhbmRsZXItPlJlbW92ZSggKnRoaXMg KTsNCi0JCX0NCisgIGlmKCBpVmljdGltICkNCisgICAgew0KKyAgICBpRXZpY3Rpb25IYW5kbGVy LT5SZW1vdmUoICp0aGlzICk7DQorICAgIH0NCiAgICAgZGVsZXRlIGlVcmw7DQogICAgIGRlbGV0 ZSBpRmlsZU5hbWU7DQogICAgIH0NCkBAIC0yMDcsMTEgKzIwNywxMSBAQCB2b2lkIENIdHRwQ2Fj aGVFbnRyeTo6U2V0U2l6ZSgNCiAgICAgICAgIC8vIGJvZHkgcmVtb3ZhbA0KICAgICAgICAgLy8g cmVtb3ZlIGl0c2VsZiBmcm9tIHRoZSBldmljdGlvbiB0YWJsZS4NCiAgICAgICAgIC8vIHRoaXMg aXMgbm8gbG9uZ2VyIGEgdmljdGltDQotCSAgICBpZiggaVZpY3RpbSApDQotCQkgICAgew0KLQkJ ICAgIGlFdmljdGlvbkhhbmRsZXItPlJlbW92ZSggKnRoaXMgKTsNCisgICAgICBpZiggaVZpY3Rp bSApDQorICAgICAgICB7DQorICAgICAgICBpRXZpY3Rpb25IYW5kbGVyLT5SZW1vdmUoICp0aGlz ICk7DQogICAgICAgICAgICAgaVZpY3RpbSA9IEVGYWxzZTsNCi0JCSAgICB9DQorICAgICAgICB9 DQogICAgICAgICB9DQogICAgIGlTaXplID0gYVNpemU7DQogICAgIH0NCkBAIC0yMzksMTMgKzIz OSwxNiBAQCBUSW50IENIdHRwQ2FjaGVFbnRyeTo6SW50ZXJuYWxpemUoDQogICAgIHsNCiAgICAg VFJBUEQoIGVyciwNCiAgICAgIFRJbnQgbGVuOw0KKyAgICANCiAgICAgLy8gdXJsIGxlbmd0aA0K ICAgICBsZW4gPSBhUmVhZFN0cmVhbS5SZWFkSW50MzJMKCk7DQogICAgIGRlbGV0ZSBpVXJsOw0K KyAgICBpVXJsPU5VTEw7DQogICAgIGlVcmwgPSBIQnVmQzg6Ok5ld0woIGxlbiApOw0KICAgICBU UHRyOCBwdHI4KCBpVXJsLT5EZXMoKSApOw0KICAgICAvLyB1cmwNCiAgICAgYVJlYWRTdHJlYW0u UmVhZEwoIHB0cjgsIGxlbiApOw0KKyAgICANCiAgICAgLy8gZmlsZW5hbWUgbGVuZ3RoDQogICAg IGxlbiA9IGFSZWFkU3RyZWFtLlJlYWRJbnQzMkwoKTsNCiAgICAgSEJ1ZkMqIGZpbGVuYW1lID0g SEJ1ZkM6Ok5ld0xDKCBsZW4gKTsNCg==