117239 2013-06-05 03:38:05 -0700 [Qt] Handle Return key without key text 2013-06-05 04:55:57 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen commit-queue hausmann kling oldest_to_newest 897234 0 allan.jensen 2013-06-05 03:38:05 -0700 A QKeyEvent for Return_Key without QKeyEvent::text() set is not handle correctly. The similar case for Enter_Key was fixed in bug 33179 897236 1 203790 allan.jensen 2013-06-05 03:39:59 -0700 Created attachment 203790 Patch 897280 2 203790 kling 2013-06-05 04:43:21 -0700 Comment on attachment 203790 Patch r=me 897293 3 203790 commit-queue 2013-06-05 04:55:55 -0700 Comment on attachment 203790 Patch Clearing flags on attachment: 203790 Committed r151213: <http://trac.webkit.org/changeset/151213> 897294 4 commit-queue 2013-06-05 04:55:57 -0700 All reviewed patches have been landed. Closing bug. 203790 2013-06-05 03:39:59 -0700 2013-06-05 04:55:54 -0700 Patch bug-117239-20130605123828.patch text/plain 3410 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjMzk0YzVjNjg1NTZk NTdiNWY5MmFmYTkyZjhjZDBkOTYwM2IzMC4uYTY0NzBlMTczNjEyZDcyZWZhZDk0MmI5NDNkNTJj ZjhkYzRhNTUyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA2LTA1ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gSGFuZGxlIFJldHVybiBrZXkgd2l0aG91dCBrZXkgdGV4dAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MjM5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBhZGRlZCB0byB0c3RfcXdlYnBhZ2Uu Y3BwLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1LZXlib2FyZEV2ZW50UXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6a2V5VGV4dEZvcktleUV2ZW50KToKKwogMjAxMy0wNi0wNCAg QWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAogICAgICAg ICBbUXRdIEZvbnQ6OnNob3VsZFVzZVNtb290aGluZygpIGhhcyBmYWtlIGRlcGVuZGVuY3kgb24g UXQgNS4xCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDRmMzY2YTdkOWRkNDYzYmVmNzVkYzcxOTdmNTA3ZGQ4 MGZlZGUwOWMuLjFiODNhYmEwZDg2MzhiN2Q3Njg1MWY1ZjZlZjUwYzkwYjQ1MjY4MzcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDYtMDUgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0XSBIYW5kbGUgUmV0 dXJuIGtleSB3aXRob3V0IGtleSB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTcyMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0IGZvciBRS2V5RXZlbnQoUmV0dXJuX0tleSkgd2l0aG91dCBr ZXkgdGV4dC4KKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6Cisg ICAgICAgICh0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kcyk6CisKIDIwMTMtMDYtMDMgIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxNTExMDkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRRdC5jcHAKaW5kZXggNTEyM2E4ZDhjOTgzZWZlOTZh OWI3ZWRkN2RhZjUzNzM4ZjVhZWIwZS4uYWYyMjk3YWQ4NmU5OTZjNmVhNzVhZDA4YmNkNTFmMjhk MjQ1MzUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1L ZXlib2FyZEV2ZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRm b3JtS2V5Ym9hcmRFdmVudFF0LmNwcApAQCAtNTg3LDYgKzU4Nyw3IEBAIHN0YXRpYyBTdHJpbmcg a2V5VGV4dEZvcktleUV2ZW50KGNvbnN0IFFLZXlFdmVudCogZXZlbnQpCiAgICAgICAgIGlmIChl dmVudC0+dGV4dCgpLmlzTnVsbCgpKQogICAgICAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgi XHQiKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBRdDo6S2V5X1JldHVybjoKICAgICBjYXNl IFF0OjpLZXlfRW50ZXI6CiAgICAgICAgIGlmIChldmVudC0+dGV4dCgpLmlzTnVsbCgpKQogICAg ICAgICAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiXHIiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQv cXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAppbmRleCBlNDMwODk4ZmMxYmU4YTc3 YjlmMTUxNzliM2E3MzFlYWRhMDE0YzRjLi45NmMyYTY1NjdkN2E5ODY5N2ZhZDA4YTUzZTJkYWZh YWQyOWVkMzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3Rf cXdlYnBhZ2UuY3BwCkBAIC0yMzIyLDYgKzIzMjIsMjAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6Omlu cHV0TWV0aG9kcygpCiAgICAgaW5wdXRWYWx1ZTIgPSBwYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVh dGVKYXZhU2NyaXB0KCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaW5wdXQ1JykudmFsdWUiKS50 b1N0cmluZygpOwogICAgIFFDT01QQVJFKGlucHV0VmFsdWUyLCBRU3RyaW5nKCJcblxudGhpcmQg bGluZSIpKTsKIAorICAgIC8vIFJldHVybiBLZXkgd2l0aG91dCBrZXkgdGV4dAorICAgIHBhZ2Ut Pm1haW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoInZhciBpbnB1dEVsZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdpbnB1dDUnKTsgaW5wdXRFbGUudmFsdWUgPSAnJzsgaW5wdXRFbGUu Zm9jdXMoKTsgaW5wdXRFbGUuc2VsZWN0KCk7Iik7CisgICAgaW5wdXRWYWx1ZTIgPSBwYWdlLT5t YWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn aW5wdXQ1JykudmFsdWUiKS50b1N0cmluZygpOworICAgIFFDT01QQVJFKGlucHV0VmFsdWUyLCBR U3RyaW5nKCIiKSk7CisKKyAgICBRS2V5RXZlbnQga2V5UmV0dXJuKFFFdmVudDo6S2V5UHJlc3Ms IFF0OjpLZXlfUmV0dXJuLCBRdDo6Tm9Nb2RpZmllcik7CisgICAgcGFnZS0+ZXZlbnQoJmtleVJl dHVybik7CisgICAgcGFnZS0+ZXZlbnQoJmV2ZW50VGV4dCk7CisgICAgcGFnZS0+ZXZlbnQoJmV2 ZW50VGV4dDIpOworICAgIHFBcHAtPnByb2Nlc3NFdmVudHMoKTsKKworICAgIGlucHV0VmFsdWUy ID0gcGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgiZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2lucHV0NScpLnZhbHVlIikudG9TdHJpbmcoKTsKKyAgICBRQ09NUEFSRShpbnB1 dFZhbHVlMiwgUVN0cmluZygiXG5cbnRoaXJkIGxpbmUiKSk7CisKICAgICAvLyBFTkQgLSBOZXds aW5lIHRlc3QgZm9yIHRleHRhcmVhCiAKICAgICBkZWxldGUgY29udGFpbmVyOwo=