117224 2013-06-04 22:59:07 -0700 Cannot set a new timer inside of timer callback in RunLoopTimerGtk & RunLoopTimerEFL 2013-06-06 06:52:50 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yoon webkit-unassigned cdumez commit-queue gyuyoung.kim jaepark mrobinson rakuco oldest_to_newest 897136 0 yoon 2013-06-04 22:59:07 -0700 RunLoopTimer should clear its isActive flag before invoking timer callback. 897710 1 203919 yoon 2013-06-06 03:43:37 -0700 Created attachment 203919 Patch 897711 2 203919 mrobinson 2013-06-06 03:49:36 -0700 Comment on attachment 203919 Patch The GTK bits look good to me. Have you ensured all tests are passing as well? 897712 3 203919 cdumez 2013-06-06 03:51:24 -0700 Comment on attachment 203919 Patch Looks sane. r=me. 897714 4 cdumez 2013-06-06 03:52:40 -0700 Sorry, didn't see Martin's comment. Leaving cq? on. 897741 5 yoon 2013-06-06 06:27:51 -0700 (In reply to comment #2) > (From update of attachment 203919 [details]) > The GTK bits look good to me. Have you ensured all tests are passing as well? Yes, all tests passed. 897743 6 yoon 2013-06-06 06:29:40 -0700 (In reply to comment #4) > Sorry, didn't see Martin's comment. Leaving cq? on. Thanks for review. All tests are passed. Could you turn cq+? 897756 7 203919 commit-queue 2013-06-06 06:52:47 -0700 Comment on attachment 203919 Patch Clearing flags on attachment: 203919 Committed r151268: <http://trac.webkit.org/changeset/151268> 897758 8 commit-queue 2013-06-06 06:52:50 -0700 All reviewed patches have been landed. Closing bug. 203919 2013-06-06 03:43:37 -0700 2013-06-06 06:52:47 -0700 Patch bug-117224-20130606194204.patch text/plain 2558 yoon U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM5YTY0MjEwYmRiMzQw ZTU1YjQ1OTlkMzYzMGVmZWM3ZGM2YzAxMy4uODRiZDQ1Yjk1MDI4YTAxZmJmNTBjMzM3YTMzZGUx NTBhMDA3ZTdiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTA0ICBHd2Fu ZyBZb29uIEh3YW5nICA8cnl1bWllbEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBDYW5ub3Qg c2V0IGEgbmV3IHRpbWVyIGluc2lkZSBvZiB0aW1lciBjYWxsYmFjayBpbiBSdW5Mb29wVGltZXJH dGsgJiBSdW5Mb29wVGltZXJFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExNzIyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJ1bkxvb3BUaW1lciBzaG91bGQgY2xlYXIgaXRzIGlzQWN0aXZlIGZsYWcg YmVmb3JlIGludm9raW5nIHRpbWVyCisgICAgICAgIGNhbGxiYWNrLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL1J1bkxvb3BFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UnVuTG9vcDo6VGlt ZXJCYXNlOjp0aW1lckZpcmVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUnVuTG9vcEd0ay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSdW5Mb29wOjpUaW1lckJhc2U6OnRpbWVyRmlyZWRDYWxs YmFjayk6CisKIDIwMTMtMDYtMDYgIEphZSBIeXVuIFBhcmsgIDxqYWUucGFya0Bjb21wYW55MTAw Lm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBHcmFwaGljcyA6IFJlZmFjdG9yIENvb3JkaW5h dGVkU3VyZmFjZSB0byBtYW5hZ2UgdGhlIGxpZmVjeWNsZSBvZiBHcmFwaGljc0NvbnRleHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SdW5Mb29wRWZsLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SdW5Mb29wRWZsLmNwcAppbmRleCBhMzgxYjM2N2Qz MzgwN2NmZmY5MzczYmE3MzA5ZmVlMmU3NjVhMTU2Li5hOTJkY2RmZTcyMzFlZDUyMTJiZjBiNTk2 YTRmNzJhNzQ2OTI1ODYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UnVuTG9vcEVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1J1bkxvb3BF ZmwuY3BwCkBAIC0xMDAsMTQgKzEwMCwxMiBAQCBib29sIFJ1bkxvb3A6OlRpbWVyQmFzZTo6dGlt ZXJGaXJlZCh2b2lkKiBkYXRhKQogewogICAgIFJ1bkxvb3A6OlRpbWVyQmFzZSogdGltZXIgPSBz dGF0aWNfY2FzdDxSdW5Mb29wOjpUaW1lckJhc2UqPihkYXRhKTsKIAotICAgIHRpbWVyLT5maXJl ZCgpOwotCi0gICAgaWYgKCF0aW1lci0+bV9pc1JlcGVhdGluZykgeworICAgIGlmICghdGltZXIt Pm1faXNSZXBlYXRpbmcpCiAgICAgICAgIHRpbWVyLT5tX3RpbWVyID0gMDsKLSAgICAgICAgcmV0 dXJuIEVDT1JFX0NBTExCQUNLX0NBTkNFTDsKLSAgICB9CiAKLSAgICByZXR1cm4gRUNPUkVfQ0FM TEJBQ0tfUkVORVc7CisgICAgdGltZXItPmZpcmVkKCk7CisKKyAgICByZXR1cm4gdGltZXItPm1f aXNSZXBlYXRpbmcgPyBFQ09SRV9DQUxMQkFDS19SRU5FVyA6IEVDT1JFX0NBTExCQUNLX0NBTkNF TDsKIH0KIAogdm9pZCBSdW5Mb29wOjpUaW1lckJhc2U6OnN0YXJ0KGRvdWJsZSBuZXh0RmlyZUlu dGVydmFsLCBib29sIHJlcGVhdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9SdW5Mb29wR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SdW5Mb29w R3RrLmNwcAppbmRleCAxOTBmMzVjYTY2ZDIyMGI0MGQ0ZjYzZjdkOWY2Yzk4NDI3NTc3NzFkLi42 ZTMyOTJkNGU5NDhiMjhiZGI4YzA4NWM1YTU0NWFhODYwZjYxZDIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUnVuTG9vcEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1J1bkxvb3BHdGsuY3BwCkBAIC0xMzYsOSArMTM2LDEwIEBAIGdib29s ZWFuIFJ1bkxvb3A6OlRpbWVyQmFzZTo6dGltZXJGaXJlZENhbGxiYWNrKFJ1bkxvb3A6OlRpbWVy QmFzZSogdGltZXIpCiAgICAgR1NvdXJjZSogY3VycmVudFRpbWVyU291cmNlID0gdGltZXItPm1f dGltZXJTb3VyY2UuZ2V0KCk7CiAgICAgYm9vbCBpc1JlcGVhdGluZyA9IHRpbWVyLT5pc1JlcGVh dGluZygpOwogICAgIC8vIFRoaXMgY2FuIGNoYW5nZSB0aGUgdGltZXJTb3VyY2UgYnkgc3RhcnRp bmcgYSBuZXcgdGltZXIgd2l0aGluIHRoZSBjYWxsYmFjay4KLSAgICB0aW1lci0+ZmlyZWQoKTsK ICAgICBpZiAoIWlzUmVwZWF0aW5nICYmIGN1cnJlbnRUaW1lclNvdXJjZSA9PSB0aW1lci0+bV90 aW1lclNvdXJjZS5nZXQoKSkKICAgICAgICAgdGltZXItPmNsZWFyVGltZXJTb3VyY2UoKTsKKwor ICAgIHRpbWVyLT5maXJlZCgpOwogICAgIHJldHVybiBpc1JlcGVhdGluZzsKIH0KIAo=