117202 2013-06-04 08:56:52 -0700 Avoid multiple copies of inline script & style strings 2013-06-05 14:20:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 arurajku webkit-unassigned ap ararunprasad bfulgham commit-queue esprehn+autocc kling koivisto rniwa oldest_to_newest 896922 0 arurajku 2013-06-04 08:56:52 -0700 https://chromiumcodereview.appspot.com/16005007 Above fix avoids the multiple copies of contents inside inline <script> & <style> 897473 1 ap 2013-06-05 10:58:24 -0700 Sounds like a really valuable optimization. 897519 2 203874 arurajku 2013-06-05 12:40:13 -0700 Created attachment 203874 Patch 897541 3 bfulgham 2013-06-05 13:59:11 -0700 Seems like a good change. ap, any reason you did not r+ this? 897542 4 203874 darin 2013-06-05 13:59:43 -0700 Comment on attachment 203874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203874&action=review > Source/WebCore/html/parser/HTMLConstructionSite.cpp:500 > + unsigned lengthLimit = shouldUseLengthLimit(task.parent.get()) ? Text::defaultLengthLimit : std::numeric_limits<unsigned>::max(); Too bad we need to compute this limit ahead of time. Sure would be nice to only do the work when we actually get close enough to hitting a limit. 897552 5 203874 commit-queue 2013-06-05 14:20:38 -0700 Comment on attachment 203874 Patch Clearing flags on attachment: 203874 Committed r151236: <http://trac.webkit.org/changeset/151236> 897553 6 commit-queue 2013-06-05 14:20:41 -0700 All reviewed patches have been landed. Closing bug. 203874 2013-06-05 12:40:13 -0700 2013-06-05 14:20:38 -0700 Patch bug-117202-20130606010840.patch text/plain 5062 arurajku U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNjYTBjODljOTc1ZWVi ZGU5OGM4YzVkNjgxZGMwOGQ3NTdmMDVlYi4uN2IyZGZjMTAwNDk0OGYyZjExNGU5MzgyMTMyODUw ZDUyNWZhOWRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDEzLTA2LTA1ICBBcnVu cHJhc2FkIFJhamt1bWFyICA8YXJ1cmFqa3VAY2lzY28uY29tPgorCisgICAgICAgIEF2b2lkIG11 bHRpcGxlIGNvcGllcyBvZiBpbmxpbmUgc2NyaXB0ICYgc3R5bGUgc3RyaW5ncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MjAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVyZ2UgZnJvbSBodHRwczov L2Nocm9taXVtY29kZXJldmlldy5hcHBzcG90LmNvbS8xNjAwNTAwNy4KKworICAgICAgICBObyBu ZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgIFRoZSBIVE1MIHBhcnNlciBicmVha3MgdXAgbGFy Z2UgdGV4dCBub2RlcyBpbnRvIHNtYWxsIGNodW5rcyB0byBhdm9pZCBzb21lCisgICAgICAgIE8o bl4yKSBlZGl0aW5nIGFsZ29yaXRobXMuIFRoaXMgZml4IHNraXBzIHRoYXQgd29ya2Fyb3VuZCBm b3IgPHNjcmlwdD4gYW5kCisgICAgICAgIDxzdHlsZT4gZWxlbWVudHMsIHdoaWNoIGFyZW4ndCBs aWtlbHkgdG8gbmVlZCBlZGl0aW5nLiBBcyBhIHJlc3VsdCwgPHNjcmlwdD4KKyAgICAgICAgZW5k cyB1cCB3aXRoIGEgc2luZ2xlIHRleHQgbm9kZSwgY29udGFpbmluZyBhIGNvbnRpZ3VvdXMgU3Ry aW5nLCB3aGljaCBpcyB0aGUKKyAgICAgICAgc291cmNlIGNvZGUgb2YgdGhhdCBpbmxpbmUgc2Ny aXB0IGJsb2NrLgorCisgICAgICAgIFByaW9yIHRoaXMgZml4LCB3ZSBjb3VsZCBlbmQgdXAgd2l0 aCB0d28gY29waWVzIG9mIGxhcmdlIGlubGluZSBzY3JpcHRzOiBvbmUKKyAgICAgICAgbW9ub2xp dGhpYyBzdHJpbmcgcmV0YWluZWQgYnkgSlNDIGFuZCBhIG51bWJlciBvZiBzaGFyZHMgcmV0YWlu ZWQgYnkgdGhlIERPTS4KKyAgICAgICAgQWZ0ZXIgdGhpcyBmaXgsIGJvdGggdGhlIERPTSBhbmQg SlNDIHVzZSB0aGUgc2FtZSBtb25vbGl0aGljIHN0cmluZywgcmVtb3ZpbmcgYQorICAgICAgICBj b3B5LgorCisgICAgICAgICogZG9tL1RleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dDo6 Y3JlYXRlV2l0aExlbmd0aExpbWl0KToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MQ29uc3Ry dWN0aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRVc2VMZW5ndGhMaW1pdCk6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0VGV4dE5vZGUp OgorCiAyMDEzLTA2LTA0ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdp YS5jb20+CiAKICAgICAgICAgW1F0XSBGaXggYSBjcmFzaCBpbiBRdFBpeG1hcFJ1bnRpbWUuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vVGV4dC5jcHAKaW5kZXggY2YzNmU1MjZlNmQ2N2FlMTFhZTRkNjA1NjMxNmIwOWVlNjgyMDFj MS4uNzM2YzkzMmMzZWM0MzNhMTc2ZDgxZGQ4MjNmNmFjZmI3NTcxNmUwYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1RleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9UZXh0 LmNwcApAQCAtMzI2LDE1ICszMjYsMTUgQEAgUGFzc1JlZlB0cjxUZXh0PiBUZXh0Ojp2aXJ0dWFs Q3JlYXRlKGNvbnN0IFN0cmluZyYgZGF0YSkKICAgICByZXR1cm4gY3JlYXRlKGRvY3VtZW50KCks IGRhdGEpOwogfQogCi1QYXNzUmVmUHRyPFRleHQ+IFRleHQ6OmNyZWF0ZVdpdGhMZW5ndGhMaW1p dChEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IFN0cmluZyYgZGF0YSwgdW5zaWduZWQgc3RhcnQs IHVuc2lnbmVkIG1heENoYXJzKQorUGFzc1JlZlB0cjxUZXh0PiBUZXh0OjpjcmVhdGVXaXRoTGVu Z3RoTGltaXQoRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBTdHJpbmcmIGRhdGEsIHVuc2lnbmVk IHN0YXJ0LCB1bnNpZ25lZCBsZW5ndGhMaW1pdCkKIHsKICAgICB1bnNpZ25lZCBkYXRhTGVuZ3Ro ID0gZGF0YS5sZW5ndGgoKTsKIAotICAgIGlmICghc3RhcnQgJiYgZGF0YUxlbmd0aCA8PSBtYXhD aGFycykKKyAgICBpZiAoIXN0YXJ0ICYmIGRhdGFMZW5ndGggPD0gbGVuZ3RoTGltaXQpCiAgICAg ICAgIHJldHVybiBjcmVhdGUoZG9jdW1lbnQsIGRhdGEpOwogCiAgICAgUmVmUHRyPFRleHQ+IHJl c3VsdCA9IFRleHQ6OmNyZWF0ZShkb2N1bWVudCwgU3RyaW5nKCkpOwotICAgIHJlc3VsdC0+cGFy c2VyQXBwZW5kRGF0YShkYXRhLCBzdGFydCwgbWF4Q2hhcnMpOworICAgIHJlc3VsdC0+cGFyc2Vy QXBwZW5kRGF0YShkYXRhLCBzdGFydCwgbGVuZ3RoTGltaXQpOwogCiAgICAgcmV0dXJuIHJlc3Vs dDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1 Y3Rpb25TaXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rp b25TaXRlLmNwcAppbmRleCA0ZmQ0M2ZhYzdlNmFlNTk2MzA0ODE5NjBkMTJhYWUzODliNTNiODFk Li40ZjNhNzc0YTdkMDgwYTYxYzdiMjk4MTAxODkxNzE5NTJlYmU2MTI4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCkBAIC03 NSw2ICs3NSwxMyBAQCBzdGF0aWMgYm9vbCBoYXNJbXBsaWVkRW5kVGFnKGNvbnN0IEhUTUxTdGFj a0l0ZW0qIGl0ZW0pCiAgICAgICAgIHx8IGl0ZW0tPmhhc1RhZ05hbWUocnRUYWcpOwogfQogCitz dGF0aWMgYm9vbCBzaG91bGRVc2VMZW5ndGhMaW1pdChjb25zdCBDb250YWluZXJOb2RlKiBub2Rl KQoreworICAgIHJldHVybiAhbm9kZS0+aGFzVGFnTmFtZShzY3JpcHRUYWcpCisgICAgICAgICYm ICFub2RlLT5oYXNUYWdOYW1lKHN0eWxlVGFnKQorICAgICAgICAmJiAhbm9kZS0+aGFzVGFnTmFt ZShTVkdOYW1lczo6c2NyaXB0VGFnKTsKK30KKwogc3RhdGljIGlubGluZSBib29sIGlzQWxsV2hp dGVzcGFjZShjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKICAgICByZXR1cm4gc3RyaW5nLmlzQWxs U3BlY2lhbENoYXJhY3RlcnM8aXNIVE1MU3BhY2U+KCk7CkBAIC00OTAsNiArNDk3LDcgQEAgdm9p ZCBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0VGV4dE5vZGUoY29uc3QgU3RyaW5nJiBjaGFy YWN0ZXJzLCBXaGl0ZXNwYWNlTW8KICAgICAgICAgfHwgKHdoaXRlc3BhY2VNb2RlID09IFdoaXRl c3BhY2VVbmtub3duICYmIGlzQWxsV2hpdGVzcGFjZShjaGFyYWN0ZXJzKSk7CiAKICAgICB1bnNp Z25lZCBjdXJyZW50UG9zaXRpb24gPSAwOworICAgIHVuc2lnbmVkIGxlbmd0aExpbWl0ID0gc2hv dWxkVXNlTGVuZ3RoTGltaXQodGFzay5wYXJlbnQuZ2V0KCkpID8gVGV4dDo6ZGVmYXVsdExlbmd0 aExpbWl0IDogc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpOwogCiAgICAgLy8g RklYTUU6IFNwbGl0dGluZyB0ZXh0IG5vZGVzIGludG8gc21hbGxlciBjaHVua3MgY29udHJhZGlj dHMgSFRNTDUgc3BlYywgYnV0IGlzIGN1cnJlbnRseSBuZWNlc3NhcnkKICAgICAvLyBmb3IgcGVy Zm9ybWFuY2UsIHNlZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1 ODk4Pi4KQEAgLTQ5OSwxMSArNTA3LDExIEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omlu c2VydFRleHROb2RlKGNvbnN0IFN0cmluZyYgY2hhcmFjdGVycywgV2hpdGVzcGFjZU1vCiAgICAg ICAgIC8vIEZJWE1FOiBXZSdyZSBvbmx5IHN1cHBvc2VkIHRvIGFwcGVuZCB0byB0aGlzIHRleHQg bm9kZSBpZiBpdAogICAgICAgICAvLyB3YXMgdGhlIGxhc3QgdGV4dCBub2RlIGluc2VydGVkIGJ5 IHRoZSBwYXJzZXIuCiAgICAgICAgIENoYXJhY3RlckRhdGEqIHRleHROb2RlID0gc3RhdGljX2Nh c3Q8Q2hhcmFjdGVyRGF0YSo+KHByZXZpb3VzQ2hpbGQpOwotICAgICAgICBjdXJyZW50UG9zaXRp b24gPSB0ZXh0Tm9kZS0+cGFyc2VyQXBwZW5kRGF0YShjaGFyYWN0ZXJzLCAwLCBUZXh0OjpkZWZh dWx0TGVuZ3RoTGltaXQpOworICAgICAgICBjdXJyZW50UG9zaXRpb24gPSB0ZXh0Tm9kZS0+cGFy c2VyQXBwZW5kRGF0YShjaGFyYWN0ZXJzLCAwLCBsZW5ndGhMaW1pdCk7CiAgICAgfQogCiAgICAg d2hpbGUgKGN1cnJlbnRQb3NpdGlvbiA8IGNoYXJhY3RlcnMubGVuZ3RoKCkpIHsKLSAgICAgICAg UmVmUHRyPFRleHQ+IHRleHROb2RlID0gVGV4dDo6Y3JlYXRlV2l0aExlbmd0aExpbWl0KHRhc2su cGFyZW50LT5kb2N1bWVudCgpLCBzaG91bGRVc2VBdG9taWNTdHJpbmcgPyBBdG9taWNTdHJpbmco Y2hhcmFjdGVycykuc3RyaW5nKCkgOiBjaGFyYWN0ZXJzLCBjdXJyZW50UG9zaXRpb24pOworICAg ICAgICBSZWZQdHI8VGV4dD4gdGV4dE5vZGUgPSBUZXh0OjpjcmVhdGVXaXRoTGVuZ3RoTGltaXQo dGFzay5wYXJlbnQtPmRvY3VtZW50KCksIHNob3VsZFVzZUF0b21pY1N0cmluZyA/IEF0b21pY1N0 cmluZyhjaGFyYWN0ZXJzKS5zdHJpbmcoKSA6IGNoYXJhY3RlcnMsIGN1cnJlbnRQb3NpdGlvbiwg bGVuZ3RoTGltaXQpOwogICAgICAgICAvLyBJZiB3ZSBoYXZlIGEgd2hvbGUgc3RyaW5nIG9mIHVu YnJlYWthYmxlIGNoYXJhY3RlcnMgdGhlIGFib3ZlIGNvdWxkIGxlYWQgdG8gYW4gaW5maW5pdGUg bG9vcC4gRXhjZWVkaW5nIHRoZSBsZW5ndGggbGltaXQgaXMgdGhlIGxlc3NlciBldmlsLgogICAg ICAgICBpZiAoIXRleHROb2RlLT5sZW5ndGgoKSkgewogICAgICAgICAgICAgU3RyaW5nIHN1YnN0 cmluZyA9IGNoYXJhY3RlcnMuc3Vic3RyaW5nKGN1cnJlbnRQb3NpdGlvbik7Cg==