117201 2013-06-04 08:48:27 -0700 AX: WK2: accessibility position is calculated every time window frame is updated 2013-06-04 13:05:35 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach commit-queue sam thorton oldest_to_newest 896918 0 cfleizach 2013-06-04 08:48:27 -0700 Evertyime WKView:_updateWIndowAndFrames is called, the AX position is also calculated. This impacts performance for all users. 896919 1 203703 cfleizach 2013-06-04 08:51:02 -0700 Created attachment 203703 patch 896954 2 203703 thorton 2013-06-04 10:33:23 -0700 Comment on attachment 203703 patch View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:460 > + if (WebCore::AXObjectCache::accessibilityEnabled()) does this really work in the UIProcess? how? 896956 3 cfleizach 2013-06-04 10:36:00 -0700 (In reply to comment #2) > (From update of attachment 203703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review > > > Source/WebKit2/UIProcess/API/mac/WKView.mm:460 > > + if (WebCore::AXObjectCache::accessibilityEnabled()) > > does this really work in the UIProcess? how? it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it 896985 4 203703 thorton 2013-06-04 11:31:16 -0700 Comment on attachment 203703 patch View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review >>> Source/WebKit2/UIProcess/API/mac/WKView.mm:460 >>> + if (WebCore::AXObjectCache::accessibilityEnabled()) >> >> does this really work in the UIProcess? how? > > it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it OK, separate values tracking the same thing in the same place, but not needing to be kept in sync explicitly. 896988 5 cfleizach 2013-06-04 11:34:04 -0700 (In reply to comment #4) > (From update of attachment 203703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review > > >>> Source/WebKit2/UIProcess/API/mac/WKView.mm:460 > >>> + if (WebCore::AXObjectCache::accessibilityEnabled()) > >> > >> does this really work in the UIProcess? how? > > > > it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it > > OK, separate values tracking the same thing in the same place, but not needing to be kept in sync explicitly. correct 897006 6 203703 commit-queue 2013-06-04 13:05:32 -0700 Comment on attachment 203703 patch Clearing flags on attachment: 203703 Committed r151181: <http://trac.webkit.org/changeset/151181> 897007 7 commit-queue 2013-06-04 13:05:35 -0700 All reviewed patches have been landed. Closing bug. 203703 2013-06-04 08:51:02 -0700 2013-06-04 13:05:32 -0700 patch patch text/plain 4446 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTE3MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA2LTA0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdLMjogYWNjZXNz aWJpbGl0eSBwb3NpdGlvbiBpcyBjYWxjdWxhdGVkIGV2ZXJ5IHRpbWUgd2luZG93IGZyYW1lIGlz IHVwZGF0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNzIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9ubHkgY2FsY3VsYXRlIHRoZSBBWCBwb3NpdGlvbiBpZiBBWCBoYXMgYWxyZWFkeSBiZWVuIGVu YWJsZWQgd2hlbiB1cGRhdGluZyB0aGUKKyAgICAgICAgV0tWaWV3J3Mgd2luZG93IGFuZCBmcmFt ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1b V0tWaWV3IF91cGRhdGVXaW5kb3dBbmRWaWV3RnJhbWVzXSk6CisgICAgICAgICgtW1dLVmlldyBf YWNjZXNzaWJpbGl0eVJlZ2lzdGVyVUlQcm9jZXNzVG9rZW5zXSk6CisgICAgICAgICAgICBEb24n dCBjYWxsIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTogaGVyZSBiZWNhdXNlIGl0IGNvdWxk IGVuYWJsZSBhY2Nlc3NpYmlsaXR5IHByZW1hdHVyZWx5LgorICAgICAgICAoLVtXS1ZpZXcgZW5h YmxlQWNjZXNzaWJpbGl0eUlmTmVjZXNzYXJ5XSk6CisgICAgICAgICAgICBBZnRlciBlbmFibGlu ZyBBWCBmb3IgdGhlIGZpcnN0IHRpbWUsIGFsc28gdXBkYXRlIHRoZSBmcmFtZSBzbyB0aGF0IHRo ZSBBWCBwb3NpdGlvbiBpcyBjb3JyZWN0LgorICAgICAgICAoLVtXS1ZpZXcgYWNjZXNzaWJpbGl0 eUZvY3VzZWRVSUVsZW1lbnRdKToKKyAgICAgICAgKC1bV0tWaWV3IGFjY2Vzc2liaWxpdHlIaXRU ZXN0Ol0pOgorICAgICAgICAoLVtXS1ZpZXcgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOl0p OgorICAgICAgICAgICAgVGVsbCB0aGUgQVhPYmplY3RDYWNoZSB0aGF0IEFYIGlzIG5vdyBlbmFi bGVkLgorCiAyMDEzLTA2LTA0ICBNaWNoYcWCIFBha3XFgmEgdmVsIFJ1dGthICA8bS5wYWt1bGFA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGbF1bV0syXSBTdWIgbWVudSBpdGVtcyBzaG91bGQg YmUgb2YgRVdLX1NVQk1FTlVfVFlQRSBhbmQgbm90IGNoZWNrYWJsZQpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMTUxMTI2KQorKysg U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC02Niw2ICs2Niw3IEBACiAjaW1wb3J0ICJXZWJQcm9jZXNzUHJveHkuaCIKICNpbXBvcnQg IldlYlN5c3RlbUludGVyZmFjZS5oIgogI2ltcG9ydCA8UXVhcnR6Q29yZS9RdWFydHpDb3JlLmg+ CisjaW1wb3J0IDxXZWJDb3JlL0FYT2JqZWN0Q2FjaGUuaD4KICNpbXBvcnQgPFdlYkNvcmUvQ29s b3JNYWMuaD4KICNpbXBvcnQgPFdlYkNvcmUvRHJhZ0NvbnRyb2xsZXIuaD4KICNpbXBvcnQgPFdl YkNvcmUvRHJhZ0RhdGEuaD4KQEAgLTQ1NSw3ICs0NTYsOSBAQAogLSAodm9pZClfdXBkYXRlV2lu ZG93QW5kVmlld0ZyYW1lcwogewogICAgIE5TUmVjdCB2aWV3RnJhbWVJbldpbmRvd0Nvb3JkaW5h dGVzID0gW3NlbGYgY29udmVydFJlY3Q6W3NlbGYgZnJhbWVdIHRvVmlldzpuaWxdOwotICAgIE5T UG9pbnQgYWNjZXNzaWJpbGl0eVBvc2l0aW9uID0gW1tzZWxmIGFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlQb3NpdGlvbkF0dHJpYnV0ZV0gcG9pbnRWYWx1ZV07Cisg ICAgTlNQb2ludCBhY2Nlc3NpYmlsaXR5UG9zaXRpb24gPSBOU01ha2VQb2ludCgwLCAwKTsKKyAg ICBpZiAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkKKyAg ICAgICAgYWNjZXNzaWJpbGl0eVBvc2l0aW9uID0gW1tzZWxmIGFjY2Vzc2liaWxpdHlBdHRyaWJ1 dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlQb3NpdGlvbkF0dHJpYnV0ZV0gcG9pbnRWYWx1ZV07CiAg ICAgCiAgICAgX2RhdGEtPl9wYWdlLT53aW5kb3dBbmRWaWV3RnJhbWVzQ2hhbmdlZCh2aWV3RnJh bWVJbldpbmRvd0Nvb3JkaW5hdGVzLCBhY2Nlc3NpYmlsaXR5UG9zaXRpb24pOwogICAgIGlmIChf ZGF0YS0+X2NsaXBzVG9WaXNpYmxlUmVjdCkKQEAgLTIxOTQsNyArMjE5Nyw3IEBACiB7CiAgICAg Ly8gSW5pdGlhbGl6ZSByZW1vdGUgYWNjZXNzaWJpbGl0eSB3aGVuIHRoZSB3aW5kb3cgY29ubmVj dGlvbiBoYXMgYmVlbiBlc3RhYmxpc2hlZC4KICAgICBOU0RhdGEgKnJlbW90ZUVsZW1lbnRUb2tl biA9IFdLQVhSZW1vdGVUb2tlbkZvckVsZW1lbnQoc2VsZik7Ci0gICAgTlNEYXRhICpyZW1vdGVX aW5kb3dUb2tlbiA9IFdLQVhSZW1vdGVUb2tlbkZvckVsZW1lbnQoW3NlbGYgYWNjZXNzaWJpbGl0 eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVdpbmRvd0F0dHJpYnV0ZV0pOworICAgIE5T RGF0YSAqcmVtb3RlV2luZG93VG9rZW4gPSBXS0FYUmVtb3RlVG9rZW5Gb3JFbGVtZW50KFtzZWxm IHdpbmRvd10pOwogICAgIENvcmVJUEM6OkRhdGFSZWZlcmVuY2UgZWxlbWVudFRva2VuID0gQ29y ZUlQQzo6RGF0YVJlZmVyZW5jZShyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihbcmVt b3RlRWxlbWVudFRva2VuIGJ5dGVzXSksIFtyZW1vdGVFbGVtZW50VG9rZW4gbGVuZ3RoXSk7CiAg ICAgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSB3aW5kb3dUb2tlbiA9IENvcmVJUEM6OkRhdGFSZWZl cmVuY2UocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4oW3JlbW90ZVdpbmRvd1Rva2Vu IGJ5dGVzXSksIFtyZW1vdGVXaW5kb3dUb2tlbiBsZW5ndGhdKTsKICAgICBfZGF0YS0+X3BhZ2Ut PnJlZ2lzdGVyVUlQcm9jZXNzQWNjZXNzaWJpbGl0eVRva2VucyhlbGVtZW50VG9rZW4sIHdpbmRv d1Rva2VuKTsKQEAgLTIyMTYsOCArMjIxOSwyMSBAQAogICAgICAgICBXS0FYUmVnaXN0ZXJSZW1v dGVQcm9jZXNzKHJlZ2lzdGVyUHJvY2VzcywgcGlkKTsgCiB9CiAKKy0gKHZvaWQpZW5hYmxlQWNj ZXNzaWJpbGl0eUlmTmVjZXNzYXJ5Cit7CisgICAgaWYgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6 OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIEFmdGVy IGVuYWJsaW5nIGFjY2Vzc2liaWxpdHkgdXBkYXRlIHRoZSB3aW5kb3cgZnJhbWUgb24gdGhlIHdl YiBwcm9jZXNzIHNvIHRoYXQgdGhlCisgICAgLy8gY29ycmVjdCBhY2Nlc3NpYmlsaXR5IHBvc2l0 aW9uIGlzIHRyYW5zbWl0dGVkICh3aGVuIEFYIGlzIG9mZiwgdGhhdCBwb3NpdGlvbiBpcyBub3Qg Y2FsY3VsYXRlZCkuCisgICAgV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZW5hYmxlQWNjZXNzaWJp bGl0eSgpOworICAgIFtzZWxmIF91cGRhdGVXaW5kb3dBbmRWaWV3RnJhbWVzXTsKK30KKwogLSAo aWQpYWNjZXNzaWJpbGl0eUZvY3VzZWRVSUVsZW1lbnQKIHsKKyAgICBbc2VsZiBlbmFibGVBY2Nl c3NpYmlsaXR5SWZOZWNlc3NhcnldOworICAgIAogICAgIGlmIChfZGF0YS0+X3BkZlZpZXdDb250 cm9sbGVyKQogICAgICAgICByZXR1cm4gTlNBY2Nlc3NpYmlsaXR5VW5pZ25vcmVkRGVzY2VuZGFu dChfZGF0YS0+X3BkZlZpZXdDb250cm9sbGVyLT5wZGZWaWV3KCkpOwogCkBAIC0yMjMxLDYgKzIy NDcsOCBAQAogCiAtIChpZClhY2Nlc3NpYmlsaXR5SGl0VGVzdDooTlNQb2ludClwb2ludAogewor ICAgIFtzZWxmIGVuYWJsZUFjY2Vzc2liaWxpdHlJZk5lY2Vzc2FyeV07CisKICAgICBpZiAoX2Rh dGEtPl9wZGZWaWV3Q29udHJvbGxlcikKICAgICAgICAgcmV0dXJuIFtfZGF0YS0+X3BkZlZpZXdD b250cm9sbGVyLT5wZGZWaWV3KCkgYWNjZXNzaWJpbGl0eUhpdFRlc3Q6cG9pbnRdOwogICAgIApA QCAtMjIzOSw2ICsyMjU3LDggQEAKIAogLSAoaWQpYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVl OihOU1N0cmluZyopYXR0cmlidXRlCiB7CisgICAgW3NlbGYgZW5hYmxlQWNjZXNzaWJpbGl0eUlm TmVjZXNzYXJ5XTsKKwogICAgIGlmIChbYXR0cmlidXRlIGlzRXF1YWxUb1N0cmluZzpOU0FjY2Vz c2liaWxpdHlDaGlsZHJlbkF0dHJpYnV0ZV0pIHsKIAogICAgICAgICBpZCBjaGlsZCA9IG5pbDsK