117198 2013-06-04 07:43:42 -0700 [GTK] Forwarding headers not generated for incremental build 2013-06-05 05:26:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98410 0 w.bielawski w.bielawski commit-queue gustavo mrobinson zan oldest_to_newest 896895 0 w.bielawski 2013-06-04 07:43:42 -0700 When adding some includes in source files in Tools/ (like WebKitTestRunner/EventSendingController.cpp) a forwarding headers will not be generated for incremental build. 896899 1 203696 w.bielawski 2013-06-04 07:52:16 -0700 Created attachment 203696 Generate forwarding headers if needed even for incremental build 896900 2 w.bielawski 2013-06-04 07:53:12 -0700 Thanks for Zan Dobersek. 896903 3 203699 w.bielawski 2013-06-04 08:08:29 -0700 Created attachment 203699 Now with changelog 897198 4 203699 cgarcia 2013-06-05 02:17:41 -0700 Comment on attachment 203699 Now with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=203699&action=review Patch looks good to me, could you please update the changelog entry to match the bug? We have scripts that parse the changelog entries, so it's important to make sure they are generated correctly. Use the prepare-ChangeLog script to make sure. > Tools/ChangeLog:3 > + [GTK] Generate forwarding headers if needed even for incremental build. This doesn't match the bug title, you should use the Tools/Scripts/prepare-ChangeLog to generate the changelog entry. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=117198. And this doesn't finish with a period 897231 5 203786 w.bielawski 2013-06-05 03:29:21 -0700 Created attachment 203786 changelog generated with script (and --bug argument) Now prepare-ChangeLog had generated Title without period on the end. Is it correct? 897308 6 203786 commit-queue 2013-06-05 05:26:57 -0700 Comment on attachment 203786 changelog generated with script (and --bug argument) Clearing flags on attachment: 203786 Committed r151215: <http://trac.webkit.org/changeset/151215> 897309 7 commit-queue 2013-06-05 05:26:59 -0700 All reviewed patches have been landed. Closing bug. 203696 2013-06-04 07:52:16 -0700 2013-06-04 08:08:29 -0700 Generate forwarding headers if needed even for incremental build generateForwardingHeadersForIncrementalBuild.patch text/plain 663 w.bielawski ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0gYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2VmaWxlLmFtCmluZGV4IDI4YTMyMzguLjhlMzg4ODgg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0KKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmlsZS5hbQpAQCAtMSw1ICsxLDUgQEAKIAot c3RhbXAtd2Via2l0dGVzdHJ1bm5lci1mb3J3YXJkaW5nLWhlYWRlcnM6ICQoV2ViS2l0MikvU2Ny aXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwgJChQcm9ncmFtc19XZWJLaXRUZXN0 UnVubmVyX1NPVVJDRVMpCitzdGFtcC13ZWJraXR0ZXN0cnVubmVyLWZvcndhcmRpbmctaGVhZGVy czogJChXZWJLaXQyKS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKFBy b2dyYW1zX1dlYktpdFRlc3RSdW5uZXJfU09VUkNFUykgJChMaWJyYXJpZXNfbGliVGVzdFJ1bm5l ckluamVjdGVkQnVuZGxlX2xhX1NPVVJDRVMpCiAJJChBTV9WX0dFTikkKFBFUkwpICQ8ICQoc3Jj ZGlyKS9Ub29scy9XZWJLaXRUZXN0UnVubmVyICQoR0VOU09VUkNFU19XRUJLSVQyKS9pbmNsdWRl IGd0ayBcCiAJJiYgZWNobyB0aW1lc3RhbXAgPiAkKEBGKQoK 203699 2013-06-04 08:08:29 -0700 2013-06-05 03:29:21 -0700 Now with changelog generateForwardingHeadersForIncrementalBuild2.patch text/plain 1314 w.bielawski ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMGEw YmY3Li4yZGY2NmQwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDYtMDQgIFdvamNpZWNoIEJpZWxhd3NraSAg PHcuYmllbGF3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIEdlbmVyYXRlIGZvcndh cmRpbmcgaGVhZGVycyBpZiBuZWVkZWQgZXZlbiBmb3IgaW5jcmVtZW50YWwgYnVpbGQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcxOTguCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL0dOVW1ha2VmaWxlLmFtOiBsaWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUgYWRkZWQg dG8gZGVwZW5kZW5jaWVzLgorCiAyMDEzLTAxLTA3ICBXb2pjaWVjaCBCaWVsYXdza2kgIDx3LmJp ZWxhd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV0tUUl0gV2ViS2l0VGVzdFJ1bm5lcidz IGV2ZW50U2VuZGVyLmNvbnRleHRDbGljaygpIHJldHVybnMgb2JqZWN0cyB3aXRob3V0IGltcGxl bWVudGVkIGNsaWNrKCkgbWV0aG9kLgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9HTlVtYWtlZmlsZS5hbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0K aW5kZXggMjhhMzIzOC4uOGUzODg4OCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9HTlVtYWtlZmlsZS5hbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2VmaWxl LmFtCkBAIC0xLDUgKzEsNSBAQAogCi1zdGFtcC13ZWJraXR0ZXN0cnVubmVyLWZvcndhcmRpbmct aGVhZGVyczogJChXZWJLaXQyKS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5w bCAkKFByb2dyYW1zX1dlYktpdFRlc3RSdW5uZXJfU09VUkNFUykKK3N0YW1wLXdlYmtpdHRlc3Ry dW5uZXItZm9yd2FyZGluZy1oZWFkZXJzOiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJhdGUtZm9y d2FyZGluZy1oZWFkZXJzLnBsICQoUHJvZ3JhbXNfV2ViS2l0VGVzdFJ1bm5lcl9TT1VSQ0VTKSAk KExpYnJhcmllc19saWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVfbGFfU09VUkNFUykKIAkkKEFN X1ZfR0VOKSQoUEVSTCkgJDwgJChzcmNkaXIpL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIgJChHRU5T T1VSQ0VTX1dFQktJVDIpL2luY2x1ZGUgZ3RrIFwKIAkmJiBlY2hvIHRpbWVzdGFtcCA+ICQoQEYp CiAK 203786 2013-06-05 03:29:21 -0700 2013-06-05 05:26:57 -0700 changelog generated with script (and --bug argument) generateForwardingHeadersForIncrementalBuild4.patch text/plain 1245 w.bielawski ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYTE1 Njc0Li5kNzZhNWQxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDYtMDUgIFdvamNpZWNoIEJpZWxhd3NraSAg PHcuYmllbGF3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIEZvcndhcmRpbmcgaGVh ZGVycyBub3QgZ2VuZXJhdGVkIGZvciBpbmNyZW1lbnRhbCBidWlsZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MTk4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0dOVW1h a2VmaWxlLmFtOiBsaWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUgYWRkZWQgdG8gZGVwZW5kZW5j aWVzLgorCiAyMDEzLTA2LTA0ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbRUZMXSBGaWxlIGRpYWxvZyBvZiBNaW5pQnJvd3NlciBoYXZlIGJyb2tlbiBi YWNrZ3JvdW5kLgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmls ZS5hbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0KaW5kZXggMjhhMzIz OC4uOGUzODg4OCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmls ZS5hbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2VmaWxlLmFtCkBAIC0xLDUg KzEsNSBAQAogCi1zdGFtcC13ZWJraXR0ZXN0cnVubmVyLWZvcndhcmRpbmctaGVhZGVyczogJChX ZWJLaXQyKS9TY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVycy5wbCAkKFByb2dyYW1z X1dlYktpdFRlc3RSdW5uZXJfU09VUkNFUykKK3N0YW1wLXdlYmtpdHRlc3RydW5uZXItZm9yd2Fy ZGluZy1oZWFkZXJzOiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk ZXJzLnBsICQoUHJvZ3JhbXNfV2ViS2l0VGVzdFJ1bm5lcl9TT1VSQ0VTKSAkKExpYnJhcmllc19s aWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVfbGFfU09VUkNFUykKIAkkKEFNX1ZfR0VOKSQoUEVS TCkgJDwgJChzcmNkaXIpL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIgJChHRU5TT1VSQ0VTX1dFQktJ VDIpL2luY2x1ZGUgZ3RrIFwKIAkmJiBlY2hvIHRpbWVzdGFtcCA+ICQoQEYpCiAK