<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>117195</bug_id>
          
          <creation_ts>2013-06-04 06:46:02 -0700</creation_ts>
          <short_desc>[Qt] Font::shouldUseSmoothing() has fake dependency on Qt 5.1</short_desc>
          <delta_ts>2013-06-17 09:04:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>117699</dependson>
    
    <dependson>117702</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Allan Sandfeld Jensen">allan.jensen</reporter>
          <assigned_to name="Allan Sandfeld Jensen">allan.jensen</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jturcotte</cc>
    
    <cc>kadam</cc>
    
    <cc>noam</cc>
    
    <cc>ossy</cc>
    
    <cc>zarvai</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>896869</commentid>
    <comment_count>0</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-06-04 06:46:02 -0700</bug_when>
    <thetext>We should get rid of this fake dependency as the changes it causes could mask real regressions in Qt 5.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>896882</commentid>
    <comment_count>1</comment_count>
      <attachid>203693</attachid>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-06-04 07:05:16 -0700</bug_when>
    <thetext>Created attachment 203693
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>897065</commentid>
    <comment_count>2</comment_count>
    <who name="Zoltan Arvai">zarvai</who>
    <bug_when>2013-06-04 15:28:45 -0700</bug_when>
    <thetext>It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>897152</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-06-05 00:09:00 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :)

There isn&apos;t size limit. But I suggest rebasing in ~500 sized batches
to avoid LayoutTests/ChangeLog conflict during half an hour long commit.
And commit in an IDLE time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>897203</commentid>
    <comment_count>4</comment_count>
      <attachid>203693</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-06-05 02:29:01 -0700</bug_when>
    <thetext>Comment on attachment 203693
Patch

Clearing flags on attachment: 203693

Committed r151205: &lt;http://trac.webkit.org/changeset/151205&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>897204</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-06-05 02:29:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>203693</attachid>
            <date>2013-06-04 07:05:16 -0700</date>
            <delta_ts>2013-06-05 02:29:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-117195-20130604160346.patch</filename>
            <type>text/plain</type>
            <size>2028</size>
            <attacher name="Allan Sandfeld Jensen">allan.jensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFkNjhlNTg5MGQwMDJm
NGY4YzI3Y2U4YzFmMmEwYjY5OWExNmE5Ny4uZmVjMzk0YzVjNjg1NTZkNTdiNWY5MmFmYTkyZjhj
ZDBkOTYwM2IzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTA0ICBBbGxh
biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR
dF0gRm9udDo6c2hvdWxkVXNlU21vb3RoaW5nKCkgaGFzIGZha2UgZGVwZW5kZW5jeSBvbiBRdCA1
LjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzE5
NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92
ZSB0aGUgZmFrZSBkZXBlbmRlbmN5IG9uIFF0IDUuMSBzbyB3ZSBtYXkgcmViYXNlIHRoZSBsYXlv
dXQgdGVzdHMKKyAgICAgICAgYmVmb3JlIHN3aXRjaGluZyB0byBRdCA1LjEKKworICAgICAgICAq
IHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGFRdC5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRhKToKKwogMjAxMy0wNi0w
NCAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgVXNlIEFT
U0VSVF9ESVNBQkxFRCBvcHRpb24gZm9yIGFzc2VydGlvbiBwdXJwb3NlIGNvZGUgaW4gSW5saW5l
Qm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250
UGxhdGZvcm1EYXRhUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv
Rm9udFBsYXRmb3JtRGF0YVF0LmNwcAppbmRleCAzN2JmZDkyMzg1M2M3NTMzOGZhNjFlN2UyN2Qx
MjlkZTdjMzNlZWNjLi45NGYzYTkxYjBiNzMzNmU3OTEyY2E2ODljZmZmMzVmMmRiMDYxNTFjIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZv
cm1EYXRhUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0Zv
bnRQbGF0Zm9ybURhdGFRdC5jcHAKQEAgLTc0LDEyICs3NCw5IEBAIEZvbnRQbGF0Zm9ybURhdGE6
OkZvbnRQbGF0Zm9ybURhdGEoY29uc3QgRm9udERlc2NyaXB0aW9uJiBkZXNjcmlwdGlvbiwgY29u
c3QgQXRvCiAgICAgZm9udC5zZXRXZWlnaHQodG9RRm9udFdlaWdodChkZXNjcmlwdGlvbi53ZWln
aHQoKSkpOwogICAgIGZvbnQuc2V0V29yZFNwYWNpbmcod29yZFNwYWNpbmcpOwogICAgIGZvbnQu
c2V0TGV0dGVyU3BhY2luZyhRRm9udDo6QWJzb2x1dGVTcGFjaW5nLCBsZXR0ZXJTcGFjaW5nKTsK
LSAgICBpZiAoZGVzY3JpcHRpb24uZm9udFNtb290aGluZygpID09IE5vU21vb3RoaW5nKQorICAg
IGlmIChkZXNjcmlwdGlvbi5mb250U21vb3RoaW5nKCkgPT0gTm9TbW9vdGhpbmcKKyAgICAgICAg
fHwgKGRlc2NyaXB0aW9uLmZvbnRTbW9vdGhpbmcoKSA9PSBBdXRvU21vb3RoaW5nICYmICFGb250
OjpzaG91bGRVc2VTbW9vdGhpbmcoKSkpCiAgICAgICAgIGZvbnQuc2V0U3R5bGVTdHJhdGVneShR
Rm9udDo6Tm9BbnRpYWxpYXMpOwotI2lmIFFUX1ZFUlNJT04gPj0gUVRfVkVSU0lPTl9DSEVDSyg1
LCAxLCAwKQotICAgIGlmIChkZXNjcmlwdGlvbi5mb250U21vb3RoaW5nKCkgPT0gQXV0b1Ntb290
aGluZyAmJiAhRm9udDo6c2hvdWxkVXNlU21vb3RoaW5nKCkpCi0gICAgICAgIGZvbnQuc2V0U3R5
bGVTdHJhdGVneShRRm9udDo6Tm9BbnRpYWxpYXMpOwotI2VuZGlmCiAKICAgICBtX2RhdGEtPmJv
bGQgPSBmb250LmJvbGQoKTsKICAgICAvLyBXZWJLaXQgYWxsb3dzIGZvbnQgc2l6ZSB6ZXJvIGJ1
dCBRRm9udCBkb2VzIG5vdC4gV2Ugd2lsbCByZXR1cm4K
</data>

          </attachment>
      

    </bug>

</bugzilla>