117181 2013-06-03 23:59:26 -0700 Refactor the code that decides whether to enable WebGL from settings to helper functions 2013-06-04 11:25:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam commit-queue esprehn+autocc oldest_to_newest 896753 0 noam 2013-06-03 23:59:26 -0700 Refactor the code that decides whether to enable WebGL from settings to helper functions 896754 1 203657 noam 2013-06-04 00:02:41 -0700 Created attachment 203657 Patch 896759 2 203657 benjamin 2013-06-04 00:38:39 -0700 Comment on attachment 203657 Patch I like the idea but the name webGLEnabled(Settings*) is confusing. What about canRunWebGL() or ableToRunWebGL()? 896769 3 noam 2013-06-04 01:10:56 -0700 (In reply to comment #2) > (From update of attachment 203657 [details]) > I like the idea but the name webGLEnabled(Settings*) is confusing. > > What about canRunWebGL() or ableToRunWebGL()? How about shouldEnableWebGL(Settings*) ? 896870 4 203690 noam 2013-06-04 06:51:02 -0700 Created attachment 203690 Patch 896980 5 203690 commit-queue 2013-06-04 11:25:51 -0700 Comment on attachment 203690 Patch Clearing flags on attachment: 203690 Committed r151176: <http://trac.webkit.org/changeset/151176> 896981 6 commit-queue 2013-06-04 11:25:53 -0700 All reviewed patches have been landed. Closing bug. 203657 2013-06-04 00:02:41 -0700 2013-06-04 06:50:57 -0700 Patch bug-117181-20130604090111.patch text/plain 2653 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE0NGQxZTQ0MzFjZTc5 OWQ4YTllOWU5MDE5YzQzYjk3NGZjNDliOC4uNzI2MzQ2NjM4MTg1NWNiYzJlYmQ4ODk0Zjg2NGY1 NTM2MDY5NDA1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2LTAzICBOb2Ft IFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWZhY3RvciB0aGUgY29k ZSB0aGF0IGRlY2lkZXMgd2hldGhlciB0byBlbmFibGUgV2ViR0wgZnJvbSBzZXR0aW5ncyB0byBo ZWxwZXIgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTcxODEKKworICAgICAgICBUaGlzIHJlbW92ZXMgc29tZSAjaWZkZWYgY3J1ZCBv dXQgb2YgdGhlIGdldENvbnRleHQoKSBmdW5jdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6cmVxdWlyZXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yV2ViR0wp OgorICAgICAgICAoV2ViQ29yZTo6d2ViR0xFbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxDYW52YXNFbGVtZW50OjpnZXRDb250ZXh0KToKKwogMjAxMy0wNi0wMiAgQXJ1bnByYXNhZCBS YWprdW1hciAgPGFydXJhamt1QGNpc2NvLmNvbT4KIAogICAgICAgICBbUXRdIE1vdmUgUXQgcG9y dCBvZmYgbGVnYWN5IGNsaXBib2FyZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVt ZW50LmNwcAppbmRleCBjZjM4Mjc5MGEyNjNhMzAwZjRmOWMwN2Y1NDhmOTIwODViNGY5OTdjLi4w ZTI5MGYwMGFmMWM0NzFmNzI0Y2IyY2JiMzVhODZiNWM2NzVjNDAwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApAQCAtMTQ3LDYgKzE0NywzMSBAQCB2b2lkIEhU TUxDYW52YXNFbGVtZW50OjpzZXRXaWR0aChpbnQgdmFsdWUpCiAgICAgc2V0QXR0cmlidXRlKHdp ZHRoQXR0ciwgU3RyaW5nOjpudW1iZXIodmFsdWUpKTsKIH0KIAorI2lmIEVOQUJMRShXRUJHTCkK K3N0YXRpYyBib29sIHJlcXVpcmVzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvcldlYkdMKCkKK3sK KyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oUVQpCisgICAg cmV0dXJuIGZhbHNlOworI2Vsc2UKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorCit9CitzdGF0 aWMgYm9vbCB3ZWJHTEVuYWJsZWQoU2V0dGluZ3MqIHNldHRpbmdzKQoreworICAgIGlmICghc2V0 dGluZ3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghc2V0dGluZ3MtPndlYkdM RW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIXJlcXVpcmVzQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0ZvcldlYkdMKCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisg ICAgcmV0dXJuIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpOworfQor I2VuZGlmCisKIENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIEhUTUxDYW52YXNFbGVtZW50OjpnZXRD b250ZXh0KGNvbnN0IFN0cmluZyYgdHlwZSwgQ2FudmFzQ29udGV4dEF0dHJpYnV0ZXMqIGF0dHJz KQogewogICAgIC8vIEEgQ2FudmFzIGNhbiBlaXRoZXIgYmUgIjJEIiBvciAid2ViZ2wiIGJ1dCBu ZXZlciBib3RoLiBJZiB5b3UgcmVxdWVzdCBhIDJEIGNhbnZhcyBhbmQgdGhlIGV4aXN0aW5nCkBA IC0xNzYsMTQgKzIwMSw4IEBAIENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIEhUTUxDYW52YXNFbGVt ZW50OjpnZXRDb250ZXh0KGNvbnN0IFN0cmluZyYgdHlwZSwgQ2FudmFzCiAgICAgICAgIH0KICAg ICAgICAgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsKICAgICB9Ci0jaWYgRU5BQkxFKFdFQkdMKSAg ICAKLSAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBkb2N1bWVudCgpLT5zZXR0aW5ncygpOwotICAg IGlmIChzZXR0aW5ncyAmJiBzZXR0aW5ncy0+d2ViR0xFbmFibGVkKCkKLSNpZiAhUExBVEZPUk0o R1RLKSAmJiAhUExBVEZPUk0oRUZMKSAmJiAhUExBVEZPUk0oUVQpCi0gICAgICAgICYmIHNldHRp bmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpCi0jZW5kaWYKLSAgICAgICAgKSB7 Ci0KKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgaWYgKHdlYkdMRW5hYmxlZChkb2N1bWVudCgpLT5z ZXR0aW5ncygpKSkgewogICAgICAgICAvLyBBY2NlcHQgdGhlIGxlZ2FjeSAid2Via2l0LTNkIiBu YW1lIGFzIHdlbGwgYXMgdGhlIHByb3Zpc2lvbmFsICJleHBlcmltZW50YWwtd2ViZ2wiIG5hbWUu CiAgICAgICAgIGJvb2wgaXMzZENvbnRleHQgPSAodHlwZSA9PSAid2Via2l0LTNkIikgfHwgKHR5 cGUgPT0gImV4cGVyaW1lbnRhbC13ZWJnbCIpOwogCg== 203690 2013-06-04 06:51:02 -0700 2013-06-04 11:25:51 -0700 Patch bug-117181-20130604154928.patch text/plain 2670 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE0NGQxZTQ0MzFjZTc5 OWQ4YTllOWU5MDE5YzQzYjk3NGZjNDliOC4uZGZkZTE2NGFiNzZhYWU0M2EwMTQ1M2E5MjgxYmEy NmM0NzMzNjI3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2LTAzICBOb2Ft IFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWZhY3RvciB0aGUgY29k ZSB0aGF0IGRlY2lkZXMgd2hldGhlciB0byBlbmFibGUgV2ViR0wgZnJvbSBzZXR0aW5ncyB0byBo ZWxwZXIgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTcxODEKKworICAgICAgICBUaGlzIHJlbW92ZXMgc29tZSAjaWZkZWYgY3J1ZCBv dXQgb2YgdGhlIGdldENvbnRleHQoKSBmdW5jdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBC ZW5qYW1pbiBQb3VsYWluLgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpyZXF1aXJlc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JXZWJH TCk6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRFbmFibGVXZWJHTCk6CisgICAgICAgIChXZWJD b3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dCk6CisKIDIwMTMtMDYtMDIgIEFydW5w cmFzYWQgUmFqa3VtYXIgIDxhcnVyYWprdUBjaXNjby5jb20+CiAKICAgICAgICAgW1F0XSBNb3Zl IFF0IHBvcnQgb2ZmIGxlZ2FjeSBjbGlwYm9hcmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2Fu dmFzRWxlbWVudC5jcHAKaW5kZXggY2YzODI3OTBhMjYzYTMwMGY0ZjljMDdmNTQ4ZjkyMDg1YjRm OTk3Yy4uNmU4YmE3YTFjNmJiZDUwY2NjM2I4NDQxNWMyOWNkZTVhYTczMzdkNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKQEAgLTE0Nyw2ICsxNDcsMzEgQEAg dm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6c2V0V2lkdGgoaW50IHZhbHVlKQogICAgIHNldEF0dHJp YnV0ZSh3aWR0aEF0dHIsIFN0cmluZzo6bnVtYmVyKHZhbHVlKSk7CiB9CiAKKyNpZiBFTkFCTEUo V0VCR0wpCitzdGF0aWMgYm9vbCByZXF1aXJlc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JXZWJH TCgpCit7CisjaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpIHx8IFBMQVRGT1JNKFFU KQorICAgIHJldHVybiBmYWxzZTsKKyNlbHNlCisgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKKwor fQorc3RhdGljIGJvb2wgc2hvdWxkRW5hYmxlV2ViR0woU2V0dGluZ3MqIHNldHRpbmdzKQorewor ICAgIGlmICghc2V0dGluZ3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghc2V0 dGluZ3MtPndlYkdMRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAo IXJlcXVpcmVzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvcldlYkdMKCkpCisgICAgICAgIHJldHVy biB0cnVlOworCisgICAgcmV0dXJuIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5h YmxlZCgpOworfQorI2VuZGlmCisKIENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIEhUTUxDYW52YXNF bGVtZW50OjpnZXRDb250ZXh0KGNvbnN0IFN0cmluZyYgdHlwZSwgQ2FudmFzQ29udGV4dEF0dHJp YnV0ZXMqIGF0dHJzKQogewogICAgIC8vIEEgQ2FudmFzIGNhbiBlaXRoZXIgYmUgIjJEIiBvciAi d2ViZ2wiIGJ1dCBuZXZlciBib3RoLiBJZiB5b3UgcmVxdWVzdCBhIDJEIGNhbnZhcyBhbmQgdGhl IGV4aXN0aW5nCkBAIC0xNzYsMTQgKzIwMSw4IEBAIENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIEhU TUxDYW52YXNFbGVtZW50OjpnZXRDb250ZXh0KGNvbnN0IFN0cmluZyYgdHlwZSwgQ2FudmFzCiAg ICAgICAgIH0KICAgICAgICAgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsKICAgICB9Ci0jaWYgRU5B QkxFKFdFQkdMKSAgICAKLSAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBkb2N1bWVudCgpLT5zZXR0 aW5ncygpOwotICAgIGlmIChzZXR0aW5ncyAmJiBzZXR0aW5ncy0+d2ViR0xFbmFibGVkKCkKLSNp ZiAhUExBVEZPUk0oR1RLKSAmJiAhUExBVEZPUk0oRUZMKSAmJiAhUExBVEZPUk0oUVQpCi0gICAg ICAgICYmIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpCi0jZW5kaWYK LSAgICAgICAgKSB7Ci0KKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgaWYgKHNob3VsZEVuYWJsZVdl YkdMKGRvY3VtZW50KCktPnNldHRpbmdzKCkpKSB7CiAgICAgICAgIC8vIEFjY2VwdCB0aGUgbGVn YWN5ICJ3ZWJraXQtM2QiIG5hbWUgYXMgd2VsbCBhcyB0aGUgcHJvdmlzaW9uYWwgImV4cGVyaW1l bnRhbC13ZWJnbCIgbmFtZS4KICAgICAgICAgYm9vbCBpczNkQ29udGV4dCA9ICh0eXBlID09ICJ3 ZWJraXQtM2QiKSB8fCAodHlwZSA9PSAiZXhwZXJpbWVudGFsLXdlYmdsIik7CiAK