11718 2006-11-29 11:20:27 -0800 REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe continues to scroll automatically. 2006-12-08 10:44:16 -0800 1 1 1 Unclassified WebKit Frames 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P1 Major --- 1 c.petersen87 ap oldest_to_newest 43827 0 c.petersen87 2006-11-29 11:20:27 -0800 11/29/06 8:30 AM Chris Petersen: * SUMMARY After I mouse up after dragging a selection outside of the iframe, the iframe continues to scroll. This is the wrong behavior since scrolling should stop in iframe after I mouse up (outside of the iframe). This regression first started with Webkit Nightly r17582 since this works with the previous nightly r17566. * STEPS TO REPRODUCE 1. With webkit nightly r17582 or newer, open test case "iframe_test.html" 2. Place in focus in the iframe and mouse down. Start to drag a selection over text in the iframe and continue to mouse down. Move the cursor so that it just outside the bottom of iframe. This should cause the iframe to scroll. 3. Now, mouse up while the iframe is scrolling. Notice the iframe DOESN'T stop scrolling when you mouse up. * RESULTS iFrame scrolling should stop when mousing up outside of iframe but doesn't. * REGRESSION Yes, this doesn't happen in stock Safari under Tiger. 43821 1 c.petersen87 2006-11-29 11:20:49 -0800 I believe this is the likely candidate that caused this regression: http://trac.webkit.org/projects/webkit/changeset/17574 43822 2 c.petersen87 2006-11-29 11:22:06 -0800 This is filed as <rdar://problem/4854259> 43823 3 11670 c.petersen87 2006-11-29 11:23:17 -0800 Created attachment 11670 iFrame test case 43536 4 11714 ap 2006-12-02 12:16:30 -0800 Created attachment 11714 proposed fix This fix makes an EventHandler hold a reference to a subframe's node in m_mousePressNode - previously, this data member wasn't reset for subframe events, continuing to reference nodes from earlier actions. There seems to be a lot of duplication in EventHandler data members at the moment (m_mousePressNode vs. m_clickNode; m_bMousePressed vs. m_mousePressed). I chose not to attempt merging any of these in this patch, and plan to file a follow-up bug. 42943 5 11714 ggaren 2006-12-07 15:17:57 -0800 Comment on attachment 11714 proposed fix r=me Please do file that follow-up bug. 42782 6 ap 2006-12-08 10:44:16 -0800 Committed revision 18079. Filed follow-up bug 11784. 11670 2006-11-29 11:23:17 -0800 2006-11-29 11:23:17 -0800 iFrame test case iframe_test.html text/html 141 c.petersen87 PGhlYWQ+Cjx0aXRsZT4KSUZSQU1FCjwvdGl0bGU+Cgo8L2hlYWQ+Cgo8Ym9keT4KCjxJRlJBTUUg U1JDPSJodHRwOi8vd3d3LmlldGYub3JnL3JmYy9yZmMyNDc1LnR4dCIgRlJBTUVCT1JERVI9MT48 L0lGUkFNRT4KCjwvYm9keT4KCjwvaHRtbD4K 11714 2006-12-02 12:16:30 -0800 2006-12-07 15:17:57 -0800 proposed fix 11718r1_patch.txt text/plain 4575 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzk4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDYtMTItMDIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzE4CisgICAgICAgIFJF R1JFU1NJT046IFdoZW4gSSBtb3VzZSB1cCBhZnRlciBkcmFnZ2luZyBhIHNlbGVjdGlvbiBvdXRz aWRlIG9mIGEgaWZyYW1lLCB0aGUgaWZyYW1lCisgICAgICAgIGNvbnRpbnVlcyB0byBzY3JvbGwg YXV0b21hdGljYWxseS4KKworICAgICAgICBUZXN0OiBtYW51YWwtdGVzdHMvYXV0b3Njcm9sbC5o dG1sCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvYXV0b3Njcm9sbC5odG1sOiBBZGRlZC4KKwor ICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50 SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KToKKyAgICAgICAgQXNzaWduIHRvIG1fbW91 c2VQcmVzc05vZGUgZWFybGllciwgc28gdGhhdCBpdCBpcyBhdmFpbGFibGUgaW4gdGhlIHN1cGVy ZnJhbWUgYXMgd2VsbC4KKyAgICAgICAgUmVzZXQgbV9tb3VzZURvd25XYXNJblN1YmZyYW1lIHRv IGZhbHNlIHdoZW4gc3RhcnRpbmcgdG8gaGFuZGxlIGEgbW91c2Vkb3duIC0gcHJldmlvdXNseSwg aXRzIHZhbHVlCisgICAgICAgIHdhcyBvbmx5IGRlZmluZWQgaWYgdGhlIGV2ZW50IHdhcyBwYXNz ZWQgZG93biB0byBhIHdpZGdldCBvciBhIHN1YmZyYW1lLgorCisgICAgICAgIChXZWJDb3JlOjpF dmVudEhhbmRsZXI6OnN0b3BBdXRvc2Nyb2xsVGltZXIpOgorICAgICAgICBJZiB0aGUgbW91c2Ug ZG93biBldmVudCB3YXMgaW4gYSBzdWJmcmFtZSwgc3RvcCB0aGUgc3ViZnJhbWUncyB0aW1lci4K KwogMjAwNi0xMi0wMiAgSm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW0gT21lcm5pY2sKSW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3Rz L2F1dG9zY3JvbGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9hdXRv c2Nyb2xsLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9hdXRvc2Ny b2xsLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjggQEAKKzxoZWFkPgorPHNjcmlwdD4K K2Z1bmN0aW9uIGFkZEZyYW1lVGV4dCgpIHsKKyAgZnJhbWVEb2MgPSB3aW5kb3cuZnJhbWVzWzBd LmRvY3VtZW50OworICBpdGVtID0gZnJhbWVEb2MuY3JlYXRlRWxlbWVudCgicCIpOworICBpdGVt LmFwcGVuZENoaWxkKGZyYW1lRG9jLmNyZWF0ZVRleHROb2RlKCJIZWxsbywgd29ybGQhIikpOwor ICBmb3IgKGkgPSAwOyBpIDwgMTAwMDsgKytpKSB7CisgICAgZnJhbWVEb2MuYm9keS5hcHBlbmRD aGlsZChpdGVtLmNsb25lTm9kZSh0cnVlKSk7CisgIH0KK30KKzwvc2NyaXB0PgorPC9oZWFkPgor Cis8Ym9keSBvbmxvYWQ9ImphdmFzY3JpcHQ6YWRkRnJhbWVUZXh0KCkiPgorCis8cD5UZXN0IGZv ciA8YSBocmVmPSJodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcxOCI+ YnVnIDExNzE4PC9hPjoKK1doZW4gSSBtb3VzZSB1cCBhZnRlciBkcmFnZ2luZyBhIHNlbGVjdGlv biBvdXRzaWRlIG9mIGEgaWZyYW1lLCB0aGUgaWZyYW1lIGNvbnRpbnVlcyB0byBzY3JvbGwgYXV0 b21hdGljYWxseS48L3A+CisKKzxwPk1ha2UgdGhlIGZyYW1lIGF1dG9zY3JvbGwgYnkgbW92aW5n IHRoZSBtb3VzZSBwb2ludGVyIG91dHNpZGUgb2YgaXQgd2hpbGUgc2VsZWN0aW5nLiAKK0F1dG9z Y3JvbGxpbmcgc2hvdWxkIHN0b3Agd2hlbiB5b3UgcmVsZWFzZSB0aGUgbW91c2UgYnV0dG9uIG91 dHNpZGUgdGhlIGZyYW1lIChpbiB0aGUgbWFpbiBmcmFtZSwgCitpbiBhbm90aGVyIHN1YmZyYW1l LCBvciBqdXN0IG91dHNpZGUgdGhlIHdpbmRvdykuPC9wPgorCis8SUZSQU1FIEZSQU1FQk9SREVS PTE+PC9JRlJBTUU+Cis8YnI+Cis8SUZSQU1FIEZSQU1FQk9SREVSPTE+PC9JRlJBTUU+CisKKzwv Ym9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IFdlYkNvcmUvbWFudWFsLXRlc3Rz L2F1dG9zY3JvbGwuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0 L2h0bWwKCkluZGV4OiBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkocmV2aXNpb24gMTc5ODQpCisrKyBXZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAK IC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgQXBwbGUgQ29tcHV0ZXIsIEluYy4gIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDYgQWxleGV5IFByb3NrdXJ5YWtvdiAo YXBAd2Via2l0Lm9yZykKICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNjcsNiAr NjgsOCBAQCB1c2luZyBuYW1lc3BhY2UgU1ZHTmFtZXM7CiAKIGNvbnN0IGRvdWJsZSBhdXRvc2Ny b2xsSW50ZXJ2YWwgPSAwLjE7CiAKK3N0YXRpYyBGcmFtZSogc3ViZnJhbWVGb3JUYXJnZXROb2Rl KE5vZGUqIG5vZGUpOworCiBFdmVudEhhbmRsZXI6OkV2ZW50SGFuZGxlcihGcmFtZSogZnJhbWUp CiAgICAgOiBtX2ZyYW1lKGZyYW1lKQogICAgICwgbV9iTW91c2VQcmVzc2VkKGZhbHNlKQpAQCAt MjQ1LDggKzI0OCw2IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQK ICAgICAvLyBDYXJlZnVsIHRoYXQgdGhlIGRyYWcgc3RhcnRpbmcgbG9naWMgc3RheXMgaW4gc3lu YyB3aXRoIGV2ZW50TWF5U3RhcnREcmFnKCkKICAgICBtX21vdXNlRG93bk1heVN0YXJ0RHJhZyA9 IHNpbmdsZUNsaWNrOwogCi0gICAgbV9tb3VzZVByZXNzTm9kZSA9IGV2ZW50LnRhcmdldE5vZGUo KTsKLSAgICAKICAgICBpZiAocGFzc1dpZGdldE1vdXNlRG93bkV2ZW50VG9XaWRnZXQoZXZlbnQp KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIApAQCAtNDYzLDYgKzQ2NCwxMiBAQCB2b2lkIEV2ZW50 SGFuZGxlcjo6c3RhcnRBdXRvc2Nyb2xsVGltZXIoCiAKIHZvaWQgRXZlbnRIYW5kbGVyOjpzdG9w QXV0b3Njcm9sbFRpbWVyKGJvb2wgcmVuZGVyZXJJc0JlaW5nRGVzdHJveWVkKQogeworICAgIGlm IChtX21vdXNlRG93bldhc0luU3ViZnJhbWUpIHsKKyAgICAgICAgRnJhbWUqIHN1YmZyYW1lID0g c3ViZnJhbWVGb3JUYXJnZXROb2RlKG1fbW91c2VQcmVzc05vZGUuZ2V0KCkpOworICAgICAgICBz dWJmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPnN0b3BBdXRvc2Nyb2xsVGltZXIocmVuZGVyZXJJc0Jl aW5nRGVzdHJveWVkKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlmICghcmVuZGVy ZXJJc0JlaW5nRGVzdHJveWVkICYmIGF1dG9zY3JvbGxSZW5kZXJlcigpKQogICAgICAgICBhdXRv c2Nyb2xsUmVuZGVyZXIoKS0+c3RvcEF1dG9zY3JvbGwoKTsKICAgICBzZXRBdXRvc2Nyb2xsUmVu ZGVyZXIoMCk7CkBAIC02NzQsNiArNjgxLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1v dXNlUHJlc3NFdmVudAogCiAgICAgbV9tb3VzZVByZXNzZWQgPSB0cnVlOwogICAgIG1fY3VycmVu dE1vdXNlUG9zaXRpb24gPSBtb3VzZUV2ZW50LnBvcygpOworICAgIG1fbW91c2VEb3duV2FzSW5T dWJmcmFtZSA9IGZhbHNlOwogICAgIAogICAgIE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMg bWV2ID0gcHJlcGFyZU1vdXNlRXZlbnQoZmFsc2UsIHRydWUsIGZhbHNlLCBtb3VzZUV2ZW50KTsK IApAQCAtNjgyLDYgKzY5MCw4IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNz RXZlbnQKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIG1fbW91c2VQcmVzc05v ZGUgPSBtZXYudGFyZ2V0Tm9kZSgpOworCiAgICAgRnJhbWUqIHN1YmZyYW1lID0gc3ViZnJhbWVG b3JUYXJnZXROb2RlKG1ldi50YXJnZXROb2RlKCkpOwogICAgIGlmIChzdWJmcmFtZSAmJiBwYXNz TW91c2VQcmVzc0V2ZW50VG9TdWJmcmFtZShtZXYsIHN1YmZyYW1lKSkgewogICAgICAgICBpbnZh bGlkYXRlQ2xpY2soKTsK