117163 2013-06-03 12:56:09 -0700 [WK2] REGRESSION(r150798): scrolling coordinator is not being enabled when WebPage is set to use fixed layout 2013-06-03 15:06:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 marcelo.lira marcelo.lira cmarcelo commit-queue darin kling luiz noam zeno oldest_to_newest 896581 0 marcelo.lira 2013-06-03 12:56:09 -0700 Since WebPageProxy can be created and methods called when no underlying WebPage exists yet, a call to WebPageProxy::setUseFixedLayout(...) will only be delivered to WebProcess by the IPC mechanism after the WebPage is created. But it is WebPage constructor that creates a DrawingArea, that calls enterAcceleratedCompositingMode(), that creates a CoordinatedLayerTreeHost, that calls WebKit::WebPage::settings()->setScrollingCoordinatorEnabled(true), if fixed layout is true. The call to WebPage::setUseFixedLayout() comes too late, and the scrolling coordinated is never enabled. 896583 1 203622 marcelo.lira 2013-06-03 13:15:43 -0700 Created attachment 203622 Patch 896619 2 203622 noam 2013-06-03 14:28:29 -0700 Comment on attachment 203622 Patch LGTM, please ask for owner review 896634 3 203622 commit-queue 2013-06-03 15:06:38 -0700 Comment on attachment 203622 Patch Clearing flags on attachment: 203622 Committed r151132: <http://trac.webkit.org/changeset/151132> 896635 4 commit-queue 2013-06-03 15:06:41 -0700 All reviewed patches have been landed. Closing bug. 203622 2013-06-03 13:15:43 -0700 2013-06-03 15:06:38 -0700 Patch bug-117163-20130603171415.patch text/plain 2753 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzdmOTJmOWQwMjNkMzUy YjU2NDdmMTU1MDExYjMxZmIzYzJlMDhlMy4uMjAyNzUzODgwY2ViMzc4NjM4MWIyOTg0ZGZiMjkw OWRjYjNiNzg5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA2LTAzICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbV0syXSBS RUdSRVNTSU9OKHIxNTA3OTgpOiBzY3JvbGxpbmcgY29vcmRpbmF0b3IgaXMgbm90IGJlaW5nIGVu YWJsZWQgd2hlbiBXZWJQYWdlIGlzIHNldCB0byB1c2UgZml4ZWQgbGF5b3V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcxNjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlZCBjYWxsIHRvIFdlYlBh Z2U6OnNldHRpbmdzKCktPnNldFNjcm9sbGluZ0Nvb3JkaW5hdG9yRW5hYmxlZCgpCisgICAgICAg IGZyb20gQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0IGNvbnN0cnVjdG9yIHRvIFdlYlBhZ2U6OnNl dFVzZUZpeGVkTGF5b3V0KCkuCisgICAgICAgIFRoZSBzY3JvbGxpbmcgY29vcmRpbmF0b3IgbXVz dCBiZSBlbmFibGVkIG9yIGRpc2FibGVkIGZvbGxvd2luZyB0aGUKKyAgICAgICAgV2ViUGFnZSdz IHVzZSBvZiBmaXhlZCBsYXlvdXQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAo V2ViS2l0OjpDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9z dCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlOjpzZXRVc2VGaXhlZExheW91dCk6CisKIDIwMTMtMDYtMDMgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTZW5kIG1vdXNlIGV2 ZW50cyB0byB0aGUgYmFubmVyIGZvciBhcyBsb25nIGFzIHRoZSBtb3VzZSBidXR0b24gaXMgZG93 bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJU cmVlSG9zdC5jcHAKaW5kZXggNDIyYWU1ZDAwNzIyZDhmNTk3MDVjOTk4M2U5NWQ1YmRlNDI5MDAw OS4uNjZiNTAxNjcxYjg1YWJmOTZiNmExMDkxZGQyOTFhNzRlYTU4NGI4ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29v cmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3Bw CkBAIC05OSw4ICs5OSw2IEBAIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Q29vcmRpbmF0ZWRM YXllclRyZWVIb3N0KFdlYlBhZ2UqIHdlYlBhZ2UpCiAgICAgLCBtX2xhc3RBbmltYXRpb25TZXJ2 aWNlVGltZSgwKQogI2VuZGlmCiB7Ci0gICAgaWYgKG1fd2ViUGFnZS0+dXNlRml4ZWRMYXlvdXQo KSkKLSAgICAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRTY3JvbGxp bmdDb29yZGluYXRvckVuYWJsZWQodHJ1ZSk7CiAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5z ZXR0aW5ncygpLT5zZXRBcHBseURldmljZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKHRydWUpOwog CiAgICAgLy8gQ3JlYXRlIGEgcm9vdCBsYXllci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCBmNzI5Y2QxMWMyNTAxMjM1MDNjMjJlNjg4NWM2 ODc4YzRjMzJmMjhkLi4wMmE2NDA3YzdjZGU3NjViODhhODU2M2RmZjZkOTNhODE3MTJhNWZmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0x MzI5LDYgKzEzMjksNyBAQCB2b2lkIFdlYlBhZ2U6OnNldFVzZUZpeGVkTGF5b3V0KGJvb2wgZml4 ZWQpCiAgICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9y Rml4ZWRQb3NpdGlvbkVuYWJsZWQoZml4ZWQpOwogICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0 Rml4ZWRQb3NpdGlvbkNyZWF0ZXNTdGFja2luZ0NvbnRleHQoZml4ZWQpOwogICAgIG1fcGFnZS0+ c2V0dGluZ3MoKS0+c2V0QXBwbHlQYWdlU2NhbGVGYWN0b3JJbkNvbXBvc2l0b3IoZml4ZWQpOwor ICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0U2Nyb2xsaW5nQ29vcmRpbmF0b3JFbmFibGVkKGZp eGVkKTsKICNlbmRpZgogCiAjaWYgVVNFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpICYmIEVOQUJMRShT TU9PVEhfU0NST0xMSU5HKQo=