117147 2013-06-03 07:21:24 -0700 [sh4] Add floating point absolute function support in baseline JIT 2013-06-04 09:59:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue fpizlo ggaren mark.lam oliver oldest_to_newest 896435 0 jbriance 2013-06-03 07:21:24 -0700 Add floating point absolute function support in sh4 baseline JIT. 896438 1 203587 jbriance 2013-06-03 07:30:06 -0700 Created attachment 203587 Add floating point absolute function support in sh4 baseline JIT 896441 2 commit-queue 2013-06-03 07:31:31 -0700 Attachment 203587 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/assembler/SH4Assembler.h']" exit_code: 1 Source/JavaScriptCore/assembler/SH4Assembler.h:181: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 896445 3 jbriance 2013-06-03 07:44:20 -0700 I've tested this patch on r151092 and I didn't see regressions when running - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc - SunSpider 1.0 I used the following dumb test to measure the performance impact of this patch: var result = 1.123; for (var i = 0; i < 5000000; ++i) { result = result + Math.abs((i / -(i+1)) + (i * 1.1)); } Using r151092 jsc without patch, I get: real 0m 6.13s user 0m 6.00s sys 0m 0.10s Using r151092 jsc with patch, I get about 4.3% better: real 0m 5.57s user 0m 5.45s sys 0m 0.10s 896927 4 203587 ggaren 2013-06-04 09:37:35 -0700 Comment on attachment 203587 Add floating point absolute function support in sh4 baseline JIT r=me 896939 5 203587 commit-queue 2013-06-04 09:59:01 -0700 Comment on attachment 203587 Add floating point absolute function support in sh4 baseline JIT Clearing flags on attachment: 203587 Committed r151174: <http://trac.webkit.org/changeset/151174> 896940 6 commit-queue 2013-06-04 09:59:03 -0700 All reviewed patches have been landed. Closing bug. 203587 2013-06-03 07:30:06 -0700 2013-06-04 09:59:00 -0700 Add floating point absolute function support in sh4 baseline JIT bug-117147.patch text/plain 3045 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMTExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTA2LTAzICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFtzaDRdIEFkZCBmbG9hdGluZyBwb2ludCBhYnNvbHV0ZSBmdW5jdGlvbiBzdXBwb3J0 IGluIGJhc2VsaW5lIEpJVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNzE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0Lmg6CisgICAgICAgIChKU0M6 Ok1hY3JvQXNzZW1ibGVyU0g0OjpzdXBwb3J0c0Zsb2F0aW5nUG9pbnRBYnMpOgorICAgICAgICAo SlNDOjpNYWNyb0Fzc2VtYmxlclNINDo6YWJzRG91YmxlKToKKyAgICAgICAgKiBhc3NlbWJsZXIv U0g0QXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OlNINEFzc2VtYmxlcjo6ZGFicyk6CisgICAg ICAgIChKU0M6OlNINEFzc2VtYmxlcjo6cHJpbnRJbnN0cik6CisKIDIwMTMtMDUtMzEgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBJbmNvcnJlY3QgYXNzZXJ0aW9u IGluIERGRzo6R3JhcGg6OnVuY2hlY2tlZEFjdGl2YXRpb25SZWdpc3RlckZvcigpCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNI NC5oCShyZXZpc2lvbiAxNTEwOTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyU0g0LmgJKHdvcmtpbmcgY29weSkKQEAgLTk0Niw3ICs5NDYsNyBAQCBw dWJsaWM6CiAgICAgc3RhdGljIGJvb2wgc3VwcG9ydHNGbG9hdGluZ1BvaW50KCkgeyByZXR1cm4g dHJ1ZTsgfQogICAgIHN0YXRpYyBib29sIHN1cHBvcnRzRmxvYXRpbmdQb2ludFRydW5jYXRlKCkg eyByZXR1cm4gdHJ1ZTsgfQogICAgIHN0YXRpYyBib29sIHN1cHBvcnRzRmxvYXRpbmdQb2ludFNx cnQoKSB7IHJldHVybiB0cnVlOyB9Ci0gICAgc3RhdGljIGJvb2wgc3VwcG9ydHNGbG9hdGluZ1Bv aW50QWJzKCkgeyByZXR1cm4gZmFsc2U7IH0KKyAgICBzdGF0aWMgYm9vbCBzdXBwb3J0c0Zsb2F0 aW5nUG9pbnRBYnMoKSB7IHJldHVybiB0cnVlOyB9CiAKICAgICB2b2lkIG1vdmVEb3VibGVUb0lu dHMoRlBSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0MSwgUmVnaXN0ZXJJRCBkZXN0MikK ICAgICB7CkBAIC0xMzkyLDkgKzEzOTIsMTAgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxl ci5kc3FydChkZXN0KTsKICAgICB9CiAgICAgCi0gICAgdm9pZCBhYnNEb3VibGUoRlBSZWdpc3Rl cklELCBGUFJlZ2lzdGVySUQpCisgICAgdm9pZCBhYnNEb3VibGUoRlBSZWdpc3RlcklEIHNyYywg RlBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVB Q0hFRCgpOworICAgICAgICBtb3ZlRG91YmxlKHNyYywgZGVzdCk7CisgICAgICAgIG1fYXNzZW1i bGVyLmRhYnMoZGVzdCk7CiAgICAgfQogCiAgICAgSnVtcCBicmFuY2hUZXN0OChSZXN1bHRDb25k aXRpb24gY29uZCwgQWRkcmVzcyBhZGRyZXNzLCBUcnVzdGVkSW1tMzIgbWFzayA9IFRydXN0ZWRJ bW0zMigtMSkpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFzc2Vt Ymxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0 QXNzZW1ibGVyLmgJKHJldmlzaW9uIDE1MTA5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE3OCw2ICsxNzgsNyBA QCBlbnVtIHsKICAgICBTVFNGUFNDUl9PUENPREUgPSAweDAwNmEsCiAgICAgTERTUk1GUFVMX09Q Q09ERSA9IDB4NDA1YSwKICAgICBGU1RTRlBVTEZSTl9PUENPREUgPSAweGYwMGQsCisgICAgRkFC U19PUENPREUgPSAweGYwNWQsCiAgICAgRlNRUlRfT1BDT0RFID0gMHhmMDZkLAogICAgIEZTQ0hH X09QQ09ERSA9IDB4ZjNmZCwKICAgICBDTFJUX09QQ09ERSA9IDgsCkBAIC05NTcsNiArOTU4LDEy IEBAIHB1YmxpYzoKICAgICAgICAgb25lU2hvcnRPcChvcGMpOwogICAgIH0KIAorICAgIHZvaWQg ZGFicyhGUFJlZ2lzdGVySUQgZHN0KQorICAgIHsKKyAgICAgICAgdWludDE2X3Qgb3BjID0gZ2V0 T3Bjb2RlR3JvdXA3KEZBQlNfT1BDT0RFLCBkc3QgPj4gMSk7CisgICAgICAgIG9uZVNob3J0T3Ao b3BjKTsKKyAgICB9CisKICAgICB2b2lkIGRzcXJ0KEZQUmVnaXN0ZXJJRCBkc3QpCiAgICAgewog ICAgICAgICB1aW50MTZfdCBvcGMgPSBnZXRPcGNvZGVHcm91cDcoRlNRUlRfT1BDT0RFLCBkc3Qg Pj4gMSk7CkBAIC0xODM2LDYgKzE4NDMsOSBAQCBwdWJsaWM6CiAgICAgICAgIGNhc2UgRlRSQ19P UENPREU6CiAgICAgICAgICAgICBmb3JtYXQgPSAiICAgIEZUUkMgRlIlZCwgRlBVTFxuIjsKICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEZBQlNfT1BDT0RFOgorICAgICAgICAgICAg Zm9ybWF0ID0gIiAgICBGQUJTIEZSJWRcbiI7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSBGU1FSVF9PUENPREU6CiAgICAgICAgICAgICBmb3JtYXQgPSAiICAgIEZTUVJUIEZSJWRc biI7CiAgICAgICAgICAgICBicmVhazsK