117132 2013-06-02 23:14:00 -0700 'onended' event is not received in AudioBufferSourceNode and OscillatorNode. 2013-06-03 04:47:43 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 praveen.j praveen.j cdumez commit-queue crogers dev_sachin eric.carlson glenn gyuyoung.kim jer.noble rakuco oldest_to_newest 896305 0 praveen.j 2013-06-02 23:14:00 -0700 m_hasEndedListener is unset even though setOnended() passes a valid reference pointer(tested on EFL port). As a result, onended event is not received by JS. 896307 1 203555 praveen.j 2013-06-02 23:30:22 -0700 Created attachment 203555 Patch 896318 2 203555 cdumez 2013-06-03 00:39:29 -0700 Comment on attachment 203555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203555&action=review > Source/WebCore/ChangeLog:3 > + [EFL] onended Event is not received in AudioBufferSourceNode and OscillatorNode. Patch is not specific to EFL so please remove [EFL] tag. > Source/WebCore/ChangeLog:11 > + No new tests. Present layout tests will cover all the scenarios. Then why doesn't this patch unskip / rebaseline any existing test? > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:-172 > - m_hasEndedListener = listener; Could you be more explicit about what was wrong with this assignment? Was the issue that listener becomes NULL after the call to setAttributeEventListener()? 896319 3 cdumez 2013-06-03 00:49:28 -0700 I skipped the related test cases in <http://trac.webkit.org/changeset/151096> for EFL port as they were failing on the bots. 896328 4 praveen.j 2013-06-03 01:21:05 -0700 (In reply to comment #2) > (From update of attachment 203555 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203555&action=review > > > Source/WebCore/ChangeLog:3 > > + [EFL] onended Event is not received in AudioBufferSourceNode and OscillatorNode. > > Patch is not specific to EFL so please remove [EFL] tag. Hmm, will update the title. > > > Source/WebCore/ChangeLog:11 > > + No new tests. Present layout tests will cover all the scenarios. > > Then why doesn't this patch unskip / rebaseline any existing test? Din't see your patch for tests rebaseline. :) Will update this as well. > > > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:-172 > > - m_hasEndedListener = listener; > > Could you be more explicit about what was wrong with this assignment? Was the issue that listener becomes NULL after the call to setAttributeEventListener()? As you said, "listener" becomes NULL after the call to setAttributeEventListener(). Will update the patch as discussed shortly. 896352 5 203564 praveen.j 2013-06-03 02:30:45 -0700 Created attachment 203564 Patch 896366 6 203564 cdumez 2013-06-03 03:35:03 -0700 Comment on attachment 203564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203564&action=review Looks good, r=me. But please improve the Changelogs before landing. > Source/WebCore/ChangeLog:3 > + onended Event is not received in AudioBufferSourceNode and OscillatorNode. 'onevent' event... > Source/WebCore/ChangeLog:8 > + PassRefPtr is set to null after usage in setAttributeEventListener(). This would be better IMHO: "The listener argument is a PassRefPtr which becomes NULL after the call to setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener boolean to be incorrectly initialized. This patch reverses the two statements so that the m_hasEndedListener is updated before the call to setAttributeEventListener()." > Source/WebCore/ChangeLog:11 > + No new tests. Present layout tests will cover all the scenarios. No new tests, already covered by existing tests. > LayoutTests/ChangeLog:8 > + Re-enabling failed webaudio tests due to 'onended' event not being "Unskip webaudio test cases that were failing due to the 'onended' event not being fired." 896367 7 cdumez 2013-06-03 03:37:05 -0700 (In reply to comment #6) > (From update of attachment 203564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203564&action=review > > Looks good, r=me. But please improve the Changelogs before landing. > > > Source/WebCore/ChangeLog:3 > > + onended Event is not received in AudioBufferSourceNode and OscillatorNode. > > 'onevent' event... I meant 'onended' event...", sorry. 896371 8 203570 praveen.j 2013-06-03 03:58:58 -0700 Created attachment 203570 Patch ChangeLog updated. 896377 9 203573 praveen.j 2013-06-03 04:17:12 -0700 Created attachment 203573 Patch Patch updated. 896389 10 203573 commit-queue 2013-06-03 04:47:40 -0700 Comment on attachment 203573 Patch Clearing flags on attachment: 203573 Committed r151101: <http://trac.webkit.org/changeset/151101> 896390 11 commit-queue 2013-06-03 04:47:43 -0700 All reviewed patches have been landed. Closing bug. 203555 2013-06-02 23:30:22 -0700 2013-06-03 02:30:45 -0700 Patch WebAudio-117132.txt text/plain 3299 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTA5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA2LTAyICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIG9uZW5k ZWQgRXZlbnQgaXMgbm90IHJlY2VpdmVkIGluIEF1ZGlvQnVmZmVyU291cmNlTm9kZSBhbmQgT3Nj aWxsYXRvck5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTcxMzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXNzaWduaW5nIHJlZmVyZW5jZSBwb2ludGVyIHRvIGJvb2xlYW4gaW4gc2V0T25lbmRl ZCgpIGRvZXNuJ3Qgc2V0IHRoZSB2YXJpYWJsZQorICAgICAgICBjb3JyZWN0bHkuIENvZGUgdXBk YXRlZCB0byBjaGVjayBldmVudGxpc3RlbmVyIGJlZm9yZSBkaXNwYXRjaGluZyB0aGUgZXZlbnQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBQcmVzZW50IGxheW91dCB0ZXN0cyB3aWxsIGNvdmVy IGFsbCB0aGUgc2NlbmFyaW9zLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb1Nj aGVkdWxlZFNvdXJjZU5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9TY2hlZHVsZWRT b3VyY2VOb2RlOjpBdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUpOgorICAgICAgICAoV2ViQ29yZTo6 QXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpzZXRPbmVuZGVkKToKKyAgICAgICAgKFdlYkNvcmU6 OkF1ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6ZmluaXNoKToKKyAgICAgICAgKFdlYkNvcmU6OkF1 ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6bm90aWZ5RW5kZWQpOgorICAgICAgICAqIE1vZHVsZXMv d2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmg6CisKIDIwMTMtMDYtMDIgIEFydW5w cmFzYWQgUmFqa3VtYXIgIDxhcnVyYWprdUBjaXNjby5jb20+CiAKICAgICAgICAgW1F0XSBNb3Zl IFF0IHBvcnQgb2ZmIGxlZ2FjeSBjbGlwYm9hcmQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvU2NoZWR1bGVkU291cmNlTm9kZS5j cHAJKHJldmlzaW9uIDE1MTA4OCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8v QXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUs NyBAQCBBdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGU6OkF1ZGlvU2NoZWR1bGVkCiAgICAgLCBtX3Bs YXliYWNrU3RhdGUoVU5TQ0hFRFVMRURfU1RBVEUpCiAgICAgLCBtX3N0YXJ0VGltZSgwKQogICAg ICwgbV9lbmRUaW1lKFVua25vd25UaW1lKQotICAgICwgbV9oYXNFbmRlZExpc3RlbmVyKGZhbHNl KQorICAgICwgbV9lbmRlZExpc3RlbmVyKDApCiB7CiB9CiAKQEAgLTE2OSw3ICsxNjksNyBAQCB2 b2lkIEF1ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6bm90ZU9mZihkCiB2b2lkIEF1ZGlvU2NoZWR1 bGVkU291cmNlTm9kZTo6c2V0T25lbmRlZChQYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3Rl bmVyKQogewogICAgIHNldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLmVuZGVk RXZlbnQsIGxpc3RlbmVyKTsKLSAgICBtX2hhc0VuZGVkTGlzdGVuZXIgPSBsaXN0ZW5lcjsKKyAg ICBtX2VuZGVkTGlzdGVuZXIgPSBvbmVuZGVkKCk7CiB9CiAKIHZvaWQgQXVkaW9TY2hlZHVsZWRT b3VyY2VOb2RlOjpmaW5pc2goKQpAQCAtMTgxLDcgKzE4MSw3IEBAIHZvaWQgQXVkaW9TY2hlZHVs ZWRTb3VyY2VOb2RlOjpmaW5pc2goKQogICAgICAgICBjb250ZXh0KCktPmRlY3JlbWVudEFjdGl2 ZVNvdXJjZUNvdW50KCk7CiAgICAgfQogCi0gICAgaWYgKG1faGFzRW5kZWRMaXN0ZW5lcikKKyAg ICBpZiAobV9lbmRlZExpc3RlbmVyKQogICAgICAgICBjYWxsT25NYWluVGhyZWFkKCZBdWRpb1Nj aGVkdWxlZFNvdXJjZU5vZGU6Om5vdGlmeUVuZGVkRGlzcGF0Y2gsIHRoaXMpOwogfQogCkBAIC0x OTIsMTMgKzE5MiwxMiBAQCB2b2lkIEF1ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6bm90aWZ5RW5k CiAKIHZvaWQgQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpub3RpZnlFbmRlZCgpCiB7Ci0gICAg RXZlbnRMaXN0ZW5lciogbGlzdGVuZXIgPSBvbmVuZGVkKCk7Ci0gICAgaWYgKCFsaXN0ZW5lcikK KyAgICBpZiAoIW1fZW5kZWRMaXN0ZW5lcikKICAgICAgICAgcmV0dXJuOwogCiAgICAgUmVmUHRy PEV2ZW50PiBldmVudCA9IEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmVuZGVkRXZlbnQsIEZB TFNFLCBGQUxTRSk7CiAgICAgZXZlbnQtPnNldFRhcmdldCh0aGlzKTsKLSAgICBsaXN0ZW5lci0+ aGFuZGxlRXZlbnQoY29udGV4dCgpLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCksIGV2ZW50Lmdl dCgpKTsKKyAgICBtX2VuZGVkTGlzdGVuZXItPmhhbmRsZUV2ZW50KGNvbnRleHQoKS0+c2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpLCBldmVudC5nZXQoKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVs ZWRTb3VyY2VOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9BdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUuaAkocmV2aXNpb24gMTUxMDg4KQorKysgU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUuaAko d29ya2luZyBjb3B5KQpAQCAtMTAxLDcgKzEwMSw3IEBAIHByb3RlY3RlZDoKICAgICAvLyBoYXMg YmVlbiByZWFjaGVkLgogICAgIGRvdWJsZSBtX2VuZFRpbWU7IC8vIGluIHNlY29uZHMKIAotICAg IGJvb2wgbV9oYXNFbmRlZExpc3RlbmVyOworICAgIEV2ZW50TGlzdGVuZXIqIG1fZW5kZWRMaXN0 ZW5lcjsKIAogICAgIHN0YXRpYyBjb25zdCBkb3VibGUgVW5rbm93blRpbWU7CiB9Owo= 203564 2013-06-03 02:30:45 -0700 2013-06-03 03:58:58 -0700 Patch WebAudio-117132.txt text/plain 3142 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTA5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTAzICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgIG9uZW5kZWQgRXZl bnQgaXMgbm90IHJlY2VpdmVkIGluIEF1ZGlvQnVmZmVyU291cmNlTm9kZSBhbmQgT3NjaWxsYXRv ck5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTcxMzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UGFzc1JlZlB0ciBpcyBzZXQgdG8gbnVsbCBhZnRlciB1c2FnZSBpbiBzZXRBdHRyaWJ1dGVFdmVu dExpc3RlbmVyKCkuCisgICAgICAgIFZhcmlhYmxlIGlzIHVwZGF0ZWQgYmVmb3JlIGNhbGxpbmcg dGhpcyBmdW5jdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFByZXNlbnQgbGF5b3V0IHRl c3RzIHdpbGwgY292ZXIgYWxsIHRoZSBzY2VuYXJpb3MuCisgICAgICAgIEVGTCBUZXN0RXhwZWN0 YXRpb24gaXMgdXBkYXRlZCB0byBlbmFibGUgMiB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMv d2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkF1ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6c2V0T25lbmRlZCk6CisKIDIwMTMtMDYtMDMgIENo YXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFdl YmtpdCBjcmFzaGVzIHdoaWxlIGxvYWRpbmcgY29udGVudCBmcm9tIEFwcGxpY2F0aW9uIENhY2hl LgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1NjaGVkdWxlZFNv dXJjZU5vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAkocmV2aXNpb24gMTUxMDk3KQorKysgU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsOCArMTY4LDggQEAgdm9pZCBBdWRpb1NjaGVkdWxlZFNv dXJjZU5vZGU6Om5vdGVPZmYoZAogCiB2b2lkIEF1ZGlvU2NoZWR1bGVkU291cmNlTm9kZTo6c2V0 T25lbmRlZChQYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyKQogewotICAgIHNldEF0 dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLmVuZGVkRXZlbnQsIGxpc3RlbmVyKTsK ICAgICBtX2hhc0VuZGVkTGlzdGVuZXIgPSBsaXN0ZW5lcjsKKyAgICBzZXRBdHRyaWJ1dGVFdmVu dExpc3RlbmVyKGV2ZW50TmFtZXMoKS5lbmRlZEV2ZW50LCBsaXN0ZW5lcik7CiB9CiAKIHZvaWQg QXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpmaW5pc2goKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTUx MDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTMtMDYtMDMgIFByYXZlZW4gUiBKYWRoYXYgIDxwcmF2ZWVuLmpAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgb25lbmRlZCBFdmVudCBpcyBub3QgcmVjZWl2ZWQgaW4gQXVkaW9CdWZm ZXJTb3VyY2VOb2RlIGFuZCBPc2NpbGxhdG9yTm9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzEzMi4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZS1lbmFibGluZyBmYWlsZWQgd2ViYXVkaW8gdGVz dHMgZHVlIHRvICdvbmVuZGVkJyBldmVudCBub3QgYmVpbmcKKyAgICAgICAgZGlzcGF0Y2hlZC4K KworICAgICAgICAqIHBsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTA2LTAz ICBDaGFybGVzIFdlaSAgPGNod2VpQGJsYWNrYmVycnkuY29tPgogCiAgICAgICAgIFdlYmtpdCBj cmFzaGVzIHdoaWxlIGxvYWRpbmcgIGNvbnRlbnQgZnJvbSBBcHBsaWNhdGlvbiBDYWNoZS4KSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAx NTEwOTcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwkod29y a2luZyBjb3B5KQpAQCAtMTgxMiwxMCArMTgxMiw2IEBAIHdlYmtpdC5vcmcvYi8xMTQ3MzkgY29t cG9zaXRpbmcvcGF0dGVybnMKICMgTmV3IGFjY2Vzc2liaWxpdHkgdGVzdCBhZGRlZCBpbiByMTQ5 MTU1IGlzIGZhaWxpbmcuCiB3ZWJraXQub3JnL2IvMTE1NjU5IGFjY2Vzc2liaWxpdHkvbWV0ZXIt ZWxlbWVudC5odG1sIFsgRmFpbHVyZSBdCiAKLSMgb25lbmRlZCBldmVudCBpcyBub3QgZmlyZWQu Ci13ZWJraXQub3JnL2IvMTE3MTMyIHdlYmF1ZGlvL2F1ZGlvYnVmZmVyc291cmNlLWVuZGVkLmh0 bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMTcxMzIgd2ViYXVkaW8vb3NjaWxsYXRvci1l bmRlZC5odG1sIFsgRmFpbHVyZSBdCi0KICMgUmVncmVzc2lvbihyMTQ5MjkyKTogTWlzc2luZyBy ZXBhaW50IHJlY3RzLgogd2Via2l0Lm9yZy9iLzExNDYxMSBmYXN0L2JveC1zaGFkb3cvc2hhZG93 LXJlcGFpbnQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzExNDYxMSBmYXN0L2Nzcy1n cmlkLWxheW91dC9ncmlkLWVsZW1lbnQtY2hhbmdlLWNvbHVtbnMtcmVwYWludC5odG1sIFsgRmFp bHVyZSBdCg== 203570 2013-06-03 03:58:58 -0700 2013-06-03 04:17:12 -0700 Patch WebAudio-117132.txt text/plain 3374 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTA5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTAzICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgICdvbmVuZGVkJyBl dmVudCBpcyBub3QgcmVjZWl2ZWQgaW4gQXVkaW9CdWZmZXJTb3VyY2VOb2RlIGFuZCBPc2NpbGxh dG9yTm9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNzEzMi4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpc3RvcGhlIER1bWV6LgorCisgICAg ICAgIFRoZSBsaXN0ZW5lciBhcmd1bWVudCBpcyBhIFBhc3NSZWZQdHIgd2hpY2ggYmVjb21lcyBO VUxMIGFmdGVyIHRoZSBjYWxsIHRvIAorICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVy KCkgaW4gc2V0T25lbmRlZCgpLiBUaGlzIGNhdXNlcyB0aGUgbV9oYXNFbmRlZExpc3RlbmVyIGJv b2xlYW4KKyAgICAgICAgdG8gYmUgaW5jb3JyZWN0bHkgaW5pdGlhbGl6ZWQuIFRoaXMgcGF0Y2gg cmV2ZXJzZXMgdGhlIHR3byBzdGF0ZW1lbnRzIHNvIHRoYXQgdGhlIAorICAgICAgICBtX2hhc0Vu ZGVkTGlzdGVuZXIgaXMgdXBkYXRlZCBiZWZvcmUgdGhlIGNhbGwgdG8gc2V0QXR0cmlidXRlRXZl bnRMaXN0ZW5lcigpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gUHJlc2VudCBsYXlvdXQgdGVz dHMgd2lsbCBjb3ZlciBhbGwgdGhlIHNjZW5hcmlvcy4KKyAgICAgICAgRUZMIFRlc3RFeHBlY3Rh dGlvbiBpcyB1cGRhdGVkIHRvIGVuYWJsZSAyIHRlc3RzLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9BdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpzZXRPbmVuZGVkKToKKwogMjAxMy0wNi0wMyAgQ2hh cmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgV2Vi a2l0IGNyYXNoZXMgd2hpbGUgbG9hZGluZyBjb250ZW50IGZyb20gQXBwbGljYXRpb24gQ2FjaGUu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvU2NoZWR1bGVkU291 cmNlTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp by9BdWRpb1NjaGVkdWxlZFNvdXJjZU5vZGUuY3BwCShyZXZpc2lvbiAxNTEwOTcpCisrKyBTb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvU2NoZWR1bGVkU291cmNlTm9kZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE2OCw4ICsxNjgsOCBAQCB2b2lkIEF1ZGlvU2NoZWR1bGVkU291 cmNlTm9kZTo6bm90ZU9mZihkCiAKIHZvaWQgQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpzZXRP bmVuZGVkKFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIpCiB7Ci0gICAgc2V0QXR0 cmlidXRlRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuZW5kZWRFdmVudCwgbGlzdGVuZXIpOwog ICAgIG1faGFzRW5kZWRMaXN0ZW5lciA9IGxpc3RlbmVyOworICAgIHNldEF0dHJpYnV0ZUV2ZW50 TGlzdGVuZXIoZXZlbnROYW1lcygpLmVuZGVkRXZlbnQsIGxpc3RlbmVyKTsKIH0KIAogdm9pZCBB dWRpb1NjaGVkdWxlZFNvdXJjZU5vZGU6OmZpbmlzaCgpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTEw OTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NSBAQAorMjAxMy0wNi0wMyAgUHJhdmVlbiBSIEphZGhhdiAgPHByYXZlZW4uakBzYW1zdW5nLmNv bT4KKworICAgICAgICAnb25lbmRlZCcgZXZlbnQgaXMgbm90IHJlY2VpdmVkIGluIEF1ZGlvQnVm ZmVyU291cmNlTm9kZSBhbmQgT3NjaWxsYXRvck5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTcxMzIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Q2hyaXN0b3BoZSBEdW1lei4KKworICAgICAgICBVbnNraXAgd2ViYXVkaW8gdGVzdCBjYXNlcyB0 aGF0IHdlcmUgZmFpbGluZyBkdWUgdG8gdGhlICdvbmVuZGVkJyBldmVudCBub3QgYmVpbmcgZmly ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMy0w Ni0wMyAgQ2hhcmxlcyBXZWkgIDxjaHdlaUBibGFja2JlcnJ5LmNvbT4KIAogICAgICAgICBXZWJr aXQgY3Jhc2hlcyB3aGlsZSBsb2FkaW5nICBjb250ZW50IGZyb20gQXBwbGljYXRpb24gQ2FjaGUu CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNp b24gMTUxMDk3KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMJ KHdvcmtpbmcgY29weSkKQEAgLTE4MTIsMTAgKzE4MTIsNiBAQCB3ZWJraXQub3JnL2IvMTE0NzM5 IGNvbXBvc2l0aW5nL3BhdHRlcm5zCiAjIE5ldyBhY2Nlc3NpYmlsaXR5IHRlc3QgYWRkZWQgaW4g cjE0OTE1NSBpcyBmYWlsaW5nLgogd2Via2l0Lm9yZy9iLzExNTY1OSBhY2Nlc3NpYmlsaXR5L21l dGVyLWVsZW1lbnQuaHRtbCBbIEZhaWx1cmUgXQogCi0jIG9uZW5kZWQgZXZlbnQgaXMgbm90IGZp cmVkLgotd2Via2l0Lm9yZy9iLzExNzEzMiB3ZWJhdWRpby9hdWRpb2J1ZmZlcnNvdXJjZS1lbmRl ZC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTE3MTMyIHdlYmF1ZGlvL29zY2lsbGF0 b3ItZW5kZWQuaHRtbCBbIEZhaWx1cmUgXQotCiAjIFJlZ3Jlc3Npb24ocjE0OTI5Mik6IE1pc3Np bmcgcmVwYWludCByZWN0cy4KIHdlYmtpdC5vcmcvYi8xMTQ2MTEgZmFzdC9ib3gtc2hhZG93L3No YWRvdy1yZXBhaW50Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTQ2MTEgZmFzdC9j c3MtZ3JpZC1sYXlvdXQvZ3JpZC1lbGVtZW50LWNoYW5nZS1jb2x1bW5zLXJlcGFpbnQuaHRtbCBb IEZhaWx1cmUgXQo= 203573 2013-06-03 04:17:12 -0700 2013-06-03 04:47:40 -0700 Patch WebAudio-117132.txt text/plain 3372 praveen.j SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTEwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA2LTAzICBQcmF2ZWVu IFIgSmFkaGF2ICA8cHJhdmVlbi5qQHNhbXN1bmcuY29tPgorCisgICAgICAgICdvbmVuZGVkJyBl dmVudCBpcyBub3QgcmVjZWl2ZWQgaW4gQXVkaW9CdWZmZXJTb3VyY2VOb2RlIGFuZCBPc2NpbGxh dG9yTm9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNzEzMi4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpc3RvcGhlIER1bWV6LgorCisgICAg ICAgIFRoZSBsaXN0ZW5lciBhcmd1bWVudCBpcyBhIFBhc3NSZWZQdHIgd2hpY2ggYmVjb21lcyBO VUxMIGFmdGVyIHRoZSBjYWxsIHRvCisgICAgICAgIHNldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIo KSBpbiBzZXRPbmVuZGVkKCkuIFRoaXMgY2F1c2VzIHRoZSBtX2hhc0VuZGVkTGlzdGVuZXIKKyAg ICAgICAgYm9vbGVhbiB0byBiZSBpbmNvcnJlY3RseSBpbml0aWFsaXplZC4gVGhpcyBwYXRjaCBy ZXZlcnNlcyB0aGUgdHdvIHN0YXRlbWVudHMgc28KKyAgICAgICAgdGhhdCB0aGUgbV9oYXNFbmRl ZExpc3RlbmVyIGlzIHVwZGF0ZWQgYmVmb3JlIHRoZSBjYWxsIHRvIHNldEF0dHJpYnV0ZUV2ZW50 TGlzdGVuZXIoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSBl eGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVs ZWRTb3VyY2VOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvU2NoZWR1bGVkU291cmNl Tm9kZTo6c2V0T25lbmRlZCk6CisKIDIwMTMtMDYtMDMgIFJhc2htaSBLdWxha2FybmkgIDxyYXNo bWkudmlqYXlAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF08c2VsZWN0PiBlbGVtZW50J3Mg dGV4dCBpcyBjbGlwcGVkIHdoZW4gYSBoZWlnaHQgaXMgc3BlY2lmaWVkIGFsb25nIHdpdGggQ1NT IGxpbmUtaGVpZ2h0LgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRp b1NjaGVkdWxlZFNvdXJjZU5vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlLmNwcAkocmV2aXNpb24gMTUx MTAwKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1NjaGVkdWxlZFNv dXJjZU5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsOCArMTY4LDggQEAgdm9pZCBBdWRp b1NjaGVkdWxlZFNvdXJjZU5vZGU6Om5vdGVPZmYoZAogCiB2b2lkIEF1ZGlvU2NoZWR1bGVkU291 cmNlTm9kZTo6c2V0T25lbmRlZChQYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyKQog ewotICAgIHNldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLmVuZGVkRXZlbnQs IGxpc3RlbmVyKTsKICAgICBtX2hhc0VuZGVkTGlzdGVuZXIgPSBsaXN0ZW5lcjsKKyAgICBzZXRB dHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5lbmRlZEV2ZW50LCBsaXN0ZW5lcik7 CiB9CiAKIHZvaWQgQXVkaW9TY2hlZHVsZWRTb3VyY2VOb2RlOjpmaW5pc2goKQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMTUxMTAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDYtMDMgIFByYXZlZW4gUiBKYWRoYXYgIDxwcmF2ZWVu LmpAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgJ29uZW5kZWQnIGV2ZW50IGlzIG5vdCByZWNlaXZl ZCBpbiBBdWRpb0J1ZmZlclNvdXJjZU5vZGUgYW5kIE9zY2lsbGF0b3JOb2RlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE3MTMyLgorCisgICAgICAg IFJldmlld2VkIGJ5IENocmlzdG9waGUgRHVtZXouCisKKyAgICAgICAgVW5za2lwIHdlYmF1ZGlv IHRlc3QgY2FzZXMgdGhhdCB3ZXJlIGZhaWxpbmcgZHVlIHRvIHRoZSAnb25lbmRlZCcgZXZlbnQg bm90IGJlaW5nIGZpcmVkLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlv bnM6CisKIDIwMTMtMDYtMDMgIFJhc2htaSBLdWxha2FybmkgIDxyYXNobWkudmlqYXlAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgW0VGTF08c2VsZWN0PiBlbGVtZW50J3MgdGV4dCBpcyBjbGlwcGVk IHdoZW4gYSBoZWlnaHQgaXMgc3BlY2lmaWVkIGFsb25nIHdpdGggQ1NTIGxpbmUtaGVpZ2h0LgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9u IDE1MTEwMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zCSh3 b3JraW5nIGNvcHkpCkBAIC0xODEyLDEwICsxODEyLDYgQEAgd2Via2l0Lm9yZy9iLzExNDczOSBj b21wb3NpdGluZy9wYXR0ZXJucwogIyBOZXcgYWNjZXNzaWJpbGl0eSB0ZXN0IGFkZGVkIGluIHIx NDkxNTUgaXMgZmFpbGluZy4KIHdlYmtpdC5vcmcvYi8xMTU2NTkgYWNjZXNzaWJpbGl0eS9tZXRl ci1lbGVtZW50Lmh0bWwgWyBGYWlsdXJlIF0KIAotIyBvbmVuZGVkIGV2ZW50IGlzIG5vdCBmaXJl ZC4KLXdlYmtpdC5vcmcvYi8xMTcxMzIgd2ViYXVkaW8vYXVkaW9idWZmZXJzb3VyY2UtZW5kZWQu aHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzExNzEzMiB3ZWJhdWRpby9vc2NpbGxhdG9y LWVuZGVkLmh0bWwgWyBGYWlsdXJlIF0KLQogIyBSZWdyZXNzaW9uKHIxNDkyOTIpOiBNaXNzaW5n IHJlcGFpbnQgcmVjdHMuCiB3ZWJraXQub3JnL2IvMTE0NjExIGZhc3QvYm94LXNoYWRvdy9zaGFk b3ctcmVwYWludC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTE0NjExIGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2dyaWQtZWxlbWVudC1jaGFuZ2UtY29sdW1ucy1yZXBhaW50Lmh0bWwgWyBG YWlsdXJlIF0K