117131 2013-06-02 22:11:43 -0700 [WTF] Add OwnArrayPtr vectortraits template 2013-06-03 00:09:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105156 1 gyuyoung.kim gyuyoung.kim benjamin cmarcelo commit-queue darin sergio oldest_to_newest 896299 0 gyuyoung.kim 2013-06-02 22:11:43 -0700 Bug 105156 needs to use Vector<OwnArrayPtr<char>>. So, we need to add OwnArrayPtr to VectorTraits, which was guided in https://bugs.webkit.org/show_bug.cgi?id=105156#c39 896300 1 203553 gyuyoung.kim 2013-06-02 22:14:05 -0700 Created attachment 203553 Patch 896301 2 gyuyoung.kim 2013-06-02 22:14:55 -0700 CC'ing Darin 896304 3 203553 darin 2013-06-02 23:05:04 -0700 Comment on attachment 203553 Patch Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before. 896309 4 gyuyoung.kim 2013-06-02 23:53:36 -0700 (In reply to comment #3) > (From update of attachment 203553 [details]) > Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before. Thank you for review. It seems to me that this patch won't great influence on build time. 896313 5 203553 commit-queue 2013-06-03 00:09:53 -0700 Comment on attachment 203553 Patch Clearing flags on attachment: 203553 Committed r151093: <http://trac.webkit.org/changeset/151093> 896314 6 commit-queue 2013-06-03 00:09:57 -0700 All reviewed patches have been landed. Closing bug. 203553 2013-06-02 22:14:05 -0700 2013-06-03 00:09:53 -0700 Patch bug-117131-20130603141237.patch text/plain 1445 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRlODIyYjU0NWMwNGY4NDc2ODk0ZjFk ZDY5MWRiMmIwZTRhZTg1ZmUuLjRlY2U4NGQ2ZTY5MjA2ZDgwYzUyN2RiNjIwOWFhZjJiODVkMTUx Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDYtMDIgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV1RGXSBBZGQgT3duQXJyYXlQdHIgdmVj dG9ydHJhaXRzIHRlbXBsYXRlIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE3MTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVG8gc3VwcG9ydCBWZWN0b3I8T3duQXJyYXlQdHI8UD4+LCB3aGljaCB3aWxs IGJlIHVzZWQgYnkgRUZMIHBvcnQuCisKKyAgICAgICAgKiB3dGYvVmVjdG9yVHJhaXRzLmg6CisK IDIwMTMtMDUtMzEgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9yZz4K IAogICAgICAgICBGaXggZG91YmxlIGhhc2ggbG9va3VwIGluIFBhZ2VNYXBNZW1vcnlVc2FnZVJl Y29yZGVyOjp2aXNpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVmVjdG9yVHJhaXRzLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3JUcmFpdHMuaAppbmRleCA2NzgyMjUwMzRhZTZlNjg3ZjZk YjJmNGVjMDNlYTZjOThlNTNhMzc3Li40YjA4MzQ0MjdkOTVlMGMyOGMwZDNhNzMwYmU4MjcxNDRk ZGI2NDI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3JUcmFpdHMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9WZWN0b3JUcmFpdHMuaApAQCAtMjEsNiArMjEsNyBAQAogI2lmbmRlZiBX VEZfVmVjdG9yVHJhaXRzX2gKICNkZWZpbmUgV1RGX1ZlY3RvclRyYWl0c19oCiAKKyNpbmNsdWRl IDx3dGYvT3duQXJyYXlQdHIuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8 d3RmL1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9UeXBlVHJhaXRzLmg+CkBAIC03OCw2ICs3OSw5 IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFA+CiAgICAgc3RydWN0 IFZlY3RvclRyYWl0czxPd25QdHI8UD4gPiA6IFNpbXBsZUNsYXNzVmVjdG9yVHJhaXRzIHsgfTsK IAorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFA+CisgICAgc3RydWN0IFZlY3RvclRyYWl0czxPd25B cnJheVB0cjxQPiA+IDogU2ltcGxlQ2xhc3NWZWN0b3JUcmFpdHMgeyB9OworCiAgICAgdGVtcGxh dGU8PgogICAgIHN0cnVjdCBWZWN0b3JUcmFpdHM8QXRvbWljU3RyaW5nPiA6IFNpbXBsZUNsYXNz VmVjdG9yVHJhaXRzIHsgfTsKIAo=