117116 2013-06-01 21:51:00 -0700 [WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient 2013-06-02 01:33:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 sergio webkit-unassigned cmarcelo commit-queue luiz noam simon.fraser thorton zeno oldest_to_newest 896158 0 sergio 2013-06-01 21:51:00 -0700 [WK2][CG]: Use a properly initialized WebPage when creating a PageClient 896159 1 203501 sergio 2013-06-01 21:55:20 -0700 Created attachment 203501 Patch 896167 2 203501 darin 2013-06-01 23:38:56 -0700 Comment on attachment 203501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203501&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:53 > + m_page = context->createWebPage(this, pageGroup); Needs a comment so someone doesn’t just move it back. Such as: // Need to call createWebPage after other data members, specifically m_visible, are initialized. 896171 3 203505 sergio 2013-06-01 23:48:17 -0700 Created attachment 203505 Patch Added comment as requested by Darin. 896178 4 203505 thorton 2013-06-02 00:37:53 -0700 Comment on attachment 203505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203505&action=review > Source/WebKit2/ChangeLog:3 > + [WK2][CG]: Use a properly initialized WebPage when creating a PageClient Oh, maybe we can use something other than [CG] in titles for Coordinated Graphics, since we already use that for CoreGraphics? 896179 5 sergio 2013-06-02 00:41:28 -0700 (In reply to comment #4) > (From update of attachment 203505 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203505&action=review > > > Source/WebKit2/ChangeLog:3 > > + [WK2][CG]: Use a properly initialized WebPage when creating a PageClient > > Oh, maybe we can use something other than [CG] in titles for Coordinated Graphics, since we already use that for CoreGraphics? My bad, I wasn't aware CG was already used for CoreGraphics. Would you like me to update the bug title (and the commit message/changleog) to use CoordinatedGraphics instead? 896180 6 thorton 2013-06-02 00:50:04 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 203505 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=203505&action=review > > > > > Source/WebKit2/ChangeLog:3 > > > + [WK2][CG]: Use a properly initialized WebPage when creating a PageClient > > > > Oh, maybe we can use something other than [CG] in titles for Coordinated Graphics, since we already use that for CoreGraphics? > > My bad, I wasn't aware CG was already used for CoreGraphics. > > Would you like me to update the bug title (and the commit message/changleog) to use CoordinatedGraphics instead? Sure :) 896181 7 203509 sergio 2013-06-02 00:56:53 -0700 Created attachment 203509 Patch Changed [CG] tag to [CoordinatedGraphics], as requested by Tim, as the former refers to CoreGraphics. 896182 8 203509 thorton 2013-06-02 01:05:26 -0700 Comment on attachment 203509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203509&action=review > Source/WebKit2/ChangeLog:42 > + Here's the relevant valgrind trace for reference: > + > + Conditional jump or move depends on uninitialised value(s) > + at 0x65A35A4: WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*, > + WTF::PassRefPtr<WebKit::WebProcessProxy>, > + WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:322) > + by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*, > + WTF::PassRefPtr<WebKit::WebProcessProxy>, > + WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:233) > + by 0x65E94BB: WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*, > + WebKit::WebContext*, WebKit::WebPageGroup*) > + (WebProcessProxy.cpp:172) > + by 0x6570957: WebKit::WebContext::createWebPage(WebKit::PageClient*, > + WebKit::WebPageGroup*, WebKit::WebPageProxy*) > + (WebContext.cpp:735) > + by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*, > + WebKit::WebPageGroup*) (WebView.cpp:52) > + by 0x6775F18: WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*, > + WebKit::WebPageGroup*) (WebViewEfl.cpp:54) > + by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*, > + WebKit::WebPageGroup*) (WebViewEfl.cpp:49) > + by 0x673E13D: WKViewCreate (WKView.cpp:33) > + by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92) This is a bit excessive for the changelog, I think, but it's fine. 896183 9 sergio 2013-06-02 01:09:42 -0700 (In reply to comment #8) > (From update of attachment 203509 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203509&action=review > [snip] > > This is a bit excessive for the changelog, I think, but it's fine. Alright, I will keep that in mind :) Thanks! 896186 10 203509 commit-queue 2013-06-02 01:33:04 -0700 Comment on attachment 203509 Patch Clearing flags on attachment: 203509 Committed r151081: <http://trac.webkit.org/changeset/151081> 896187 11 commit-queue 2013-06-02 01:33:07 -0700 All reviewed patches have been landed. Closing bug. 203501 2013-06-01 21:55:20 -0700 2013-06-01 23:48:09 -0700 Patch bug-117116-20130602004741.patch text/plain 3847 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzhjMDIyOGM2MzhjOTg2 MWU2MDYyNmRmOTRlYTM1NmQ1OGJkMjI4Yy4uY2RjN2Y0ZWYyNmE1OGRmZjk1M2Y5MmNlZDgzOTUx NTFlMjg3Y2FhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ5IEBACisyMDEzLTA2LTAxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1dL Ml1bQ0ddOiBVc2UgYSBwcm9wZXJseSBpbml0aWFsaXplZCBXZWJQYWdlIHdoZW4gY3JlYXRpbmcg YSBQYWdlQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTcxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBWYWxncmluZCByZXBvcnRlZCBhICJjb25kaXRpb25hbCBqdW1wIG9yIG1vdmUgZGVwZW5k cyBvbiB1bmluaXRpYWxpc2VkIHZhbHVlIgorICAgICAgICBhdCBXZWJQYWdlUHJveHkgY29uc3Ry dWN0b3IsIHdoZW4gY2hlY2tpbmcgdGhlIG1faXNWaXNpYmxlIHZhcmlhYmxlIGluc2lkZQorICAg ICAgICB0aGUgRU5BQkxFKFBBR0VfVklTSUJJTElUWV9BUEkpIGd1YXJkLgorCisgICAgICAgIFRo ZSBpc3N1ZSB3YXMgdHJhY2tlZCBkb3duIHRvIHRoZSBXZWJWaWV3IGNvbnN0cnVjdG9yLCB3aGlj aCB3YXMgY3JlYXRpbmcgYQorICAgICAgICBXZWJLaXQ6OlBhZ2VDbGllbnQqIG1ha2luZyB1c2Ug b2YgYHRoaXMnIGJlZm9yZSBoYXZpbmcgaW5pdGlhbGl6ZWQgYWxsIG9mIGl0cworICAgICAgICBh dHRyaWJ1dGVzLgorCisgICAgICAgIFRoZSBzb2x1dGlvbiB3YXMgdG8gbW92ZSB0aGUgaW5pdGlh bGl6YXRpb24gb2YgdGhlIGBwYWdlJyBtZW1iZXIgdG8gaW5zaWRlIHRoZQorICAgICAgICBjb25z dHJ1Y3RvciBpdHNlbGYgLSBvdXQgb2YgdGhlIGluaXRpYWxpemF0aW9uIGxpc3QgLSwgd2hlcmUg d2UgY2FuIGd1YXJhbnRlZQorICAgICAgICBhbGwgdGhlIHJlbGV2YW50IHN0dWZmIGhhcyBhbHJl YWR5IGJlZW4gcHJvcGVybHkgaW5pdGlhbGl6ZWQuCisKKyAgICAgICAgSGVyZSdzIHRoZSByZWxl dmFudCB2YWxncmluZCB0cmFjZSBmb3IgcmVmZXJlbmNlOgorCisgICAgICAgIENvbmRpdGlvbmFs IGp1bXAgb3IgbW92ZSBkZXBlbmRzIG9uIHVuaW5pdGlhbGlzZWQgdmFsdWUocykKKyAgICAgICAg ICAgIGF0IDB4NjVBMzVBNDogV2ViS2l0OjpXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94eShXZWJL aXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXVEY6OlBhc3NSZWZQ dHI8V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk+LAorICAgICAgICAgICAgICAgICAgICAgICAgICBX ZWJLaXQ6OldlYlBhZ2VHcm91cCosIHVuc2lnbmVkIGxvbmcpIChXZWJQYWdlUHJveHkuY3BwOjMy MikKKyAgICAgICAgICAgIGJ5IDB4NjVBMkJBMjogV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNyZWF0 ZShXZWJLaXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXVEY6OlBh c3NSZWZQdHI8V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk+LAorICAgICAgICAgICAgICAgICAgICAg ICAgICBXZWJLaXQ6OldlYlBhZ2VHcm91cCosIHVuc2lnbmVkIGxvbmcpIChXZWJQYWdlUHJveHku Y3BwOjIzMykKKyAgICAgICAgICAgIGJ5IDB4NjVFOTRCQjogV2ViS2l0OjpXZWJQcm9jZXNzUHJv eHk6OmNyZWF0ZVdlYlBhZ2UoV2ViS2l0OjpQYWdlQ2xpZW50KiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgV2ViS2l0OjpXZWJDb250ZXh0KiwgV2ViS2l0OjpXZWJQYWdlR3JvdXAqKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAoV2ViUHJvY2Vzc1Byb3h5LmNwcDoxNzIpCisgICAgICAg ICAgICBieSAweDY1NzA5NTc6IFdlYktpdDo6V2ViQ29udGV4dDo6Y3JlYXRlV2ViUGFnZShXZWJL aXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJLaXQ6OldlYlBh Z2VHcm91cCosIFdlYktpdDo6V2ViUGFnZVByb3h5KikKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgKFdlYkNvbnRleHQuY3BwOjczNSkKKyAgICAgICAgICAgIGJ5IDB4Njc2NzNFMzogV2ViS2l0 OjpXZWJWaWV3OjpXZWJWaWV3KFdlYktpdDo6V2ViQ29udGV4dCosCisgICAgICAgICAgICAgICAg ICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKikgKFdlYlZpZXcuY3BwOjUyKQorICAgICAg ICAgICAgYnkgMHg2Nzc1RjE4OiBXZWJLaXQ6OldlYlZpZXdFZmw6OldlYlZpZXdFZmwoV2ViS2l0 OjpXZWJDb250ZXh0KiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0OjpXZWJQYWdl R3JvdXAqKSAoV2ViVmlld0VmbC5jcHA6NTQpCisgICAgICAgICAgICBieSAweDY3NzVFQjQ6IFdl YktpdDo6V2ViVmlldzo6Y3JlYXRlKFdlYktpdDo6V2ViQ29udGV4dCosCisgICAgICAgICAgICAg ICAgICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKikgKFdlYlZpZXdFZmwuY3BwOjQ5KQor ICAgICAgICAgICAgYnkgMHg2NzNFMTNEOiBXS1ZpZXdDcmVhdGUgKFdLVmlldy5jcHA6MzMpCisg ICAgICAgICAgICBieSAweDY3NjNFQ0U6IEVXS1ZpZXdDcmVhdGUgKGV3a192aWV3LmNwcDo5MikK KworICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3OjpXZWJWaWV3KToKKwogMjAxMy0wNS0zMSAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0g QWRkIGEgbnVsbCBjaGVja2luZyBjb25kaXRpb24gdG8gaW4gaGlkZSgpIG9mIEV3a0NvbnRleHRN ZW51CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL1dlYlZpZXcuY3BwCmluZGV4IDU3ZTYxZmM2ZmE0OTFjZWU0ODlhOTVhMDI3OWZmNzJj YzNiNjM2MDguLjdkYjFiYzU5MjYxZThlMDkwYzAxZGRiYjU3MmJmZWE4NGFmZTU4ZWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L1dlYlZpZXcuY3BwCkBAIC00NSwxMiArNDUsMTMgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViVmlldzo6V2ViVmlldyhXZWJDb250ZXh0KiBjb250 ZXh0LCBXZWJQYWdlR3JvdXAqIHBhZ2VHcm91cCkKLSAgICA6IG1fcGFnZShjb250ZXh0LT5jcmVh dGVXZWJQYWdlKHRoaXMsIHBhZ2VHcm91cCkpCi0gICAgLCBtX2ZvY3VzZWQoZmFsc2UpCisgICAg OiBtX2ZvY3VzZWQoZmFsc2UpCiAgICAgLCBtX3Zpc2libGUoZmFsc2UpCiAgICAgLCBtX2NvbnRl bnRTY2FsZUZhY3RvcigxLjApCiAgICAgLCBtX29wYWNpdHkoMS4wKQogeworICAgIG1fcGFnZSA9 IGNvbnRleHQtPmNyZWF0ZVdlYlBhZ2UodGhpcywgcGFnZUdyb3VwKTsKKwogICAgIG1fcGFnZS0+ cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFi bGVkKHRydWUpOwogICAgIG1fcGFnZS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldEZv cmNlQ29tcG9zaXRpbmdNb2RlKHRydWUpOwogCg== 203505 2013-06-01 23:48:17 -0700 2013-06-02 00:56:43 -0700 Patch bug-117116-20130602024039.patch text/plain 3949 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzhjMDIyOGM2MzhjOTg2 MWU2MDYyNmRmOTRlYTM1NmQ1OGJkMjI4Yy4uY2RjN2Y0ZWYyNmE1OGRmZjk1M2Y5MmNlZDgzOTUx NTFlMjg3Y2FhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ5IEBACisyMDEzLTA2LTAxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1dL Ml1bQ0ddOiBVc2UgYSBwcm9wZXJseSBpbml0aWFsaXplZCBXZWJQYWdlIHdoZW4gY3JlYXRpbmcg YSBQYWdlQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTcxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBWYWxncmluZCByZXBvcnRlZCBhICJjb25kaXRpb25hbCBqdW1wIG9yIG1vdmUgZGVwZW5k cyBvbiB1bmluaXRpYWxpc2VkIHZhbHVlIgorICAgICAgICBhdCBXZWJQYWdlUHJveHkgY29uc3Ry dWN0b3IsIHdoZW4gY2hlY2tpbmcgdGhlIG1faXNWaXNpYmxlIHZhcmlhYmxlIGluc2lkZQorICAg ICAgICB0aGUgRU5BQkxFKFBBR0VfVklTSUJJTElUWV9BUEkpIGd1YXJkLgorCisgICAgICAgIFRo ZSBpc3N1ZSB3YXMgdHJhY2tlZCBkb3duIHRvIHRoZSBXZWJWaWV3IGNvbnN0cnVjdG9yLCB3aGlj aCB3YXMgY3JlYXRpbmcgYQorICAgICAgICBXZWJLaXQ6OlBhZ2VDbGllbnQqIG1ha2luZyB1c2Ug b2YgYHRoaXMnIGJlZm9yZSBoYXZpbmcgaW5pdGlhbGl6ZWQgYWxsIG9mIGl0cworICAgICAgICBh dHRyaWJ1dGVzLgorCisgICAgICAgIFRoZSBzb2x1dGlvbiB3YXMgdG8gbW92ZSB0aGUgaW5pdGlh bGl6YXRpb24gb2YgdGhlIGBwYWdlJyBtZW1iZXIgdG8gaW5zaWRlIHRoZQorICAgICAgICBjb25z dHJ1Y3RvciBpdHNlbGYgLSBvdXQgb2YgdGhlIGluaXRpYWxpemF0aW9uIGxpc3QgLSwgd2hlcmUg d2UgY2FuIGd1YXJhbnRlZQorICAgICAgICBhbGwgdGhlIHJlbGV2YW50IHN0dWZmIGhhcyBhbHJl YWR5IGJlZW4gcHJvcGVybHkgaW5pdGlhbGl6ZWQuCisKKyAgICAgICAgSGVyZSdzIHRoZSByZWxl dmFudCB2YWxncmluZCB0cmFjZSBmb3IgcmVmZXJlbmNlOgorCisgICAgICAgIENvbmRpdGlvbmFs IGp1bXAgb3IgbW92ZSBkZXBlbmRzIG9uIHVuaW5pdGlhbGlzZWQgdmFsdWUocykKKyAgICAgICAg ICAgIGF0IDB4NjVBMzVBNDogV2ViS2l0OjpXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94eShXZWJL aXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXVEY6OlBhc3NSZWZQ dHI8V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk+LAorICAgICAgICAgICAgICAgICAgICAgICAgICBX ZWJLaXQ6OldlYlBhZ2VHcm91cCosIHVuc2lnbmVkIGxvbmcpIChXZWJQYWdlUHJveHkuY3BwOjMy MikKKyAgICAgICAgICAgIGJ5IDB4NjVBMkJBMjogV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNyZWF0 ZShXZWJLaXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXVEY6OlBh c3NSZWZQdHI8V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk+LAorICAgICAgICAgICAgICAgICAgICAg ICAgICBXZWJLaXQ6OldlYlBhZ2VHcm91cCosIHVuc2lnbmVkIGxvbmcpIChXZWJQYWdlUHJveHku Y3BwOjIzMykKKyAgICAgICAgICAgIGJ5IDB4NjVFOTRCQjogV2ViS2l0OjpXZWJQcm9jZXNzUHJv eHk6OmNyZWF0ZVdlYlBhZ2UoV2ViS2l0OjpQYWdlQ2xpZW50KiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgV2ViS2l0OjpXZWJDb250ZXh0KiwgV2ViS2l0OjpXZWJQYWdlR3JvdXAqKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAoV2ViUHJvY2Vzc1Byb3h5LmNwcDoxNzIpCisgICAgICAg ICAgICBieSAweDY1NzA5NTc6IFdlYktpdDo6V2ViQ29udGV4dDo6Y3JlYXRlV2ViUGFnZShXZWJL aXQ6OlBhZ2VDbGllbnQqLAorICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJLaXQ6OldlYlBh Z2VHcm91cCosIFdlYktpdDo6V2ViUGFnZVByb3h5KikKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgKFdlYkNvbnRleHQuY3BwOjczNSkKKyAgICAgICAgICAgIGJ5IDB4Njc2NzNFMzogV2ViS2l0 OjpXZWJWaWV3OjpXZWJWaWV3KFdlYktpdDo6V2ViQ29udGV4dCosCisgICAgICAgICAgICAgICAg ICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKikgKFdlYlZpZXcuY3BwOjUyKQorICAgICAg ICAgICAgYnkgMHg2Nzc1RjE4OiBXZWJLaXQ6OldlYlZpZXdFZmw6OldlYlZpZXdFZmwoV2ViS2l0 OjpXZWJDb250ZXh0KiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0OjpXZWJQYWdl R3JvdXAqKSAoV2ViVmlld0VmbC5jcHA6NTQpCisgICAgICAgICAgICBieSAweDY3NzVFQjQ6IFdl YktpdDo6V2ViVmlldzo6Y3JlYXRlKFdlYktpdDo6V2ViQ29udGV4dCosCisgICAgICAgICAgICAg ICAgICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKikgKFdlYlZpZXdFZmwuY3BwOjQ5KQor ICAgICAgICAgICAgYnkgMHg2NzNFMTNEOiBXS1ZpZXdDcmVhdGUgKFdLVmlldy5jcHA6MzMpCisg ICAgICAgICAgICBieSAweDY3NjNFQ0U6IEVXS1ZpZXdDcmVhdGUgKGV3a192aWV3LmNwcDo5MikK KworICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3OjpXZWJWaWV3KToKKwogMjAxMy0wNS0zMSAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0g QWRkIGEgbnVsbCBjaGVja2luZyBjb25kaXRpb24gdG8gaW4gaGlkZSgpIG9mIEV3a0NvbnRleHRN ZW51CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL1dlYlZpZXcuY3BwCmluZGV4IDU3ZTYxZmM2ZmE0OTFjZWU0ODlhOTVhMDI3OWZmNzJj YzNiNjM2MDguLmNmNzRmOWZhMjI5YTUxNzJmM2M4NTcyOGM5M2ZlNTVlMmZjZjYxYWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L1dlYlZpZXcuY3BwCkBAIC00NSwxMiArNDUsMTQgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViVmlldzo6V2ViVmlldyhXZWJDb250ZXh0KiBjb250 ZXh0LCBXZWJQYWdlR3JvdXAqIHBhZ2VHcm91cCkKLSAgICA6IG1fcGFnZShjb250ZXh0LT5jcmVh dGVXZWJQYWdlKHRoaXMsIHBhZ2VHcm91cCkpCi0gICAgLCBtX2ZvY3VzZWQoZmFsc2UpCisgICAg OiBtX2ZvY3VzZWQoZmFsc2UpCiAgICAgLCBtX3Zpc2libGUoZmFsc2UpCiAgICAgLCBtX2NvbnRl bnRTY2FsZUZhY3RvcigxLjApCiAgICAgLCBtX29wYWNpdHkoMS4wKQogeworICAgIC8vIE5lZWQg dG8gY2FsbCBjcmVhdGVXZWJQYWdlIGFmdGVyIG90aGVyIGRhdGEgbWVtYmVycywgc3BlY2lmaWNh bGx5IG1fdmlzaWJsZSwgYXJlIGluaXRpYWxpemVkLgorICAgIG1fcGFnZSA9IGNvbnRleHQtPmNy ZWF0ZVdlYlBhZ2UodGhpcywgcGFnZUdyb3VwKTsKKwogICAgIG1fcGFnZS0+cGFnZUdyb3VwKCkt PnByZWZlcmVuY2VzKCktPnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKHRydWUpOwog ICAgIG1fcGFnZS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldEZvcmNlQ29tcG9zaXRp bmdNb2RlKHRydWUpOwogCg== 203509 2013-06-02 00:56:53 -0700 2013-06-02 01:33:04 -0700 Patch bug-117116-20130602035526.patch text/plain 3966 sergio U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzhjMDIyOGM2MzhjOTg2 MWU2MDYyNmRmOTRlYTM1NmQ1OGJkMjI4Yy4uNDgxMjg3YjlmZmI2NWJkMmJiZDcyZDBhZjg4Mjk1 YjFkNTI4OTc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ5IEBACisyMDEzLTA2LTAxICBTZXJn aW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1dL Ml1bQ29vcmRpbmF0ZWRHcmFwaGljc106IFVzZSBhIHByb3Blcmx5IGluaXRpYWxpemVkIFdlYlBh Z2Ugd2hlbiBjcmVhdGluZyBhIFBhZ2VDbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzExNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFZhbGdyaW5kIHJlcG9ydGVkIGEgImNvbmRpdGlvbmFsIGp1 bXAgb3IgbW92ZSBkZXBlbmRzIG9uIHVuaW5pdGlhbGlzZWQgdmFsdWUiCisgICAgICAgIGF0IFdl YlBhZ2VQcm94eSBjb25zdHJ1Y3Rvciwgd2hlbiBjaGVja2luZyB0aGUgbV9pc1Zpc2libGUgdmFy aWFibGUgaW5zaWRlCisgICAgICAgIHRoZSBFTkFCTEUoUEFHRV9WSVNJQklMSVRZX0FQSSkgZ3Vh cmQuCisKKyAgICAgICAgVGhlIGlzc3VlIHdhcyB0cmFja2VkIGRvd24gdG8gdGhlIFdlYlZpZXcg Y29uc3RydWN0b3IsIHdoaWNoIHdhcyBjcmVhdGluZyBhCisgICAgICAgIFdlYktpdDo6UGFnZUNs aWVudCogbWFraW5nIHVzZSBvZiBgdGhpcycgYmVmb3JlIGhhdmluZyBpbml0aWFsaXplZCBhbGwg b2YgaXRzCisgICAgICAgIGF0dHJpYnV0ZXMuCisKKyAgICAgICAgVGhlIHNvbHV0aW9uIHdhcyB0 byBtb3ZlIHRoZSBpbml0aWFsaXphdGlvbiBvZiB0aGUgYHBhZ2UnIG1lbWJlciB0byBpbnNpZGUg dGhlCisgICAgICAgIGNvbnN0cnVjdG9yIGl0c2VsZiAtIG91dCBvZiB0aGUgaW5pdGlhbGl6YXRp b24gbGlzdCAtLCB3aGVyZSB3ZSBjYW4gZ3VhcmFudGVlCisgICAgICAgIGFsbCB0aGUgcmVsZXZh bnQgc3R1ZmYgaGFzIGFscmVhZHkgYmVlbiBwcm9wZXJseSBpbml0aWFsaXplZC4KKworICAgICAg ICBIZXJlJ3MgdGhlIHJlbGV2YW50IHZhbGdyaW5kIHRyYWNlIGZvciByZWZlcmVuY2U6CisKKyAg ICAgICAgQ29uZGl0aW9uYWwganVtcCBvciBtb3ZlIGRlcGVuZHMgb24gdW5pbml0aWFsaXNlZCB2 YWx1ZShzKQorICAgICAgICAgICAgYXQgMHg2NUEzNUE0OiBXZWJLaXQ6OldlYlBhZ2VQcm94eTo6 V2ViUGFnZVByb3h5KFdlYktpdDo6UGFnZUNsaWVudCosCisgICAgICAgICAgICAgICAgICAgICAg ICAgIFdURjo6UGFzc1JlZlB0cjxXZWJLaXQ6OldlYlByb2Nlc3NQcm94eT4sCisgICAgICAgICAg ICAgICAgICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKiwgdW5zaWduZWQgbG9uZykgKFdl YlBhZ2VQcm94eS5jcHA6MzIyKQorICAgICAgICAgICAgYnkgMHg2NUEyQkEyOiBXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6Y3JlYXRlKFdlYktpdDo6UGFnZUNsaWVudCosCisgICAgICAgICAgICAgICAg ICAgICAgICAgIFdURjo6UGFzc1JlZlB0cjxXZWJLaXQ6OldlYlByb2Nlc3NQcm94eT4sCisgICAg ICAgICAgICAgICAgICAgICAgICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKiwgdW5zaWduZWQgbG9u ZykgKFdlYlBhZ2VQcm94eS5jcHA6MjMzKQorICAgICAgICAgICAgYnkgMHg2NUU5NEJCOiBXZWJL aXQ6OldlYlByb2Nlc3NQcm94eTo6Y3JlYXRlV2ViUGFnZShXZWJLaXQ6OlBhZ2VDbGllbnQqLAor ICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJLaXQ6OldlYkNvbnRleHQqLCBXZWJLaXQ6Oldl YlBhZ2VHcm91cCopCisgICAgICAgICAgICAgICAgICAgICAgICAgIChXZWJQcm9jZXNzUHJveHku Y3BwOjE3MikKKyAgICAgICAgICAgIGJ5IDB4NjU3MDk1NzogV2ViS2l0OjpXZWJDb250ZXh0Ojpj cmVhdGVXZWJQYWdlKFdlYktpdDo6UGFnZUNsaWVudCosCisgICAgICAgICAgICAgICAgICAgICAg ICAgIFdlYktpdDo6V2ViUGFnZUdyb3VwKiwgV2ViS2l0OjpXZWJQYWdlUHJveHkqKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAoV2ViQ29udGV4dC5jcHA6NzM1KQorICAgICAgICAgICAgYnkg MHg2NzY3M0UzOiBXZWJLaXQ6OldlYlZpZXc6OldlYlZpZXcoV2ViS2l0OjpXZWJDb250ZXh0KiwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0OjpXZWJQYWdlR3JvdXAqKSAoV2ViVmll dy5jcHA6NTIpCisgICAgICAgICAgICBieSAweDY3NzVGMTg6IFdlYktpdDo6V2ViVmlld0VmbDo6 V2ViVmlld0VmbChXZWJLaXQ6OldlYkNvbnRleHQqLAorICAgICAgICAgICAgICAgICAgICAgICAg ICBXZWJLaXQ6OldlYlBhZ2VHcm91cCopIChXZWJWaWV3RWZsLmNwcDo1NCkKKyAgICAgICAgICAg IGJ5IDB4Njc3NUVCNDogV2ViS2l0OjpXZWJWaWV3OjpjcmVhdGUoV2ViS2l0OjpXZWJDb250ZXh0 KiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0OjpXZWJQYWdlR3JvdXAqKSAoV2Vi Vmlld0VmbC5jcHA6NDkpCisgICAgICAgICAgICBieSAweDY3M0UxM0Q6IFdLVmlld0NyZWF0ZSAo V0tWaWV3LmNwcDozMykKKyAgICAgICAgICAgIGJ5IDB4Njc2M0VDRTogRVdLVmlld0NyZWF0ZSAo ZXdrX3ZpZXcuY3BwOjkyKQorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OldlYlZpZXcpOgorCiAy MDEzLTA1LTMxICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF1bV0syXSBBZGQgYSBudWxsIGNoZWNraW5nIGNvbmRpdGlvbiB0byBpbiBoaWRl KCkgb2YgRXdrQ29udGV4dE1lbnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKaW5kZXggNTdlNjFmYzZmYTQ5MWNl ZTQ4OWE5NWEwMjc5ZmY3MmNjM2I2MzYwOC4uY2Y3NGY5ZmEyMjlhNTE3MmYzYzg1NzI4YzkzZmU1 NWUyZmNmNjFhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5h dGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nv b3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAKQEAgLTQ1LDEyICs0NSwxNCBAQCB1c2luZyBu YW1lc3BhY2UgV2ViQ29yZTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBXZWJWaWV3OjpXZWJWaWV3 KFdlYkNvbnRleHQqIGNvbnRleHQsIFdlYlBhZ2VHcm91cCogcGFnZUdyb3VwKQotICAgIDogbV9w YWdlKGNvbnRleHQtPmNyZWF0ZVdlYlBhZ2UodGhpcywgcGFnZUdyb3VwKSkKLSAgICAsIG1fZm9j dXNlZChmYWxzZSkKKyAgICA6IG1fZm9jdXNlZChmYWxzZSkKICAgICAsIG1fdmlzaWJsZShmYWxz ZSkKICAgICAsIG1fY29udGVudFNjYWxlRmFjdG9yKDEuMCkKICAgICAsIG1fb3BhY2l0eSgxLjAp CiB7CisgICAgLy8gTmVlZCB0byBjYWxsIGNyZWF0ZVdlYlBhZ2UgYWZ0ZXIgb3RoZXIgZGF0YSBt ZW1iZXJzLCBzcGVjaWZpY2FsbHkgbV92aXNpYmxlLCBhcmUgaW5pdGlhbGl6ZWQuCisgICAgbV9w YWdlID0gY29udGV4dC0+Y3JlYXRlV2ViUGFnZSh0aGlzLCBwYWdlR3JvdXApOworCiAgICAgbV9w YWdlLT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMoKS0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGlu Z0VuYWJsZWQodHJ1ZSk7CiAgICAgbV9wYWdlLT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMoKS0+ c2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAK