117096 2013-05-31 15:38:48 -0700 Make build-webkit output VCExpress 2010 build logs properly 2013-06-03 14:58:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham commit-queue roger_fong oldest_to_newest 896016 0 roger_fong 2013-05-31 15:38:48 -0700 This includes first of all ALWAYS outputting the logs (failure or success) and secondly we should use the AssembleBuildLogs project output. 896017 1 203471 roger_fong 2013-05-31 15:45:30 -0700 Created attachment 203471 patch 896023 2 203471 bfulgham 2013-05-31 16:35:56 -0700 Comment on attachment 203471 patch r=me! 896024 3 203471 commit-queue 2013-05-31 16:36:49 -0700 Comment on attachment 203471 patch Rejecting attachment 203471 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 203471, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/723431 896632 4 roger_fong 2013-06-03 14:58:33 -0700 http://trac.webkit.org/changeset/151056 203471 2013-05-31 15:45:30 -0700 2013-05-31 16:36:49 -0700 patch patch.patch text/plain 2362 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1MTA0OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA1LTMxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgTWFrZSBidWlsZC13ZWJraXQgb3V0cHV0IFZDRXhwcmVzcyAyMDEwIGJ1aWxk IGxvZ3MgcHJvcGVybHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTcwOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOb2JvZHkoT09QUyEpLgorCisg ICAgICAgIE1ha2UgaXQgc28gdGhhdCBvdXRwdXQgZnJvbSBWQ0V4cHJlc3MgaXMgYWx3YXlzIHBy aW50ZWQgdG8gY29uc29sZS4KKyAgICAgICAgQWxzbyBnZXQgYnVpbGQgbG9nIHJlc3VsdHMgZnJv bSBBc3NlbWJsZUJ1aWxkTG9ncyBwcm9qZWN0IG91dHB1dC4KKworICAgICAgICAqIFNjcmlwdHMv YnVpbGQtd2Via2l0OgorCiAyMDEzLTA1LTMxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBVc2UgV2luTGF1bmNoZXIgdG8gZGlzcGxheSBM YXlvdXRUZXN0IHJlc3VsdHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShyZXZpc2lvbiAxNTA5OTQpCisr KyBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkod29ya2luZyBjb3B5KQpAQCAtMzQ3LDE3ICsz NDcsMjYgQEAKICAgICAjIFZhcmlvdXMgYnVpbGQqIGNhbGxzIGFib3ZlIG1heSBjaGFuZ2UgdGhl IENXRC4KICAgICBjaGRpcldlYktpdCgpOwogCisgICAgbXkgJGJhc2VQcm9kdWN0RGlyID0gYmFz ZVByb2R1Y3REaXIoKTsKKyAgICBpZiAodXNpbmdWaXN1YWxTdHVkaW9FeHByZXNzKCkpIHsKKyAg ICAgICAgIyBWaXN1YWwgU3R1ZGlvIEV4cHJlc3MgaXMgc28gbGFtZSBpdCBjYW4ndCBzdGRvdXQg YnVpbGQgZmFpbHVyZXMuCisgICAgICAgICMgU28gd2UgZmluZCBpdHMgbG9ncyBhbmQgZHVtcCB0 aGVtIHRvIHRoZSBjb25zb2xlIG91cnNlbHZlcy4KKyAgICAgICAgCisgICAgICAgIG9wZW4obXkg JE9VVFBVVF9IQU5ETEUsICc8JywgIiRiYXNlUHJvZHVjdERpci9CdWlsZE91dHB1dC5odG0iKTsK KyAgICAgICAgaWYgKCRPVVRQVVRfSEFORExFKSB7CisgICAgICAgICAgICBwcmludCB3aGlsZSAo PCRPVVRQVVRfSEFORExFPik7CisgICAgICAgICAgICBjbG9zZSgkT1VUUFVUX0hBTkRMRSk7Cisg ICAgICAgIH0KKyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBwcmludCAiRXJyb3I6IEJ1aWxk T3V0cHV0Lmh0bSBjcmVhdGVkIGJ5IEFzc2VtYmxlQnVpbGRMb2dzIHByb2plY3QgaXMgbWlzc2lu ZyEiOworICAgICAgICB9CisgICAgfQorCiAgICAgaWYgKGV4aXRTdGF0dXMoJHJlc3VsdCkpIHsK ICAgICAgICAgbXkgJHNjcmlwdERpciA9IHJlbGF0aXZlU2NyaXB0c0RpcigpOwotICAgICAgICBp ZiAodXNpbmdWaXN1YWxTdHVkaW9FeHByZXNzKCkpIHsKLSAgICAgICAgICAgICMgVmlzdWFsIFN0 dWRpbyBFeHByZXNzIGlzIHNvIGxhbWUgaXQgY2FuJ3Qgc3Rkb3V0IGJ1aWxkIGZhaWx1cmVzLgot ICAgICAgICAgICAgIyBTbyB3ZSBmaW5kIGl0cyBsb2dzIGFuZCBkdW1wIHRoZW0gdG8gdGhlIGNv bnNvbGUgb3Vyc2VsdmVzLgotICAgICAgICAgICAgc3lzdGVtKEZpbGU6OlNwZWMtPmNhdGZpbGUo JHNjcmlwdERpciwgInByaW50LXZzZS1mYWlsdXJlLWxvZ3MiKSk7Ci0gICAgICAgIH0KICAgICAg ICAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSkgewogICAgICAgICAgICAgcHJpbnQgIlxuXG49PT09 PSBCVUlMRCBGQUlMRUQgPT09PT09XG5cbiI7CiAgICAgICAgICAgICBwcmludCAiUGxlYXNlIGVu c3VyZSB5b3UgaGF2ZSBydW4gJHNjcmlwdERpci91cGRhdGUtd2Via2l0IHRvIGluc3RhbGwgZGVw ZW5kZW5jaWVzLlxuXG4iOwotICAgICAgICAgICAgbXkgJGJhc2VQcm9kdWN0RGlyID0gYmFzZVBy b2R1Y3REaXIoKTsKICAgICAgICAgICAgIHByaW50ICJZb3UgY2FuIHZpZXcgYnVpbGQgZXJyb3Jz IGJ5IGNoZWNraW5nIHRoZSBCdWlsZExvZy5odG0gZmlsZXMgbG9jYXRlZCBhdDpcbiRiYXNlUHJv ZHVjdERpci9vYmovPHByb2plY3Q+Lzxjb25maWc+LlxuIjsKICAgICAgICAgfQogICAgICAgICBl eGl0IGV4aXRTdGF0dXMoJHJlc3VsdCk7Cg==