117076 2013-05-31 08:14:53 -0700 Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins 2013-05-31 11:10:17 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino bdakin jonlee sam thorton oldest_to_newest 895894 0 dino 2013-05-31 08:14:53 -0700 https://bugs.webkit.org/show_bug.cgi?id=116490 changed the way snapshotting plugins can use accelerated compositing, allowing them to start in that mode before snapshotting. It turns out that this isn't a great user experience. So, for plugins that we know can support software-snapshotting, don't put them in compositing mode. <rdar://problem/14030364> 895895 1 203448 dino 2013-05-31 08:19:06 -0700 Created attachment 203448 Patch 895918 2 dino 2013-05-31 09:46:10 -0700 Comments from Anders on IRC: - don't put the MIMETypeRegistry method in - use == rather than startsWith 895930 3 dino 2013-05-31 10:04:48 -0700 Committed r151026: <http://trac.webkit.org/changeset/151026> 895941 4 sam 2013-05-31 11:10:17 -0700 What exactly is broken here? You say that it "isn't a great user experience", but what does that mean? Can't we always use the CA path rather than the software snapshotting? 203448 2013-05-31 08:19:06 -0700 2013-05-31 09:43:07 -0700 Patch bug-117076-20130601011741.patch text/plain 5304 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwOTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkxNDA4NzMzYWM0MGU5 YTJiZDEwMDFmZmM1ZjE4NTRkNDkzODZkNS4uZTU2NmFiZjgwOGE3MmRjNjY2NzQzZTZjMzdmYmVm ZTgyZjAyNmUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA1LTMxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBjcmVhdGUgYW4gYWNj ZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXIgdW5sZXNzIHdlIGhhdmUgdG8gZm9yIHNuYXBzaG90 dGluZyBwbHVnLWlucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE3MDc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDAzMDM2ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW5kIGV4cG9ydCBh IG1ldGhvZCB0byBpZGVudGlmeSB0aGUgQWRvYmUgRmxhc2ggTUlNRSBUeXBlLgorCisgICAgICAg ICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNSU1FVHlwZVJlZ2lzdHJ5Ojppc0ZsYXNoTUlNRVR5cGUp OgorICAgICAgICAqIHBsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuaDoKKwogMjAxMy0wNS0yOSAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgLXdlYmtpdC10ZXh0LXVu ZGVybGluZS1wb3NpdGlvbiBzaG91bGQgbm90IGJlIGluaGVyaXRlZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGFk NjUyMWVlNTg5MWM2MzU5YTdjZmVlNTg0MTBhZGU4MTRiZWUxOTEuLjE3ZjRiNWFkMzUzYjY5OWEz MDExYThlZjNlMmYyOTE1NzhiMGIyOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAx My0wNS0zMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3Qg Y3JlYXRlIGFuIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGxheWVyIHVubGVzcyB3ZSBoYXZlIHRv IGZvciBzbmFwc2hvdHRpbmcgcGx1Zy1pbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExNzA3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQwMzAz NjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYg YSBwbHVnLWluIGNhbiBzdXBwb3J0IHNvZnR3YXJlIHNuYXBzaG90dGluZywgdGhlbiBkb24ndCBj cmVhdGUgYW4KKyAgICAgICAgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXIgZm9yIGl0IHdo aWxlIGluIHNuYXBzaG90IG1vZGUuIFRoaXMgaXMgYQorICAgICAgICBiZXR0ZXIgdXNlciBleHBl cmllbmNlIC0tIG90aGVyd2lzZSB0aGUgcGFnZS9wbHVnLWluIGxvb2tzIGxpa2UgaXQgYnJva2Uu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAg IChXZWJLaXQ6OlBsdWdpblZpZXc6OmlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQpOiBJ ZiB3ZSBhcmUgaW4gc25hcHNob3R0aW5nIG1vZGUKKyAgICAgICAgYW5kIHdlIGFyZSBhIEZsYXNo IHBsdWdpbiAodGhlIG9ubHkgb25lIHRoYXQgc3VwcG9ydHMgc29mdHdhcmUgc25hcHNob3RzIGF0 IHRoZSBtb21lbnQpCisgICAgICAgIHRoZW4gZG8gbm90IGNyZWF0ZSBhbiBhY2NlbGVyYXRlZCBj b21wb3NpdGluZyBsYXllci4KKwogMjAxMy0wNS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdCBzaG91bGQgZXhwb3NlIEhTVFMgQVBJcyB0 byBkZXRlcm1pbmUgd2hldGhlciBhIGhvc3QgaXMgaW4gdGhlIEhTVFMgY2FjaGUgYW5kIHRvIHJl c2V0IEhTVFMgcG9saWNpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXggM2Q3MzkyZWI1YWEzMDYz YzQxYjllYTBlZmJlYzFiYmNkZmNmNDgxOC4uMmQwY2QyMGRhZTZkMmEwMTEzM2I0MDk4YWJmZGQ4 Zjc2N2MyMTQxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KKysr IGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTUzMyw2ICs1MzMsNyBAQCBfX1pO N1dlYkNvcmUxNkxlZ2FjeVdlYkFyY2hpdmU2Y3JlYXRlRVBOU181UmFuZ2VFCiBfX1pON1dlYkNv cmUxNkxlZ2FjeVdlYkFyY2hpdmU2Y3JlYXRlRXYKIF9fWk43V2ViQ29yZTE2TUlNRVR5cGVSZWdp c3RyeTE1Y2FuU2hvd01JTUVUeXBlRVJLTjNXVEY2U3RyaW5nRQogX19aTjdXZWJDb3JlMTZNSU1F VHlwZVJlZ2lzdHJ5MjBpc0phdmFBcHBsZXRNSU1FVHlwZUVSS04zV1RGNlN0cmluZ0UKK19fWk43 V2ViQ29yZTE2TUlNRVR5cGVSZWdpc3RyeTE1aXNGbGFzaE1JTUVUeXBlRVJLTjNXVEY2U3RyaW5n RQogX19aTjdXZWJDb3JlMTZNSU1FVHlwZVJlZ2lzdHJ5MjNnZXRNSU1FVHlwZUZvckV4dGVuc2lv bkVSS04zV1RGNlN0cmluZ0UKIF9fWk43V2ViQ29yZTE2TUlNRVR5cGVSZWdpc3RyeTI0aXNTdXBw b3J0ZWRJbWFnZU1JTUVUeXBlRVJLTjNXVEY2U3RyaW5nRQogX19aTjdXZWJDb3JlMTZNSU1FVHlw ZVJlZ2lzdHJ5MjVpc1BERk9yUG9zdFNjcmlwdE1JTUVUeXBlRVJLTjNXVEY2U3RyaW5nRQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAppbmRleCBmY2U2N2Ni YTA1Yzc0MTRhN2FmMTNlY2E0MmE4ZDQwMTA4M2NiNDU3Li40MjJlN2JiZGE4NmUyNzc4NjIxZGZl NmFiZDg2NWY4MTQ3MmM3OGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9N SU1FVHlwZVJlZ2lzdHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlw ZVJlZ2lzdHJ5LmNwcApAQCAtNjE3LDYgKzYxNywxMSBAQCBib29sIE1JTUVUeXBlUmVnaXN0cnk6 OmlzSmF2YUFwcGxldE1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiAgICAgICAgIHx8 IG1pbWVUeXBlLnN0YXJ0c1dpdGgoImFwcGxpY2F0aW9uL3gtamF2YS12bSIsIGZhbHNlKTsKIH0K IAorYm9vbCBNSU1FVHlwZVJlZ2lzdHJ5Ojppc0ZsYXNoTUlNRVR5cGUoY29uc3QgU3RyaW5nJiBt aW1lVHlwZSkKK3sKKyAgICByZXR1cm4gbWltZVR5cGUuc3RhcnRzV2l0aCgiYXBwbGljYXRpb24v eC1zaG9ja3dhdmUtZmxhc2giLCBmYWxzZSk7Cit9CisKIGJvb2wgTUlNRVR5cGVSZWdpc3RyeTo6 aXNQREZPclBvc3RTY3JpcHRNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogewogICAg IGlmIChtaW1lVHlwZS5pc0VtcHR5KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlw ZVJlZ2lzdHJ5LmgKaW5kZXggZWNjNzY2Y2M0NzFkNWJhMTg0YjU0YzA0NGJjODk2OTczZWQyNDAx NC4uZDdiMjljODM4ZjZmNDVlMjk1OTdhN2MyMjA1NWMyYmJiYWQ2Y2YyOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuaApAQCAtNzksNiArNzksOSBAQCBwdWJs aWM6CiAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIGEgbWltZSB0eXBlIGlzIGEgdmFsaWQgSmF2YSBh cHBsZXQgbWltZSB0eXBlCiAgICAgc3RhdGljIGJvb2wgaXNKYXZhQXBwbGV0TUlNRVR5cGUoY29u c3QgU3RyaW5nJiBtaW1lVHlwZSk7CiAKKyAgICAvLyBDaGVjayB0byBzZWUgaWYgYSBtaW1lIHR5 cGUgaXMgYSBGbGFzaCBtaW1lIHR5cGUKKyAgICBzdGF0aWMgYm9vbCBpc0ZsYXNoTUlNRVR5cGUo Y29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7CisKICAgICAvLyBDaGVjayB0byBzZWUgaWYgYSBtaW1l IHR5cGUgaXMgYSBwbHVnaW4gaW1wbGVtZW50ZWQgYnkgdGhlCiAgICAgLy8gYnJvd3NlciAoZS5n LiBhIFF0IFBsdWdpbikuCiAgICAgc3RhdGljIGJvb2wgaXNBcHBsaWNhdGlvblBsdWdpbk1JTUVU eXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IGNlNmRmNjA2YWJhYTRlYWEwYzUzZTUw YmQyMjIxNzc4YjJmY2M0Y2UuLmU1ZjFiNWUwNzNiZjdkNTFmZjMzZDU4YTMzODMxYTU3ZGE5Mzg1 NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmll dy5jcHAKQEAgLTEzOTMsNiArMTM5MywxMyBAQCBib29sIFBsdWdpblZpZXc6OmlzQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ0VuYWJsZWQoKQogICAgIGlmICghc2V0dGluZ3MpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAorICAgIC8vIFdlIGtub3cgdGhhdCBzb21lIHBsdWctaW5zIGNhbiBzdXBwb3J0 IHNuYXBzaG90dGluZyB3aXRob3V0IG5lZWRpbmcKKyAgICAvLyBhY2NlbGVyYXRlZCBjb21wb3Np dGluZy4gU2luY2Ugd2UncmUgdHJ5aW5nIHRvIHNuYXBzaG90IHRoZW0gYW55d2F5LAorICAgIC8v IHB1dCB0aGVtIGludG8gbm9ybWFsIGNvbXBvc2l0aW5nIG1vZGUuIEEgc2lkZSBiZW5lZml0IGlz IHRoYXQgdGhpcyBtaWdodAorICAgIC8vIGFsbG93IHRoZSBlbnRpcmUgcGFnZSB0byBzdGF5IGlu IHRoYXQgbW9kZS4KKyAgICBpZiAobV9wbHVnaW5FbGVtZW50LT5kaXNwbGF5U3RhdGUoKSA8IEhU TUxQbHVnSW5FbGVtZW50OjpSZXN0YXJ0aW5nICYmIE1JTUVUeXBlUmVnaXN0cnk6OmlzRmxhc2hN SU1FVHlwZShtX3BhcmFtZXRlcnMubWltZVR5cGUpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK ICAgICByZXR1cm4gc2V0dGluZ3MtPmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKCk7CiB9 CiAK