117064 2013-05-31 01:41:58 -0700 [WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste. 2013-06-05 21:13:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 huangxueqing webkit-unassigned bfulgham commit-queue darin oldest_to_newest 895814 0 huangxueqing 2013-05-31 01:41:58 -0700 Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste. 895829 1 203425 huangxueqing 2013-05-31 02:11:04 -0700 Created attachment 203425 patch 896057 2 203425 bfulgham 2013-05-31 22:38:55 -0700 Comment on attachment 203425 patch View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > Source/WebCore/ChangeLog:11 > + (WebCore::Editor::newGeneralClipboard): Please add a note here describing what is changed. > Source/WebCore/ChangeLog:13 > + (WebCore::Pasteboard::createForCopyAndPaste): Ditto. 896286 3 203551 huangxueqing 2013-06-02 19:10:15 -0700 Created attachment 203551 patch 896287 4 huangxueqing 2013-06-02 19:11:02 -0700 (In reply to comment #2) > (From update of attachment 203425 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review > > This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > > > Source/WebCore/ChangeLog:11 > > + (WebCore::Editor::newGeneralClipboard): > > Please add a note here describing what is changed. > Done > > Source/WebCore/ChangeLog:13 > > + (WebCore::Pasteboard::createForCopyAndPaste): > > Ditto. Done 897621 5 huangxueqing 2013-06-05 19:03:36 -0700 Brent, please review this patch again, thanks. 897634 6 203551 commit-queue 2013-06-05 21:13:06 -0700 Comment on attachment 203551 patch Clearing flags on attachment: 203551 Committed r151253: <http://trac.webkit.org/changeset/151253> 897635 7 commit-queue 2013-06-05 21:13:08 -0700 All reviewed patches have been landed. Closing bug. 203425 2013-05-31 02:11:04 -0700 2013-06-02 19:10:15 -0700 patch 117064.patch text/plain 2781 huangxueqing SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDEwKQ0KKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNyBAQA0KKzIwMTMtMDUtMzEgIFh1 ZXFpbmcgSHVhbmcgIDxodWFuZ3h1ZXFpbmdAYmFpZHUuY29tPgorCisgICAgICAgIE1vdmUgT2xl R2V0Q2xpcGJvYXJkIHRvIFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzA2NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNo YW5nZSwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0VkaXRvcldpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6Om5ld0dlbmVyYWxDbGlwYm9hcmQpOgorICAg ICAgICAqIHBsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSk6CisKIDIwMTMtMDUtMzAgIEV1Z2Vu ZSBLbHl1Y2huaWtvdiAgPGV1c3Rhc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgc2VsZWN0aW9u U3RhcnQvc2VsZWN0aW9uRW5kIHJldHVybiAib2Jzb2xldGUiIHZhbHVlcyB3aGVuIHJlcXVlc3Rl ZCBkdXJpbmcgImlucHV0IiBldmVudApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2lu L0VkaXRvcldpbi5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93 aW4vRWRpdG9yV2luLmNwcAkocmV2aXNpb24gMTUxMDA5KQ0KKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9FZGl0b3JXaW4uY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMjYsMzEgKzI2LDE1 IEBADQogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkVkaXRvci5oIgogCi0jaW5jbHVk ZSAiQ09NUHRyLmgiCiAjaW5jbHVkZSAiQ2xpcGJvYXJkLmgiCi0jaW5jbHVkZSAiRG9jdW1lbnQu aCIKLSNpbmNsdWRlICJFZGl0b3JDbGllbnQuaCIKLSNpbmNsdWRlICJFbGVtZW50LmgiCiAjaW5j bHVkZSAiRnJhbWUuaCIKLSNpbmNsdWRlICJQYXN0ZWJvYXJkLmgiCi0jaW5jbHVkZSAiVGV4dEl0 ZXJhdG9yLmgiCi0jaW5jbHVkZSAiVmlzaWJsZVVuaXRzLmgiCi0jaW5jbHVkZSAiaHRtbGVkaXRp bmcuaCIKIAotI2luY2x1ZGUgPHdpbmRvd3MuaD4KLQogbmFtZXNwYWNlIFdlYkNvcmUgewogCisv LyBGSVhNRTogRGVsZXRlIHRoaXMgZmlsZSB3aGVuIHJlbW92aW5nIExFR0FDWV9TVFlMRV9BQlNU UkFDVF9DTElQQk9BUkRfQ0xBU1MuCiBQYXNzUmVmUHRyPENsaXBib2FyZD4gRWRpdG9yOjpuZXdH ZW5lcmFsQ2xpcGJvYXJkKENsaXBib2FyZEFjY2Vzc1BvbGljeSBwb2xpY3ksIEZyYW1lKiBmcmFt ZSkKIHsKLSAgICBDT01QdHI8SURhdGFPYmplY3Q+IGNsaXBib2FyZERhdGE7Ci0jaWYgIU9TKFdJ TkNFKQotICAgIGlmICghU1VDQ0VFREVEKE9sZUdldENsaXBib2FyZCgmY2xpcGJvYXJkRGF0YSkp KQotICAgICAgICBjbGlwYm9hcmREYXRhID0gMDsKLSNlbmRpZgotICAgIFJlZlB0cjxDbGlwYm9h cmQ+IGNsaXBib2FyZCA9IENsaXBib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKHBvbGljeSk7 Ci0gICAgY29uc3RfY2FzdDxQYXN0ZWJvYXJkJj4oY2xpcGJvYXJkLT5wYXN0ZWJvYXJkKCkpLnNl dEV4dGVybmFsRGF0YU9iamVjdChjbGlwYm9hcmREYXRhLmdldCgpKTsKLSAgICByZXR1cm4gY2xp cGJvYXJkLnJlbGVhc2UoKTsKKyAgICByZXR1cm4gQ2xpcGJvYXJkOjpjcmVhdGVGb3JDb3B5QW5k UGFzdGUocG9saWN5KTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCShyZXZpc2lvbiAx NTEwMDkpDQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3Bw CSh3b3JraW5nIGNvcHkpDQpAQCAtOTgsNyArOTgsMTQgQEANCiAKIFBhc3NPd25QdHI8UGFzdGVi b2FyZD4gUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCkKIHsKLSAgICByZXR1cm4g YWRvcHRQdHIobmV3IFBhc3RlYm9hcmQpOworICAgIE93blB0cjxQYXN0ZWJvYXJkPiBwYXN0ZWJv YXJkID0gYWRvcHRQdHIobmV3IFBhc3RlYm9hcmQpOworICAgIENPTVB0cjxJRGF0YU9iamVjdD4g Y2xpcGJvYXJkRGF0YTsKKyNpZiAhT1MoV0lOQ0UpCisgICAgaWYgKCFTVUNDRUVERUQoT2xlR2V0 Q2xpcGJvYXJkKCZjbGlwYm9hcmREYXRhKSkpCisgICAgICAgIGNsaXBib2FyZERhdGEgPSAwOwor I2VuZGlmCisgICAgcGFzdGVib2FyZC0+c2V0RXh0ZXJuYWxEYXRhT2JqZWN0KGNsaXBib2FyZERh dGEuZ2V0KCkpOworICAgIHJldHVybiBwYXN0ZWJvYXJkLnJlbGVhc2UoKTsKIH0KIAogUGFzc093 blB0cjxQYXN0ZWJvYXJkPiBQYXN0ZWJvYXJkOjpjcmVhdGVQcml2YXRlKCkK 203551 2013-06-02 19:10:15 -0700 2013-06-05 21:13:06 -0700 patch 117064.patch text/plain 2924 huangxueqing SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDEwKQ0KKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNyBAQA0KKzIwMTMtMDUtMzEgIFh1 ZXFpbmcgSHVhbmcgIDxodWFuZ3h1ZXFpbmdAYmFpZHUuY29tPgorCisgICAgICAgIE1vdmUgT2xl R2V0Q2xpcGJvYXJkIHRvIFBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNzA2NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNo YW5nZSwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0VkaXRvcldpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6Om5ld0dlbmVyYWxDbGlwYm9hcmQpOiBFZGl0 b3Igc2hvdWxkIG5vdCBjcmVhdGUgSURhdGFPYmplY3QgZXhwbGljaXRseSB0aGVuIHNldCBpdCB0 byBQYXN0ZWJvYXJkLgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBhc3RlYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZSk6IENv bnN0cnVjdCBhIFBhc3RlYm9hcmQgYW5kIGNyZWF0ZSBJRGF0YU9iamVjdCBieSAiT2xlR2V0Q2xp cGJvYXJkIi4KKwogMjAxMy0wNS0zMCAgRXVnZW5lIEtseXVjaG5pa292ICA8ZXVzdGFzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBzZWxlY3Rpb25TdGFydC9zZWxlY3Rpb25FbmQgcmV0dXJuICJv YnNvbGV0ZSIgdmFsdWVzIHdoZW4gcmVxdWVzdGVkIGR1cmluZyAiaW5wdXQiIGV2ZW50CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRWRpdG9yV2luLmNwcA0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9FZGl0b3JXaW4uY3BwCShyZXZpc2lvbiAx NTEwMDkpDQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0VkaXRvcldpbi5jcHAJKHdv cmtpbmcgY29weSkNCkBAIC0yNiwzMSArMjYsMTUgQEANCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAiRWRpdG9yLmgiCiAKLSNpbmNsdWRlICJDT01QdHIuaCIKICNpbmNsdWRlICJDbGlw Ym9hcmQuaCIKLSNpbmNsdWRlICJEb2N1bWVudC5oIgotI2luY2x1ZGUgIkVkaXRvckNsaWVudC5o IgotI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRlICJGcmFtZS5oIgotI2luY2x1ZGUgIlBh c3RlYm9hcmQuaCIKLSNpbmNsdWRlICJUZXh0SXRlcmF0b3IuaCIKLSNpbmNsdWRlICJWaXNpYmxl VW5pdHMuaCIKLSNpbmNsdWRlICJodG1sZWRpdGluZy5oIgogCi0jaW5jbHVkZSA8d2luZG93cy5o PgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKy8vIEZJWE1FOiBEZWxldGUgdGhpcyBmaWxlIHdo ZW4gcmVtb3ZpbmcgTEVHQUNZX1NUWUxFX0FCU1RSQUNUX0NMSVBCT0FSRF9DTEFTUy4KIFBhc3NS ZWZQdHI8Q2xpcGJvYXJkPiBFZGl0b3I6Om5ld0dlbmVyYWxDbGlwYm9hcmQoQ2xpcGJvYXJkQWNj ZXNzUG9saWN5IHBvbGljeSwgRnJhbWUqIGZyYW1lKQogewotICAgIENPTVB0cjxJRGF0YU9iamVj dD4gY2xpcGJvYXJkRGF0YTsKLSNpZiAhT1MoV0lOQ0UpCi0gICAgaWYgKCFTVUNDRUVERUQoT2xl R2V0Q2xpcGJvYXJkKCZjbGlwYm9hcmREYXRhKSkpCi0gICAgICAgIGNsaXBib2FyZERhdGEgPSAw OwotI2VuZGlmCi0gICAgUmVmUHRyPENsaXBib2FyZD4gY2xpcGJvYXJkID0gQ2xpcGJvYXJkOjpj cmVhdGVGb3JDb3B5QW5kUGFzdGUocG9saWN5KTsKLSAgICBjb25zdF9jYXN0PFBhc3RlYm9hcmQm PihjbGlwYm9hcmQtPnBhc3RlYm9hcmQoKSkuc2V0RXh0ZXJuYWxEYXRhT2JqZWN0KGNsaXBib2Fy ZERhdGEuZ2V0KCkpOwotICAgIHJldHVybiBjbGlwYm9hcmQucmVsZWFzZSgpOworICAgIHJldHVy biBDbGlwYm9hcmQ6OmNyZWF0ZUZvckNvcHlBbmRQYXN0ZShwb2xpY3kpOwogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFzdGVi b2FyZFdpbi5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4v UGFzdGVib2FyZFdpbi5jcHAJKHJldmlzaW9uIDE1MTAwOSkNCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC05OCw3ICs5 OCwxNCBAQA0KIAogUGFzc093blB0cjxQYXN0ZWJvYXJkPiBQYXN0ZWJvYXJkOjpjcmVhdGVGb3JD b3B5QW5kUGFzdGUoKQogewotICAgIHJldHVybiBhZG9wdFB0cihuZXcgUGFzdGVib2FyZCk7Cisg ICAgT3duUHRyPFBhc3RlYm9hcmQ+IHBhc3RlYm9hcmQgPSBhZG9wdFB0cihuZXcgUGFzdGVib2Fy ZCk7CisgICAgQ09NUHRyPElEYXRhT2JqZWN0PiBjbGlwYm9hcmREYXRhOworI2lmICFPUyhXSU5D RSkKKyAgICBpZiAoIVNVQ0NFRURFRChPbGVHZXRDbGlwYm9hcmQoJmNsaXBib2FyZERhdGEpKSkK KyAgICAgICAgY2xpcGJvYXJkRGF0YSA9IDA7CisjZW5kaWYKKyAgICBwYXN0ZWJvYXJkLT5zZXRF eHRlcm5hbERhdGFPYmplY3QoY2xpcGJvYXJkRGF0YS5nZXQoKSk7CisgICAgcmV0dXJuIHBhc3Rl Ym9hcmQucmVsZWFzZSgpOwogfQogCiBQYXNzT3duUHRyPFBhc3RlYm9hcmQ+IFBhc3RlYm9hcmQ6 OmNyZWF0ZVByaXZhdGUoKQo=