117062 2013-05-31 00:43:41 -0700 [sh4] Handle branchType properly in branchTruncateDoubleToInt32 2013-05-31 11:19:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue oliver oldest_to_newest 895799 0 jbriance 2013-05-31 00:43:41 -0700 Current implementation of branchTruncateDoubleToInt32 is incorrect when branchType == BranchIfTruncateSuccessful in sh4 baseline JIT. 895800 1 203416 jbriance 2013-05-31 00:47:13 -0700 Created attachment 203416 Handle branchType properly in branchTruncateDoubleToInt32 in sh4 baseline JIT 895942 2 203416 commit-queue 2013-05-31 11:19:08 -0700 Comment on attachment 203416 Handle branchType properly in branchTruncateDoubleToInt32 in sh4 baseline JIT Clearing flags on attachment: 203416 Committed r151030: <http://trac.webkit.org/changeset/151030> 895943 3 commit-queue 2013-05-31 11:19:09 -0700 All reviewed patches have been landed. Closing bug. 203416 2013-05-31 00:47:13 -0700 2013-05-31 11:19:08 -0700 Handle branchType properly in branchTruncateDoubleToInt32 in sh4 baseline JIT bug-117062.patch text/plain 2013 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA1LTMxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFtzaDRdIEhhbmRsZSBicmFuY2hUeXBlIHByb3Blcmx5IGluIGJyYW5jaFRydW5jYXRl RG91YmxlVG9JbnQzMi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExNzA2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgYnJhbmNoVHJ1bmNhdGVEb3VibGVUb0lu dDMyIGlzIGluY29ycmVjdAorICAgICAgICB3aGVuIGJyYW5jaFR5cGUgPT0gQnJhbmNoSWZUcnVu Y2F0ZVN1Y2Nlc3NmdWwgaW4gc2g0IGJhc2VsaW5lIEpJVC4KKworICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlclNINC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlclNINDo6 YnJhbmNoVHJ1bmNhdGVEb3VibGVUb0ludDMyKToKKwogMjAxMy0wNS0zMCAgRGF2aWQgRmFybGVy ICA8ZGZhcmxlckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGpzY29yZS10ZXN0IHdoZW4gbm90 IHVzaW5nIC0tc2RrIG9wdGlvbiB3aXRoIGpzRHJpdmVyLnBsCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCShyZXZpc2lv biAxNTEwMDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyU0g0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE0OTgsMTIgKzE0OTgsMTIgQEAgcHVibGljOgog ICAgICAgICBtX2Fzc2VtYmxlci5mdHJjZHJtZnB1bChzcmMpOwogICAgICAgICBtX2Fzc2VtYmxl ci5zdHNmcHVsUmVnKGRlc3QpOwogICAgICAgICBtX2Fzc2VtYmxlci5sb2FkQ29uc3RhbnQoMHg3 ZmZmZmZmZiwgc2NyYXRjaFJlZzMpOwotICAgICAgICBtX2Fzc2VtYmxlci5jbXBsUmVnUmVnKGRl c3QsIHNjcmF0Y2hSZWczLCBTSDRDb25kaXRpb24oYnJhbmNoVHlwZSA9PSBCcmFuY2hJZlRydW5j YXRlRmFpbGVkID8gRXF1YWwgOiBOb3RFcXVhbCkpOworICAgICAgICBtX2Fzc2VtYmxlci5jbXBs UmVnUmVnKGRlc3QsIHNjcmF0Y2hSZWczLCBTSDRDb25kaXRpb24oRXF1YWwpKTsKICAgICAgICAg bV9hc3NlbWJsZXIuZW5zdXJlU3BhY2UobV9hc3NlbWJsZXIubWF4SW5zdHJ1Y3Rpb25TaXplICsg MTQsIHNpemVvZih1aW50MzJfdCkpOwogICAgICAgICBtX2Fzc2VtYmxlci5icmFuY2goQlRfT1BD T0RFLCAyKTsKICAgICAgICAgbV9hc3NlbWJsZXIuYWRkbEltbThyKDEsIHNjcmF0Y2hSZWczKTsK LSAgICAgICAgbV9hc3NlbWJsZXIuY21wbFJlZ1JlZyhkZXN0LCBzY3JhdGNoUmVnMywgU0g0Q29u ZGl0aW9uKGJyYW5jaFR5cGUgPT0gQnJhbmNoSWZUcnVuY2F0ZUZhaWxlZCA/IEVxdWFsIDogTm90 RXF1YWwpKTsKLSAgICAgICAgcmV0dXJuIGJyYW5jaFRydWUoKTsKKyAgICAgICAgbV9hc3NlbWJs ZXIuY21wbFJlZ1JlZyhkZXN0LCBzY3JhdGNoUmVnMywgU0g0Q29uZGl0aW9uKEVxdWFsKSk7Cisg ICAgICAgIHJldHVybiAoYnJhbmNoVHlwZSA9PSBCcmFuY2hJZlRydW5jYXRlRmFpbGVkKSA/IGJy YW5jaFRydWUoKSA6IGJyYW5jaEZhbHNlKCk7CiAgICAgfQogCiAgICAgLy8gU3RhY2sgbWFuaXB1 bGF0aW9uIG9wZXJhdGlvbnMK