117057 2013-05-30 16:14:46 -0700 [sh4] Fix Overflow case of branchMul32 in baseline JIT 2013-05-31 11:22:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue oliver oldest_to_newest 895717 0 jbriance 2013-05-30 16:14:46 -0700 Current implementation of Overflow case in branchMul32 performs an unsigned multiplication whereas a signed multiplication is expected here. 895722 1 203393 jbriance 2013-05-30 16:22:52 -0700 Created attachment 203393 Fix Overflow case of branchMul32 in sh4 baseline JIT 895737 2 203393 commit-queue 2013-05-30 16:53:55 -0700 Comment on attachment 203393 Fix Overflow case of branchMul32 in sh4 baseline JIT Rejecting attachment 203393 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 203393, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 117057. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/728103 895791 3 203412 jbriance 2013-05-31 00:17:50 -0700 Created attachment 203412 Fix Overflow case of branchMul32 in sh4 baseline JIT (with ChangeLog) Better with a ChangeLog, indeed. 895949 4 203412 commit-queue 2013-05-31 11:22:47 -0700 Comment on attachment 203412 Fix Overflow case of branchMul32 in sh4 baseline JIT (with ChangeLog) Clearing flags on attachment: 203412 Committed r151033: <http://trac.webkit.org/changeset/151033> 895950 5 commit-queue 2013-05-31 11:22:49 -0700 All reviewed patches have been landed. Closing bug. 203393 2013-05-30 16:22:52 -0700 2013-05-31 00:17:25 -0700 Fix Overflow case of branchMul32 in sh4 baseline JIT bug-117057.patch text/plain 1451 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyU0g0LmgJKHJldmlzaW9uIDE1MDk4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkod29ya2luZyBjb3B5KQpAQCAtMTkwMSwxNyAr MTkwMSwxNyBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwg KGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7 CiAKICAgICAgICAgaWYgKGNvbmQgPT0gT3ZlcmZsb3cpIHsKLSAgICAgICAgICAgIFJlZ2lzdGVy SUQgc2NyMSA9IGNsYWltU2NyYXRjaCgpOwotICAgICAgICAgICAgUmVnaXN0ZXJJRCBzY3IgPSBj bGFpbVNjcmF0Y2goKTsKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLmRtdWxsUmVnUmVnKHNyYywg ZGVzdCk7CisgICAgICAgICAgICBSZWdpc3RlcklEIHNjcnNpZ24gPSBjbGFpbVNjcmF0Y2goKTsK KyAgICAgICAgICAgIFJlZ2lzdGVySUQgbXNicmVzID0gY2xhaW1TY3JhdGNoKCk7CisgICAgICAg ICAgICBtX2Fzc2VtYmxlci5kbXVsc2xSZWdSZWcoc3JjLCBkZXN0KTsKICAgICAgICAgICAgIG1f YXNzZW1ibGVyLnN0c21hY2woZGVzdCk7Ci0gICAgICAgICAgICBtX2Fzc2VtYmxlci5tb3ZJbW04 KC0zMSwgc2NyKTsKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLm1vdmxSZWdSZWcoZGVzdCwgc2Ny MSk7Ci0gICAgICAgICAgICBtX2Fzc2VtYmxlci5zaGFkUmVnUmVnKHNjcjEsIHNjcik7Ci0gICAg ICAgICAgICBtX2Fzc2VtYmxlci5zdHNtYWNoKHNjcik7Ci0gICAgICAgICAgICBtX2Fzc2VtYmxl ci5jbXBsUmVnUmVnKHNjciwgc2NyMSwgU0g0Q29uZGl0aW9uKEVxdWFsKSk7Ci0gICAgICAgICAg ICByZWxlYXNlU2NyYXRjaChzY3IxKTsKLSAgICAgICAgICAgIHJlbGVhc2VTY3JhdGNoKHNjcik7 CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbXBweihkZXN0KTsKKyAgICAgICAgICAgIG1fYXNz ZW1ibGVyLm1vdnQoc2Nyc2lnbik7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5hZGRsSW1tOHIo LTEsIHNjcnNpZ24pOworICAgICAgICAgICAgbV9hc3NlbWJsZXIuc3RzbWFjaChtc2JyZXMpOwor ICAgICAgICAgICAgbV9hc3NlbWJsZXIuY21wbFJlZ1JlZyhtc2JyZXMsIHNjcnNpZ24sIFNINENv bmRpdGlvbihFcXVhbCkpOworICAgICAgICAgICAgcmVsZWFzZVNjcmF0Y2gobXNicmVzKTsKKyAg ICAgICAgICAgIHJlbGVhc2VTY3JhdGNoKHNjcnNpZ24pOwogICAgICAgICAgICAgcmV0dXJuIGJy YW5jaEZhbHNlKCk7CiAgICAgICAgIH0KIAo= 203412 2013-05-31 00:17:50 -0700 2013-05-31 11:22:47 -0700 Fix Overflow case of branchMul32 in sh4 baseline JIT (with ChangeLog) bug-117057_2.patch text/plain 2263 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA1LTMxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFtzaDRdIEZpeCBPdmVyZmxvdyBjYXNlIG9mIGJyYW5jaE11bDMyIGluIGJhc2VsaW5l IEpJVC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NzA1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1 cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgT3ZlcmZsb3cgY2FzZSBpbiBicmFuY2hNdWwzMiBwZXJm b3JtcyBhbgorICAgICAgICB1bnNpZ25lZCBtdWx0aXBsaWNhdGlvbiB3aGVyZWFzIGEgc2lnbmVk IG11bHRpcGxpY2F0aW9uIGlzIGV4cGVjdGVkLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyU0g0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0OjpicmFuY2hN dWwzMik6CisKIDIwMTMtMDUtMzAgIERhdmlkIEZhcmxlciAgPGRmYXJsZXJAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCBqc2NvcmUtdGVzdCB3aGVuIG5vdCB1c2luZyAtLXNkayBvcHRpb24gd2l0 aCBqc0RyaXZlci5wbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclNINC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkocmV2aXNpb24gMTUxMDA5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCSh3b3JraW5nIGNvcHkp CkBAIC0xOTAxLDE3ICsxOTAxLDE3IEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKChjb25kID09 IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWduZWQpIHx8IChjb25kID09IFplcm8pIHx8IChjb25k ID09IE5vblplcm8pKTsKIAogICAgICAgICBpZiAoY29uZCA9PSBPdmVyZmxvdykgewotICAgICAg ICAgICAgUmVnaXN0ZXJJRCBzY3IxID0gY2xhaW1TY3JhdGNoKCk7Ci0gICAgICAgICAgICBSZWdp c3RlcklEIHNjciA9IGNsYWltU2NyYXRjaCgpOwotICAgICAgICAgICAgbV9hc3NlbWJsZXIuZG11 bGxSZWdSZWcoc3JjLCBkZXN0KTsKKyAgICAgICAgICAgIFJlZ2lzdGVySUQgc2Nyc2lnbiA9IGNs YWltU2NyYXRjaCgpOworICAgICAgICAgICAgUmVnaXN0ZXJJRCBtc2JyZXMgPSBjbGFpbVNjcmF0 Y2goKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmRtdWxzbFJlZ1JlZyhzcmMsIGRlc3QpOwog ICAgICAgICAgICAgbV9hc3NlbWJsZXIuc3RzbWFjbChkZXN0KTsKLSAgICAgICAgICAgIG1fYXNz ZW1ibGVyLm1vdkltbTgoLTMxLCBzY3IpOwotICAgICAgICAgICAgbV9hc3NlbWJsZXIubW92bFJl Z1JlZyhkZXN0LCBzY3IxKTsKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLnNoYWRSZWdSZWcoc2Ny MSwgc2NyKTsKLSAgICAgICAgICAgIG1fYXNzZW1ibGVyLnN0c21hY2goc2NyKTsKLSAgICAgICAg ICAgIG1fYXNzZW1ibGVyLmNtcGxSZWdSZWcoc2NyLCBzY3IxLCBTSDRDb25kaXRpb24oRXF1YWwp KTsKLSAgICAgICAgICAgIHJlbGVhc2VTY3JhdGNoKHNjcjEpOwotICAgICAgICAgICAgcmVsZWFz ZVNjcmF0Y2goc2NyKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtcHB6KGRlc3QpOworICAg ICAgICAgICAgbV9hc3NlbWJsZXIubW92dChzY3JzaWduKTsKKyAgICAgICAgICAgIG1fYXNzZW1i bGVyLmFkZGxJbW04cigtMSwgc2Nyc2lnbik7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5zdHNt YWNoKG1zYnJlcyk7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbXBsUmVnUmVnKG1zYnJlcywg c2Nyc2lnbiwgU0g0Q29uZGl0aW9uKEVxdWFsKSk7CisgICAgICAgICAgICByZWxlYXNlU2NyYXRj aChtc2JyZXMpOworICAgICAgICAgICAgcmVsZWFzZVNjcmF0Y2goc2Nyc2lnbik7CiAgICAgICAg ICAgICByZXR1cm4gYnJhbmNoRmFsc2UoKTsKICAgICAgICAgfQogCg==