117054 2013-05-30 16:01:34 -0700 [sh4] Fix double floating point transfer in baseline JIT 2013-05-31 11:21:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue oliver oldest_to_newest 895706 0 jbriance 2013-05-30 16:01:34 -0700 In current implementation, dmovRegReg function transfers only one single FPRegister as PR=1 and SZ=0 in floating point status/control register. So double transfers must be performed with two fmov.s opcodes instead of one fmov opcode. 895710 1 203391 jbriance 2013-05-30 16:06:39 -0700 Created attachment 203391 Fix double floating point transfer in sh4 baseline JIT 895733 2 203391 commit-queue 2013-05-30 16:40:49 -0700 Comment on attachment 203391 Fix double floating point transfer in sh4 baseline JIT Rejecting attachment 203391 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 203391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 150990 = 3a9d5ce0e5d6551b2b2f24471ca33137a186d6b3 r150991 = 867209b59d27a858f4a74cad2deb1cd7d2ab7ea3 r150992 = 899992352f0b7b7f0e53c31c8b599892ad46f824 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/693331 895788 3 203411 jbriance 2013-05-31 00:11:49 -0700 Created attachment 203411 Fix double floating point transfer in sh4 baseline JIT (with ChangeLog) Better with a ChangeLog, indeed. 895945 4 203411 commit-queue 2013-05-31 11:21:13 -0700 Comment on attachment 203411 Fix double floating point transfer in sh4 baseline JIT (with ChangeLog) Clearing flags on attachment: 203411 Committed r151031: <http://trac.webkit.org/changeset/151031> 895946 5 commit-queue 2013-05-31 11:21:15 -0700 All reviewed patches have been landed. Closing bug. 203391 2013-05-30 16:06:39 -0700 2013-05-31 00:10:57 -0700 Fix double floating point transfer in sh4 baseline JIT bug-117054.patch text/plain 2028 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyU0g0LmgJKHJldmlzaW9uIDE1MDk4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkod29ya2luZyBjb3B5KQpAQCAtOTY1LDYgKzk2 NSwxNCBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLmZzdHNmcHVsKGRlc3QpOwogICAg IH0KIAorICAgIHZvaWQgbW92ZURvdWJsZShGUFJlZ2lzdGVySUQgc3JjLCBGUFJlZ2lzdGVySUQg ZGVzdCkKKyAgICB7CisgICAgICAgIGlmIChzcmMgIT0gZGVzdCkgeworICAgICAgICAgICAgbV9h c3NlbWJsZXIuZm1vdnNSZWdSZWcoKEZQUmVnaXN0ZXJJRCkoc3JjICsgMSksIChGUFJlZ2lzdGVy SUQpKGRlc3QgKyAxKSk7CisgICAgICAgICAgICBtX2Fzc2VtYmxlci5mbW92c1JlZ1JlZyhzcmMs IGRlc3QpOworICAgICAgICB9CisgICAgfQorCiAgICAgdm9pZCBsb2FkRmxvYXQoQmFzZUluZGV4 IGFkZHJlc3MsIEZQUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgUmVnaXN0ZXJJRCBz Y3IgPSBjbGFpbVNjcmF0Y2goKTsKQEAgLTEwNjUsMTAgKzEwNzMsMTAgQEAgcHVibGljOgogICAg IHZvaWQgYWRkRG91YmxlKEZQUmVnaXN0ZXJJRCBvcDEsIEZQUmVnaXN0ZXJJRCBvcDIsIEZQUmVn aXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgaWYgKG9wMSA9PSBkZXN0KQotICAgICAgICAg ICAgbV9hc3NlbWJsZXIuZGFkZFJlZ1JlZyhvcDIsIGRlc3QpOworICAgICAgICAgICAgYWRkRG91 YmxlKG9wMiwgZGVzdCk7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgbV9hc3NlbWJsZXIu ZG1vdlJlZ1JlZyhvcDEsIGRlc3QpOwotICAgICAgICAgICAgbV9hc3NlbWJsZXIuZGFkZFJlZ1Jl ZyhvcDIsIGRlc3QpOworICAgICAgICAgICAgbW92ZURvdWJsZShvcDIsIGRlc3QpOworICAgICAg ICAgICAgYWRkRG91YmxlKG9wMSwgZGVzdCk7CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTE0NDAs OCArMTQ0OCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3FydERvdWJsZShGUFJlZ2lzdGVySUQg c3JjLCBGUFJlZ2lzdGVySUQgZGVzdCkKICAgICB7Ci0gICAgICAgIGlmIChkZXN0ICE9IHNyYykK LSAgICAgICAgICAgIG1fYXNzZW1ibGVyLmRtb3ZSZWdSZWcoc3JjLCBkZXN0KTsKKyAgICAgICAg bW92ZURvdWJsZShzcmMsIGRlc3QpOwogICAgICAgICBtX2Fzc2VtYmxlci5kc3FydChkZXN0KTsK ICAgICB9CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFz c2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv U0g0QXNzZW1ibGVyLmgJKHJldmlzaW9uIDE1MDk4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTgyOSw2ICs4Mjks MTIgQEAgcHVibGljOgogICAgICAgICBvbmVTaG9ydE9wKG9wYywgdHJ1ZSwgZmFsc2UpOwogICAg IH0KIAorICAgIHZvaWQgZm1vdnNSZWdSZWcoRlBSZWdpc3RlcklEIHNyYywgRlBSZWdpc3RlcklE IGRzdCkKKyAgICB7CisgICAgICAgIHVpbnQxNl90IG9wYyA9IGdldE9wY29kZUdyb3VwMShGTU9W X09QQ09ERSwgZHN0LCBzcmMpOworICAgICAgICBvbmVTaG9ydE9wKG9wYywgdHJ1ZSwgZmFsc2Up OworICAgIH0KKwogICAgIHZvaWQgZm1vdnNSZWFkcm0oUmVnaXN0ZXJJRCBzcmMsIEZQUmVnaXN0 ZXJJRCBkc3QpCiAgICAgewogICAgICAgICB1aW50MTZfdCBvcGMgPSBnZXRPcGNvZGVHcm91cDEo Rk1PVlNfUkVBRF9STV9PUENPREUsIGRzdCwgc3JjKTsK 203411 2013-05-31 00:11:49 -0700 2013-05-31 11:21:13 -0700 Fix double floating point transfer in sh4 baseline JIT (with ChangeLog) bug-117054_2.patch text/plain 3125 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUxMDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTA1LTMxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFtzaDRdIEZpeCBkb3VibGUgZmxvYXRpbmcgcG9pbnQgdHJhbnNmZXIgaW4gYmFzZWxp bmUgSklULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE3MDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gY3VycmVudCBpbXBsZW1lbnRhdGlvbiwgZG1vdlJlZ1JlZyBmdW5jdGlvbiB0cmFuc2ZlcnMg b25seSBvbmUgc2luZ2xlCisgICAgICAgIEZQUmVnaXN0ZXIgYXMgUFI9MSBhbmQgU1o9MCBpbiBm bG9hdGluZyBwb2ludCBzdGF0dXMvY29udHJvbCByZWdpc3Rlci4KKyAgICAgICAgRG91YmxlIHRy YW5zZmVycyBtdXN0IGJlIHBlcmZvcm1lZCB3aXRoIHR3byBmbW92LnMgb3Bjb2Rlcy4KKworICAg ICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oOgorICAgICAgICAoSlNDOjpNYWNy b0Fzc2VtYmxlclNINDo6bW92ZURvdWJsZSk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVy U0g0OjphZGREb3VibGUpOiBIYW5kbGUgKG9wMj09ZGVzdCkgY2FzZSBwcm9wZXJseS4KKyAgICAg ICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6OnNxcnREb3VibGUpOgorICAgICAgICAqIGFzc2Vt Ymxlci9TSDRBc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6U0g0QXNzZW1ibGVyOjpmbW92c1Jl Z1JlZyk6CisKIDIwMTMtMDUtMzAgIERhdmlkIEZhcmxlciAgPGRmYXJsZXJAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCBqc2NvcmUtdGVzdCB3aGVuIG5vdCB1c2luZyAtLXNkayBvcHRpb24gd2l0 aCBqc0RyaXZlci5wbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlclNINC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkocmV2aXNpb24gMTUxMDA5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCSh3b3JraW5nIGNvcHkp CkBAIC05NjUsNiArOTY1LDE0IEBAIHB1YmxpYzoKICAgICAgICAgbV9hc3NlbWJsZXIuZnN0c2Zw dWwoZGVzdCk7CiAgICAgfQogCisgICAgdm9pZCBtb3ZlRG91YmxlKEZQUmVnaXN0ZXJJRCBzcmMs IEZQUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgaWYgKHNyYyAhPSBkZXN0KSB7Cisg ICAgICAgICAgICBtX2Fzc2VtYmxlci5mbW92c1JlZ1JlZygoRlBSZWdpc3RlcklEKShzcmMgKyAx KSwgKEZQUmVnaXN0ZXJJRCkoZGVzdCArIDEpKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmZt b3ZzUmVnUmVnKHNyYywgZGVzdCk7CisgICAgICAgIH0KKyAgICB9CisKICAgICB2b2lkIGxvYWRG bG9hdChCYXNlSW5kZXggYWRkcmVzcywgRlBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAg ICBSZWdpc3RlcklEIHNjciA9IGNsYWltU2NyYXRjaCgpOwpAQCAtMTA2NSwxMCArMTA3MywxMCBA QCBwdWJsaWM6CiAgICAgdm9pZCBhZGREb3VibGUoRlBSZWdpc3RlcklEIG9wMSwgRlBSZWdpc3Rl cklEIG9wMiwgRlBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBpZiAob3AxID09IGRl c3QpCi0gICAgICAgICAgICBtX2Fzc2VtYmxlci5kYWRkUmVnUmVnKG9wMiwgZGVzdCk7CisgICAg ICAgICAgICBhZGREb3VibGUob3AyLCBkZXN0KTsKICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAg ICBtX2Fzc2VtYmxlci5kbW92UmVnUmVnKG9wMSwgZGVzdCk7Ci0gICAgICAgICAgICBtX2Fzc2Vt Ymxlci5kYWRkUmVnUmVnKG9wMiwgZGVzdCk7CisgICAgICAgICAgICBtb3ZlRG91YmxlKG9wMiwg ZGVzdCk7CisgICAgICAgICAgICBhZGREb3VibGUob3AxLCBkZXN0KTsKICAgICAgICAgfQogICAg IH0KIApAQCAtMTQ0MCw4ICsxNDQ4LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzcXJ0RG91Ymxl KEZQUmVnaXN0ZXJJRCBzcmMsIEZQUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAgICAgICAgaWYg KGRlc3QgIT0gc3JjKQotICAgICAgICAgICAgbV9hc3NlbWJsZXIuZG1vdlJlZ1JlZyhzcmMsIGRl c3QpOworICAgICAgICBtb3ZlRG91YmxlKHNyYywgZGVzdCk7CiAgICAgICAgIG1fYXNzZW1ibGVy LmRzcXJ0KGRlc3QpOwogICAgIH0KICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAkocmV2aXNpb24gMTUxMDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpA QCAtODI5LDYgKzgyOSwxMiBAQCBwdWJsaWM6CiAgICAgICAgIG9uZVNob3J0T3Aob3BjLCB0cnVl LCBmYWxzZSk7CiAgICAgfQogCisgICAgdm9pZCBmbW92c1JlZ1JlZyhGUFJlZ2lzdGVySUQgc3Jj LCBGUFJlZ2lzdGVySUQgZHN0KQorICAgIHsKKyAgICAgICAgdWludDE2X3Qgb3BjID0gZ2V0T3Bj b2RlR3JvdXAxKEZNT1ZfT1BDT0RFLCBkc3QsIHNyYyk7CisgICAgICAgIG9uZVNob3J0T3Aob3Bj LCB0cnVlLCBmYWxzZSk7CisgICAgfQorCiAgICAgdm9pZCBmbW92c1JlYWRybShSZWdpc3RlcklE IHNyYywgRlBSZWdpc3RlcklEIGRzdCkKICAgICB7CiAgICAgICAgIHVpbnQxNl90IG9wYyA9IGdl dE9wY29kZUdyb3VwMShGTU9WU19SRUFEX1JNX09QQ09ERSwgZHN0LCBzcmMpOwo=